52178 2011-01-10 16:29:58 -0800 Remove extraneous COMPILER(GCC) condition when checking GCC_VERSION_AT_LEAST() 2011-01-10 16:52:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dbates dbates oldest_to_newest 332036 0 dbates 2011-01-10 16:29:58 -0800 Following up from Darin Adler's comment in bug #51866 <https://bugs.webkit.org/show_bug.cgi?id=51866#c16>, it is sufficient to test for GCC_VERSION_AT_LEAST() instead of COMPILER(GCC) && GCC_VERSION_AT_LEAST(). 332041 1 78470 dbates 2011-01-10 16:41:26 -0800 Created attachment 78470 Patch 332042 2 78470 mrobinson 2011-01-10 16:43:49 -0800 Comment on attachment 78470 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78470&action=review Looks good, but pleae double-check the wording in the ChangeLog. > Source/JavaScriptCore/ChangeLog:11 > + It is sufficient to test GCC_VERSION_AT_LEAST() instead of both COMPILER(GCC) and > + GCC_VERSION_AT_LEAST() as GCC_VERSION_AT_LEAST() is defined only when we are > + compiling with GCC (i.e. COMPILER(GCC) is true). > + Careful with this wording. My reading of this is that GCC_VERSION_AT_LEAST() is undefined when we aren't on GCC, but in actuality GCC_VERSION_AT_LEAST() is defined as 0. 332043 3 dbates 2011-01-10 16:44:43 -0800 (In reply to comment #2) > (From update of attachment 78470 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=78470&action=review > > Looks good, but pleae double-check the wording in the ChangeLog. > > > Source/JavaScriptCore/ChangeLog:11 > > + It is sufficient to test GCC_VERSION_AT_LEAST() instead of both COMPILER(GCC) and > > + GCC_VERSION_AT_LEAST() as GCC_VERSION_AT_LEAST() is defined only when we are > > + compiling with GCC (i.e. COMPILER(GCC) is true). > > + > > Careful with this wording. My reading of this is that GCC_VERSION_AT_LEAST() is undefined when we aren't on GCC, but in actuality GCC_VERSION_AT_LEAST() is defined as 0. Will fix before landing. 332049 4 dbates 2011-01-10 16:52:16 -0800 Committed r75454: <http://trac.webkit.org/changeset/75454> 78470 2011-01-10 16:41:26 -0800 2011-01-10 16:43:49 -0800 Patch Bug52178.patch text/plain 3008 dbates SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzU0NDcpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAK KzIwMTEtMDEtMTAgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBleHRyYW5lb3VzIENP TVBJTEVSKEdDQykgY29uZGl0aW9uIHdoZW4gY2hlY2tpbmcgR0NDX1ZFUlNJT05fQVRfTEVBU1Qo KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTIxNzgK KworICAgICAgICBJdCBpcyBzdWZmaWNpZW50IHRvIHRlc3QgR0NDX1ZFUlNJT05fQVRfTEVBU1Qo KSBpbnN0ZWFkIG9mIGJvdGggQ09NUElMRVIoR0NDKSBhbmQKKyAgICAgICAgR0NDX1ZFUlNJT05f QVRfTEVBU1QoKSBhcyBHQ0NfVkVSU0lPTl9BVF9MRUFTVCgpIGlzIGRlZmluZWQgb25seSB3aGVu IHdlIGFyZQorICAgICAgICBjb21waWxpbmcgd2l0aCBHQ0MgKGkuZS4gQ09NUElMRVIoR0NDKSBp cyB0cnVlKS4KKworICAgICAgICAqIGppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmg6CisgICAgICAg IChKU0M6OkV4ZWN1dGFibGVBbGxvY2F0b3I6OmNhY2hlRmx1c2gpOgorICAgICAgICAqIHd0Zi9Q bGF0Zm9ybS5oOgorCiAyMDExLTAxLTEwICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAcmltLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oCShyZXZpc2lvbiA3NTQ0NikK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0yMzEsOCArMjMxLDggQEAgcHVibGljOgogI2VsaWYgQ1BVKE1JUFMpCiAg ICAgc3RhdGljIHZvaWQgY2FjaGVGbHVzaCh2b2lkKiBjb2RlLCBzaXplX3Qgc2l6ZSkKICAgICB7 Ci0jaWYgQ09NUElMRVIoR0NDKSAmJiBHQ0NfVkVSU0lPTl9BVF9MRUFTVCg0LDMsMCkKLSNpZiBX VEZfTUlQU19JU0FfUkVWKDIpICYmICFHQ0NfVkVSU0lPTl9BVF9MRUFTVCg0LDQsMykKKyNpZiBH Q0NfVkVSU0lPTl9BVF9MRUFTVCg0LCAzLCAwKQorI2lmIFdURl9NSVBTX0lTQV9SRVYoMikgJiYg IUdDQ19WRVJTSU9OX0FUX0xFQVNUKDQsIDQsIDMpCiAgICAgICAgIGludCBsaW5lU2l6ZTsKICAg ICAgICAgYXNtKCJyZGh3ciAlMCwgJDEiIDogIj1yIiAobGluZVNpemUpKTsKICAgICAgICAgLy8K SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDc1NDQ3KQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBA IC04Nyw3ICs4Nyw3IEBACiAjZGVmaW5lIEdDQ19WRVJTSU9OIChfX0dOVUNfXyAqIDEwMDAwICsg X19HTlVDX01JTk9SX18gKiAxMDAgKyBfX0dOVUNfUEFUQ0hMRVZFTF9fKQogI2RlZmluZSBHQ0Nf VkVSU0lPTl9BVF9MRUFTVChtYWpvciwgbWlub3IsIHBhdGNoKSAoR0NDX1ZFUlNJT04gPj0gKG1h am9yICogMTAwMDAgKyBtaW5vciAqIDEwMCArIHBhdGNoKSkKICNlbHNlCi0vKiBkZWZpbmUgdGhp cyBmb3IgIUdDQyBjb21waWxlcnMsIGp1c3Qgc28gd2UgY2FuIHdyaXRlIHRoaW5ncyBsaWtlIENP TVBJTEVSKEdDQykgJiYgR0NDX1ZFUlNJT05fQVRfTEVBU1QoNCwxLDApICovCisvKiBEZWZpbmUg dGhpcyBmb3IgIUdDQyBjb21waWxlcnMsIGp1c3Qgc28gd2UgY2FuIHdyaXRlIHRoaW5ncyBsaWtl IEdDQ19WRVJTSU9OX0FUX0xFQVNUKDQsIDEsIDApLiAqLwogI2RlZmluZSBHQ0NfVkVSU0lPTl9B VF9MRUFTVChtYWpvciwgbWlub3IsIHBhdGNoKSAwCiAjZW5kaWYKIApAQCAtOTU2LDggKzk1Niw4 IEBACiAjZGVmaW5lIEVOQUJMRV9SRVBBSU5UX1RIUk9UVExJTkcgMAogI2VuZGlmCiAKLS8qIERp c2FibGUgdGhlIEpJVCBvbiB2ZXJzaW9uZCBvZiBHQ0MgcHJpb3IgdG8gNC4xICovCi0jaWYgIWRl ZmluZWQoRU5BQkxFX0pJVCkgJiYgQ09NUElMRVIoR0NDKSAmJiAhR0NDX1ZFUlNJT05fQVRfTEVB U1QoNCwxLDApCisvKiBEaXNhYmxlIHRoZSBKSVQgb24gdmVyc2lvbnMgb2YgR0NDIHByaW9yIHRv IDQuMSAqLworI2lmICFkZWZpbmVkKEVOQUJMRV9KSVQpICYmIENPTVBJTEVSKEdDQykgJiYgIUdD Q19WRVJTSU9OX0FUX0xFQVNUKDQsIDEsIDApCiAjZGVmaW5lIEVOQUJMRV9KSVQgMAogI2VuZGlm CiAKQEAgLTk2OSw3ICs5NjksNyBAQAogLyogVGhlIEpJVCBpcyBlbmFibGVkIGJ5IGRlZmF1bHQg b24gYWxsIHg4NiwgeDY0LTY0LCBBUk0gJiBNSVBTIHBsYXRmb3Jtcy4gKi8KICNpZiAhZGVmaW5l ZChFTkFCTEVfSklUKSBcCiAgICAgJiYgKENQVShYODYpIHx8IENQVShYODZfNjQpIHx8IENQVShB Uk0pIHx8IENQVShNSVBTKSkgXAotICAgICYmIChPUyhEQVJXSU4pIHx8ICFDT01QSUxFUihHQ0Mp IHx8IEdDQ19WRVJTSU9OX0FUX0xFQVNUKDQsMSwwKSkgXAorICAgICYmIChPUyhEQVJXSU4pIHx8 ICFDT01QSUxFUihHQ0MpIHx8IEdDQ19WRVJTSU9OX0FUX0xFQVNUKDQsIDEsIDApKSBcCiAgICAg JiYgIU9TKFdJTkNFKQogI2RlZmluZSBFTkFCTEVfSklUIDEKICNlbmRpZgo=