52156 2011-01-10 11:01:22 -0800 REGRESSION (r75289): Assertion failure in JSC::Heap::destroy() when running JS tests 2011-01-10 12:17:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Windows XP RESOLVED FIXED http://build.webkit.org/builders/Windows%20XP%20Debug%20%28Tests%29/builds/24054/steps/jscore-test/logs/stdio InRadar, LayoutTestFailure, PlatformOnly P2 Normal --- 1 aroben webkit-unassigned barraclough ggaren msaboff oliver oldest_to_newest 331714 0 aroben 2011-01-10 11:01:22 -0800 To reproduce: 1. run-javascriptcore-tests Three tests will hit an assertion. The tests are: js1_5/Regress/regress-152646.js js1_5/Regress/regress-192414.js js1_5/Regress/regress-96526-002.js The assertion is in Heap::destroy. It is: ASSERT(!m_globalData->dynamicGlobalObject); m_globalData->dynamicGlobalObject seems always to be 0x01500000. Here's the backtrace: > JavaScriptCore.dll!JSC::Heap::destroy() Line 90 + 0x28 bytes C++ jsc.exe!cleanupGlobalData(JSC::JSGlobalData * globalData=0x00f2be88) Line 364 C++ jsc.exe!main(int argc=6, char * * argv=0x00cfed00) Line 356 + 0x9 bytes C++ jsc.exe!__tmainCRTStartup() Line 597 + 0x17 bytes C kernel32.dll!_BaseProcessStart@4() + 0x23 bytes 331715 1 aroben 2011-01-10 11:01:38 -0800 Is there any way to skip JS tests? 331716 2 aroben 2011-01-10 11:02:11 -0800 <rdar://problem/8842022> 331717 3 aroben 2011-01-10 11:03:32 -0800 Looks like run-javascriptcore-tests has support for skipping tests. 331721 4 aroben 2011-01-10 11:11:12 -0800 I skipped these tests in r75392. 331722 5 aroben 2011-01-10 11:12:03 -0800 Maybe this was caused by r75289? 331735 6 oliver 2011-01-10 11:19:09 -0800 (In reply to comment #5) > Maybe this was caused by r75289? I would guess so, rather than disabling those tests, i think it would be better to rollout that patch. 331746 7 ggaren 2011-01-10 11:24:03 -0800 Yes, please roll out the offending patch. 331747 8 ggaren 2011-01-10 11:24:23 -0800 (...and re-enable the tests.) 331804 9 aroben 2011-01-10 12:03:26 -0800 I don't know what the offending patch is yet. I'm testing r75289 now. 331811 10 aroben 2011-01-10 12:06:29 -0800 Rolling out r75289 fixes the assertions. 331815 11 barraclough 2011-01-10 12:08:25 -0800 :-( 331829 12 aroben 2011-01-10 12:17:09 -0800 Rolled out r75289 and r75392. I commented in bug 26276.