52154 2011-01-10 10:47:32 -0800 JITStubs doesn't compile when using ARMv7Assembler and RVCT 2011-01-10 12:39:29 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 0 dave+webkit webkit-unassigned barraclough commit-queue dbates oliver webkit.review.bot oldest_to_newest 331696 0 dave+webkit 2011-01-10 10:47:32 -0800 Compilation errors occur when using ARMv7Assembler and RVCT compiler. CTIs aren't defined. 331706 1 78413 dave+webkit 2011-01-10 10:54:09 -0800 Created attachment 78413 Add CTI asm versions for RVCT with THUMB2 331708 2 webkit.review.bot 2011-01-10 10:57:10 -0800 Attachment 78413 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/jit/JITStubs.cpp']" exit_code: 1 Source/JavaScriptCore/ChangeLog:3: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Source/JavaScriptCore/ChangeLog:12: Line contains tab character. [whitespace/tab] [5] Total errors found: 7 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 331749 3 78413 eric 2011-01-10 11:25:20 -0800 Comment on attachment 78413 Add CTI asm versions for RVCT with THUMB2 Please fix the tabs. 331778 4 78419 dave+webkit 2011-01-10 11:44:14 -0800 Created attachment 78419 Same as 78413 without tabs in ChangeLog 331846 5 78419 commit-queue 2011-01-10 12:39:23 -0800 Comment on attachment 78419 Same as 78413 without tabs in ChangeLog Clearing flags on attachment: 78419 Committed r75413: <http://trac.webkit.org/changeset/75413> 331847 6 commit-queue 2011-01-10 12:39:29 -0800 All reviewed patches have been landed. Closing bug. 78413 2011-01-10 10:54:09 -0800 2011-01-10 11:44:14 -0800 Add CTI asm versions for RVCT with THUMB2 patch52154.txt text/plain 3454 dave+webkit Y29tbWl0IDIzNjA5YzQ2NWUyNzliOTk3NDBmMDY0Yzk3OTIzOTFmNDRkYzBkMWQKQXV0aG9yOiBE YXZlIFRhcHVza2EgPGR0YXB1c2thQHJpbS5jb20+CkRhdGU6ICAgTW9uIEphbiAxMCAxMzo0Mjoz MSAyMDExIC0wNTAwCgogICAgMjAxMS0wMS0xMCAgRGF2ZSBUYXB1c2thICA8ZHRhcHVza2FAcmlt LmNvbT4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAog ICAgICAgICAgICBBZGQgQ1RJIEFTTSB2ZXJzaW9ucyBmb3IgUlZDVCBBUk0gVEhVTUIyIG1vZGUu CiAgICAKICAgICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTUyMTU0CiAgICAKICAgICAgICAgICAgKiBqaXQvSklUU3R1YnMuY3BwOgogICAgICAgICAgICAo SlNDOjpjdGlUcmFtcG9saW5lKToKICAgICAgICAgICAgKEpTQzo6Y3RpVk1UaHJvd1RyYW1wb2xp bmUpOgogICAgICAgICAgICAoSlNDOjpjdGlPcFRocm93Tm90Q2F1Z2h0KToKCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwppbmRleCA0MTQyNmYxLi4wNmQ0YmJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wMS0xMCAgRGF2ZSBUYXB1c2thICA8ZHRhcHVza2FA cmltLmNvbT4KKworCQlSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworCQlBZGQgQ1RJIEFT TSB2ZXJzaW9ucyBmb3IgUlZDVCBBUk0gVEhVTUIyIG1vZGUuCisKKwkJaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyMTU0CisKKwkJKiBqaXQvSklUU3R1YnMuY3BwOgor CQkoSlNDOjpjdGlUcmFtcG9saW5lKToKKwkJKEpTQzo6Y3RpVk1UaHJvd1RyYW1wb2xpbmUpOgor CQkoSlNDOjpjdGlPcFRocm93Tm90Q2F1Z2h0KToKKwogMjAxMS0wMS0wOCAgUGF0cmljayBHYW5z dGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBB ZGxlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAKaW5kZXggMDk1OWE2ZS4u N2Q4NmU1YyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAKQEAgLTEsNyAr MSw3IEBACiAvKgogICogQ29weXJpZ2h0IChDKSAyMDA4LCAyMDA5IEFwcGxlIEluYy4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KICAqIENvcHlyaWdodCAoQykgMjAwOCBDYW1lcm9uIFp3YXJpY2ggPGN3 endhcmljaEB1d2F0ZXJsb28uY2E+Ci0gKiBDb3B5cmlnaHQgKEMpIFJlc2VhcmNoIEluIE1vdGlv biBMaW1pdGVkIDIwMTAuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIFJl c2VhcmNoIEluIE1vdGlvbiBMaW1pdGVkIDIwMTAsIDIwMTEuIEFsbCByaWdodHMgcmVzZXJ2ZWQu CiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jt cywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlk ZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTczNyw2ICs3MzcsNTQgQEAgU1lN Qk9MX1NUUklORyhjdGlPcFRocm93Tm90Q2F1Z2h0KSAiOiIgIlxuIgogICAgICJtb3YgcGMsIGxy IiAiXG4iCiApOwogCisjZWxpZiBDT01QSUxFUihSVkNUKSAmJiBDUFUoQVJNX1RIVU1CMikKKwor X19hc20gRW5jb2RlZEpTVmFsdWUgY3RpVHJhbXBvbGluZSh2b2lkKiwgUmVnaXN0ZXJGaWxlKiwg Q2FsbEZyYW1lKiwgSlNWYWx1ZSosIFByb2ZpbGVyKiosIEpTR2xvYmFsRGF0YSopCit7CisgICAg UFJFU0VSVkU4CisgICAgc3ViIHNwLCBzcCwgIyBFTkFCTEVfUFJPRklMRVJfUkVGRVJFTkNFX09G RlNFVAorICAgIHN0ciBsciwgW3NwLCAjIFBSRVNFUlZFRF9SRVRVUk5fQUREUkVTU19PRkZTRVQg XQorICAgIHN0ciByNCwgW3NwLCAjIFBSRVNFUlZFRF9SNF9PRkZTRVQgXQorICAgIHN0ciByNSwg W3NwLCAjIFBSRVNFUlZFRF9SNV9PRkZTRVQgXQorICAgIHN0ciByNiwgW3NwLCAjIFBSRVNFUlZF RF9SNl9PRkZTRVQgXQorICAgIHN0ciByMSwgW3NwLCAjIFJFR0lTVEVSX0ZJTEVfT0ZGU0VUIF0K KyAgICBzdHIgcjIsIFtzcCwgIyBDQUxMRlJBTUVfT0ZGU0VUIF0KKyAgICBzdHIgcjMsIFtzcCwg IyBFWENFUFRJT05fT0ZGU0VUIF0KKyAgICBjcHkgcjUsIHIyCisgICAgbW92IHI2LCAjNTEyCisg ICAgYmx4IHIwCisgICAgbGRyIHI2LCBbc3AsICMgUFJFU0VSVkVEX1I2X09GRlNFVCBdCisgICAg bGRyIHI1LCBbc3AsICMgUFJFU0VSVkVEX1I1X09GRlNFVCBdCisgICAgbGRyIHI0LCBbc3AsICMg UFJFU0VSVkVEX1I0X09GRlNFVCBdCisgICAgbGRyIGxyLCBbc3AsICMgUFJFU0VSVkVEX1JFVFVS Tl9BRERSRVNTX09GRlNFVCBdCisgICAgYWRkIHNwLCBzcCwgIyBFTkFCTEVfUFJPRklMRVJfUkVG RVJFTkNFX09GRlNFVAorICAgIGJ4IGxyCit9CisKK19fYXNtIHZvaWQgY3RpVk1UaHJvd1RyYW1w b2xpbmUoKQoreworICAgIFBSRVNFUlZFOAorICAgIGNweSByMCwgc3AKKyAgICBibCBjdGlfdm1f dGhyb3cKKyAgICBsZHIgcjYsIFtzcCwgIyBQUkVTRVJWRURfUjZfT0ZGU0VUIF0KKyAgICBsZHIg cjUsIFtzcCwgIyBQUkVTRVJWRURfUjVfT0ZGU0VUIF0KKyAgICBsZHIgcjQsIFtzcCwgIyBQUkVT RVJWRURfUjRfT0ZGU0VUIF0KKyAgICBsZHIgbHIsIFtzcCwgIyBQUkVTRVJWRURfUkVUVVJOX0FE RFJFU1NfT0ZGU0VUIF0KKyAgICBhZGQgc3AsIHNwLCAjIEVOQUJMRV9QUk9GSUxFUl9SRUZFUkVO Q0VfT0ZGU0VUCisgICAgYnggbHIKK30KKworX19hc20gdm9pZCBjdGlPcFRocm93Tm90Q2F1Z2h0 KCkKK3sKKyAgICBQUkVTRVJWRTgKKyAgICBsZHIgcjYsIFtzcCwgIyBQUkVTRVJWRURfUjZfT0ZG U0VUIF0KKyAgICBsZHIgcjUsIFtzcCwgIyBQUkVTRVJWRURfUjVfT0ZGU0VUIF0KKyAgICBsZHIg cjQsIFtzcCwgIyBQUkVTRVJWRURfUjRfT0ZGU0VUIF0KKyAgICBsZHIgbHIsIFtzcCwgIyBQUkVT RVJWRURfUkVUVVJOX0FERFJFU1NfT0ZGU0VUIF0KKyAgICBhZGQgc3AsIHNwLCAjIEVOQUJMRV9Q Uk9GSUxFUl9SRUZFUkVOQ0VfT0ZGU0VUCisgICAgYnggbHIKK30KKwogI2VsaWYgQ09NUElMRVIo UlZDVCkgJiYgQ1BVKEFSTV9UUkFESVRJT05BTCkKIAogX19hc20gRW5jb2RlZEpTVmFsdWUgY3Rp VHJhbXBvbGluZSh2b2lkKiwgUmVnaXN0ZXJGaWxlKiwgQ2FsbEZyYW1lKiwgdm9pZCogLyp1bnVz ZWQxKi8sIFByb2ZpbGVyKiosIEpTR2xvYmFsRGF0YSopCg== 78419 2011-01-10 11:44:14 -0800 2011-01-10 12:39:23 -0800 Same as 78413 without tabs in ChangeLog patch52154.txt text/plain 3496 dave+webkit Y29tbWl0IDM4OTE0MTgwYjM2ODVkYjllNmRlOGUwOTk3MzM3YmEzNDA2OTgyMDAKQXV0aG9yOiBE YXZlIFRhcHVza2EgPGR0YXB1c2thQHJpbS5jb20+CkRhdGU6ICAgTW9uIEphbiAxMCAxMzo0Mjoz MSAyMDExIC0wNTAwCgogICAgMjAxMS0wMS0xMCAgRGF2ZSBUYXB1c2thICA8ZHRhcHVza2FAcmlt LmNvbT4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAog ICAgICAgICAgICBBZGQgQ1RJIEFTTSB2ZXJzaW9ucyBmb3IgUlZDVCBBUk0gVEhVTUIyIG1vZGUu CiAgICAKICAgICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTUyMTU0CiAgICAKICAgICAgICAgICAgKiBqaXQvSklUU3R1YnMuY3BwOgogICAgICAgICAgICAo SlNDOjpjdGlUcmFtcG9saW5lKToKICAgICAgICAgICAgKEpTQzo6Y3RpVk1UaHJvd1RyYW1wb2xp bmUpOgogICAgICAgICAgICAoSlNDOjpjdGlPcFRocm93Tm90Q2F1Z2h0KToKCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L0NoYW5nZUxvZwppbmRleCA0MTQyNmYxLi44ZjhkMGM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wMS0xMCAgRGF2ZSBUYXB1c2thICA8ZHRhcHVza2FA cmltLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgQ1RJIEFTTSB2ZXJzaW9ucyBmb3IgUlZDVCBBUk0gVEhVTUIyIG1vZGUuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyMTU0CisKKyAgICAg ICAgKiBqaXQvSklUU3R1YnMuY3BwOgorICAgICAgICAoSlNDOjpjdGlUcmFtcG9saW5lKToKKyAg ICAgICAgKEpTQzo6Y3RpVk1UaHJvd1RyYW1wb2xpbmUpOgorICAgICAgICAoSlNDOjpjdGlPcFRo cm93Tm90Q2F1Z2h0KToKKwogMjAxMS0wMS0wOCAgUGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUU3R1YnMuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAKaW5kZXggMDk1OWE2ZS4uN2Q4NmU1YyAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2ppdC9KSVRTdHVicy5jcHAKQEAgLTEsNyArMSw3IEBACiAvKgogICog Q29weXJpZ2h0IChDKSAyMDA4LCAyMDA5IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K ICAqIENvcHlyaWdodCAoQykgMjAwOCBDYW1lcm9uIFp3YXJpY2ggPGN3endhcmljaEB1d2F0ZXJs b28uY2E+Ci0gKiBDb3B5cmlnaHQgKEMpIFJlc2VhcmNoIEluIE1vdGlvbiBMaW1pdGVkIDIwMTAu IEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIFJlc2VhcmNoIEluIE1vdGlv biBMaW1pdGVkIDIwMTAsIDIwMTEuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0 cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRo b3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9s bG93aW5nIGNvbmRpdGlvbnMKQEAgLTczNyw2ICs3MzcsNTQgQEAgU1lNQk9MX1NUUklORyhjdGlP cFRocm93Tm90Q2F1Z2h0KSAiOiIgIlxuIgogICAgICJtb3YgcGMsIGxyIiAiXG4iCiApOwogCisj ZWxpZiBDT01QSUxFUihSVkNUKSAmJiBDUFUoQVJNX1RIVU1CMikKKworX19hc20gRW5jb2RlZEpT VmFsdWUgY3RpVHJhbXBvbGluZSh2b2lkKiwgUmVnaXN0ZXJGaWxlKiwgQ2FsbEZyYW1lKiwgSlNW YWx1ZSosIFByb2ZpbGVyKiosIEpTR2xvYmFsRGF0YSopCit7CisgICAgUFJFU0VSVkU4CisgICAg c3ViIHNwLCBzcCwgIyBFTkFCTEVfUFJPRklMRVJfUkVGRVJFTkNFX09GRlNFVAorICAgIHN0ciBs ciwgW3NwLCAjIFBSRVNFUlZFRF9SRVRVUk5fQUREUkVTU19PRkZTRVQgXQorICAgIHN0ciByNCwg W3NwLCAjIFBSRVNFUlZFRF9SNF9PRkZTRVQgXQorICAgIHN0ciByNSwgW3NwLCAjIFBSRVNFUlZF RF9SNV9PRkZTRVQgXQorICAgIHN0ciByNiwgW3NwLCAjIFBSRVNFUlZFRF9SNl9PRkZTRVQgXQor ICAgIHN0ciByMSwgW3NwLCAjIFJFR0lTVEVSX0ZJTEVfT0ZGU0VUIF0KKyAgICBzdHIgcjIsIFtz cCwgIyBDQUxMRlJBTUVfT0ZGU0VUIF0KKyAgICBzdHIgcjMsIFtzcCwgIyBFWENFUFRJT05fT0ZG U0VUIF0KKyAgICBjcHkgcjUsIHIyCisgICAgbW92IHI2LCAjNTEyCisgICAgYmx4IHIwCisgICAg bGRyIHI2LCBbc3AsICMgUFJFU0VSVkVEX1I2X09GRlNFVCBdCisgICAgbGRyIHI1LCBbc3AsICMg UFJFU0VSVkVEX1I1X09GRlNFVCBdCisgICAgbGRyIHI0LCBbc3AsICMgUFJFU0VSVkVEX1I0X09G RlNFVCBdCisgICAgbGRyIGxyLCBbc3AsICMgUFJFU0VSVkVEX1JFVFVSTl9BRERSRVNTX09GRlNF VCBdCisgICAgYWRkIHNwLCBzcCwgIyBFTkFCTEVfUFJPRklMRVJfUkVGRVJFTkNFX09GRlNFVAor ICAgIGJ4IGxyCit9CisKK19fYXNtIHZvaWQgY3RpVk1UaHJvd1RyYW1wb2xpbmUoKQoreworICAg IFBSRVNFUlZFOAorICAgIGNweSByMCwgc3AKKyAgICBibCBjdGlfdm1fdGhyb3cKKyAgICBsZHIg cjYsIFtzcCwgIyBQUkVTRVJWRURfUjZfT0ZGU0VUIF0KKyAgICBsZHIgcjUsIFtzcCwgIyBQUkVT RVJWRURfUjVfT0ZGU0VUIF0KKyAgICBsZHIgcjQsIFtzcCwgIyBQUkVTRVJWRURfUjRfT0ZGU0VU IF0KKyAgICBsZHIgbHIsIFtzcCwgIyBQUkVTRVJWRURfUkVUVVJOX0FERFJFU1NfT0ZGU0VUIF0K KyAgICBhZGQgc3AsIHNwLCAjIEVOQUJMRV9QUk9GSUxFUl9SRUZFUkVOQ0VfT0ZGU0VUCisgICAg YnggbHIKK30KKworX19hc20gdm9pZCBjdGlPcFRocm93Tm90Q2F1Z2h0KCkKK3sKKyAgICBQUkVT RVJWRTgKKyAgICBsZHIgcjYsIFtzcCwgIyBQUkVTRVJWRURfUjZfT0ZGU0VUIF0KKyAgICBsZHIg cjUsIFtzcCwgIyBQUkVTRVJWRURfUjVfT0ZGU0VUIF0KKyAgICBsZHIgcjQsIFtzcCwgIyBQUkVT RVJWRURfUjRfT0ZGU0VUIF0KKyAgICBsZHIgbHIsIFtzcCwgIyBQUkVTRVJWRURfUkVUVVJOX0FE RFJFU1NfT0ZGU0VUIF0KKyAgICBhZGQgc3AsIHNwLCAjIEVOQUJMRV9QUk9GSUxFUl9SRUZFUkVO Q0VfT0ZGU0VUCisgICAgYnggbHIKK30KKwogI2VsaWYgQ09NUElMRVIoUlZDVCkgJiYgQ1BVKEFS TV9UUkFESVRJT05BTCkKIAogX19hc20gRW5jb2RlZEpTVmFsdWUgY3RpVHJhbXBvbGluZSh2b2lk KiwgUmVnaXN0ZXJGaWxlKiwgQ2FsbEZyYW1lKiwgdm9pZCogLyp1bnVzZWQxKi8sIFByb2ZpbGVy KiosIEpTR2xvYmFsRGF0YSopCg==