52141 2011-01-10 00:36:05 -0800 [Chromium] Issue 57432: Layout Test fast/canvas/drawImage-with-negative-source-destination.html failing with --accelerated-2d-canvas 2011-01-10 19:30:06 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 honten webkit-unassigned abarth honten jamesr kbr mdelaney7 senorblanco oldest_to_newest 331528 0 78379 honten 2011-01-10 00:36:05 -0800 Created attachment 78379 Fix shader program Issue 57432: Layout Test fast/canvas/drawImage-with-negative-source-destination.html failing with --accelerated-2d-canvas Originally the test result was following, run_webkit_tests --accelerated-2d-canvas fast/canvas/drawImage-with-negative-source-destination.html Txt diffs: --- D:\src\chromium1\src\webkit\Release\layout-test-results\fast/canvas/drawImage-with-negative-source-destination-expected.txt +++ D:\src\chromium1\src\webkit\Release\layout-test-results\fast/canvas/drawImage-with-negative-source-destination-actual.txt @@ -3,8 +3,8 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS imgdata[4] is 0 -PASS imgdata[5] is 255 +FAIL imgdata[4] should be 0. Was 255. +FAIL imgdata[5] should be 255. Was 0. PASS imgdata[6] is 0 PASS successfullyParsed is true 331530 1 honten 2011-01-10 00:40:50 -0800 Could you review my patch? This is originally reported in Chromium project, but the same error can be shown in WebKit itself. Thanks, 331532 2 78379 abarth 2011-01-10 01:05:25 -0800 Comment on attachment 78379 Fix shader program Thanks for the patch, but all patches need to have a ChangeLog entry that describes why we're making the change. In the case, you'll want to mention the test that you're fixing and why we should replace texCoord with gl_TexCoord[0]. This page has more detailed information: http://webkit.org/coding/contributing.html 331616 3 78379 senorblanco 2011-01-10 07:14:09 -0800 Comment on attachment 78379 Fix shader program View in context: https://bugs.webkit.org/attachment.cgi?id=78379&action=review > WebCore/platform/graphics/gpu/TexShader.cpp:58 > + " gl_TexCoord[0] = texMatrix * position;\n" This fix doesn't make sense to me. AFAIK, gl_TexCoord is not available in OpenGL ES 2.0 (and deprecated as of desktop GLSL 1.3) and we shouldn't be introducing it into new code. It's possible that this worked due to some kind of artifact of the GLES2 -> desktop GL translation, but we shouldn't be relying on that. 332007 4 78463 senorblanco 2011-01-10 15:49:34 -0800 Created attachment 78463 Patch 332013 5 78463 jamesr 2011-01-10 15:53:22 -0800 Comment on attachment 78463 Patch R=me 332128 6 honten 2011-01-10 19:28:54 -0800 I see, Anyway, thank you for your patch!! It is good study for me;-) 332129 7 senorblanco 2011-01-10 19:30:06 -0800 Committed r75469: <http://trac.webkit.org/changeset/75469> 78379 2011-01-10 00:36:05 -0800 2011-01-10 15:49:29 -0800 Fix shader program 57432.patch text/plain 1249 honten ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1RleFNoYWRlci5jcHAg Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9UZXhTaGFkZXIuY3BwCmluZGV4IGQ3ZmZh MTcuLjgzNGFiY2UgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1Rl eFNoYWRlci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvVGV4U2hhZGVy LmNwcApAQCAtNTQsOSArNTQsOCBAQCBQYXNzT3duUHRyPFRleFNoYWRlcj4gVGV4U2hhZGVyOjpj cmVhdGUoR3JhcGhpY3NDb250ZXh0M0QqIGNvbnRleHQpCiAgICAgICAgICJ1bmlmb3JtIG1hdDMg bWF0cml4O1xuIgogICAgICAgICAidW5pZm9ybSBtYXQzIHRleE1hdHJpeDtcbiIKICAgICAgICAg ImF0dHJpYnV0ZSB2ZWMzIHBvc2l0aW9uO1xuIgotICAgICAgICAidmFyeWluZyB2ZWMzIHRleENv b3JkO1xuIgogICAgICAgICAidm9pZCBtYWluKCkge1xuIgotICAgICAgICAiICAgIHRleENvb3Jk ID0gdGV4TWF0cml4ICogcG9zaXRpb247XG4iCisgICAgICAgICIgICAgZ2xfVGV4Q29vcmRbMF0g PSB0ZXhNYXRyaXggKiBwb3NpdGlvbjtcbiIKICAgICAgICAgIiAgICBnbF9Qb3NpdGlvbiA9IHZl YzQobWF0cml4ICogcG9zaXRpb24sIDEuMCk7XG4iCiAgICAgICAgICJ9XG4iOwogICAgIHN0YXRp YyBjb25zdCBjaGFyKiBmcmFnbWVudFNoYWRlclNvdXJjZSA9CkBAIC02NSw5ICs2NCw4IEBAIFBh c3NPd25QdHI8VGV4U2hhZGVyPiBUZXhTaGFkZXI6OmNyZWF0ZShHcmFwaGljc0NvbnRleHQzRCog Y29udGV4dCkKICAgICAgICAgIiNlbmRpZlxuIgogICAgICAgICAidW5pZm9ybSBzYW1wbGVyMkQg c2FtcGxlcjtcbiIKICAgICAgICAgInVuaWZvcm0gZmxvYXQgYWxwaGE7XG4iCi0gICAgICAgICJ2 YXJ5aW5nIHZlYzMgdGV4Q29vcmQ7XG4iCiAgICAgICAgICJ2b2lkIG1haW4oKSB7XG4iCi0gICAg ICAgICIgICAgZ2xfRnJhZ0NvbG9yID0gdGV4dHVyZTJEKHNhbXBsZXIsIHRleENvb3JkLnh5KSog dmVjNChhbHBoYSk7XG4iCisgICAgICAgICIgICAgZ2xfRnJhZ0NvbG9yID0gdGV4dHVyZTJEKHNh bXBsZXIsIGdsX1RleENvb3JkWzBdLnh5KSogdmVjNChhbHBoYSk7XG4iCiAgICAgICAgICJ9XG4i OwogICAgIHVuc2lnbmVkIHByb2dyYW0gPSBsb2FkUHJvZ3JhbShjb250ZXh0LCB2ZXJ0ZXhTaGFk ZXJTb3VyY2UsIGZyYWdtZW50U2hhZGVyU291cmNlKTsKICAgICBpZiAoIXByb2dyYW0pCg== 78463 2011-01-10 15:49:34 -0800 2011-01-10 15:53:22 -0800 Patch bug-52141-20110110184932.patch text/plain 4408 senorblanco SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc1NDQyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzQgQEAKKzIwMTEtMDEtMTAgIFN0ZXBoZW4g V2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGNhbnZhcy0+Y2FudmFzIGRyYXdzIG9uIHRo ZSBHUFUgcGF0aC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUyMTQxCisgICAgICAgIAorICAgICAgICBUd28gcHJvYmxlbXM6ICBhY2NvcmRpbmcgdG8g dGhlIGNhbnZhcyBzcGVjLCBib3RoIHNvdXJjZSBhbmQKKyAgICAgICAgZGVzdGluYXRpb24gcmVj dHMgY2FuIGhhdmUgbmVnYXRpdmUgd2lkdGggb3IgaGVpZ2h0LCBidXQgdGhpcyBzaG91bGRuJ3QK KyAgICAgICAgY2F1c2UgdGhlIGltYWdlIHRvIGJlIGZsaXBwZWQuICBTbyB3ZSBuZWVkIHRvIG5v cm1hbGl6ZSB0aGUgcmVjdHMgKGluCisgICAgICAgIHRoZSBzb2Z0d2FyZSBwYXRoLCB0aGlzIGlz IGRvbmUgYnkgQml0bWFwSW1hZ2UqOjpkcmF3KS4gIFNlY29uZGx5LCBpbgorICAgICAgICB0aGUg RkJPLT5GQk8gcGF0aCwgdGhlIGltYWdlIG5lZWRzIHRvIGJlIGZsaXBwZWQgdmVydGljYWxseSwg c2luY2UgaXQKKyAgICAgICAgaXMgZHJhd24gdXBzaWRlIGRvd24uICBXZSB3ZXJlIGRvaW5nIHRo aXMgYnkgZmxpcHBpbmcgdGhlIGRlc3RpbmF0aW9uCisgICAgICAgIHJlY3QsIGJ1dCB0aGlzIGRv ZXNuJ3Qgd29yayBpZiB0aGUgc291cmNlIHJlY3QgaXMgbm90IHRoZSBlbnRpcmUgaW1hZ2UsCisg ICAgICAgIHNpbmNlIHdlIGV4dHJhY3QgdGhlIHdyb25nIHBhcnQgb2YgdGhlIGltYWdlLiAgRml4 ZWQgYnkgZmxpcHBpbmcgdGhlCisgICAgICAgIHNvdXJjZSByZWN0IGluc3RlYWQgKGFuZCBmbGlw cGluZyBpdCB3aXRoaW4gdGhlIGltYWdlIGJ1ZmZlcidzIGhlaWdodCwKKyAgICAgICAgbm90IHRo ZSBzb3VyY2UgcmVjdCdzIGhlaWdodCkuCisKKyAgICAgICAgQ292ZXJlZCBieSBmYXN0L2NhbnZh cy9kcmF3SW1hZ2Utd2l0aC1uZWdhdGl2ZS1zb3VyY2UtZGVzdGluYXRpb24uaHRtbC4KKworCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9CaXRtYXBJbWFnZVNpbmdsZUZyYW1lU2tp YS5oOgorICAgICAgICBQdXQgbm9ybWFsaXplUmVjdCgpIGluIGdsb2JhbCBzY29wZS4KKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9za2lhL0ltYWdlQnVmZmVyU2tpYS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6ZHJhdyk6CisgICAgICAgIEZpeCBhcyBhYm92ZTogIG5v cm1hbGl6ZSBib3RoIHNvdXJjZSBhbmQgZGVzdCByZWN0cywgYW5kIGZsaXAgdGhlCisgICAgICAg IHNvdXJjZSByZWN0IGluc3RlYWQgb2YgdGhlIGRlc3QgcmVjdC4KKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9za2lhL0ltYWdlU2tpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpub3JtYWxp emVSZWN0KToKKyAgICAgICAgUHV0IG5vcm1hbGl6ZVJlY3QoKSBpbiBnbG9iYWwgc2NvcGUuCisK IDIwMTEtMDEtMTAgIExlb25pZCBFYnJpbCAgPGxlb25pZC5lYnJpbEBub2tpYS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0JpdG1hcEltYWdlU2luZ2xlRnJhbWVT a2lhLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9CaXRtYXBJbWFnZVNpbmdsZUZyYW1lU2tpYS5oCShyZXZpc2lvbiA3NTQzOSkKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvQml0bWFwSW1hZ2VTaW5nbGVGcmFtZVNr aWEuaAkod29ya2luZyBjb3B5KQpAQCAtODIsNiArODIsOCBAQCBwcml2YXRlOgogICAgIGV4cGxp Y2l0IEJpdG1hcEltYWdlU2luZ2xlRnJhbWVTa2lhKGNvbnN0IFNrQml0bWFwJik7CiB9OwogCitG bG9hdFJlY3Qgbm9ybWFsaXplUmVjdChjb25zdCBGbG9hdFJlY3QmKTsKKwogfSAvLyBuYW1lc3Bh Y2UgV2ViQ29yZQogCiAjZW5kaWYgIC8vIEJpdG1hcEltYWdlU2luZ2xlRnJhbWVTa2lhX2gKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lh LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L0ltYWdlQnVmZmVyU2tpYS5jcHAJKHJldmlzaW9uIDc1NDM5KQorKysgU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xMTQsMTEgKzExNCwxMiBAQCB2b2lkIEltYWdlQnVmZmVyOjpkcmF3KEdyYXBoaWNzQ29u dGV4dCogCiAgICAgICAgIGlmIChjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKS0+Y2FuQWNjZWxl cmF0ZSgpKSB7CiAgICAgICAgICAgICBEcmF3aW5nQnVmZmVyKiBzb3VyY2VEcmF3aW5nQnVmZmVy ID0gbV9kYXRhLm1fcGxhdGZvcm1Db250ZXh0LmdwdUNhbnZhcygpLT5kcmF3aW5nQnVmZmVyKCk7 CiAgICAgICAgICAgICB1bnNpZ25lZCBzb3VyY2VUZXh0dXJlID0gc3RhdGljX2Nhc3Q8dW5zaWdu ZWQ+KHNvdXJjZURyYXdpbmdCdWZmZXItPnBsYXRmb3JtQ29sb3JCdWZmZXIoKSk7Ci0gICAgICAg ICAgICBGbG9hdFJlY3QgZGVzdFJlY3RGbGlwcGVkKGRlc3RSZWN0KTsKLSAgICAgICAgICAgIGRl c3RSZWN0RmxpcHBlZC5zZXRZKGRlc3RSZWN0LnkoKSArIGRlc3RSZWN0LmhlaWdodCgpKTsKLSAg ICAgICAgICAgIGRlc3RSZWN0RmxpcHBlZC5zZXRIZWlnaHQoLWRlc3RSZWN0LmhlaWdodCgpKTsK KyAgICAgICAgICAgIEZsb2F0UmVjdCBkZXN0UmVjdE5vcm1hbGl6ZWQobm9ybWFsaXplUmVjdChk ZXN0UmVjdCkpOworICAgICAgICAgICAgRmxvYXRSZWN0IHNyY1JlY3RGbGlwcGVkKG5vcm1hbGl6 ZVJlY3Qoc3JjUmVjdCkpOworICAgICAgICAgICAgc3JjUmVjdEZsaXBwZWQuc2V0WShtX3NpemUu aGVpZ2h0KCkgLSBzcmNSZWN0LnkoKSk7CisgICAgICAgICAgICBzcmNSZWN0RmxpcHBlZC5zZXRI ZWlnaHQoLXNyY1JlY3QuaGVpZ2h0KCkpOwogICAgICAgICAgICAgY29udGV4dC0+cGxhdGZvcm1D b250ZXh0KCktPnByZXBhcmVGb3JIYXJkd2FyZURyYXcoKTsKLSAgICAgICAgICAgIGNvbnRleHQt PnBsYXRmb3JtQ29udGV4dCgpLT5ncHVDYW52YXMoKS0+ZHJhd1RleHR1cmVkUmVjdChzb3VyY2VU ZXh0dXJlLCBtX3NpemUsIHNyY1JlY3QsIGRlc3RSZWN0RmxpcHBlZCwgc3R5bGVDb2xvclNwYWNl LCBvcCk7CisgICAgICAgICAgICBjb250ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKS0+Z3B1Q2FudmFz KCktPmRyYXdUZXh0dXJlZFJlY3Qoc291cmNlVGV4dHVyZSwgbV9zaXplLCBzcmNSZWN0RmxpcHBl ZCwgZGVzdFJlY3ROb3JtYWxpemVkLCBzdHlsZUNvbG9yU3BhY2UsIG9wKTsKICAgICAgICAgICAg IHJldHVybjsKICAgICAgICAgfQogICAgICAgICBtX2RhdGEubV9wbGF0Zm9ybUNvbnRleHQuc3lu Y1NvZnR3YXJlQ2FudmFzKCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9za2lhL0ltYWdlU2tpYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3BwCShyZXZpc2lvbiA3NTQzOSkKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VTa2lhLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjk4LDcgKzI5OCw3IEBAIHN0YXRpYyB2b2lkIFRyYW5zZm9ybURpbWVuc2lvbnMo Y29uc3QgU2sKIH0KIAogLy8gQSBoZWxwZXIgbWV0aG9kIGZvciB0cmFuc2xhdGluZyBuZWdhdGl2 ZSB3aWR0aCBhbmQgaGVpZ2h0IHZhbHVlcy4KLXN0YXRpYyBGbG9hdFJlY3Qgbm9ybWFsaXplUmVj dChjb25zdCBGbG9hdFJlY3QmIHJlY3QpCitGbG9hdFJlY3Qgbm9ybWFsaXplUmVjdChjb25zdCBG bG9hdFJlY3QmIHJlY3QpCiB7CiAgICAgRmxvYXRSZWN0IG5vcm0gPSByZWN0OwogICAgIGlmIChu b3JtLndpZHRoKCkgPCAwKSB7Cg==