52111 2011-01-08 11:14:59 -0800 [Qt] [WK2] MiniBrowser does not load pages opened in new windows 2011-01-10 11:22:14 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 1 benjamin webkit-unassigned benjamin kling webkit.review.bot oldest_to_newest 331230 0 78321 benjamin 2011-01-08 11:14:59 -0800 Created attachment 78321 test case When opening a page in new window with WebKit 2, the target page is never loaded. The attached test case illustrate 3 cases not working with Minibrowser. 331607 1 kling 2011-01-10 06:58:14 -0800 This is a bug in MiniBrowser, patch coming. 331611 2 78397 kling 2011-01-10 07:06:31 -0800 Created attachment 78397 Proposed patch 331613 3 78397 kling 2011-01-10 07:07:46 -0800 Comment on attachment 78397 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=78397&action=review > Tools/MiniBrowser/qt/BrowserView.h:40 > + BrowserView(QGraphicsWKView::BackingStoreType, QWKContext* context, QWidget* parent = 0); Dammit Kling, the "context" argument name isn't necessary here. 331614 4 webkit.review.bot 2011-01-10 07:09:40 -0800 Attachment 78397 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/MiniBrowser/qt/BrowserView.cpp', u'Tools/MiniBrowser/qt/BrowserView.h', u'Tools/MiniBrowser/qt/BrowserWindow.cpp', u'Tools/MiniBrowser/qt/BrowserWindow.h', u'WebKit2/ChangeLog', u'WebKit2/UIProcess/API/qt/qwkpage.cpp']" exit_code: 1 Tools/MiniBrowser/qt/BrowserView.h:40: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 331618 5 kling 2011-01-10 07:26:40 -0800 Committed r75373: <http://trac.webkit.org/changeset/75373> 331740 6 benjamin 2011-01-10 11:22:14 -0800 Wow, and https://bugs.webkit.org/show_bug.cgi?id=41441 fixes the last case so I have nothing left to do. Amazing job Andreas, thanks for the help. 78321 2011-01-08 11:14:59 -0800 2011-01-08 11:14:59 -0800 test case index.html text/html 404 benjamin PGh0bWw+CiAgPGJvZHk+CiAgICA8b2w+CiAgICAgIDxsaT48YSBocmVmPSJodHRwOi8vbGluZ3Vh LmlraXBvdS5jb20vIiB0YXJnZXQ9Il9ibGFuayI+UmVndWxhciBsaW5rIHdpdGggdGFyZ2V0PV9i bGFuazwvYT48L2xpPgogICAgICA8bGk+PGEgaHJlZj0iaHR0cDovL2lraXBvdS5jb20vIiBvbmNs aWNrPSJ3aW5kb3cub3BlbignaHR0cDovL2xpbmd1YS5pa2lwb3UuY29tLycpOyByZXR1cm4gZmFs c2U7Ij5MaW5rIG9wZW5lZCBieSB3aW5kb3cub3BlbjwvYT48L2xpPgogICAgICA8bGk+PGEgaHJl Zj0iaHR0cDovL2xpbmd1YS5pa2lwb3UuY29tLyI+UmVndWxhciBsaW5rPC9hPiAodXNlIGNvbnRl eHQgbWVudS0+b3BlbiBpbiBuZXcgd2luZG93KTwvbGk+CiAgICA8L29sPgogIDwvYm9keT4KPC9o dG1sPgo= 78397 2011-01-10 07:06:31 -0800 2011-01-10 07:17:42 -0800 Proposed patch bug-52111.diff text/plain 4568 kling ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxNjA3 OTNlLi45N2JmNDRmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTEtMDEtMTAgIEFuZHJlYXMgS2xpbmcgIDxrbGlu Z0B3ZWJraXQub3JnPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gW1dLMl0gTWluaUJyb3dzZXIgZG9lcyBub3QgbG9hZCBwYWdlcyBvcGVuZWQg aW4gbmV3IHdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUyMTExCisKKyAgICAgICAgV2hlbiBnZXR0aW5nIGEgY3JlYXRlTmV3UGFnZSgpIGNh bGxiYWNrIGZyb20gUVdLUGFnZSwgY3JlYXRlIHRoZQorICAgICAgICBuZXcgcGFnZSB3aXRoIHRo ZSBzYW1lIFFXS0NvbnRleHQgYXMgdGhlIHBhZ2UgdGhhdCBpcyBwYXNzZWQgdG8KKyAgICAgICAg dGhlIGNhbGxiYWNrLgorCisgICAgICAgICogTWluaUJyb3dzZXIvcXQvQnJvd3NlclZpZXcuaDoK KyAgICAgICAgKiBNaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmNwcDoKKyAgICAgICAgKG5l d1BhZ2VGdW5jdGlvbik6CisgICAgICAgIChCcm93c2VyV2luZG93OjpCcm93c2VyV2luZG93KToK KyAgICAgICAgKiBNaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93Lmg6CisKKzIwMTEtMDEtMTAg IEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5 IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgogCiAgICAgICAgIFtRdF0gTWluaUJyb3dzZXI6 IFJlbW92ZSBzdXBlcmZsdW91cyBjcmVhdGVOZXdQYWdlKCkgY2FsbGJhY2sKZGlmZiAtLWdpdCBh L1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJWaWV3LmNwcCBiL1Rvb2xzL01pbmlCcm93c2Vy L3F0L0Jyb3dzZXJWaWV3LmNwcAppbmRleCA0YjhiZDkwLi42MTE4Zjc5IDEwMDY0NAotLS0gYS9U b29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyVmlldy5jcHAKKysrIGIvVG9vbHMvTWluaUJyb3dz ZXIvcXQvQnJvd3NlclZpZXcuY3BwCkBAIC0zMCwxMCArMzAsMTAgQEAKIAogI2luY2x1ZGUgPFFH cmFwaGljc1NjZW5lPgogCi1Ccm93c2VyVmlldzo6QnJvd3NlclZpZXcoUUdyYXBoaWNzV0tWaWV3 OjpCYWNraW5nU3RvcmVUeXBlIGJhY2tpbmdTdG9yZVR5cGUsIFFXaWRnZXQqIHBhcmVudCkKK0Jy b3dzZXJWaWV3OjpCcm93c2VyVmlldyhRR3JhcGhpY3NXS1ZpZXc6OkJhY2tpbmdTdG9yZVR5cGUg YmFja2luZ1N0b3JlVHlwZSwgUVdLQ29udGV4dCogY29udGV4dCwgUVdpZGdldCogcGFyZW50KQog ICAgIDogUUdyYXBoaWNzVmlldyhwYXJlbnQpCiAgICAgLCBtX2l0ZW0oMCkKLSAgICAsIG1fY29u dGV4dChuZXcgUVdLQ29udGV4dCh0aGlzKSkKKyAgICAsIG1fY29udGV4dChjb250ZXh0ID8gY29u dGV4dCA6IG5ldyBRV0tDb250ZXh0KHRoaXMpKQogewogICAgIG1faXRlbSA9IG5ldyBRR3JhcGhp Y3NXS1ZpZXcobV9jb250ZXh0LCBiYWNraW5nU3RvcmVUeXBlLCAwKTsKICAgICBzZXRTY2VuZShu ZXcgUUdyYXBoaWNzU2NlbmUodGhpcykpOwpkaWZmIC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIv cXQvQnJvd3NlclZpZXcuaCBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJWaWV3LmgKaW5k ZXggNzY4MGFhNy4uNzdhOWIwZCAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvcXQvQnJv d3NlclZpZXcuaAorKysgYi9Ub29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyVmlldy5oCkBAIC0z Nyw3ICszNyw3IEBAIGNsYXNzIEJyb3dzZXJWaWV3IDogcHVibGljIFFHcmFwaGljc1ZpZXcgewog ICAgIFFfT0JKRUNUCiAKIHB1YmxpYzoKLSAgICBCcm93c2VyVmlldyhRR3JhcGhpY3NXS1ZpZXc6 OkJhY2tpbmdTdG9yZVR5cGUsIFFXaWRnZXQqIHBhcmVudCA9IDApOworICAgIEJyb3dzZXJWaWV3 KFFHcmFwaGljc1dLVmlldzo6QmFja2luZ1N0b3JlVHlwZSwgUVdLQ29udGV4dCogY29udGV4dCwg UVdpZGdldCogcGFyZW50ID0gMCk7CiAgICAgdmlydHVhbCB+QnJvd3NlclZpZXcoKSB7IGRlbGV0 ZSBtX2l0ZW07IH0KIAogICAgIHZvaWQgbG9hZChjb25zdCBRU3RyaW5nJik7CmRpZmYgLS1naXQg YS9Ub29scy9NaW5pQnJvd3Nlci9xdC9Ccm93c2VyV2luZG93LmNwcCBiL1Rvb2xzL01pbmlCcm93 c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3BwCmluZGV4IGJlMDhjYWUuLmM2M2M5ZDYgMTAwNjQ0Ci0t LSBhL1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3BwCisrKyBiL1Rvb2xzL01p bmlCcm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuY3BwCkBAIC0yOCwyMCArMjgsMjAgQEAKIAogI2lu Y2x1ZGUgIkJyb3dzZXJXaW5kb3cuaCIKIAotc3RhdGljIFFXS1BhZ2UqIG5ld1BhZ2VGdW5jdGlv bihRV0tQYWdlKikKK3N0YXRpYyBRV0tQYWdlKiBuZXdQYWdlRnVuY3Rpb24oUVdLUGFnZSogcGFn ZSkKIHsKLSAgICBCcm93c2VyV2luZG93KiB3aW5kb3cgPSBuZXcgQnJvd3NlcldpbmRvdygpOwor ICAgIEJyb3dzZXJXaW5kb3cqIHdpbmRvdyA9IG5ldyBCcm93c2VyV2luZG93KHBhZ2UtPmNvbnRl eHQoKSk7CiAgICAgcmV0dXJuIHdpbmRvdy0+cGFnZSgpOwogfQogCiBRR3JhcGhpY3NXS1ZpZXc6 OkJhY2tpbmdTdG9yZVR5cGUgQnJvd3NlcldpbmRvdzo6YmFja2luZ1N0b3JlVHlwZUZvck5ld1dp bmRvdyA9IFFHcmFwaGljc1dLVmlldzo6U2ltcGxlOwogCi1Ccm93c2VyV2luZG93OjpCcm93c2Vy V2luZG93KCkKK0Jyb3dzZXJXaW5kb3c6OkJyb3dzZXJXaW5kb3coUVdLQ29udGV4dCogY29udGV4 dCkKIHsKICAgICBzZXRBdHRyaWJ1dGUoUXQ6OldBX0RlbGV0ZU9uQ2xvc2UpOwogCiAgICAgbV9t ZW51ID0gbmV3IFFNZW51QmFyKCk7Ci0gICAgbV9icm93c2VyID0gbmV3IEJyb3dzZXJWaWV3KGJh Y2tpbmdTdG9yZVR5cGVGb3JOZXdXaW5kb3cpOworICAgIG1fYnJvd3NlciA9IG5ldyBCcm93c2Vy VmlldyhiYWNraW5nU3RvcmVUeXBlRm9yTmV3V2luZG93LCBjb250ZXh0KTsKICAgICBtX2FkZHJl c3NCYXIgPSBuZXcgUUxpbmVFZGl0KCk7CiAKICAgICBtX21lbnUtPmFkZEFjdGlvbigiTmV3IFdp bmRvdyIsIHRoaXMsIFNMT1QobmV3V2luZG93KCkpKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlC cm93c2VyL3F0L0Jyb3dzZXJXaW5kb3cuaCBiL1Rvb2xzL01pbmlCcm93c2VyL3F0L0Jyb3dzZXJX aW5kb3cuaAppbmRleCAwMDEwZmJlLi5mOTg0MzA5IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJv d3Nlci9xdC9Ccm93c2VyV2luZG93LmgKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvcXQvQnJvd3Nl cldpbmRvdy5oCkBAIC0zOCw3ICszOCw3IEBAIGNsYXNzIEJyb3dzZXJXaW5kb3cgOiBwdWJsaWMg UU1haW5XaW5kb3cgewogICAgIFFfT0JKRUNUCiAKIHB1YmxpYzoKLSAgICBCcm93c2VyV2luZG93 KCk7CisgICAgQnJvd3NlcldpbmRvdyhRV0tDb250ZXh0KiA9IDApOwogICAgIH5Ccm93c2VyV2lu ZG93KCk7CiAgICAgdm9pZCBsb2FkKGNvbnN0IFFTdHJpbmcmIHVybCk7CiAKZGlmZiAtLWdpdCBh L1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTAwNjE4ZS4uNmJi MmEwYSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0Mi9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wMS0xMCAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdl YmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1F0XSBbV0syXSBNaW5pQnJvd3NlciBkb2VzIG5vdCBsb2FkIHBhZ2VzIG9wZW5lZCBpbiBu ZXcgd2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9NTIxMTEKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHA6CisgICAg ICAgIChRV0tQYWdlOjpjb250ZXh0KTogSW1wbGVtZW50IHRoaXMgbWV0aG9kLgorCiAyMDExLTAx LTA5ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgU2ltb24gRnJhc2VyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3 a3BhZ2UuY3BwIGIvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwCmluZGV4IGUx MTNiZDAuLmYwYTBjNTYgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2tw YWdlLmNwcAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAKQEAgLTQ4 OCw2ICs0ODgsMTEgQEAgV0tQYWdlUmVmIFFXS1BhZ2U6OnBhZ2VSZWYoKSBjb25zdAogICAgIHJl dHVybiB0b0FQSShkLT5wYWdlLmdldCgpKTsKIH0KIAorUVdLQ29udGV4dCogUVdLUGFnZTo6Y29u dGV4dCgpIGNvbnN0Cit7CisgICAgcmV0dXJuIGQtPmNvbnRleHQ7Cit9CisKIFFXS1ByZWZlcmVu Y2VzKiBRV0tQYWdlOjpwcmVmZXJlbmNlcygpIGNvbnN0CiB7CiAgICAgaWYgKCFkLT5wcmVmZXJl bmNlcykgewo=