52108 2011-01-08 03:01:04 -0800 [Qt][WK2] QWKView does not propagate show and hide events to the drawing area 2011-01-08 11:13:05 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 kbalazs webkit-unassigned kenneth zalan oldest_to_newest 331186 0 kbalazs 2011-01-08 03:01:04 -0800 Changes in the visibility of the widget should be propagated to the drawing area to stop or resume updating it in the web process. 331222 1 78319 kbalazs 2011-01-08 10:43:25 -0800 Created attachment 78319 proposed patch 331225 2 78320 kbalazs 2011-01-08 10:57:50 -0800 Created attachment 78320 patch - with build fix 331226 3 kenneth 2011-01-08 11:01:41 -0800 Zalan, FYI, how does this fit with your work? 331229 4 kbalazs 2011-01-08 11:12:13 -0800 Comitted in http://trac.webkit.org/changeset/75323. 78319 2011-01-08 10:43:25 -0800 2011-01-08 10:57:50 -0800 proposed patch sh.diff text/plain 1755 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ODgwNGZiMi4uNzkyYTJiZiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNCArMSwxNSBAQAorMjAxMS0wMS0wOCAgQmFsYXpzIEtlbGVt ZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XVtXSzJdIFFXS1ZpZXcgZG9lcyBub3QgcHJvcGFnYXRlIHNo b3cgYW5kIGhpZGUgZXZlbnRzIHRvIHRoZSBkcmF3aW5nIGFyZWEKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyMTA4CisKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL3F0L3FncmFwaGljc3drdmlldy5jcHA6CisgICAgICAgIChRR3JhcGhpY3NXS1ZpZXc6 OmV2ZW50KTogQ2FsbCBzZXRQYWdlSXNWaXNpYmxlIG9uIHRoZSBkcmF3aW5nIGFyZWEKKyAgICAg ICAgaWYgdGhlIGV2ZW50IGlzIFNob3cgb3IgSGlkZS4KKwogMjAxMC0xMi0yMCAgQmFsYXpzIEtl bGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCiAKZGlmZiAtLWdpdCBhL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhp Y3N3a3ZpZXcuY3BwIGIvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FncmFwaGljc3drdmlldy5j cHAKaW5kZXggNzg3NjYxNC4uMzhiOGM3NCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3F0L3FncmFwaGljc3drdmlldy5jcHAKKysrIGIvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3FncmFwaGljc3drdmlldy5jcHAKQEAgLTIyMSwxMSArMjIxLDIzIEBAIFFWYXJpYW50IFFHcmFw aGljc1dLVmlldzo6aXRlbUNoYW5nZShHcmFwaGljc0l0ZW1DaGFuZ2UgY2hhbmdlLCBjb25zdCBR VmFyaWFudCYKIC8qISBccmVpbXAKICovCiBib29sIFFHcmFwaGljc1dLVmlldzo6ZXZlbnQoUUV2 ZW50KiBldmVudCkKIHsKLSAgICBpZiAoZXZlbnQtPnR5cGUoKSA9PSBRRXZlbnQ6OlRvdWNoQmVn aW4gfHwgZXZlbnQtPnR5cGUoKSA9PSBRRXZlbnQ6OlRvdWNoRW5kIHx8IGV2ZW50LT50eXBlKCkg PT0gUUV2ZW50OjpUb3VjaFVwZGF0ZSkgeworICAgIFR5cGUgZXZlbnRUeXBlID0gZXZlbnQtPnR5 cGUoKTsKKyAgICBzd2l0Y2ggKGV2ZW50VHlwZSkgeworICAgIGNhc2UgUUV2ZW50OjpUb3VjaEJl Z2luOgorICAgIGNhc2UgUUV2ZW50OjpUb3VjaEVuZDoKKyAgICBjYXNlIFFFdmVudDo6VG91Y2hV cGRhdGU6CiAgICAgICAgIHRvdWNoRXZlbnQoc3RhdGljX2Nhc3Q8UVRvdWNoRXZlbnQqPihldmVu dCkpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICBjYXNlIFFFdmVudDo6U2hvdzoKKyAgICAg ICAgcGFnZSgpLT5kLT5wYWdlLT5kcmF3aW5nQXJlYSgpLT5zZXRQYWdlSXNWaXNpYmxlKHRydWUp OworICAgICAgICBicmVhazsKKyAgICBjYXNlIFFFdmVudDo6SGlkZToKKyAgICAgICAgcGFnZSgp LT5kLT5wYWdlLT5kcmF3aW5nQXJlYSgpLT5zZXRQYWdlSXNWaXNpYmxlKGZhbHNlKTsKKyAgICAg ICAgYnJlYWs7CisgICAgZGVmYXVsdDoKKyAgICAgICAgYnJlYWs7CiAgICAgfQogCiAgICAgLy8g SGVyZSBzbyB0aGF0IGl0IGNhbiBiZSByZWltcGxlbWVudGVkIHdpdGhvdXQgYnJlYWtpbmcgQUJJ LgogICAgIHJldHVybiBRR3JhcGhpY3NXaWRnZXQ6OmV2ZW50KGV2ZW50KTsK 78320 2011-01-08 10:57:50 -0800 2011-01-08 11:13:05 -0800 patch - with build fix sh.diff text/plain 1763 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ZDIzNGNkZi4uODA1YWYzNyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsNCArMSwxNSBAQAorMjAxMS0wMS0wOCAgQmFsYXpzIEtlbGVt ZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XVtXSzJdIFFXS1ZpZXcgZG9lcyBub3QgcHJvcGFnYXRlIHNo b3cgYW5kIGhpZGUgZXZlbnRzIHRvIHRoZSBkcmF3aW5nIGFyZWEKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyMTA4CisKKyAgICAgICAgKiBVSVByb2Nl c3MvQVBJL3F0L3FncmFwaGljc3drdmlldy5jcHA6CisgICAgICAgIChRR3JhcGhpY3NXS1ZpZXc6 OmV2ZW50KTogQ2FsbCBzZXRQYWdlSXNWaXNpYmxlIG9uIHRoZSBkcmF3aW5nIGFyZWEKKyAgICAg ICAgaWYgdGhlIGV2ZW50IGlzIFNob3cgb3IgSGlkZS4KKwogMjAxMC0xMi0yMCAgQmFsYXpzIEtl bGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCiAKZGlmZiAtLWdpdCBhL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhp Y3N3a3ZpZXcuY3BwIGIvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FncmFwaGljc3drdmlldy5j cHAKaW5kZXggNzg3NjYxNC4uOWYxNTcxNyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3F0L3FncmFwaGljc3drdmlldy5jcHAKKysrIGIvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3FncmFwaGljc3drdmlldy5jcHAKQEAgLTIyMSwxMSArMjIxLDIzIEBAIFFWYXJpYW50IFFHcmFw aGljc1dLVmlldzo6aXRlbUNoYW5nZShHcmFwaGljc0l0ZW1DaGFuZ2UgY2hhbmdlLCBjb25zdCBR VmFyaWFudCYKIC8qISBccmVpbXAKICovCiBib29sIFFHcmFwaGljc1dLVmlldzo6ZXZlbnQoUUV2 ZW50KiBldmVudCkKIHsKLSAgICBpZiAoZXZlbnQtPnR5cGUoKSA9PSBRRXZlbnQ6OlRvdWNoQmVn aW4gfHwgZXZlbnQtPnR5cGUoKSA9PSBRRXZlbnQ6OlRvdWNoRW5kIHx8IGV2ZW50LT50eXBlKCkg PT0gUUV2ZW50OjpUb3VjaFVwZGF0ZSkgeworICAgIFFFdmVudDo6VHlwZSBldmVudFR5cGUgPSBl dmVudC0+dHlwZSgpOworICAgIHN3aXRjaCAoZXZlbnRUeXBlKSB7CisgICAgY2FzZSBRRXZlbnQ6 OlRvdWNoQmVnaW46CisgICAgY2FzZSBRRXZlbnQ6OlRvdWNoRW5kOgorICAgIGNhc2UgUUV2ZW50 OjpUb3VjaFVwZGF0ZToKICAgICAgICAgdG91Y2hFdmVudChzdGF0aWNfY2FzdDxRVG91Y2hFdmVu dCo+KGV2ZW50KSk7CiAgICAgICAgIHJldHVybiB0cnVlOworICAgIGNhc2UgUUV2ZW50OjpTaG93 OgorICAgICAgICBwYWdlKCktPmQtPnBhZ2UtPmRyYXdpbmdBcmVhKCktPnNldFBhZ2VJc1Zpc2li bGUodHJ1ZSk7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgUUV2ZW50OjpIaWRlOgorICAgICAg ICBwYWdlKCktPmQtPnBhZ2UtPmRyYXdpbmdBcmVhKCktPnNldFBhZ2VJc1Zpc2libGUoZmFsc2Up OworICAgICAgICBicmVhazsKKyAgICBkZWZhdWx0OgorICAgICAgICBicmVhazsKICAgICB9CiAK ICAgICAvLyBIZXJlIHNvIHRoYXQgaXQgY2FuIGJlIHJlaW1wbGVtZW50ZWQgd2l0aG91dCBicmVh a2luZyBBQkkuCiAgICAgcmV0dXJuIFFHcmFwaGljc1dpZGdldDo6ZXZlbnQoZXZlbnQpOwo=