52096 2011-01-07 18:02:30 -0800 [GTK] Filenames are converted to URLs during edit drags 2011-01-18 11:07:28 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 40833 1 mrobinson webkit-unassigned oldest_to_newest 331120 0 mrobinson 2011-01-07 18:02:30 -0800 This is a companion fix to https://bugs.webkit.org/show_bug.cgi?id=38826. It can be observed by the failure of editing/pasteboard/file-drag-to-editable.html. 331133 1 78298 mrobinson 2011-01-07 18:55:35 -0800 Created attachment 78298 Patch 331911 2 78298 eric 2011-01-10 13:48:03 -0800 Comment on attachment 78298 Patch I'm confused by what you're doing for local files. Is this tested? 331918 3 mrobinson 2011-01-10 13:51:40 -0800 (In reply to comment #2) > (From update of attachment 78298 [details]) > I'm confused by what you're doing for local files. Is this tested? Essentially, during edit drags, filenames should not be advertised as a URL on the drag, but otherwise they should be. This bug was fixed for Chromium (and Mac I believe) in https://bugs.webkit.org/show_bug.cgi?id=38826. The test in that bug relied on beginDragWithFiles, so it didn't fail on GTK+ at the time (it was skipped). This patch fixes the bug and unskips the test in question (it depends on the landing of beginDragWithFiles) patch. 331919 4 mrobinson 2011-01-10 13:51:41 -0800 (In reply to comment #2) > (From update of attachment 78298 [details]) > I'm confused by what you're doing for local files. Is this tested? Essentially, during edit drags, filenames should not be advertised as a URL on the drag, but otherwise they should be. This bug was fixed for Chromium (and Mac I believe) in https://bugs.webkit.org/show_bug.cgi?id=38826. The test in that bug relied on beginDragWithFiles, so it didn't fail on GTK+ at the time (it was skipped). This patch fixes the bug and unskips the test in question (it depends on the landing of beginDragWithFiles) patch. 332214 5 78298 eric 2011-01-11 03:05:33 -0800 Comment on attachment 78298 Patch OK. 335941 6 mrobinson 2011-01-18 11:06:34 -0800 Committed r76039: <http://trac.webkit.org/changeset/76039> 78298 2011-01-07 18:55:35 -0800 2011-01-18 11:07:28 -0800 Patch bug-52096-20110107185531.patch text/plain 3153 mrobinson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3MDZiYTdlNDY1MzJkNDM2MGE0ZjcyMzE2YjkxMjc4ZWYyNWU3NTUzLi42ZDliYzI4 ZTNjNTliMGU4OTJmNTMzZjE3MWE5ZGJhMzlmNWUzMWU1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTEtMDEtMDcgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEZpbGVu YW1lcyBhcmUgY29udmVydGVkIHRvIFVSTHMgZHVyaW5nIGVkaXQgZHJhZ3MKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyMDk2CisKKyAgICAgICAgKiBw bGF0Zm9ybS9ndGsvU2tpcHBlZDogVW5za2lwIHBhc3NpbmcgdGVzdC4KKwogMjAxMS0wMS0wNyAg QWRhbSBCZXJna3Zpc3QgIDxhZGFtLmJlcmdrdmlzdEBlcmljc3Nvbi5jb20+IGFuZCBNYXJ0aW4g Um9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lw cGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKaW5kZXggOTQ1YWU4ZmI5NmJj NjA4Mjc3YWZjNDNjYzcyYTE2N2QyZDhkYjgyOC4uMWExMDEwZWYxYTI4MTg0YjlmY2MwNDQyNzVh NDcxMWY1YWU1OGI5NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBw ZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQKQEAgLTUzNTAsMTAgKzUz NTAsNiBAQCBodHRwL3Rlc3RzL2xvY2FsL2Jsb2Ivc2VuZC1zbGljZWQtZGF0YS1ibG9iLmh0bWwK ICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyMDk0CiBlZGl0aW5n L3Bhc3RlYm9hcmQvZmlsZXMtZHVyaW5nLXBhZ2UtZHJhZ3MuaHRtbAogCi0jIFtHVEtdIEZpbGVu YW1lcyBhcmUgY29udmVydGVkIHRvIFVSTHMgZHVyaW5nIGVkaXQgZHJhZ3MKLSMgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyMDk2Ci1lZGl0aW5nL3Bhc3RlYm9hcmQv ZmlsZS1kcmFnLXRvLWVkaXRhYmxlLmh0bWw6Ci0KICMgVGhlIGZlYXR1cmUgd2FzIGRpc2FibGVk IGR1ZSB0byBhIGNvbXBhdGliaWxpdHkgaXNzdWUuCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00MDUyMAogZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9u LWxvc3QtZm9jdXNhYmxlLmh0bWwKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggMzBkMjE5ZGMwYjk3OTZlZWE3ZjFmNDI4N2Y2MzZhYjNhMDcy NDc2Ni4uNzlkYTc2YjM0Y2I0YzNjYzU5N2QzMjgxNDA3YzY5YWUyZjUyMDQ4MiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwx NyBAQAogMjAxMS0wMS0wNyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+ CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10g RmlsZW5hbWVzIGFyZSBjb252ZXJ0ZWQgdG8gVVJMcyBkdXJpbmcgZWRpdCBkcmFncworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTIwOTYKKworICAgICAg ICAqIHBsYXRmb3JtL2d0ay9EcmFnRGF0YUd0ay5jcHA6IE9ubHkgYWR2ZXJ0aXNlIGFuZCBkZWxp dmVyIGZpbGVuYW1lcyBhcyBVUkxzIGlmIHRoZQorICAgICAgICBjb252ZXJzaW9uIHBvbGljeSBh bGxvd3MgaXQuCisgICAgICAgIChXZWJDb3JlOjpEcmFnRGF0YTo6Y29udGFpbnNVUkwpOiBEaXR0 by4KKyAgICAgICAgKFdlYkNvcmU6OkRyYWdEYXRhOjphc1VSTCk6IERpdHRvLgorCisyMDExLTAx LTA3ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KKwogICAgICAgICBC dWlsZCBmaXggZm9yIEdUSysuCiAKICAgICAgICAgKiBHTlVtYWtlZmlsZS5hbTogQWRkIFJlbmRl ckZ1bGxTY3JlZW4uY3BwIHRvIHRoZSBzb3VyY2VzIGxpc3QuCmRpZmYgLS1naXQgYS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9EcmFnRGF0YUd0ay5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9EcmFn RGF0YUd0ay5jcHAKaW5kZXggNDJkZGIxNjk2MWUyZDY5ZTJkMzM5Y2Y1ZmRiN2RiZjIzZGY1OWZh OC4uZDZmNDY4NjVmNTllZmYwMGQxOGM5OGE5MjM1YzY0ZDdlNDM4ZjVmOSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvRHJhZ0RhdGFHdGsuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL0RyYWdEYXRhR3RrLmNwcApAQCAtNjcsMTEgKzY3LDE5IEBAIGJvb2wgRHJhZ0RhdGE6 OmNvbnRhaW5zQ29tcGF0aWJsZUNvbnRlbnQoKSBjb25zdAogCiBib29sIERyYWdEYXRhOjpjb250 YWluc1VSTChGaWxlbmFtZUNvbnZlcnNpb25Qb2xpY3kgZmlsZW5hbWVQb2xpY3kpIGNvbnN0CiB7 Ci0gICAgcmV0dXJuIG1fcGxhdGZvcm1EcmFnRGF0YS0+aGFzVVJMKCk7CisgICAgcmV0dXJuICFh c1VSTChmaWxlbmFtZVBvbGljeSkuaXNFbXB0eSgpOwogfQogCiBTdHJpbmcgRHJhZ0RhdGE6OmFz VVJMKEZpbGVuYW1lQ29udmVyc2lvblBvbGljeSBmaWxlbmFtZVBvbGljeSwgU3RyaW5nKiB0aXRs ZSkgY29uc3QKIHsKKyAgICBpZiAoIW1fcGxhdGZvcm1EcmFnRGF0YS0+aGFzVVJMKCkpCisgICAg ICAgIHJldHVybiBTdHJpbmcoKTsKKyAgICBpZiAoZmlsZW5hbWVQb2xpY3kgIT0gQ29udmVydEZp bGVuYW1lcykgeworICAgICAgICBLVVJMIHVybChLVVJMKCksIG1fcGxhdGZvcm1EcmFnRGF0YS0+ dXJsKCkpOworICAgICAgICBpZiAodXJsLmlzTG9jYWxGaWxlKCkpCisgICAgICAgICAgICByZXR1 cm4gU3RyaW5nKCk7CisgICAgfQorCiAgICAgU3RyaW5nIHVybChtX3BsYXRmb3JtRHJhZ0RhdGEt PnVybCgpKTsKICAgICBpZiAodGl0bGUpCiAgICAgICAgICp0aXRsZSA9IG1fcGxhdGZvcm1EcmFn RGF0YS0+dXJsTGFiZWwoKTsK