52014 2011-01-06 13:48:34 -0800 [Qt] GraphicsContext::drawConvexPolygon() has unnecessary code for shadow 2011-01-06 16:08:53 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 helder webkit-unassigned ariya.hidayat commit-queue kenneth kling mdelaney7 oldest_to_newest 330389 0 helder 2011-01-06 13:48:34 -0800 The function is only used by RenderObject to draw box sides. The shadow branch is never used and thus can be removed. 330393 1 78156 helder 2011-01-06 13:50:26 -0800 Created attachment 78156 Patch 330412 2 78156 kenneth 2011-01-06 14:10:04 -0800 Comment on attachment 78156 Patch Covered by tests I suppose? 330427 3 78156 ariya.hidayat 2011-01-06 14:29:09 -0800 Comment on attachment 78156 Patch cq+ 330520 4 78156 commit-queue 2011-01-06 16:08:46 -0800 Comment on attachment 78156 Patch Clearing flags on attachment: 78156 Committed r75207: <http://trac.webkit.org/changeset/75207> 330521 5 commit-queue 2011-01-06 16:08:53 -0800 All reviewed patches have been landed. Closing bug. 78156 2011-01-06 13:50:26 -0800 2011-01-06 16:08:46 -0800 Patch bug-52014-20110106135023.patch text/plain 1905 helder ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZGE5ZjZhNGVlOTA0NjNkNzQyNzI2MTQ2YzkwZWJkMGNlZTJjOTc2My4uZTFjMmM5MGI3ODE0Yzky YTU0ZTY1Y2RiNTVmNTM4ZTMyYjI5MjI5OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMS0wMS0wNiAgSGVs ZGVyIENvcnJlaWEgIDxoZWxkZXJAc2VuY2hhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEdyYXBoaWNzQ29udGV4dDo6ZHJhd0NvbnZl eFBvbHlnb24oKSBoYXMgdW5uZWNlc3NhcnkgY29kZSBmb3Igc2hhZG93CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjAxNAorCisgICAgICAgIFRoZSBm dW5jdGlvbiBpcyBvbmx5IHVzZWQgYnkgUmVuZGVyT2JqZWN0IHRvIGRyYXcgYm94IHNpZGVzLgor ICAgICAgICBUaGUgc2hhZG93IGJyYW5jaCBpcyBuZXZlciB1c2VkIGFuZCB0aHVzIGNhbiBiZSBy ZW1vdmVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcmUgbmVjZXNzYXJ5LgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpkcmF3Q29udmV4UG9seWdvbik6CisKIDIwMTAtMTIt MjggIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBL ZW5uZXRoIFJ1c3NlbGwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0 L0dyYXBoaWNzQ29udGV4dFF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3Jh cGhpY3NDb250ZXh0UXQuY3BwCmluZGV4IGZiMjhiYWFlOTJhMmQ2MDg1MTg1YzQwNTQxNjZlZjBj MjkwYjA1NzAuLmUyMzdmYzBhOGJjZjFiZjJhMDQzNDg1OTA3NWZiOGYxOTY0YWE5ZWEgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3Bw CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3Bw CkBAIC00NTAsMTkgKzQ1MCw2IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpkcmF3Q29udmV4UG9s eWdvbihzaXplX3QgbnBvaW50cywgY29uc3QgRmxvYXRQb2ludCogcG9pbnRzCiAgICAgY29uc3Qg Ym9vbCBhbnRpQWxpYXMgPSBwLT50ZXN0UmVuZGVySGludChRUGFpbnRlcjo6QW50aWFsaWFzaW5n KTsKICAgICBwLT5zZXRSZW5kZXJIaW50KFFQYWludGVyOjpBbnRpYWxpYXNpbmcsIHNob3VsZEFu dGlhbGlhcyk7CiAKLSAgICBpZiAoaGFzU2hhZG93KCkpIHsKLSAgICAgICAgcC0+c2F2ZSgpOwot ICAgICAgICBwLT50cmFuc2xhdGUobV9kYXRhLT5zaGFkb3cub2Zmc2V0KCkpOwotICAgICAgICBp ZiAocC0+YnJ1c2goKS5zdHlsZSgpICE9IFF0OjpOb0JydXNoKQotICAgICAgICAgICAgcC0+c2V0 QnJ1c2goUUJydXNoKG1fZGF0YS0+c2hhZG93Lm1fY29sb3IpKTsKLSAgICAgICAgUVBlbiBwZW4o cC0+cGVuKCkpOwotICAgICAgICBpZiAocGVuLnN0eWxlKCkgIT0gUXQ6Ok5vUGVuKSB7Ci0gICAg ICAgICAgICBwZW4uc2V0Q29sb3IobV9kYXRhLT5zaGFkb3cubV9jb2xvcik7Ci0gICAgICAgICAg ICBwLT5zZXRQZW4ocGVuKTsKLSAgICAgICAgfQotICAgICAgICBwLT5kcmF3Q29udmV4UG9seWdv bihwb2x5Z29uKTsKLSAgICAgICAgcC0+cmVzdG9yZSgpOwotICAgIH0KICAgICBwLT5kcmF3Q29u dmV4UG9seWdvbihwb2x5Z29uKTsKIAogICAgIHAtPnNldFJlbmRlckhpbnQoUVBhaW50ZXI6OkFu dGlhbGlhc2luZywgYW50aUFsaWFzKTsK