52012 2011-01-06 13:06:40 -0800 Test Result Server not removing old results. 2011-01-07 02:34:41 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jparent jparent abarth commit-queue eric mihaip ojan webkit.review.bot oldest_to_newest 330353 0 jparent 2011-01-06 13:06:40 -0800 Simple off-by-one error: If the number of results for the first result is equal to the value we truncate results at, subsequent results never get removed. Example: Given {"results":[[200,"F"],[1,"N"]], "times":[[200,0],[1,2]]}, merging in a new failing result should remove the old "N" entry, yielding: {"results":[[200,"F"], "times":[[200,0]}, but currently yields {"results":[[200,"F"],[1,"N"]], "times":[[200,0],[1,2]]}. 330415 1 78159 jparent 2011-01-06 14:14:56 -0800 Created attachment 78159 Patch 330658 2 78159 eric 2011-01-06 23:13:46 -0800 Comment on attachment 78159 Patch rs=me. 330667 3 78159 commit-queue 2011-01-06 23:31:30 -0800 Comment on attachment 78159 Patch Clearing flags on attachment: 78159 Committed r75234: <http://trac.webkit.org/changeset/75234> 330668 4 commit-queue 2011-01-06 23:31:37 -0800 All reviewed patches have been landed. Closing bug. 330708 5 webkit.review.bot 2011-01-07 02:34:41 -0800 http://trac.webkit.org/changeset/75234 might have broken Leopard Intel Debug (Tests) 78159 2011-01-06 14:14:56 -0800 2011-01-06 23:31:30 -0800 Patch bug-52012-20110106141455.patch text/plain 2609 jparent SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc1MTg5KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTEtMDEtMDYgIEp1bGllIFBhcmVudCAgPGpwYXJlbnRAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3Qg UmVzdWx0IFNlcnZlciBub3QgcmVtb3Zpbmcgb2xkIHJlc3VsdHMuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MjAxMgorCisgICAgICAgICogVGVzdFJl c3VsdFNlcnZlci9tb2RlbC9qc29ucmVzdWx0cy5weToKKyAgICAgICAgRml4IG9mZi1ieS1vbmU6 IFRydW5jYXRlIGlmID49IG51bV9ydW5zLCBub3QganVzdCA+LgorICAgICAgICAqIFRlc3RSZXN1 bHRTZXJ2ZXIvbW9kZWwvanNvbnJlc3VsdHNfdW5pdHRlc3QucHk6CisgICAgICAgIEFkZCB1bml0 IHRlc3QgdG8gdGVzdCB0aGF0IG1lcmdpbmcgaW4gYSBuZXcgcmVzdWx0IHdpdGggdGhlIHNhbWUg dmFsdWUKKyAgICAgICAgYXMgdGhlIGxhc3QgcmVzdWx0IGNhdXNlcyBwcmV2aW91cyByZXN1bHQg dG8gZmFsbCBvZmYuCisKIDIwMTEtMDEtMDYgIEV2YW4gTWFydGluICA8ZXZhbkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4KSW5kZXg6IFRvb2xzL1Rlc3RS ZXN1bHRTZXJ2ZXIvbW9kZWwvanNvbnJlc3VsdHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVz dFJlc3VsdFNlcnZlci9tb2RlbC9qc29ucmVzdWx0cy5weQkocmV2aXNpb24gNzUxNzUpCisrKyBU b29scy9UZXN0UmVzdWx0U2VydmVyL21vZGVsL2pzb25yZXN1bHRzLnB5CSh3b3JraW5nIGNvcHkp CkBAIC0zMDUsNyArMzA1LDcgQEAgY2xhc3MgSnNvblJlc3VsdHMob2JqZWN0KToKICAgICAgICAg Zm9yIHJlc3VsdCBpbiBlbmNvZGVkX2xpc3Q6CiAgICAgICAgICAgICBudW1fYnVpbGRzID0gbnVt X2J1aWxkcyArIHJlc3VsdFswXQogICAgICAgICAgICAgaW5kZXggPSBpbmRleCArIDEKLSAgICAg ICAgICAgIGlmIG51bV9idWlsZHMgPiBudW1fcnVuczoKKyAgICAgICAgICAgIGlmIG51bV9idWls ZHMgPj0gbnVtX3J1bnM6CiAgICAgICAgICAgICAgICAgcmV0dXJuIGVuY29kZWRfbGlzdFs6aW5k ZXhdCiAKICAgICAgICAgcmV0dXJuIGVuY29kZWRfbGlzdApJbmRleDogVG9vbHMvVGVzdFJlc3Vs dFNlcnZlci9tb2RlbC9qc29ucmVzdWx0c191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9UZXN0UmVzdWx0U2VydmVyL21vZGVsL2pzb25yZXN1bHRzX3VuaXR0ZXN0LnB5CShyZXZpc2lv biA3NTE3NSkKKysrIFRvb2xzL1Rlc3RSZXN1bHRTZXJ2ZXIvbW9kZWwvanNvbnJlc3VsdHNfdW5p dHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTMyMiw2ICszMjIsMTggQEAgY2xhc3MgSnNvblJl c3VsdHNUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKQogICAgICAgICAgICAgKFsiMyIsICIyIiwgIjEi XSwgW1siMDAxLmh0bWwiLCAiWzEsXCJUXCJdLFsiICsgbWF4X2J1aWxkcyArICIsXCJGXCJdIiwg IlsxLDFdLFsiICsgbWF4X2J1aWxkcyArICIsMF0iXV0pLAogICAgICAgICAgICAgaW50KG1heF9i dWlsZHMpKQogCisgICAgICAgICMgVGVzdCB0aGF0IG1lcmdpbmcgaW4gYSBuZXcgcmVzdWx0IG9m IHRoZSBzYW1lIHR5cGUgYXMgdGhlIGxhc3QgcmVzdWx0CisgICAgICAgICMgY2F1c2VzIG9sZCBy ZXN1bHRzIHRvIGZhbGwgb2ZmLgorICAgICAgICBtYXhfYnVpbGRzID0gc3RyKGpzb25yZXN1bHRz LkpTT05fUkVTVUxUU19NQVhfQlVJTERTX1NNQUxMKQorICAgICAgICBzZWxmLl90ZXN0X21lcmdl KAorICAgICAgICAgICAgIyBBZ2dyZWdhdGVkIHJlc3VsdHMKKyAgICAgICAgICAgIChbIjIiLCAi MSJdLCBbWyIwMDEuaHRtbCIsICJbIiArIG1heF9idWlsZHMgKyAiLFwiRlwiXSxbMSxcIk5cIl0i LCAiWyIgKyBtYXhfYnVpbGRzICsgIiwwXSxbMSwxXSJdXSksCisgICAgICAgICAgICAjIEluY3Jl bWVudGFsIHJlc3VsdHMKKyAgICAgICAgICAgIChbIjMiXSwgW1siMDAxLmh0bWwiLCAiWzEsXCJG XCJdIiwgIlsxLDBdIl1dKSwKKyAgICAgICAgICAgICMgRXhwZWN0ZWQgcmVzdWx0cworICAgICAg ICAgICAgKFsiMyIsICIyIiwgIjEiXSwgW1siMDAxLmh0bWwiLCAiWyIgKyBtYXhfYnVpbGRzICsg IixcIkZcIl0iLCAiWyIgKyBtYXhfYnVpbGRzICsgIiwwXSJdXSksCisgICAgICAgICAgICBpbnQo bWF4X2J1aWxkcykpCisKICAgICAgICAgIyBHZXQgdGVzdCBuYW1lIGxpc3Qgb25seS4gRG9uJ3Qg aW5jbHVkZSBub24tdGVzdC1saXN0IGRhdGEgYW5kCiAgICAgICAgICMgb2YgdGVzdCByZXN1bHQg ZGV0YWlscy4KICAgICAgICAgc2VsZi5fdGVzdF9nZXRfdGVzdF9saXN0KAo=