52009 2011-01-06 12:38:03 -0800 WKView on Windows has no equivalent of Mac's -[WKView setDraws[Transparent]Background:] 2011-05-04 15:20:49 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Windows XP RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 1 aroben andersca adachan andersca sam oldest_to_newest 330320 0 aroben 2011-01-06 12:38:03 -0800 WKView on Mac has the following APIs: -[WKView setDrawsBackground:] -[WKView setDrawsTransparentBackground:] These allow API clients to cause the WKView to be transparent or to have some other custom background. We have no equivalent of this on Windows (but don't need it, at the moment, either). 330322 1 aroben 2011-01-06 12:38:33 -0800 <rdar://problem/8829746> 398272 2 92319 andersca 2011-05-04 14:51:38 -0700 Created attachment 92319 Patch 398285 3 92319 aroben 2011-05-04 15:06:52 -0700 Comment on attachment 92319 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92319&action=review > Source/WebKit2/UIProcess/win/WebView.cpp:642 > -static void drawPageBackground(HDC dc, const RECT& rect) > +static void drawPageBackground(HDC dc, const WebPageProxy* page, const RECT& rect) > { > - // Mac checks WebPageProxy::drawsBackground and > - // WebPageProxy::drawsTransparentBackground here, but those are always false on > - // Windows currently (see <http://webkit.org/b/52009>). > + if (!page->drawsBackground() || page->drawsTransparentBackground()) > + return; > + > ::FillRect(dc, &rect, reinterpret_cast<HBRUSH>(COLOR_WINDOW + 1)); > } Failing to paint parts of the HWND will lead to pixel smearing when Aero is disabled. That doesn't seem good! 398299 4 92319 aroben 2011-05-04 15:17:13 -0700 Comment on attachment 92319 Patch I guess this will perhaps someday be useful if we add a way to make a WS_EX_LAYERED WKView. Maybe we'll find other uses for it before then. 398301 5 andersca 2011-05-04 15:20:49 -0700 Committed r85794: <http://trac.webkit.org/changeset/85794> 92319 2011-05-04 14:51:38 -0700 2011-05-04 15:17:13 -0700 Patch bug-52009-20110504145137.patch text/plain 4441 andersca SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg1NzkwKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjggQEAKKzIwMTEtMDUtMDQgIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXS1ZpZXcgb24gV2luZG93cyBoYXMgbm8gZXF1aXZhbGVu dCBvZiBNYWMncyAtW1dLVmlldyBzZXREcmF3c1tUcmFuc3BhcmVudF1CYWNrZ3JvdW5kOl0KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUyMDA5CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS84ODI5NzQ2PgorCisgICAgICAgIEFkZCBhbmQgaW1wbGVtZW50 IFdLVmlld1NldERyYXdzVHJhbnNwYXJlbnRCYWNrZ3JvdW5kIG9uIHdpbmRvd3MuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL0Mvd2luL1dLVmlldy5jcHA6CisgICAgICAgIChXS1ZpZXdTZXRE cmF3c1RyYW5zcGFyZW50QmFja2dyb3VuZCk6CisgICAgICAgIChXS1ZpZXdEcmF3c1RyYW5zcGFy ZW50QmFja2dyb3VuZCk6CisgICAgICAgIENhbGwgdGhyb3VnaCB0byB0aGUgV2ViUGFnZVByb3h5 IG9iamVjdC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQy93aW4vV0tWaWV3Lmg6CisgICAg ICAgICogVUlQcm9jZXNzL3dpbi9XZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYktpdDo6ZHJhd1Bh Z2VCYWNrZ3JvdW5kKToKKyAgICAgICAgRG9uJ3QgZmlsbCB0aGUgcmVjdCB3aXRoIHdoaXRlIGlm IFdlYlBhZ2VQcm94eTo6ZHJhd3NCYWNrZ3JvdW5kKCkgb3IgCisgICAgICAgIFdlYlBhZ2VQcm94 eTo6ZHJhd3NUcmFuc3BhcmVudEJhY2tncm91bmQoKSByZXR1cm5zIGZhbHNlLiBCZWNhdXNlIG9m IGxpbWl0YXRpb25zIGluIFdpbjMyLAorICAgICAgICBib3RoIGRyYXdzQmFja2dyb3VuZCBhbmQg ZHJhd3NUcmFuc3BhcmVudEJhY2tncm91bmQgYXJlIHByZXR0eSBtdWNoIGVxdWl2YWxlbnQuCisK KyAgICAgICAgKFdlYktpdDo6V2ViVmlldzo6cGFpbnQpOgorICAgICAgICBQYXNzIHRoZSBXZWJQ YWdlUHJveHkgb2JqZWN0IHRvIGRyYXdQYWdlQmFja2dyb3VuZC4KKwogMjAxMS0wNS0wNCAgVGFv IEJhaSAgPG1pY2hhZWxiYWlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh dmlkIEtpbHplci4KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy93aW4vV0tW aWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Mvd2lu L1dLVmlldy5jcHAJKHJldmlzaW9uIDg1Nzg0KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9DL3dpbi9XS1ZpZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDMsMyArMTAzLDE0IEBA IHZvaWQgV0tWaWV3VW5hcHBseUVkaXRDb21tYW5kKFdLVmlld1JlZiAKIHsKICAgICB0b0ltcGwo dmlld1JlZiktPnVuYXBwbHlFZGl0Q29tbWFuZCh0b0ltcGwoY29tbWFuZCkpOwogfQorCit2b2lk IFdLVmlld1NldERyYXdzVHJhbnNwYXJlbnRCYWNrZ3JvdW5kKFdLVmlld1JlZiB2aWV3UmVmLCBi b29sIGRyYXdzVHJhbnNwYXJlbnRCYWNrZ3JvdW5kKQoreworICAgIHRvSW1wbCh2aWV3UmVmKS0+ cGFnZSgpLT5zZXREcmF3c1RyYW5zcGFyZW50QmFja2dyb3VuZChkcmF3c1RyYW5zcGFyZW50QmFj a2dyb3VuZCk7Cit9CisKK2Jvb2wgV0tWaWV3RHJhd3NUcmFuc3BhcmVudEJhY2tncm91bmQoV0tW aWV3UmVmIHZpZXdSZWYpCit7CisgICAgcmV0dXJuIHRvSW1wbCh2aWV3UmVmKS0+cGFnZSgpLT5k cmF3c1RyYW5zcGFyZW50QmFja2dyb3VuZCgpOworfQorCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL0Mvd2luL1dLVmlldy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQy93aW4vV0tWaWV3LmgJKHJldmlzaW9uIDg1Nzg0KQorKysgU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9DL3dpbi9XS1ZpZXcuaAkod29ya2luZyBjb3B5KQpAQCAt NzgsNiArNzgsOSBAQCB0eXBlZGVmIHZvaWQgKCpXS1ZpZXdGaW5kSW5kaWNhdG9yQ2FsbGJhCiBX S19FWFBPUlQgdm9pZCBXS1ZpZXdTZXRGaW5kSW5kaWNhdG9yQ2FsbGJhY2soV0tWaWV3UmVmIHZp ZXcsIFdLVmlld0ZpbmRJbmRpY2F0b3JDYWxsYmFjayBjYWxsYmFjaywgdm9pZCogY29udGV4dCk7 CiBXS19FWFBPUlQgV0tWaWV3RmluZEluZGljYXRvckNhbGxiYWNrIFdLVmlld0dldEZpbmRJbmRp Y2F0b3JDYWxsYmFjayhXS1ZpZXdSZWYgdmlldywgdm9pZCoqIGNvbnRleHQpOwogCitXS19FWFBP UlQgdm9pZCBXS1ZpZXdTZXREcmF3c1RyYW5zcGFyZW50QmFja2dyb3VuZChXS1ZpZXdSZWYgdmll dywgYm9vbCBkcmF3c1RyYW5zcGFyZW50QmFja2dyb3VuZCk7CitXS19FWFBPUlQgYm9vbCBXS1Zp ZXdEcmF3c1RyYW5zcGFyZW50QmFja2dyb3VuZChXS1ZpZXdSZWYgdmlldyk7CisKICNpZmRlZiBf X2NwbHVzcGx1cwogfQogI2VuZGlmCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mvd2lu L1dlYlZpZXcuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy93aW4v V2ViVmlldy5jcHAJKHJldmlzaW9uIDg1Nzg0KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L3dpbi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjMzLDExICs2MzMsMTEgQEAgTFJF U1VMVCBXZWJWaWV3OjpvbktleUV2ZW50KEhXTkQgaFduZCwgVQogICAgIHJldHVybiAwOwogfQog Ci1zdGF0aWMgdm9pZCBkcmF3UGFnZUJhY2tncm91bmQoSERDIGRjLCBjb25zdCBSRUNUJiByZWN0 KQorc3RhdGljIHZvaWQgZHJhd1BhZ2VCYWNrZ3JvdW5kKEhEQyBkYywgY29uc3QgV2ViUGFnZVBy b3h5KiBwYWdlLCBjb25zdCBSRUNUJiByZWN0KQogewotICAgIC8vIE1hYyBjaGVja3MgV2ViUGFn ZVByb3h5OjpkcmF3c0JhY2tncm91bmQgYW5kCi0gICAgLy8gV2ViUGFnZVByb3h5OjpkcmF3c1Ry YW5zcGFyZW50QmFja2dyb3VuZCBoZXJlLCBidXQgdGhvc2UgYXJlIGFsd2F5cyBmYWxzZSBvbgot ICAgIC8vIFdpbmRvd3MgY3VycmVudGx5IChzZWUgPGh0dHA6Ly93ZWJraXQub3JnL2IvNTIwMDk+ KS4KKyAgICBpZiAoIXBhZ2UtPmRyYXdzQmFja2dyb3VuZCgpIHx8IHBhZ2UtPmRyYXdzVHJhbnNw YXJlbnRCYWNrZ3JvdW5kKCkpCisgICAgICAgIHJldHVybjsKKwogICAgIDo6RmlsbFJlY3QoZGMs ICZyZWN0LCByZWludGVycHJldF9jYXN0PEhCUlVTSD4oQ09MT1JfV0lORE9XICsgMSkpOwogfQog CkBAIC02NTMsMTcgKzY1MywxNyBAQCB2b2lkIFdlYlZpZXc6OnBhaW50KEhEQyBoZGMsIGNvbnN0 IEludFJlCiAgICAgICAgICAgICBWZWN0b3I8SW50UmVjdD4gdW5wYWludGVkUmVjdHMgPSB1bnBh aW50ZWRSZWdpb24ucmVjdHMoKTsKICAgICAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwg dW5wYWludGVkUmVjdHMuc2l6ZSgpOyArK2kpIHsKICAgICAgICAgICAgICAgICBSRUNUIHdpblJl Y3QgPSB1bnBhaW50ZWRSZWN0c1tpXTsKLSAgICAgICAgICAgICAgICBkcmF3UGFnZUJhY2tncm91 bmQoaGRjLCB1bnBhaW50ZWRSZWN0c1tpXSk7CisgICAgICAgICAgICAgICAgZHJhd1BhZ2VCYWNr Z3JvdW5kKGhkYywgbV9wYWdlLmdldCgpLCB1bnBhaW50ZWRSZWN0c1tpXSk7CiAgICAgICAgICAg ICB9CiAgICAgICAgIH0gZWxzZQotICAgICAgICAgICAgZHJhd1BhZ2VCYWNrZ3JvdW5kKGhkYywg ZGlydHlSZWN0KTsKKyAgICAgICAgICAgIGRyYXdQYWdlQmFja2dyb3VuZChoZGMsIG1fcGFnZS5n ZXQoKSwgZGlydHlSZWN0KTsKIAogICAgICAgICBtX3BhZ2UtPmRpZERyYXcoKTsKICAgICB9IGVs c2UgewogICAgICAgICBpZiAobV9wYWdlLT5pc1ZhbGlkKCkgJiYgbV9wYWdlLT5kcmF3aW5nQXJl YSgpICYmIG1fcGFnZS0+ZHJhd2luZ0FyZWEoKS0+cGFpbnQoZGlydHlSZWN0LCBoZGMpKQogICAg ICAgICAgICAgbV9wYWdlLT5kaWREcmF3KCk7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIGRy YXdQYWdlQmFja2dyb3VuZChoZGMsIGRpcnR5UmVjdCk7CisgICAgICAgICAgICBkcmF3UGFnZUJh Y2tncm91bmQoaGRjLCBtX3BhZ2UuZ2V0KCksIGRpcnR5UmVjdCk7CiAgICAgfQogfQogCg==