52003 2011-01-06 12:05:19 -0800 [gdb] handle inaccessible memory and UChar* 2011-01-06 13:10:09 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 evan evan abarth eric hayato webkit.review.bot oldest_to_newest 330281 0 evan 2011-01-06 12:05:19 -0800 [gdb] handle inaccessible memory and UChar* 330287 1 78144 evan 2011-01-06 12:09:16 -0800 Created attachment 78144 Patch 330290 2 evan 2011-01-06 12:11:33 -0800 CC hayato, who did some work in this area 330292 3 78144 tony 2011-01-06 12:13:46 -0800 Comment on attachment 78144 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78144&action=review > Tools/gdb/webkit.py:238 > + pretty_printers = [ Nit: tuple 330316 4 evan 2011-01-06 12:34:12 -0800 Committed r75178: <http://trac.webkit.org/changeset/75178> 330356 5 webkit.review.bot 2011-01-06 13:10:09 -0800 http://trac.webkit.org/changeset/75178 might have broken Chromium Mac Release 78144 2011-01-06 12:09:16 -0800 2011-01-06 12:13:46 -0800 Patch bug-52003-20110106120912.patch text/plain 3807 evan ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2OTli YzA4ZTA0NGE4MjBjZDM2MjhkZjQ5NmNmZmEyOTcxY2EzZGQ3Li4wODI3YzU0ZTU5ZmU0MzI3ZWYy ODMyYjNiOGM0ODc1NjM4MDFkZGM0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDEtMDYgIEV2YW4gTWFydGlu ICA8ZXZhbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW2dkYl0gaGFuZGxlIGluYWNjZXNzaWJsZSBtZW1vcnkgYW5kIFVDaGFy KgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTIwMDMK KworICAgICAgICBUbyBwcmV0dHktcHJpbnQgYSBVQ2hhciosIHdlIGp1c3QgZ3JvcGUgYXJvdW5k IGluIHRoZSBtZW1vcnkKKyAgICAgICAgbG9va2luZyBmb3IgYSB0ZXJtaW5hdGluZyBOVUwuICBX ZSBuZWVkIHRvIGhhbmRsZSB0aGUgZXhjZXB0aW9uCisgICAgICAgIHRoYXQgY2FuIG9jY3VyIHdo ZW4gd2UgcG9rZSBpbnRvIGFuIGludmFsaWQgbG9jYXRpb24uCisKKyAgICAgICAgQWRkaXRpb25h bGx5LCB0aGUgbG9naWMgZm9yIGNob29zaW5nIHdoaWNoIHByZXR0eS1wcmludGVyIHdvdWxkCisg ICAgICAgIGVhcmx5IHJldHVybiBiZWZvcmUgaGl0dGluZyB0aGUgcG9pbnQgd2hlcmUgd2UnZCB1 c2UgdGhlIFVDaGFyKgorICAgICAgICBwcmludGVyLiAgKERpZCB0aGlzIGV2ZXIgd29yaz8gIEhv dyBkaWQgaXQgcmVncmVzcz8pCisKKyAgICAgICAgKiBnZGIvd2Via2l0LnB5OgorCiAyMDExLTAx LTA1ICBKYW1lcyBTaW1vbnNlbiAgPHNpbW9uamFtQGNocm9taXVtLm9yZz4KIAogICAgICAgICBV bnJldmlld2VkLiBBZGRpbmcgbXlzZWxmIHRvIHRoZSBsaXN0IG9mIGNvbW1pdHRlcnMuCmRpZmYg LS1naXQgYS9Ub29scy9nZGIvd2Via2l0LnB5IGIvVG9vbHMvZ2RiL3dlYmtpdC5weQppbmRleCA5 NWMzZDljZjUyZTQ1N2NlZDI0ZjE5ZThlMjM5NTIyM2Q3NzkwODUwLi5jZmFhOGUxOTQ3NmQ2ZDRh MGY1NGU5NGIyMmMwNWM5NjNjOTdmZTAwIDEwMDY0NAotLS0gYS9Ub29scy9nZGIvd2Via2l0LnB5 CisrKyBiL1Rvb2xzL2dkYi93ZWJraXQucHkKQEAgLTQ5LDEyICs0OSwxOCBAQCBkZWYgdXN0cmlu Z190b19zdHJpbmcocHRyLCBsZW5ndGg9Tm9uZSk6CiAgICAgaWYgbGVuZ3RoIGlzIE5vbmU6CiAg ICAgICAgICMgVHJ5IHRvIGd1ZXNzIGF0IHRoZSBsZW5ndGguCiAgICAgICAgIGZvciBpIGluIHhy YW5nZSgwLCAyMDQ4KToKLSAgICAgICAgICAgIGlmIGludCgocHRyICsgaSkuZGVyZWZlcmVuY2Uo KSkgPT0gMDoKKyAgICAgICAgICAgIHRyeToKKyAgICAgICAgICAgICAgICBpZiBpbnQoKHB0ciAr IGkpLmRlcmVmZXJlbmNlKCkpID09IDA6CisgICAgICAgICAgICAgICAgICAgIGxlbmd0aCA9IGkK KyAgICAgICAgICAgICAgICAgICAgYnJlYWsKKyAgICAgICAgICAgIGV4Y2VwdCBSdW50aW1lRXJy b3I6CisgICAgICAgICAgICAgICAgIyBXZSBpbmRleGVkIGludG8gaW5hY2Nlc3NpYmxlIG1lbW9y eTsgZ2l2ZSB1cC4KICAgICAgICAgICAgICAgICBsZW5ndGggPSBpCisgICAgICAgICAgICAgICAg ZXh0cmEgPSB1JyAoZ2RiIGhpdCBpbmFjY2Vzc2libGUgbWVtb3J5KScKICAgICAgICAgICAgICAg ICBicmVhawogICAgICAgICBpZiBsZW5ndGggaXMgTm9uZToKICAgICAgICAgICAgIGxlbmd0aCA9 IDI1NgotICAgICAgICAgICAgZXh0cmEgPSB1JyAobm8gdHJhaWxpbmcgTlVMIGZvdW5kKScKKyAg ICAgICAgICAgIGV4dHJhID0gdScgKGdkYiBmb3VuZCBubyB0cmFpbGluZyBOVUwpJwogICAgIGVs c2U6CiAgICAgICAgIGxlbmd0aCA9IGludChsZW5ndGgpCiAKQEAgLTIyOSwxNSArMjM1LDE1IEBA IGNsYXNzIFdURlZlY3RvclByaW50ZXI6CiAgICAgICAgIHJldHVybiAnYXJyYXknCiAKIGRlZiBh ZGRfcHJldHR5X3ByaW50ZXJzKCk6Ci0gICAgcHJldHR5X3ByaW50ZXJzX2RpY3QgPSB7Ci0gICAg ICAgIHJlLmNvbXBpbGUoIl5XVEY6OlZlY3RvcjwuKj4kIik6IFdURlZlY3RvclByaW50ZXIsCi0g ICAgICAgIHJlLmNvbXBpbGUoIl5XVEY6OkF0b21pY1N0cmluZyQiKTogV1RGQXRvbWljU3RyaW5n UHJpbnRlciwKLSAgICAgICAgcmUuY29tcGlsZSgiXldURjo6U3RyaW5nJCIpOiBXVEZTdHJpbmdQ cmludGVyLAotICAgICAgICByZS5jb21waWxlKCJeV2ViQ29yZTo6UXVhbGlmaWVkTmFtZSQiKTog V2ViQ29yZVF1YWxpZmllZE5hbWVQcmludGVyLAotICAgICAgICByZS5jb21waWxlKCJeSlNDOjpV U3RyaW5nJCIpOiBKU0NVU3RyaW5nUHJpbnRlciwKLSAgICAgICAgcmUuY29tcGlsZSgiXkpTQzo6 SWRlbnRpZmllciQiKTogSlNDSWRlbnRpZmllclByaW50ZXIsCi0gICAgICAgIHJlLmNvbXBpbGUo Il5KU0M6OkpTU3RyaW5nJCIpOiBKU0NKU1N0cmluZ1ByaW50ZXIsCi0gICAgfQorICAgIHByZXR0 eV9wcmludGVycyA9IFsKKyAgICAgICAgKHJlLmNvbXBpbGUoIl5XVEY6OlZlY3RvcjwuKj4kIiks IFdURlZlY3RvclByaW50ZXIpLAorICAgICAgICAocmUuY29tcGlsZSgiXldURjo6QXRvbWljU3Ry aW5nJCIpLCBXVEZBdG9taWNTdHJpbmdQcmludGVyKSwKKyAgICAgICAgKHJlLmNvbXBpbGUoIl5X VEY6OlN0cmluZyQiKSwgV1RGU3RyaW5nUHJpbnRlciksCisgICAgICAgIChyZS5jb21waWxlKCJe V2ViQ29yZTo6UXVhbGlmaWVkTmFtZSQiKSwgV2ViQ29yZVF1YWxpZmllZE5hbWVQcmludGVyKSwK KyAgICAgICAgKHJlLmNvbXBpbGUoIl5KU0M6OlVTdHJpbmckIiksIEpTQ1VTdHJpbmdQcmludGVy KSwKKyAgICAgICAgKHJlLmNvbXBpbGUoIl5KU0M6OklkZW50aWZpZXIkIiksIEpTQ0lkZW50aWZp ZXJQcmludGVyKSwKKyAgICAgICAgKHJlLmNvbXBpbGUoIl5KU0M6OkpTU3RyaW5nJCIpLCBKU0NK U1N0cmluZ1ByaW50ZXIpLAorICAgIF0KIAogICAgIGRlZiBsb29rdXBfZnVuY3Rpb24odmFsKToK ICAgICAgICAgIiIiRnVuY3Rpb24gdXNlZCB0byBsb2FkIHByZXR0eSBwcmludGVyczsgd2lsbCBi ZSBwYXNzZWQgdG8gR0RCLiIiIgpAQCAtMjQ1LDEyICsyNTEsMTEgQEAgZGVmIGFkZF9wcmV0dHlf cHJpbnRlcnMoKToKICAgICAgICAgaWYgdHlwZS5jb2RlID09IGdkYi5UWVBFX0NPREVfUkVGOgog ICAgICAgICAgICAgdHlwZSA9IHR5cGUudGFyZ2V0KCkKICAgICAgICAgdHlwZSA9IHR5cGUudW5x dWFsaWZpZWQoKS5zdHJpcF90eXBlZGVmcygpCi0gICAgICAgIHR5cGVuYW1lID0gdHlwZS50YWcK LSAgICAgICAgaWYgbm90IHR5cGVuYW1lOgotICAgICAgICAgICAgcmV0dXJuIE5vbmUKLSAgICAg ICAgZm9yIGZ1bmN0aW9uLCBwcmV0dHlfcHJpbnRlciBpbiBwcmV0dHlfcHJpbnRlcnNfZGljdC5p dGVtcygpOgotICAgICAgICAgICAgaWYgZnVuY3Rpb24uc2VhcmNoKHR5cGVuYW1lKToKLSAgICAg ICAgICAgICAgICByZXR1cm4gcHJldHR5X3ByaW50ZXIodmFsKQorICAgICAgICB0YWcgPSB0eXBl LnRhZworICAgICAgICBpZiB0YWc6CisgICAgICAgICAgICBmb3IgZnVuY3Rpb24sIHByZXR0eV9w cmludGVyIGluIHByZXR0eV9wcmludGVyczoKKyAgICAgICAgICAgICAgICBpZiBmdW5jdGlvbi5z ZWFyY2godGFnKToKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHByZXR0eV9wcmludGVyKHZh bCkKIAogICAgICAgICBpZiB0eXBlLmNvZGUgPT0gZ2RiLlRZUEVfQ09ERV9QVFI6CiAgICAgICAg ICAgICBuYW1lID0gc3RyKHR5cGUudGFyZ2V0KCkudW5xdWFsaWZpZWQoKSkK