51985 2011-01-06 01:14:39 -0800 [Qt][GTK] Use GraphicsContext::hasShadow() in port-specific code 2011-01-06 04:07:26 -0800 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 helder webkit-unassigned abarth ariya.hidayat commit-queue eric mdelaney7 webkit.review.bot oldest_to_newest 330063 0 helder 2011-01-06 01:14:39 -0800 r75139 introduced GraphicsContext::hasShadow(). This can now simplify and unify some code in the Qt and GTK ports. 330064 1 78102 helder 2011-01-06 01:17:45 -0800 Created attachment 78102 Patch 330069 2 78102 commit-queue 2011-01-06 02:50:06 -0800 Comment on attachment 78102 Patch Clearing flags on attachment: 78102 Committed r75148: <http://trac.webkit.org/changeset/75148> 330070 3 commit-queue 2011-01-06 02:50:12 -0800 All reviewed patches have been landed. Closing bug. 330094 4 commit-queue 2011-01-06 04:00:41 -0800 The commit-queue encountered the following flaky tests while processing attachment 78102: http/tests/xmlhttprequest/re-login.html bug 51987 (author: ap@webkit.org) The commit-queue is continuing to process your patch. 330095 5 webkit.review.bot 2011-01-06 04:07:26 -0800 http://trac.webkit.org/changeset/75148 might have broken Leopard Intel Debug (Tests) 78102 2011-01-06 01:17:45 -0800 2011-01-06 02:50:06 -0800 Patch bug-51985-20110106011743.patch text/plain 7335 helder ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzE0MTNmNDU5MjhjM2M2ODRmODI4N2UyNTNlMDVhYzI3MzI3ZmI5MS4uMzUzNTI4ODI5M2Y2MDg1 OTI2YTkwZDIyY2Q2MjIxNmM2ZDI0ZmQ4MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMS0wMS0wNiAgSGVs ZGVyIENvcnJlaWEgIDxoZWxkZXJAc2VuY2hhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdW0dUS10gVXNlIEdyYXBoaWNzQ29udGV4dDo6 aGFzU2hhZG93KCkgaW4gcG9ydC1zcGVjaWZpYyBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTk4NQorCisgICAgICAgIHI3NTEzOSBpbnRyb2R1 Y2VkIEdyYXBoaWNzQ29udGV4dDo6aGFzU2hhZG93KCkuIFRoaXMgY2FuIG5vdyBzaW1wbGlmeQor ICAgICAgICBhbmQgdW5pZnkgc29tZSBjb2RlIGluIHRoZSBRdCBhbmQgR1RLIHBvcnRzLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cyBuZWNlc3NhcnkgZm9yIHRoaXMgcmVmYWN0b3JpbmcuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRDYWlyby5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OmZpbGxSZWN0KToKKyAgICAgICAg KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6ZmlsbFJvdW5kZWRSZWN0KToKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGVDYWly by5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dFF0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6ZHJhd0NvbnZleFBvbHlnb24p OgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpmaWxsUGF0aCk6CisgICAgICAg IChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQ6OnN0cm9rZVBhdGgpOgorICAgICAgICAoV2ViQ29y ZTo6R3JhcGhpY3NDb250ZXh0OjpmaWxsUmVjdCk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGlj c0NvbnRleHQ6OmZpbGxSb3VuZGVkUmVjdCk6CisKIDIwMTEtMDEtMDUgIFhpYW56aHUgV2FuZyAg PHdhbmd4aWFuemh1QGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2 aW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNz Q29udGV4dENhaXJvLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhp Y3NDb250ZXh0Q2Fpcm8uY3BwCmluZGV4IGE3ODNlMmJiYTJmYzk5YzMxY2I0MmU4NzViYjc5NDZj MzEzYTMxZjcuLmNkYmZjNTdiN2JmMWExYWJjZTY3ODBiZGE4OWE0Mjg4Y2FjMmY0MmMgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0Q2Fp cm8uY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250 ZXh0Q2Fpcm8uY3BwCkBAIC01NjMsNyArNTYzLDcgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmZp bGxSZWN0KGNvbnN0IEZsb2F0UmVjdCYgcmVjdCwgY29uc3QgQ29sb3ImIGNvbG9yLCBDb2xvclMK ICAgICBpZiAocGFpbnRpbmdEaXNhYmxlZCgpKQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAo bV9kYXRhLT5oYXNTaGFkb3coKSkKKyAgICBpZiAoaGFzU2hhZG93KCkpCiAgICAgICAgIG1fZGF0 YS0+c2hhZG93LmRyYXdSZWN0U2hhZG93KHRoaXMsIGVuY2xvc2luZ0ludFJlY3QocmVjdCkpOwog CiAgICAgaWYgKGNvbG9yLmFscGhhKCkpCkBAIC0xMDkxLDcgKzEwOTEsNyBAQCB2b2lkIEdyYXBo aWNzQ29udGV4dDo6ZmlsbFJvdW5kZWRSZWN0KGNvbnN0IEludFJlY3QmIHIsIGNvbnN0IEludFNp emUmIHRvcExlZnQsCiAgICAgaWYgKHBhaW50aW5nRGlzYWJsZWQoKSkKICAgICAgICAgcmV0dXJu OwogCi0gICAgaWYgKG1fZGF0YS0+aGFzU2hhZG93KCkpCisgICAgaWYgKGhhc1NoYWRvdygpKQog ICAgICAgICBtX2RhdGEtPnNoYWRvdy5kcmF3UmVjdFNoYWRvdyh0aGlzLCByLCB0b3BMZWZ0LCB0 b3BSaWdodCwgYm90dG9tTGVmdCwgYm90dG9tUmlnaHQpOwogCiAgICAgY2Fpcm9fdCogY3IgPSBt X2RhdGEtPmNyOwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9H cmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGVDYWlyby5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jYWlyby9HcmFwaGljc0NvbnRleHRQbGF0Zm9ybVByaXZhdGVDYWlyby5oCmluZGV4 IDQ5NGI0MGQ4YTg2MzlkMWNhZTNhMjQ3NDEzZGE1NTY1M2M3NGY5ZmMuLjU2MDJiNmNiZmM4MzA4 OTliNDNmM2VkY2NlODk2MTEzMDE3MTUzOTcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2Fpcm8vR3JhcGhpY3NDb250ZXh0UGxhdGZvcm1Qcml2YXRlQ2Fpcm8uaAorKysg Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0dyYXBoaWNzQ29udGV4dFBsYXRmb3Jt UHJpdmF0ZUNhaXJvLmgKQEAgLTk5LDcgKzk5LDYgQEAgcHVibGljOgogCiAgICAgQ29udGV4dFNo YWRvdyBzaGFkb3c7CiAgICAgVmVjdG9yPENvbnRleHRTaGFkb3c+IHNoYWRvd1N0YWNrOwotICAg IGJvb2wgaGFzU2hhZG93KCkgY29uc3QgeyByZXR1cm4gc2hhZG93Lm1fdHlwZSAhPSBDb250ZXh0 U2hhZG93OjpOb1NoYWRvdzsgfQogCiAjaWYgUExBVEZPUk0oR1RLKQogICAgIEdka0V2ZW50RXhw b3NlKiBleHBvc2U7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dy YXBoaWNzQ29udGV4dFF0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhp Y3NDb250ZXh0UXQuY3BwCmluZGV4IDc4YTE0ZjRhNGYyNDdjZjc5NDg4NjhiYWI3ZTFhNTcyYmU1 NWQyMDQuLmZiMjhiYWFlOTJhMmQ2MDg1MTg1YzQwNTQxNjZlZjBjMjkwYjA1NzAgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0UXQuY3BwCkBA IC0yMDIsMTEgKzIwMiw2IEBAIHB1YmxpYzoKICAgICBDb250ZXh0U2hhZG93IHNoYWRvdzsKICAg ICBRU3RhY2s8Q29udGV4dFNoYWRvdz4gc2hhZG93U3RhY2s7CiAKLSAgICBib29sIGhhc1NoYWRv dygpIGNvbnN0Ci0gICAgewotICAgICAgICByZXR1cm4gc2hhZG93Lm1fdHlwZSAhPSBDb250ZXh0 U2hhZG93OjpOb1NoYWRvdzsKLSAgICB9Ci0KICAgICBRUmVjdEYgY2xpcEJvdW5kaW5nUmVjdCgp IGNvbnN0CiAgICAgewogI2lmIFFUX1ZFUlNJT04gPj0gUVRfVkVSU0lPTl9DSEVDSyg0LCA4LCAw KQpAQCAtNDU1LDcgKzQ1MCw3IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpkcmF3Q29udmV4UG9s eWdvbihzaXplX3QgbnBvaW50cywgY29uc3QgRmxvYXRQb2ludCogcG9pbnRzCiAgICAgY29uc3Qg Ym9vbCBhbnRpQWxpYXMgPSBwLT50ZXN0UmVuZGVySGludChRUGFpbnRlcjo6QW50aWFsaWFzaW5n KTsKICAgICBwLT5zZXRSZW5kZXJIaW50KFFQYWludGVyOjpBbnRpYWxpYXNpbmcsIHNob3VsZEFu dGlhbGlhcyk7CiAKLSAgICBpZiAobV9kYXRhLT5oYXNTaGFkb3coKSkgeworICAgIGlmIChoYXNT aGFkb3coKSkgewogICAgICAgICBwLT5zYXZlKCk7CiAgICAgICAgIHAtPnRyYW5zbGF0ZShtX2Rh dGEtPnNoYWRvdy5vZmZzZXQoKSk7CiAgICAgICAgIGlmIChwLT5icnVzaCgpLnN0eWxlKCkgIT0g UXQ6Ok5vQnJ1c2gpCkBAIC01MDgsNyArNTAzLDcgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmZp bGxQYXRoKGNvbnN0IFBhdGgmIHBhdGgpCiAgICAgUVBhaW50ZXJQYXRoIHBsYXRmb3JtUGF0aCA9 IHBhdGgucGxhdGZvcm1QYXRoKCk7CiAgICAgcGxhdGZvcm1QYXRoLnNldEZpbGxSdWxlKHRvUXRG aWxsUnVsZShmaWxsUnVsZSgpKSk7CiAKLSAgICBpZiAobV9kYXRhLT5oYXNTaGFkb3coKSkgewor ICAgIGlmIChoYXNTaGFkb3coKSkgewogICAgICAgICBDb250ZXh0U2hhZG93KiBzaGFkb3cgPSBj b250ZXh0U2hhZG93KCk7CiAgICAgICAgIGlmIChzaGFkb3ctPm11c3RVc2VDb250ZXh0U2hhZG93 KHRoaXMpIHx8IG1fc3RhdGUuZmlsbFBhdHRlcm4gfHwgbV9zdGF0ZS5maWxsR3JhZGllbnQpCiAg ICAgICAgIHsKQEAgLTU0Niw3ICs1NDEsNyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6c3Ryb2tl UGF0aChjb25zdCBQYXRoJiBwYXRoKQogICAgIFFQYWludGVyUGF0aCBwbGF0Zm9ybVBhdGggPSBw YXRoLnBsYXRmb3JtUGF0aCgpOwogICAgIHBsYXRmb3JtUGF0aC5zZXRGaWxsUnVsZSh0b1F0Rmls bFJ1bGUoZmlsbFJ1bGUoKSkpOwogCi0gICAgaWYgKG1fZGF0YS0+aGFzU2hhZG93KCkpIHsKKyAg ICBpZiAoaGFzU2hhZG93KCkpIHsKICAgICAgICAgQ29udGV4dFNoYWRvdyogc2hhZG93ID0gY29u dGV4dFNoYWRvdygpOwogICAgICAgICBpZiAoc2hhZG93LT5tdXN0VXNlQ29udGV4dFNoYWRvdyh0 aGlzKSB8fCBtX3N0YXRlLnN0cm9rZVBhdHRlcm4gfHwgbV9zdGF0ZS5zdHJva2VHcmFkaWVudCkK ICAgICAgICAgewpAQCAtNjYzLDcgKzY1OCw3IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpmaWxs UmVjdChjb25zdCBGbG9hdFJlY3QmIHJlY3QpCiAgICAgICAgIEFmZmluZVRyYW5zZm9ybSBhZmZp bmU7CiAgICAgICAgIFFCcnVzaCBicnVzaChtX3N0YXRlLmZpbGxQYXR0ZXJuLT5jcmVhdGVQbGF0 Zm9ybVBhdHRlcm4oYWZmaW5lKSk7CiAgICAgICAgIFFQaXhtYXAqIGltYWdlID0gbV9zdGF0ZS5m aWxsUGF0dGVybi0+dGlsZUltYWdlKCktPm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7Ci0g ICAgICAgIFFQYWludGVyKiBzaGFkb3dQYWludGVyID0gbV9kYXRhLT5oYXNTaGFkb3coKSA/IHNo YWRvdy0+YmVnaW5TaGFkb3dMYXllcih0aGlzLCBub3JtYWxpemVkUmVjdCkgOiAwOworICAgICAg ICBRUGFpbnRlciogc2hhZG93UGFpbnRlciA9IGhhc1NoYWRvdygpID8gc2hhZG93LT5iZWdpblNo YWRvd0xheWVyKHRoaXMsIG5vcm1hbGl6ZWRSZWN0KSA6IDA7CiAgICAgICAgIGlmIChzaGFkb3dQ YWludGVyKSB7CiAgICAgICAgICAgICBkcmF3UmVwZWF0UGF0dGVybihzaGFkb3dQYWludGVyLCBp bWFnZSwgbm9ybWFsaXplZFJlY3QsIG1fc3RhdGUuZmlsbFBhdHRlcm4tPnJlcGVhdFgoKSwgbV9z dGF0ZS5maWxsUGF0dGVybi0+cmVwZWF0WSgpKTsKICAgICAgICAgICAgIHNoYWRvd1BhaW50ZXIt PnNldENvbXBvc2l0aW9uTW9kZShRUGFpbnRlcjo6Q29tcG9zaXRpb25Nb2RlX1NvdXJjZUluKTsK QEAgLTY3NCw3ICs2NjksNyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6ZmlsbFJlY3QoY29uc3Qg RmxvYXRSZWN0JiByZWN0KQogICAgIH0gZWxzZSBpZiAobV9zdGF0ZS5maWxsR3JhZGllbnQpIHsK ICAgICAgICAgUUJydXNoIGJydXNoKCptX3N0YXRlLmZpbGxHcmFkaWVudC0+cGxhdGZvcm1HcmFk aWVudCgpKTsKICAgICAgICAgYnJ1c2guc2V0VHJhbnNmb3JtKG1fc3RhdGUuZmlsbEdyYWRpZW50 LT5ncmFkaWVudFNwYWNlVHJhbnNmb3JtKCkpOwotICAgICAgICBRUGFpbnRlciogc2hhZG93UGFp bnRlciA9IG1fZGF0YS0+aGFzU2hhZG93KCkgPyBzaGFkb3ctPmJlZ2luU2hhZG93TGF5ZXIodGhp cywgbm9ybWFsaXplZFJlY3QpIDogMDsKKyAgICAgICAgUVBhaW50ZXIqIHNoYWRvd1BhaW50ZXIg PSBoYXNTaGFkb3coKSA/IHNoYWRvdy0+YmVnaW5TaGFkb3dMYXllcih0aGlzLCBub3JtYWxpemVk UmVjdCkgOiAwOwogICAgICAgICBpZiAoc2hhZG93UGFpbnRlcikgewogICAgICAgICAgICAgc2hh ZG93UGFpbnRlci0+ZmlsbFJlY3Qobm9ybWFsaXplZFJlY3QsIGJydXNoKTsKICAgICAgICAgICAg IHNoYWRvd1BhaW50ZXItPnNldENvbXBvc2l0aW9uTW9kZShRUGFpbnRlcjo6Q29tcG9zaXRpb25N b2RlX1NvdXJjZUluKTsKQEAgLTY4Myw3ICs2NzgsNyBAQCB2b2lkIEdyYXBoaWNzQ29udGV4dDo6 ZmlsbFJlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0KQogICAgICAgICB9CiAgICAgICAgIHAtPmZp bGxSZWN0KG5vcm1hbGl6ZWRSZWN0LCBicnVzaCk7CiAgICAgfSBlbHNlIHsKLSAgICAgICAgaWYg KG1fZGF0YS0+aGFzU2hhZG93KCkpIHsKKyAgICAgICAgaWYgKGhhc1NoYWRvdygpKSB7CiAgICAg ICAgICAgICBpZiAoc2hhZG93LT5tdXN0VXNlQ29udGV4dFNoYWRvdyh0aGlzKSkgewogICAgICAg ICAgICAgICAgIFFQYWludGVyKiBzaGFkb3dQYWludGVyID0gc2hhZG93LT5iZWdpblNoYWRvd0xh eWVyKHRoaXMsIG5vcm1hbGl6ZWRSZWN0KTsKICAgICAgICAgICAgICAgICBpZiAoc2hhZG93UGFp bnRlcikgewpAQCAtNzE0LDcgKzcwOSw3IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpmaWxsUmVj dChjb25zdCBGbG9hdFJlY3QmIHJlY3QsIGNvbnN0IENvbG9yJiBjb2xvciwgQ29sb3JTCiAgICAg UVBhaW50ZXIqIHAgPSBtX2RhdGEtPnAoKTsKICAgICBRUmVjdEYgbm9ybWFsaXplZFJlY3QgPSBy ZWN0Lm5vcm1hbGl6ZWQoKTsKIAotICAgIGlmIChtX2RhdGEtPmhhc1NoYWRvdygpKSB7CisgICAg aWYgKGhhc1NoYWRvdygpKSB7CiAgICAgICAgIENvbnRleHRTaGFkb3cqIHNoYWRvdyA9IGNvbnRl eHRTaGFkb3coKTsKICAgICAgICAgaWYgKHNoYWRvdy0+bXVzdFVzZUNvbnRleHRTaGFkb3codGhp cykpIHsKICAgICAgICAgICAgIFFQYWludGVyKiBzaGFkb3dQYWludGVyID0gc2hhZG93LT5iZWdp blNoYWRvd0xheWVyKHRoaXMsIG5vcm1hbGl6ZWRSZWN0KTsKQEAgLTczOCw3ICs3MzMsNyBAQCB2 b2lkIEdyYXBoaWNzQ29udGV4dDo6ZmlsbFJvdW5kZWRSZWN0KGNvbnN0IEludFJlY3QmIHJlY3Qs IGNvbnN0IEludFNpemUmIHRvcExlZgogICAgIFBhdGggcGF0aDsKICAgICBwYXRoLmFkZFJvdW5k ZWRSZWN0KHJlY3QsIHRvcExlZnQsIHRvcFJpZ2h0LCBib3R0b21MZWZ0LCBib3R0b21SaWdodCk7 CiAgICAgUVBhaW50ZXIqIHAgPSBtX2RhdGEtPnAoKTsKLSAgICBpZiAobV9kYXRhLT5oYXNTaGFk b3coKSkgeworICAgIGlmIChoYXNTaGFkb3coKSkgewogICAgICAgICBDb250ZXh0U2hhZG93KiBz aGFkb3cgPSBjb250ZXh0U2hhZG93KCk7CiAgICAgICAgIGlmIChzaGFkb3ctPm11c3RVc2VDb250 ZXh0U2hhZG93KHRoaXMpKSB7CiAgICAgICAgICAgICBRUGFpbnRlciogc2hhZG93UGFpbnRlciA9 IHNoYWRvdy0+YmVnaW5TaGFkb3dMYXllcih0aGlzLCByZWN0KTsK