51981 2011-01-05 21:54:42 -0800 [Qt] [Symbian] Fix building NPAPI support 2011-01-17 00:28:43 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC All RESOLVED FIXED Qt, QtTriaged P3 Normal --- 1 laszlo.gombos webkit-unassigned abarth andersca brettw commit-queue eric fishd oldest_to_newest 330026 0 laszlo.gombos 2011-01-05 21:54:42 -0800 The build failure reported is the following: compile : WebKit2\Shared\Plugins\Netscape\NetscapePluginModule.cpp "Y:/epoc32/include/mw/QtCore/qsize.h", line 88: Error: #338: more than one instance of overloaded function "operator*" has "C" linkage friend inline const QSize operator*(qreal, const QSize &); ^ "Y:/epoc32/include/mw/QtCore/qsize.h", line 95: Error: #800: this declaration may not have extern "C" linkage Q_DECLARE_TYPEINFO(QSize, Q_MOVABLE_TYPE); ^ It seems that the "C" linkage declaration is not used consistently and the following section of the npapi.h is included both with and without the "C" linkage declaration (depending the ordering of the include files). #if defined(XP_SYMBIAN) #include <QEvent> #include <QRegion> #endif 330032 1 78096 laszlo.gombos 2011-01-05 22:11:52 -0800 Created attachment 78096 proposed patch 331902 2 eric 2011-01-10 13:39:11 -0800 I'm trying to think who knows npapi.h these days. 335177 3 78096 hausmann 2011-01-17 00:07:40 -0800 Comment on attachment 78096 proposed patch I think this change is correct. A header file should not rely on extern "C" being set but declare it itself. Plus npapi.h already has the extern "C" declarations a bit further down the file. 335186 4 78096 commit-queue 2011-01-17 00:28:36 -0800 Comment on attachment 78096 proposed patch Clearing flags on attachment: 78096 Committed r75925: <http://trac.webkit.org/changeset/75925> 335188 5 commit-queue 2011-01-17 00:28:43 -0800 All reviewed patches have been landed. Closing bug. 78096 2011-01-05 22:11:52 -0800 2011-01-17 00:28:36 -0800 proposed patch 51981.patch text/plain 1189 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NTEzNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMDEtMDUgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gW1N5bWJpYW5dIEZpeCBidWlsZGluZyBOUEFQSSBzdXBwb3J0CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTk4MQorCisgICAgICAg IE1ha2Ugc3VyZSB0aGF0IG5wYXBpLmggaXMgYWx3YXlzIGluY2x1ZGVkIG91dHNpZGUgb2YgdGhl IGV4dGVybiAiQyIKKyAgICAgICAgbGlua2FnZSBkZWNsYXJhdGlvbiBibG9jay4KKworICAgICAg ICBObyBuZXcgdGVzdHMgYXMgdGhlcmUgaXMgbm8gbmV3IGZ1bmN0aW9uYWxpdHkuCisKKyAgICAg ICAgKiBicmlkZ2UvbnBydW50aW1lLmg6CisKIDIwMTEtMDEtMDUgIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQXJpeWEgSGlkYXlh dC4KSW5kZXg6IFdlYkNvcmUvYnJpZGdlL25wcnVudGltZS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvYnJpZGdlL25wcnVudGltZS5oCShyZXZpc2lvbiA3NTEyMikKKysrIFdlYkNvcmUvYnJpZGdl L25wcnVudGltZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMywxMiArMzMsMTIgQEAKICNpZm5kZWYg X05QX1JVTlRJTUVfSF8KICNkZWZpbmUgX05QX1JVTlRJTUVfSF8KIAorI2luY2x1ZGUgIm5wYXBp LmgiCisKICNpZmRlZiBfX2NwbHVzcGx1cwogZXh0ZXJuICJDIiB7CiAjZW5kaWYKIAotI2luY2x1 ZGUgIm5wYXBpLmgiCi0KIC8qCiAgICAgVGhpcyBBUEkgaXMgdXNlZCB0byBmYWNpbGl0YXRlIGJp bmRpbmcgY29kZSB3cml0dGVuIGluIEMgdG8gc2NyaXB0CiAgICAgb2JqZWN0cy4gIFRoZSBBUEkg aW4gdGhpcyBoZWFkZXIgZG9lcyBub3QgYXNzdW1lIHRoZSBwcmVzZW5jZSBvZiBhCg==