51974 2011-01-05 17:48:13 -0800 Atomics.h has incorrect GCC test for ext/atomicity.h when using LSB compilers 2012-08-08 02:10:41 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 audiofanatic webkit-unassigned hausmann jedrzej.nowacki paroga webkit.review.bot oldest_to_newest 329938 0 audiofanatic 2011-01-05 17:48:13 -0800 In JacaScriptCore/wtf/Atomics.h the following code block can be found around line 64: #if OS(WINDOWS) #include <windows.h> #elif OS(DARWIN) #include <libkern/OSAtomic.h> #elif OS(ANDROID) #include <cutils/atomic.h> #elif COMPILER(GCC) && !OS(SYMBIAN) #if (__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 2)) #include <ext/atomicity.h> #else #include <bits/atomicity.h> #endif #endif The test for the GCC version is not correct when the LSB compiler is being used under linux, since the LSB headers only have bits/atomicity.h and not ext/atomicity.h. A more correct test would be: #if ((__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 2))) && !defined(__LSB_VERSION__) For reference, the LSB and Qt bug trackers also have corresponding entries about this particular webkit issue: http://bugs.linuxbase.org/show_bug.cgi?id=2522 http://bugreports.qt.nokia.com/browse/QTBUG-16329 330277 1 paroga 2011-01-06 12:04:16 -0800 Can you provide a patch for this? See http://webkit.org/coding/contributing.html 376207 2 jedrzej.nowacki 2011-03-30 05:09:57 -0700 As far I understand ext/atomicity.h file should not be included at all. The file starts from this warning: /** @file atomicity.h * This is an internal header file, included by other library headers. * You should not attempt to use it directly. */ Changing status to New 655779 3 149104 alvaro 2012-06-22 14:39:38 -0700 Created attachment 149104 Patch 680290 4 hausmann 2012-07-27 01:33:36 -0700 Would you like help landing this, i.e. using the commit queue? 689841 5 audiofanatic 2012-08-07 21:17:52 -0700 Not sure what the holdup is here. Alvaro provided a patch, so I'm assuming your last comment was directed to him. My changed employment arrangements mean I no longer can commit time to these issues myself. 690069 6 149104 webkit.review.bot 2012-08-08 02:10:38 -0700 Comment on attachment 149104 Patch Clearing flags on attachment: 149104 Committed r125010: <http://trac.webkit.org/changeset/125010> 690070 7 webkit.review.bot 2012-08-08 02:10:41 -0700 All reviewed patches have been landed. Closing bug. 149104 2012-06-22 14:39:38 -0700 2012-08-08 02:10:38 -0700 Patch bug-51974-20120622233935.patch text/plain 1304 alvaro SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMjEwNTYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA2LTIyICBBbHZhcm8gTG9wZXogT3J0ZWdh ICA8YWx2YXJvQGFsb2Jicy5jb20+CisKKyAgICAgICAgQXRvbWljcy5oIGhhcyBpbmNvcnJlY3Qg R0NDIHRlc3QgZm9yIGV4dC9hdG9taWNpdHkuaCB3aGVuIHVzaW5nIExTQiBjb21waWxlcnMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxOTc0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvQXRvbWlj cy5oOiBJbmhpYml0cyB0aGUgaW5jbHVzaW9uIG9mIHRoZSBhdG9taWNpdHkuaCBHTlUgQysrCisg ICAgICAgIGV4dGVuc2lvbiB3aGVuIGNvbXBpbGluZyB3aXRoIGEgTFNCIGNvbXBsaWFudCBjb21w aWxlci4gVGhhbmtzIHRvCisgICAgICAgIENyYWlnIFNjb3R0IGZvciB0aGUgbmV3IHByZWNvbXBp bGVyIGNoZWNrIGNvZGUuCisKIDIwMTItMDYtMjIgIFBldGVyIEJldmVybG9vICA8cGV0ZXJAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gRGlzYWJsZSBjKysweCBjb21wYXRpYmls aXR5IHdhcm5pbmdzIGluIEphdmFTY3JpcHRDb3JlLmd5cCB3aGVuIGJ1aWxkaW5nIGZvciBBbmRy b2lkCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9BdG9taWNzLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dURi93dGYvQXRvbWljcy5oCShyZXZpc2lvbiAxMjEwMTUpCisrKyBTb3VyY2UvV1RGL3d0Zi9B dG9taWNzLmgJKHdvcmtpbmcgY29weSkKQEAgLTcyLDcgKzcyLDcgQEAKICNlbGlmIE9TKEFORFJP SUQpCiAjaW5jbHVkZSA8c3lzL2F0b21pY3MuaD4KICNlbGlmIENPTVBJTEVSKEdDQykKLSNpZiAo X19HTlVDX18gPiA0KSB8fCAoKF9fR05VQ19fID09IDQpICYmIChfX0dOVUNfTUlOT1JfXyA+PSAy KSkKKyNpZiAoKF9fR05VQ19fID4gNCkgfHwgKChfX0dOVUNfXyA9PSA0KSAmJiAoX19HTlVDX01J Tk9SX18gPj0gMikpKSAmJiAhZGVmaW5lZChfX0xTQl9WRVJTSU9OX18pCiAjaW5jbHVkZSA8ZXh0 L2F0b21pY2l0eS5oPgogI2Vsc2UKICNpbmNsdWRlIDxiaXRzL2F0b21pY2l0eS5oPgo=