51971 2011-01-05 17:14:59 -0800 change the way we do comment highlighting in the code review tool 2011-01-05 20:37:17 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth commit-queue eric oldest_to_newest 329907 0 ojan 2011-01-05 17:14:59 -0800 change the way we do comment highlighting in the code review tool 329909 1 78077 ojan 2011-01-05 17:16:12 -0800 Created attachment 78077 Patch 329935 2 78077 abarth 2011-01-05 17:43:18 -0800 Comment on attachment 78077 Patch Interesting idea. I'll be interested to see how this works in side-by-side mode. I feel like you're teaching me JavaScript in these patches, which I appreciate. :) 330001 3 78077 commit-queue 2011-01-05 20:37:11 -0800 Comment on attachment 78077 Patch Clearing flags on attachment: 78077 Committed r75133: <http://trac.webkit.org/changeset/75133> 330002 4 commit-queue 2011-01-05 20:37:17 -0800 All reviewed patches have been landed. Closing bug. 78077 2011-01-05 17:16:12 -0800 2011-01-05 20:37:11 -0800 Patch bug-51971-20110105171610.patch text/plain 5143 ojan ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRl cy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDQ2OTI3YzRmM2NlMGE5Y2E1NDVlNTZk NWVjNzE5ODEzN2NjNWYxM2EuLmE4MTVlZjJmODdiZmRlODRjOWFhNmJiZjJmNmYzODg3NDYxNTMw ZDQgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIv V2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEx LTAxLTA1ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgY2hhbmdlIHRoZSB3YXkgd2UgZG8gY29t bWVudCBoaWdobGlnaHRpbmcgaW4gdGhlIGNvZGUgcmV2aWV3IHRvb2wKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxOTcxCisKKyAgICAgICAgU3RvcmUg YSBzcGFjZS1zZXBhcmF0ZWQgbGlzdCBvZiBiYXNlIGxpbmUgSURzIG9uIGVhY2ggbGluZSB0aGF0 IGhhcworICAgICAgICBjb21tZW50cyBhc3NvY2lhdGVkIHdpdGggdGhhdCBsaW5lLiBUaGlzIGFs bG93cyBmb3Igb3ZlcmxhcHBpbmcgY29tbWVudHMsCisgICAgICAgIGJ1dCBtb3JlIGltcG9ydGFu dGx5LCBtYWtlcyBhZGRpbmcgc2lkZS1ieS1zaWRlIGRpZmYgc3VwcG9ydCBlYXNpZXIuCisKKyAg ICAgICAgKiBjb2RlLXJldmlldy5qczoKKwogMjAxMS0wMS0wNCAgT2phbiBWYWZhaSAgPG9qYW5A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIEluY3JlbWVudCB2ZXJzaW9uIG51bWJlciB0byBhdm9p ZCBnZXR0aW5nIHRoZSBjYWNoZWQgSlMgZmlsZS4KZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mu d2Via2l0Lm9yZy9jb2RlLXJldmlldy5qcyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb2Rl LXJldmlldy5qcwppbmRleCBkYWE5OWU3ODcxMGIyOWFhODU1NDUxN2YzYjQzMzYxNzkwNDY1ZGU2 Li42MTc1YjYzZGFiZTgzMmRiYzJhZTcwNGE1ODE2MGRjN2JiZGI3ZTYwIDEwMDY0NAotLS0gYS9X ZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMKKysrIGIvV2Vic2l0ZXMvYnVn cy53ZWJraXQub3JnL2NvZGUtcmV2aWV3LmpzCkBAIC03MTcsMjAgKzcxNywyNiBAQAogICAgICAg Zm9jdXNQcmV2aW91c0NvbW1lbnQoKTsKICAgfSk7CiAKLSAgZnVuY3Rpb24gY29udGV4dExpbmVz Rm9yKGxpbmUpIHsKLSAgICB2YXIgY29udGV4dCA9IFtdOwotICAgIHdoaWxlIChsaW5lLmhhc0Ns YXNzKCdjb21tZW50Q29udGV4dCcpKSB7Ci0gICAgICAkLm1lcmdlKGNvbnRleHQsIGxpbmUpOwot ICAgICAgbGluZSA9IGxpbmUucHJldigpOwotICAgIH0KLSAgICByZXR1cm4gJChjb250ZXh0LnJl dmVyc2UoKSk7CisgIGZ1bmN0aW9uIGNvbnRleHRMaW5lc0ZvcihsaW5lX2lkKSB7CisgICAgcmV0 dXJuICQoJ2RpdltkYXRhLWNvbW1lbnQtYmFzZS1saW5lfj0iJyArIGxpbmVfaWQgKyAnIl0nKTsK KyAgfQorCisgIGZ1bmN0aW9uIG51bWJlckZyb20obGluZV9pZCkgeworICAgIHJldHVybiBOdW1i ZXIobGluZV9pZC5yZXBsYWNlKCdsaW5lJywgJycpKTsKICAgfQogCiAgIGZ1bmN0aW9uIHRyaW1D b21tZW50Q29udGV4dFRvQmVmb3JlKGxpbmUpIHsKLSAgICB3aGlsZSAobGluZS5oYXNDbGFzcygn Y29tbWVudENvbnRleHQnKSAmJiBsaW5lLmF0dHIoJ2RhdGEtaGFzLWNvbW1lbnQnKSAhPSAndHJ1 ZScpIHsKLSAgICAgIGxpbmUucmVtb3ZlQ2xhc3MoJ2NvbW1lbnRDb250ZXh0Jyk7Ci0gICAgICBs aW5lID0gbGluZS5wcmV2KCk7Ci0gICAgfQorICAgIHZhciBiYXNlX2xpbmVfaWQgPSBsaW5lLmF0 dHIoJ2RhdGEtY29tbWVudC1iYXNlLWxpbmUnKTsKKyAgICB2YXIgbGluZV90b190cmltX3RvID0g bnVtYmVyRnJvbShsaW5lLmF0dHIoJ2lkJykpOworICAgIGNvbnRleHRMaW5lc0ZvcihiYXNlX2xp bmVfaWQpLmVhY2goZnVuY3Rpb24oKSB7CisgICAgICB2YXIgaWQgPSAkKHRoaXMpLmF0dHIoJ2lk Jyk7CisgICAgICBpZiAobnVtYmVyRnJvbShpZCkgPiBsaW5lX3RvX3RyaW1fdG8pCisgICAgICAg IHJldHVybjsKKworICAgICAgcmVtb3ZlRGF0YUNvbW1lbnRCYXNlTGluZSh0aGlzLCBiYXNlX2xp bmVfaWQpOworICAgICAgaWYgKCEkKHRoaXMpLmF0dHIoJ2RhdGEtY29tbWVudC1iYXNlLWxpbmUn KSkKKyAgICAgICAgJCh0aGlzKS5yZW1vdmVDbGFzcygnY29tbWVudENvbnRleHQnKTsKKyAgICB9 KTsKICAgfQogCiAgIHZhciBpbl9kcmFnX3NlbGVjdCA9IGZhbHNlOwpAQCAtNzQ2LDM4ICs3NTIs ODQgQEAKICAgICAgIHRyaW1Db21tZW50Q29udGV4dFRvQmVmb3JlKGxpbmUucHJldigpKTsKICAg fSkubGl2ZSgnbW91c2Vkb3duJywgZnVuY3Rpb24oKSB7CiAgICAgaW5fZHJhZ19zZWxlY3QgPSB0 cnVlOwotICAgICQodGhpcykucGFyZW50KCkuYWRkQ2xhc3MoJ3NlbGVjdGVkJyk7CisgICAgJChs aW5lRnJvbUxpbmVEZXNjZW5kYW50KHRoaXMpKS5hZGRDbGFzcygnc2VsZWN0ZWQnKTsKICAgICBl dmVudC5wcmV2ZW50RGVmYXVsdCgpOwogICB9KTsKLSAgCisKICAgJCgnLkxpbmUnKS5saXZlKCdt b3VzZWVudGVyJywgZnVuY3Rpb24oKSB7CiAgICAgaWYgKCFpbl9kcmFnX3NlbGVjdCkKICAgICAg IHJldHVybjsKIAotICAgIHZhciBiZWZvcmUgPSAkKHRoaXMpLnByZXZVbnRpbCgnLnNlbGVjdGVk JykKLSAgICBpZiAoYmVmb3JlLnByZXYoKS5oYXNDbGFzcygnc2VsZWN0ZWQnKSkKLSAgICAgIGJl Zm9yZS5hZGRDbGFzcygnc2VsZWN0ZWQnKTsKLQotICAgIHZhciBhZnRlciA9ICQodGhpcykubmV4 dFVudGlsKCcuc2VsZWN0ZWQnKQotICAgIGlmIChhZnRlci5uZXh0KCkuaGFzQ2xhc3MoJ3NlbGVj dGVkJykpCi0gICAgICBhZnRlci5hZGRDbGFzcygnc2VsZWN0ZWQnKTsKLQotICAgICQodGhpcyku YWRkQ2xhc3MoJ3NlbGVjdGVkJyk7CisgICAgdmFyIGxpbmUgPSBsaW5lRnJvbUxpbmVDb250YWlu ZXIodGhpcyk7CisgICAgbGluZS5hZGRDbGFzcygnc2VsZWN0ZWQnKTsKICAgfSkubGl2ZSgnbW91 c2V1cCcsIGZ1bmN0aW9uKCkgewogICAgIGlmICghaW5fZHJhZ19zZWxlY3QpCiAgICAgICByZXR1 cm47CiAgICAgdmFyIHNlbGVjdGVkID0gJCgnLnNlbGVjdGVkJyk7CiAgICAgdmFyIHNob3VsZF9h ZGRfY29tbWVudCA9ICFzZWxlY3RlZC5sYXN0KCkubmV4dCgpLmhhc0NsYXNzKCdjb21tZW50Q29u dGV4dCcpOwogICAgIHNlbGVjdGVkLmFkZENsYXNzKCdjb21tZW50Q29udGV4dCcpOwotICAgIGlm IChzaG91bGRfYWRkX2NvbW1lbnQpCi0gICAgICBhZGRDb21tZW50Rm9yKHNlbGVjdGVkLmxhc3Qo KSk7CisKKyAgICB2YXIgaWQ7CisgICAgaWYgKHNob3VsZF9hZGRfY29tbWVudCkgeworICAgICAg dmFyIGxhc3QgPSBsaW5lRnJvbUxpbmVEZXNjZW5kYW50KHNlbGVjdGVkLmxhc3QoKVswXSk7Cisg ICAgICBhZGRDb21tZW50Rm9yKCQobGFzdCkpOworICAgICAgaWQgPSBsYXN0LmlkOworICAgIH0g ZWxzZSB7CisgICAgICBpZCA9IHNlbGVjdGVkLmxhc3QoKS5uZXh0KClbMF0uZ2V0QXR0cmlidXRl KCdkYXRhLWNvbW1lbnQtYmFzZS1saW5lJyk7CisgICAgfQorCisgICAgc2VsZWN0ZWQuZWFjaChm dW5jdGlvbigpIHsKKyAgICAgIGFkZERhdGFDb21tZW50QmFzZUxpbmUodGhpcywgaWQpOworICAg IH0pOwogICB9KTsKIAorICBmdW5jdGlvbiBhZGREYXRhQ29tbWVudEJhc2VMaW5lKGxpbmUsIGlk KSB7CisgICAgdmFyIHZhbCA9ICQobGluZSkuYXR0cignZGF0YS1jb21tZW50LWJhc2UtbGluZScp OworCisgICAgdmFyIHBhcnRzID0gdmFsID8gdmFsLnNwbGl0KCcgJykgOiBbXTsKKyAgICBmb3Ig KHZhciBpID0gMDsgaSA8IHBhcnRzLmxlbmd0aDsgaSsrKSB7CisgICAgICBpZiAocGFydHNbaV0g PT0gaWQpCisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICBwYXJ0cy5wdXNoKGlkKTsKKyAg ICAkKGxpbmUpLmF0dHIoJ2RhdGEtY29tbWVudC1iYXNlLWxpbmUnLCBwYXJ0cy5qb2luKCcgJykp OworICB9CisKKyAgZnVuY3Rpb24gcmVtb3ZlRGF0YUNvbW1lbnRCYXNlTGluZShsaW5lLCBpZCkg eworICAgIHZhciB2YWwgPSAkKGxpbmUpLmF0dHIoJ2RhdGEtY29tbWVudC1iYXNlLWxpbmUnKTsK KyAgICBpZiAoIXZhbCkKKyAgICAgIHJldHVybjsKKworICAgIHZhciBwYXJ0cyA9IHZhbC5zcGxp dCgnICcpOworICAgIHZhciBuZXdWYWwgPSBbXTsKKyAgICBmb3IgKHZhciBpID0gMDsgaSA8IHBh cnRzLmxlbmd0aDsgaSsrKSB7CisgICAgICBpZiAocGFydHNbaV0gIT0gaWQpCisgICAgICAgIG5l d1ZhbC5wdXNoKHBhcnRzW2ldKTsKKyAgICB9CisKKyAgICAkKGxpbmUpLmF0dHIoJ2RhdGEtY29t bWVudC1iYXNlLWxpbmUnLCBuZXdWYWwuam9pbignICcpKTsKKyAgfQorCisgIGZ1bmN0aW9uIGxp bmVGcm9tTGluZURlc2NlbmRhbnQoZGVzY2VuZGFudCkgeworICAgIHdoaWxlIChkZXNjZW5kYW50 ICYmICEkKGRlc2NlbmRhbnQpLmhhc0NsYXNzKCdMaW5lJykpIHsKKyAgICAgIGRlc2NlbmRhbnQg PSBkZXNjZW5kYW50LnBhcmVudE5vZGU7CisgICAgfQorICAgIHJldHVybiBkZXNjZW5kYW50Owor ICB9CisKKyAgZnVuY3Rpb24gbGluZUZyb21MaW5lQ29udGFpbmVyKGxpbmVDb250YWluZXIpIHsK KyAgICB2YXIgbGluZSA9ICQobGluZUNvbnRhaW5lcik7CisgICAgaWYgKCFsaW5lLmhhc0NsYXNz KCdMaW5lJykpCisgICAgICBsaW5lID0gJCgnLkxpbmUnLCBsaW5lKTsKKyAgICByZXR1cm4gbGlu ZTsKKyAgfQorCiAgICQoJy5EaWZmU2VjdGlvbicpLmxpdmUoJ21vdXNlbGVhdmUnLCBzdG9wRHJh Z1NlbGVjdCkubGl2ZSgnbW91c2V1cCcsIHN0b3BEcmFnU2VsZWN0KTsKIAogICBmdW5jdGlvbiBj b250ZXh0U25pcHBldEZvcihsaW5lLCBpbmRlbnQpIHsKICAgICB2YXIgc25pcHBldHMgPSBbXQot ICAgIGNvbnRleHRMaW5lc0ZvcihsaW5lKS5lYWNoKGZ1bmN0aW9uKCkgeworICAgIGNvbnRleHRM aW5lc0ZvcihsaW5lLmF0dHIoJ2lkJykpLmVhY2goZnVuY3Rpb24oKSB7CiAgICAgICB2YXIgYWN0 aW9uID0gJyAnOwogICAgICAgaWYgKCQodGhpcykuaGFzQ2xhc3MoJ2FkZCcpKQogICAgICAgICBh Y3Rpb24gPSAnKyc7Cg==