51970 2011-01-05 16:50:54 -0800 check-webkit-style should allow unnecessary parameter names in WebKit2 APIs 2011-01-05 20:09:41 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jeffm jeffm ap commit-queue oldest_to_newest 329872 0 jeffm 2011-01-05 16:50:54 -0800 check=webkit-style should allow parameter names in WebKit2 APIs 329875 1 78064 jeffm 2011-01-05 16:54:12 -0800 Created attachment 78064 Patch 329876 2 78064 aroben 2011-01-05 16:55:50 -0800 Comment on attachment 78064 Patch You should update the comment above this section to explain why we allow "unnecessary" parameter names. (It's because we're matching CF's header style.) 329887 3 78070 jeffm 2011-01-05 17:03:06 -0800 Created attachment 78070 Patch 329890 4 78072 jeffm 2011-01-05 17:07:15 -0800 Created attachment 78072 Patch 329892 5 jeffm 2011-01-05 17:07:39 -0800 OK, both the change log and comments in the script have been updated. 329960 6 levin 2011-01-05 18:22:39 -0800 *** Bug 51938 has been marked as a duplicate of this bug. *** 329995 7 78072 commit-queue 2011-01-05 20:09:35 -0800 Comment on attachment 78072 Patch Clearing flags on attachment: 78072 Committed r75132: <http://trac.webkit.org/changeset/75132> 329996 8 commit-queue 2011-01-05 20:09:41 -0800 All reviewed patches have been landed. Closing bug. 78064 2011-01-05 16:54:12 -0800 2011-01-05 17:03:03 -0800 Patch bug-51970-20110105165408.patch text/plain 1117 jeffm SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc1MTE5KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTEtMDEtMDUgIEplZmYgTWlsbGVyICA8amVmZm1AYXBwbGUuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtp dC1zdHlsZSBzaG91bGQgYWxsb3cgcGFyYW1ldGVyIG5hbWVzIGluIFdlYktpdDIgQVBJcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE5NzAKKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weToKKyAgICAgICAgQWRkIC1y ZWFkYWJpbGl0eS9uYW1pbmcgZm9yIFdlYktpdDIgQyBBUEkgZGlyZWN0b3JpZXMuCisKIDIwMTEt MDEtMDUgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IE9qYW4gVmFmYWkuCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXIucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy LnB5CShyZXZpc2lvbiA3NTA4NSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlci5weQkod29ya2luZyBjb3B5KQpAQCAtMTc0LDYgKzE3NCw3IEBAIF9QQVRIX1JVTEVTX1NQ RUNJRklFUiA9IFsKICAgICAgICJXZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJ L2MvIl0sCiAgICAgIFsiLWJ1aWxkL2luY2x1ZGVfb3JkZXIiLAogICAgICAgIi1yZWFkYWJpbGl0 eS9uYW1pbmciLAorICAgICAgIi1yZWFkYWJpbGl0eS9wYXJhbWV0ZXJfbmFtZSIsCiAgICAgICAi LXdoaXRlc3BhY2UvZGVjbGFyYXRpb24iXSksCiAgICAgKFsjIE5vdGhpbmcgaW4gV2ViS2l0MiB1 c2VzIGNvbmZpZy5oLgogICAgICAgIldlYktpdDIvIl0sCg== 78070 2011-01-05 17:03:06 -0800 2011-01-05 17:07:11 -0800 Patch bug-51970-20110105170302.patch text/plain 1170 jeffm SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc1MTE5KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTEtMDEtMDUgIEplZmYgTWlsbGVyICA8amVmZm1AYXBwbGUuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtp dC1zdHlsZSBzaG91bGQgYWxsb3cgdW5uZWNlc3NhcnkgcGFyYW1ldGVyIG5hbWVzIGluIFdlYktp dDIgQVBJcyBiZWNhdXNlIHdlJ3JlIG1hdGNoaW5nIENGJ3MgaGVhZGVyIHN0eWxlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTk3MAorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5OgorICAgICAgICBBZGQgLXJlYWRh YmlsaXR5L25hbWluZyBmb3IgV2ViS2l0MiBDIEFQSSBkaXJlY3Rvcmllcy4KKwogMjAxMS0wMS0w NSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg T2phbiBWYWZhaS4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5w eQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkJ KHJldmlzaW9uIDc1MDg1KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNzQsNiArMTc0LDcgQEAgX1BBVEhfUlVMRVNfU1BFQ0lG SUVSID0gWwogICAgICAgIldlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy8i XSwKICAgICAgWyItYnVpbGQvaW5jbHVkZV9vcmRlciIsCiAgICAgICAiLXJlYWRhYmlsaXR5L25h bWluZyIsCisgICAgICAiLXJlYWRhYmlsaXR5L3BhcmFtZXRlcl9uYW1lIiwKICAgICAgICItd2hp dGVzcGFjZS9kZWNsYXJhdGlvbiJdKSwKICAgICAoWyMgTm90aGluZyBpbiBXZWJLaXQyIHVzZXMg Y29uZmlnLmguCiAgICAgICAiV2ViS2l0Mi8iXSwK 78072 2011-01-05 17:07:15 -0800 2011-01-05 20:09:35 -0800 Patch bug-51970-20110105170711.patch text/plain 1507 jeffm SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc1MTE5KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTEtMDEtMDUgIEplZmYgTWlsbGVyICA8amVmZm1AYXBwbGUuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtp dC1zdHlsZSBzaG91bGQgYWxsb3cgdW5uZWNlc3NhcnkgcGFyYW1ldGVyIG5hbWVzIGluIFdlYktp dDIgQVBJcyBiZWNhdXNlIHdlJ3JlIG1hdGNoaW5nIENGJ3MgaGVhZGVyIHN0eWxlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTk3MAorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5OgorICAgICAgICBBZGQgLXJlYWRh YmlsaXR5L25hbWluZyBmb3IgV2ViS2l0MiBDIEFQSSBkaXJlY3Rvcmllcy4KKwogMjAxMS0wMS0w NSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg T2phbiBWYWZhaS4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5w eQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkJ KHJldmlzaW9uIDc1MDg1KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xNjksMTEgKzE2OSwxMyBAQCBfUEFUSF9SVUxFU19TUEVD SUZJRVIgPSBbCiAgICAgIFsiLWJ1aWxkL2luY2x1ZGVfb3JkZXIiLAogICAgICAgIi1yZWFkYWJp bGl0eS9uYW1pbmciXSksCiAgICAgKFsjIFRoZSBXZWJLaXQyIEMgQVBJIGhhcyBuYW1lcyB3aXRo IHVuZGVyc2NvcmVzIGFuZCB3aGl0ZXNwYWNlLWFsaWduZWQKLSAgICAgICMgc3RydWN0IG1lbWJl cnMuCisgICAgICAjIHN0cnVjdCBtZW1iZXJzLiBBbHNvLCB3ZSBhbGxvdyB1bm5lY2Vzc2FyeSBw YXJhbWV0ZXIgbmFtZXMgaW4KKyAgICAgICMgV2ViS2l0MiBBUElzIGJlY2F1c2Ugd2UncmUgbWF0 Y2hpbmcgQ0YncyBoZWFkZXIgc3R5bGUuCiAgICAgICAiV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Mv IiwKICAgICAgICJXZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvIl0sCiAg ICAgIFsiLWJ1aWxkL2luY2x1ZGVfb3JkZXIiLAogICAgICAgIi1yZWFkYWJpbGl0eS9uYW1pbmci LAorICAgICAgIi1yZWFkYWJpbGl0eS9wYXJhbWV0ZXJfbmFtZSIsCiAgICAgICAiLXdoaXRlc3Bh Y2UvZGVjbGFyYXRpb24iXSksCiAgICAgKFsjIE5vdGhpbmcgaW4gV2ViS2l0MiB1c2VzIGNvbmZp Zy5oLgogICAgICAgIldlYktpdDIvIl0sCg==