51968 2011-01-05 16:25:39 -0800 WebKit2: Add APIs to WKBundleFrame to get content bounds and scroll offset 2011-01-06 12:18:00 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jeffm jeffm abarth commit-queue eric webkit.review.bot oldest_to_newest 329861 0 jeffm 2011-01-05 16:25:39 -0800 WebKit2: Add APIs to WKBundleFrame to get content bounds and scroll offset 329862 1 jeffm 2011-01-05 16:28:25 -0800 This is to support the equivalent of IWebFramePrivate::contentBounds() and IWebFramePrivate::scrollOffset from WebKit1. 329865 2 78061 jeffm 2011-01-05 16:32:21 -0800 Created attachment 78061 Patch 329903 3 78061 jeffm 2011-01-05 17:11:42 -0800 Comment on attachment 78061 Patch Obsoleting this patch, once https://bugs.webkit.org/show_bug.cgi?id=51970 lands I'll redo the patch to include the parameter names in the header. 330019 4 78095 jeffm 2011-01-05 21:31:31 -0800 Created attachment 78095 Patch to add APIs to WKBundleFrame to get content bounds and scroll offset 330021 5 78095 darin 2011-01-05 21:38:45 -0800 Comment on attachment 78095 Patch to add APIs to WKBundleFrame to get content bounds and scroll offset View in context: https://bugs.webkit.org/attachment.cgi?id=78095&action=review > WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:145 > + WKRect contentBounds = { {0, 0}, {0, 0} }; We’d normally put four more spaces in there. 330022 6 jeffm 2011-01-05 21:43:26 -0800 (In reply to comment #5) > (From update of attachment 78095 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=78095&action=review > > > WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:145 > > + WKRect contentBounds = { {0, 0}, {0, 0} }; > > We’d normally put four more spaces in there. Normally, I prefer contentBounds = { 0 }, which avoids any dependency on the internal structure of WKRect, but Sam said he did it this way. Thanks for reviewing. 330234 7 78095 commit-queue 2011-01-06 11:08:56 -0800 Comment on attachment 78095 Patch to add APIs to WKBundleFrame to get content bounds and scroll offset Clearing flags on attachment: 78095 Committed r75171: <http://trac.webkit.org/changeset/75171> 330235 8 commit-queue 2011-01-06 11:09:02 -0800 All reviewed patches have been landed. Closing bug. 330299 9 webkit.review.bot 2011-01-06 12:18:00 -0800 http://trac.webkit.org/changeset/75171 might have broken GTK Linux 32-bit Release 78061 2011-01-05 16:32:21 -0800 2011-01-05 17:11:42 -0800 Patch bug-51968-20110105163217.patch text/plain 3049 jeffm SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NTExNSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDEtMDUgIEplZmYgTWlsbGVyICA8amVmZm1AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktp dDI6IEFkZCBBUElzIHRvIFdLQnVuZGxlRnJhbWUgdG8gZ2V0IGNvbnRlbnQgYm91bmRzIGFuZCBz Y3JvbGwgb2Zmc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD01MTk2OAorCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9X S0J1bmRsZUZyYW1lLmNwcDoKKyAgICAgICAgKFdLQnVuZGxlRnJhbWVHZXRDb250ZW50Qm91bmRz KToKKyAgICAgICAgKFdLQnVuZGxlRnJhbWVHZXRTY3JvbGxPZmZzZXQpOgorICAgICAgICAqIFdl YlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVGcmFtZS5oOgorICAgICAgICBB ZGQgV0tCdW5kbGVGcmFtZUdldENvbnRlbnRCb3VuZHMoKSBhbmQgV0tCdW5kbGVGcmFtZUdldFNj cm9sbE9mZnNldCgpLgorCiAyMDExLTAxLTA1ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29t Ym9zQG5va2lhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KSW5kZXg6IFdl YktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZUZyYW1lLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tC dW5kbGVGcmFtZS5jcHAJKHJldmlzaW9uIDc1MDg1KQorKysgV2ViS2l0Mi9XZWJQcm9jZXNzL0lu amVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlRnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z MCw2ICszMCw3IEBACiAjaW5jbHVkZSAiV0tCdW5kbGVBUElDYXN0LmgiCiAjaW5jbHVkZSAiV2Vi RnJhbWUuaCIKICNpbmNsdWRlIDxXZWJDb3JlL0ZyYW1lLmg+CisjaW5jbHVkZSA8V2ViQ29yZS9G cmFtZVZpZXcuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiB1c2luZyBuYW1lc3BhY2Ug V2ViS2l0OwpAQCAtMTM4LDMgKzEzOSwzNiBAQCBib29sIFdLQnVuZGxlRnJhbWVBbGxvd3NGb2xs b3dpbmdMaW5rKFdLCiB7CiAgICAgcmV0dXJuIHRvSW1wbChmcmFtZVJlZiktPmFsbG93c0ZvbGxv d2luZ0xpbmsoV2ViQ29yZTo6S1VSTChXZWJDb3JlOjpLVVJMKCksIHRvSW1wbCh1cmxSZWYpLT5z dHJpbmcoKSkpOwogfQorCitXS1JlY3QgV0tCdW5kbGVGcmFtZUdldENvbnRlbnRCb3VuZHMoV0tC dW5kbGVGcmFtZVJlZiBmcmFtZVJlZikKK3sKKyAgICBXS1JlY3QgY29udGVudEJvdW5kcyA9IHsg ezAsIDB9LCB7MCwgMH0gfTsKKyAgICAKKyAgICBGcmFtZSogY29yZUZyYW1lID0gdG9JbXBsKGZy YW1lUmVmKS0+Y29yZUZyYW1lKCk7CisgICAgaWYgKCFjb3JlRnJhbWUpCisgICAgICAgIHJldHVy biBjb250ZW50Qm91bmRzOworICAgIAorICAgIEZyYW1lVmlldyogdmlldyA9IGNvcmVGcmFtZS0+ dmlldygpOworICAgIGlmICghdmlldykKKyAgICAgICAgcmV0dXJuIGNvbnRlbnRCb3VuZHM7Cisg ICAgCisgICAgY29udGVudEJvdW5kcy5zaXplLndpZHRoID0gdmlldy0+Y29udGVudHNXaWR0aCgp OworICAgIGNvbnRlbnRCb3VuZHMuc2l6ZS5oZWlnaHQgPSB2aWV3LT5jb250ZW50c0hlaWdodCgp OworICAgIAorICAgIHJldHVybiBjb250ZW50Qm91bmRzOworfQorCitXS19FWFBPUlQgV0tTaXpl IFdLQnVuZGxlRnJhbWVHZXRTY3JvbGxPZmZzZXQoV0tCdW5kbGVGcmFtZVJlZiBmcmFtZVJlZikK K3sKKyAgICBXS1NpemUgc2Nyb2xsT2Zmc2V0ID0geyAwLCAwIH07CisgICAgCisgICAgRnJhbWUq IGNvcmVGcmFtZSA9IHRvSW1wbChmcmFtZVJlZiktPmNvcmVGcmFtZSgpOworICAgIGlmICghY29y ZUZyYW1lKQorICAgICAgICByZXR1cm4gc2Nyb2xsT2Zmc2V0OworICAgIAorICAgIEZyYW1lVmll dyogdmlldyA9IGNvcmVGcmFtZS0+dmlldygpOworICAgIGlmICghdmlldykKKyAgICAgICAgcmV0 dXJuIHNjcm9sbE9mZnNldDsKKyAgICAKKyAgICByZXR1cm4gdG9BUEkodmlldy0+c2Nyb2xsT2Zm c2V0KCkpOworfQpJbmRleDogV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9j L1dLQnVuZGxlRnJhbWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0 ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVGcmFtZS5oCShyZXZpc2lvbiA3NTA4NSkKKysrIFdlYktp dDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZUZyYW1lLmgJKHdvcmtp bmcgY29weSkKQEAgLTI4LDYgKzI4LDcgQEAKIAogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0ph dmFTY3JpcHQuaD4KICNpbmNsdWRlIDxXZWJLaXQyL1dLQmFzZS5oPgorI2luY2x1ZGUgPFdlYktp dDIvV0tHZW9tZXRyeS5oPgogCiAjaWZkZWYgX19jcGx1c3BsdXMKIGV4dGVybiAiQyIgewpAQCAt NTEsNiArNTIsOSBAQCBXS19FWFBPUlQgV0tCdW5kbGVQYWdlUmVmIFdLQnVuZGxlRnJhbWVHCiAK IFdLX0VYUE9SVCBib29sIFdLQnVuZGxlRnJhbWVBbGxvd3NGb2xsb3dpbmdMaW5rKFdLQnVuZGxl RnJhbWVSZWYgZnJhbWUsIFdLVVJMUmVmIHVybCk7CiAKK1dLX0VYUE9SVCBXS1JlY3QgV0tCdW5k bGVGcmFtZUdldENvbnRlbnRCb3VuZHMoV0tCdW5kbGVGcmFtZVJlZik7CitXS19FWFBPUlQgV0tT aXplIFdLQnVuZGxlRnJhbWVHZXRTY3JvbGxPZmZzZXQoV0tCdW5kbGVGcmFtZVJlZik7CisKICNp ZmRlZiBfX2NwbHVzcGx1cwogfQogI2VuZGlmCg== 78095 2011-01-05 21:31:31 -0800 2011-01-06 11:08:56 -0800 Patch to add APIs to WKBundleFrame to get content bounds and scroll offset 51968_2.patch text/plain 3061 jeffm SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NTEzNSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDEtMDUgIEplZmYgTWlsbGVyICA8amVmZm1AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYktp dDI6IEFkZCBBUElzIHRvIFdLQnVuZGxlRnJhbWUgdG8gZ2V0IGNvbnRlbnQgYm91bmRzIGFuZCBz Y3JvbGwgb2Zmc2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD01MTk2OAorCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9X S0J1bmRsZUZyYW1lLmNwcDoKKyAgICAgICAgKFdLQnVuZGxlRnJhbWVHZXRDb250ZW50Qm91bmRz KToKKyAgICAgICAgKFdLQnVuZGxlRnJhbWVHZXRTY3JvbGxPZmZzZXQpOgorICAgICAgICAqIFdl YlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVGcmFtZS5oOgorICAgICAgICBB ZGQgV0tCdW5kbGVGcmFtZUdldENvbnRlbnRCb3VuZHMoKSBhbmQgV0tCdW5kbGVGcmFtZUdldFNj cm9sbE9mZnNldCgpLgorCiAyMDExLTAxLTA1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZGVycyBDYXJsc3Nvbi4KSW5kZXg6IFdl YktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZUZyYW1lLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUvQVBJL2MvV0tC dW5kbGVGcmFtZS5jcHAJKHJldmlzaW9uIDc1MTM1KQorKysgV2ViS2l0Mi9XZWJQcm9jZXNzL0lu amVjdGVkQnVuZGxlL0FQSS9jL1dLQnVuZGxlRnJhbWUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z MCw2ICszMCw3IEBACiAjaW5jbHVkZSAiV0tCdW5kbGVBUElDYXN0LmgiCiAjaW5jbHVkZSAiV2Vi RnJhbWUuaCIKICNpbmNsdWRlIDxXZWJDb3JlL0ZyYW1lLmg+CisjaW5jbHVkZSA8V2ViQ29yZS9G cmFtZVZpZXcuaD4KIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiB1c2luZyBuYW1lc3BhY2Ug V2ViS2l0OwpAQCAtMTM4LDMgKzEzOSwzNiBAQCBib29sIFdLQnVuZGxlRnJhbWVBbGxvd3NGb2xs b3dpbmdMaW5rKFdLCiB7CiAgICAgcmV0dXJuIHRvSW1wbChmcmFtZVJlZiktPmFsbG93c0ZvbGxv d2luZ0xpbmsoV2ViQ29yZTo6S1VSTChXZWJDb3JlOjpLVVJMKCksIHRvSW1wbCh1cmxSZWYpLT5z dHJpbmcoKSkpOwogfQorCitXS1JlY3QgV0tCdW5kbGVGcmFtZUdldENvbnRlbnRCb3VuZHMoV0tC dW5kbGVGcmFtZVJlZiBmcmFtZVJlZikKK3sKKyAgICBXS1JlY3QgY29udGVudEJvdW5kcyA9IHsg ezAsIDB9LCB7MCwgMH0gfTsKKyAgICAKKyAgICBGcmFtZSogY29yZUZyYW1lID0gdG9JbXBsKGZy YW1lUmVmKS0+Y29yZUZyYW1lKCk7CisgICAgaWYgKCFjb3JlRnJhbWUpCisgICAgICAgIHJldHVy biBjb250ZW50Qm91bmRzOworICAgIAorICAgIEZyYW1lVmlldyogdmlldyA9IGNvcmVGcmFtZS0+ dmlldygpOworICAgIGlmICghdmlldykKKyAgICAgICAgcmV0dXJuIGNvbnRlbnRCb3VuZHM7Cisg ICAgCisgICAgY29udGVudEJvdW5kcy5zaXplLndpZHRoID0gdmlldy0+Y29udGVudHNXaWR0aCgp OworICAgIGNvbnRlbnRCb3VuZHMuc2l6ZS5oZWlnaHQgPSB2aWV3LT5jb250ZW50c0hlaWdodCgp OworICAgIAorICAgIHJldHVybiBjb250ZW50Qm91bmRzOworfQorCitXS19FWFBPUlQgV0tTaXpl IFdLQnVuZGxlRnJhbWVHZXRTY3JvbGxPZmZzZXQoV0tCdW5kbGVGcmFtZVJlZiBmcmFtZVJlZikK K3sKKyAgICBXS1NpemUgc2Nyb2xsT2Zmc2V0ID0geyAwLCAwIH07CisgICAgCisgICAgRnJhbWUq IGNvcmVGcmFtZSA9IHRvSW1wbChmcmFtZVJlZiktPmNvcmVGcmFtZSgpOworICAgIGlmICghY29y ZUZyYW1lKQorICAgICAgICByZXR1cm4gc2Nyb2xsT2Zmc2V0OworICAgIAorICAgIEZyYW1lVmll dyogdmlldyA9IGNvcmVGcmFtZS0+dmlldygpOworICAgIGlmICghdmlldykKKyAgICAgICAgcmV0 dXJuIHNjcm9sbE9mZnNldDsKKyAgICAKKyAgICByZXR1cm4gdG9BUEkodmlldy0+c2Nyb2xsT2Zm c2V0KCkpOworfQpJbmRleDogV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9j L1dLQnVuZGxlRnJhbWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0 ZWRCdW5kbGUvQVBJL2MvV0tCdW5kbGVGcmFtZS5oCShyZXZpc2lvbiA3NTEzNSkKKysrIFdlYktp dDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvYy9XS0J1bmRsZUZyYW1lLmgJKHdvcmtp bmcgY29weSkKQEAgLTI4LDYgKzI4LDcgQEAKIAogI2luY2x1ZGUgPEphdmFTY3JpcHRDb3JlL0ph dmFTY3JpcHQuaD4KICNpbmNsdWRlIDxXZWJLaXQyL1dLQmFzZS5oPgorI2luY2x1ZGUgPFdlYktp dDIvV0tHZW9tZXRyeS5oPgogCiAjaWZkZWYgX19jcGx1c3BsdXMKIGV4dGVybiAiQyIgewpAQCAt NTEsNiArNTIsOSBAQCBXS19FWFBPUlQgV0tCdW5kbGVQYWdlUmVmIFdLQnVuZGxlRnJhbWVHCiAK IFdLX0VYUE9SVCBib29sIFdLQnVuZGxlRnJhbWVBbGxvd3NGb2xsb3dpbmdMaW5rKFdLQnVuZGxl RnJhbWVSZWYgZnJhbWUsIFdLVVJMUmVmIHVybCk7CiAKK1dLX0VYUE9SVCBXS1JlY3QgV0tCdW5k bGVGcmFtZUdldENvbnRlbnRCb3VuZHMoV0tCdW5kbGVGcmFtZVJlZiBmcmFtZSk7CitXS19FWFBP UlQgV0tTaXplIFdLQnVuZGxlRnJhbWVHZXRTY3JvbGxPZmZzZXQoV0tCdW5kbGVGcmFtZVJlZiBm cmFtZSk7CisKICNpZmRlZiBfX2NwbHVzcGx1cwogfQogI2VuZGlmCg==