51962 2011-01-05 15:19:07 -0800 minor code cleanup for code review tool 2011-01-05 19:20:10 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth commit-queue eric oldest_to_newest 329824 0 ojan 2011-01-05 15:19:07 -0800 minor code cleanup for code review tool 329825 1 78054 ojan 2011-01-05 15:21:18 -0800 Created attachment 78054 Patch 329977 2 78054 commit-queue 2011-01-05 19:20:05 -0800 Comment on attachment 78054 Patch Clearing flags on attachment: 78054 Committed r75131: <http://trac.webkit.org/changeset/75131> 329978 3 commit-queue 2011-01-05 19:20:10 -0800 All reviewed patches have been landed. Closing bug. 78054 2011-01-05 15:21:18 -0800 2011-01-05 19:20:05 -0800 Patch bug-51962-20110105152117.patch text/plain 2489 ojan ZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRl cy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDQ2OTI3YzRmM2NlMGE5Y2E1NDVlNTZk NWVjNzE5ODEzN2NjNWYxM2EuLjBhZDAxNDBjMjYyM2FiNTk2YjRhNDcxNmNjZTU4MmI4NjJkZGU2 NzYgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIv V2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEx LTAxLTA1ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbWlub3IgY29kZSBjbGVhbnVwIGZvciBj b2RlIHJldmlldyB0b29sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD01MTk2MgorCisgICAgICAgIENvbnNvbGlkYXRlcyBzb21lIHF1ZXJpZXMgdG8gdXNp bmcgc2hhcmVkIGZ1bmN0aW9ucy4KKworICAgICAgICAqIGNvZGUtcmV2aWV3LmpzOgorCiAyMDEx LTAxLTA0ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5jcmVt ZW50IHZlcnNpb24gbnVtYmVyIHRvIGF2b2lkIGdldHRpbmcgdGhlIGNhY2hlZCBKUyBmaWxlLgpk aWZmIC0tZ2l0IGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3LmpzIGIvV2Vi c2l0ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3LmpzCmluZGV4IGRhYTk5ZTc4NzEwYjI5 YWE4NTU0NTE3ZjNiNDMzNjE3OTA0NjVkZTYuLjY5OTQxMDllY2RhOGVlNDlmMjZlOWMyNDdjYmRm NmE1MmFkOGQ5NGEgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb2RlLXJl dmlldy5qcworKysgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMKQEAg LTUzMyw2ICs1MzMsMTAgQEAKICAgICByZXR1cm4gTnVtYmVyKGxpbmUucXVlcnlTZWxlY3Rvcign LnRvJykudGV4dENvbnRlbnQpOwogICB9CiAKKyAgZnVuY3Rpb24gdGV4dENvbnRlbnRzRm9yKGxp bmUpIHsKKyAgICByZXR1cm4gJCgnLnRleHQnLCBsaW5lKS50ZXh0KCk7CisgIH0KKwogICBmdW5j dGlvbiBsaW5lTnVtYmVyRm9yRmlyc3ROb25Db250ZXh0TGluZShwYXRjaGVkX2ZpbGUsIGxpbmUs IHByZXZfbGluZSwgY29udGV4dCwgaHVua19udW0pIHsKICAgICBpZiAoY29udGV4dC5sZW5ndGgp IHsKICAgICAgIHZhciBwcmV2X2xpbmVfbnVtID0gZnJvbUxpbmVOdW1iZXIocHJldl9saW5lKSAt IDE7CkBAIC01NjAsNyArNTY0LDcgQEAKIAogICAgICAgZm9yICh2YXIgaiA9IDAsIGxpbmVzX2xl biA9IGxpbmVzLmxlbmd0aDsgaiA8IGxpbmVzX2xlbjsgaisrKSB7CiAgICAgICAgIHZhciBsaW5l ID0gbGluZXNbal07Ci0gICAgICAgIHZhciBsaW5lX2NvbnRlbnRzID0gbGluZS5xdWVyeVNlbGVj dG9yKCcudGV4dCcpLnRleHRDb250ZW50OworICAgICAgICB2YXIgbGluZV9jb250ZW50cyA9IHRl eHRDb250ZW50c0ZvcihsaW5lKTsKICAgICAgICAgaWYgKCQobGluZSkuaGFzQ2xhc3MoJ2FkZCcp KSB7CiAgICAgICAgICAgaWYgKGN1cnJlbnRfbGluZSA9PSAtMSkgewogICAgICAgICAgICAgY3Vy cmVudF9saW5lID0gbGluZU51bWJlckZvckZpcnN0Tm9uQ29udGV4dExpbmUocGF0Y2hlZF9maWxl LCBsaW5lLCBsaW5lc1tqLTFdLCBjb250ZXh0LCBodW5rX251bSk7CkBAIC03ODMsOCArNzg3LDcg QEAKICAgICAgICAgYWN0aW9uID0gJysnOwogICAgICAgZWxzZSBpZiAoJCh0aGlzKS5oYXNDbGFz cygncmVtb3ZlJykpCiAgICAgICAgIGFjdGlvbiA9ICctJzsKLSAgICAgIHZhciB0ZXh0ID0gJCh0 aGlzKS5jaGlsZHJlbignLnRleHQnKS50ZXh0KCk7Ci0gICAgICBzbmlwcGV0cy5wdXNoKGluZGVu dCArIGFjdGlvbiArIHRleHQpOworICAgICAgc25pcHBldHMucHVzaChpbmRlbnQgKyBhY3Rpb24g KyB0ZXh0Q29udGVudHNGb3IodGhpcykpOwogICAgIH0pOwogICAgIHJldHVybiBzbmlwcGV0cy5q b2luKCdcbicpOwogICB9CkBAIC03OTksNyArODAyLDcgQEAKIAogICBmdW5jdGlvbiBzbmlwcGV0 Rm9yKGxpbmUsIGluZGVudCkgewogICAgIHZhciBmaWxlX25hbWUgPSBmaWxlTmFtZUZvcihsaW5l KTsKLSAgICB2YXIgbGluZV9udW1iZXIgPSBsaW5lLmhhc0NsYXNzKCdyZW1vdmUnKSA/ICctJyAr IGxpbmUuY2hpbGRyZW4oJy5mcm9tJykudGV4dCgpIDogbGluZS5jaGlsZHJlbignLnRvJykudGV4 dCgpOworICAgIHZhciBsaW5lX251bWJlciA9IGxpbmUuaGFzQ2xhc3MoJ3JlbW92ZScpID8gJy0n ICsgZnJvbUxpbmVOdW1iZXIobGluZVswXSkgOiB0b0xpbmVOdW1iZXIobGluZVswXSk7CiAgICAg cmV0dXJuIGluZGVudCArIGZpbGVfbmFtZSArICc6JyArIGxpbmVfbnVtYmVyICsgJ1xuJyArIGNv bnRleHRTbmlwcGV0Rm9yKGxpbmUsIGluZGVudCk7CiAgIH0KIAo=