5195 2005-09-30 01:48:28 -0700 drawing with cacheDisplayInRect:toBitmapImageRep: doesn't trigger layout on Leopard 2022-08-09 10:38:18 -0700 1 1 1 Unclassified WebKit DOM 420+ Mac OS X 10.4 RESOLVED CONFIGURATION CHANGED InRadar P2 Normal --- 1 duncan webkit-unassigned ahmad.saleem792 ap bfulgham emacemac7 ian mitz rniwa webkit-bug-importer oldest_to_newest 20969 0 duncan 2005-09-30 01:48:28 -0700 Updates to the DOM are rendered after 250ms: WebCore/khtml/xml/dom_docimpl.cpp:106:const int cLayoutScheduleThreshold = 250; When a WebView is used for the purpose of making screenshots (or perhaps even when less latency is desired), and the caller is manipulating the DOM and it knows that there are no more updates, a way to explicitly force the rendering of such changes would be desirable. The attached patch adds a "forceLayout" method to WebView, that flushes rendering by calling the underlying view's layout method. The attached DumpRenderTree-derived source demonstrates how a bitmap grabbed from a WebView is white without the forced layout, but is correct when the new method is called. 20970 1 4102 duncan 2005-09-30 02:05:13 -0700 Created attachment 4102 patch 20971 2 4103 duncan 2005-09-30 02:07:38 -0700 Created attachment 4103 test case Build with something like: gcc -g -o dump dump.m -F<path to webkit build dir> -framework WebKit -framework WebCore -framework JavaScriptCore -framework Cocoa run with something like: DYLD_FRAMEWORK_PATH=<path to webkit build dir> ./dump 20975 3 4102 darin 2005-09-30 07:42:39 -0700 Comment on attachment 4102 patch I don't think we want this. We do want to perform layout, bypassing the timer, but as a direct response to another method call that requires layout. For example, if there's a call to render the view into a buffer, then that call should force layout. We should only add a call like this to API if there is no way to accomplish this automatically, and I believe there is. 20976 4 darin 2005-09-30 07:44:00 -0700 Now having looked at this test case, I think that we have to figure out how cacheDisplayInRect will force layout; I think there's code that tries to do it and is buggy. 21022 5 4119 duncan 2005-09-30 13:32:02 -0700 Created attachment 4119 patch cacheDisplayInRect:toBitmapImageRep: doesn't trigger any notification, so I override it in WebView and force a layout before calling the super method. 21208 6 4119 darin 2005-10-02 20:32:35 -0700 Comment on attachment 4119 patch I still don't think this is quite right. We should not be overriding this particular method, but rather the code path it follows that requires layout. In particular, we want this to work properly even if you make the call directly on the WebHTMLView. Is there really a need to support repainting without relayout? I don't think there is. Any painting should presumably create layout. The comment on the ChangeLog indicates an idea that somehow we would paint but still wait for a layout scheduling threshold; I think that's wrong. 21361 7 4199 darin 2005-10-04 13:26:31 -0700 Created attachment 4199 patch doing what Duncan and I discussed in email 21398 8 4210 duncan 2005-10-05 03:41:41 -0700 Created attachment 4210 Tweaked test case This slightly tweaked testcase demonstrates that Darin's latest patch fixes the problem. 21422 9 4199 darin 2005-10-05 10:05:27 -0700 Comment on attachment 4199 patch doing what Duncan and I discussed in email Since Duncan confirms this code fixes the problem, lets get it reviewed and checked in. 21637 10 4199 mjs 2005-10-09 16:35:14 -0700 Comment on attachment 4199 patch doing what Duncan and I discussed in email r=me 21638 11 4199 mjs 2005-10-09 17:01:02 -0700 Comment on attachment 4199 patch doing what Duncan and I discussed in email Eric points out that this patch violats the style guidelines - single-line if blocks are put in braces and they should not be. Please fix before landing. 21825 12 adele 2005-10-11 12:08:11 -0700 This fix caused http://bugzilla.opendarwin.org/show_bug.cgi?id=5335 21830 13 mitz 2005-10-11 13:06:07 -0700 More accurately, the WebHTMLView patch attached to this bug resulted in subviews (such as form widgets) not being rendered in the pixel tests. The additional patch that fixed that (which is not in bugzilla) is what caused bug 5335. 21898 14 4199 darin 2005-10-12 07:35:29 -0700 Comment on attachment 4199 patch doing what Duncan and I discussed in email I'll need to come up with a version of this that doesn't break drawing controls in the layout tests or drawing text field insertion points. 57808 15 darin 2007-10-04 19:47:38 -0700 I suspect this is fixed in Leopard. 73755 16 darin 2008-03-14 11:57:26 -0700 For those with access to Radar, <rdar://problem/5668489> is related Radar bug. 85920 17 mitz 2008-07-14 17:18:47 -0700 (In reply to comment #15) > I suspect this is fixed in Leopard. And I think <http://trac.webkit.org/changeset/35176> fixed this for Tiger. 85926 18 duncan 2008-07-14 23:46:44 -0700 I just tried the testcase on TOT on 10.5.4 and it is still not fixed. 87506 19 sullivan 2008-07-31 10:38:12 -0700 This was fixed on Tiger a while back, but still not fixed on Leopard. I have a fix for Leopard. 87510 20 sullivan 2008-07-31 10:50:55 -0700 Committed revision 35488. 88149 21 mitz 2008-08-08 20:41:12 -0700 Unfortunately the Leopard fix had to be rolled out in <http://trac.webkit.org/changeset/35650>. I am re-opening the bug, but I am not sure there is a way to fix it in Leopard. 1889969 22 ahmad.saleem792 2022-08-09 05:49:55 -0700 ap@webkit.org and rniwa@webkit.org - Is this needed any more? I can only found one reference about "cacheDisplayInRect": https://github.com/WebKit/WebKit/blob/a742d4b71e27e2f1e82e90c3b26150aa0366fdcd/Tools/DumpRenderTree/mac/DumpRenderTree.mm#L801 1890018 23 rniwa 2022-08-09 10:37:20 -0700 We've re-rewriten code around this by now. 1890019 24 webkit-bug-importer 2022-08-09 10:38:18 -0700 <rdar://problem/98392152> 4102 2005-09-30 02:05:13 -0700 2005-09-30 13:32:02 -0700 patch forcelayout.patch text/plain 2090 duncan SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dl YktpdC9DaGFuZ2VMb2csdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMzMzNgpkaWZmIC1wIC11IC1y MS4zMzM2IFdlYktpdC9DaGFuZ2VMb2cKLS0tIFdlYktpdC9DaGFuZ2VMb2cJMjggU2VwIDIwMDUg MjE6MDQ6NDcgLTAwMDAJMS4zMzM2CisrKyBXZWJLaXQvQ2hhbmdlTG9nCTMwIFNlcCAyMDA1IDA5 OjA1OjM4IC0wMDAwCkBAIC0xLDMgKzEsMTggQEAKKzIwMDUtMDktMzAgIER1bmNhbiBXaWxjb3gg IDxkdW5jYW5AbWNsaW5rLml0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogV2ViVmlldy5zdWJwcm9qL1dlYlZpZXcubToKKyAgICAgICAgKC1bV2Vi VmlldyBmb3JjZUxheW91dF0pOgorCisgICAgICAgIEFkZCBmb3JjZUxheW91dCBtZXRob2QsIHRo YXQgY2FsbHMgZG93biB0byBLV1FLSFRNTFBhcnQ6OmZvcmNlTGF5b3V0IGFuZAorICAgICAgICB1 bHRpbWF0ZWx5IEtIVE1MVmlldzo6bGF5b3V0LCBzaG9ydGN1dHRpbmcgS0hUTUxWaWV3J3MgaW50 ZXJuYWwgcmVsYXlvdXQKKyAgICAgICAgc2NoZWR1bGluZyB0aHJlc2hvbGQgdGltZXIuCisKKyAg ICAgICAgKiBXZWJWaWV3LnN1YnByb2ovV2ViVmlld1ByaXZhdGUuaDoKKworICAgICAgICBBZGQg Zm9yY2VMYXlvdXQgdG8gV2ViUGVuZGluZ1B1YmxpYyBjYXRlZ29yeS4KKwogMjAwNS0wOS0yOCAg SnVzdGluIEdhcmNpYSAgPGp1c3Rpbi5nYXJjaWFAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IGdlb2ZmCkluZGV4OiBXZWJLaXQvV2ViVmlldy5zdWJwcm9qL1dlYlZpZXcubQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0L1dlYlZpZXcuc3VicHJvai9XZWJWaWV3 Lm0sdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMzA5CmRpZmYgLXAgLXUgLXIxLjMwOSBXZWJLaXQv V2ViVmlldy5zdWJwcm9qL1dlYlZpZXcubQotLS0gV2ViS2l0L1dlYlZpZXcuc3VicHJvai9XZWJW aWV3Lm0JMjggU2VwIDIwMDUgMTg6NDM6MTQgLTAwMDAJMS4zMDkKKysrIFdlYktpdC9XZWJWaWV3 LnN1YnByb2ovV2ViVmlldy5tCTMwIFNlcCAyMDA1IDA5OjA1OjQwIC0wMDAwCkBAIC0yNTY1LDYg KzI1NjUsMTIgQEAgc3RhdGljIFdlYkZyYW1lICppbmNyZW1lbnRGcmFtZShXZWJGcmFtZQogICAg IHJldHVybiBfcHJpdmF0ZS0+c2NyaXB0RGVidWdEZWxlZ2F0ZTsKIH0KIAorLSAodm9pZClmb3Jj ZUxheW91dAoreworICAgIFdlYkJyaWRnZSAqYnJpZGdlID0gW1tzZWxmIG1haW5GcmFtZV0gX2Jy aWRnZV07CisgICAgW2JyaWRnZSBmb3JjZUxheW91dEFkanVzdGluZ1ZpZXdTaXplOk5PXTsKK30K KwogQGVuZAogCiBAaW1wbGVtZW50YXRpb24gV2ViVmlldyAoV2ViVmlld1ByaW50aW5nUHJpdmF0 ZSkKSW5kZXg6IFdlYktpdC9XZWJWaWV3LnN1YnByb2ovV2ViVmlld1ByaXZhdGUuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0L1dlYlZpZXcuc3VicHJvai9XZWJWaWV3UHJp dmF0ZS5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE0OApkaWZmIC1wIC11IC1yMS4xNDggV2Vi S2l0L1dlYlZpZXcuc3VicHJvai9XZWJWaWV3UHJpdmF0ZS5oCi0tLSBXZWJLaXQvV2ViVmlldy5z dWJwcm9qL1dlYlZpZXdQcml2YXRlLmgJMjMgQXVnIDIwMDUgMDE6MjI6MTYgLTAwMDAJMS4xNDgK KysrIFdlYktpdC9XZWJWaWV3LnN1YnByb2ovV2ViVmlld1ByaXZhdGUuaAkzMCBTZXAgMjAwNSAw OTowNTo0MSAtMDAwMApAQCAtMTA0LDYgKzEwNCw4IEBAIHR5cGVkZWYgZW51bSB7CiAqLyAgICAK IC0gKGlkKXNjcmlwdERlYnVnRGVsZWdhdGU7CiAKKy0gKHZvaWQpZm9yY2VMYXlvdXQ7CisKIEBl bmQKIAogQGludGVyZmFjZSBXZWJWaWV3IChXZWJQcml2YXRlKQo= 4103 2005-09-30 02:07:38 -0700 2005-10-05 03:41:41 -0700 test case dump.m text/plain 2863 duncan I2ltcG9ydCA8Rm91bmRhdGlvbi9OU1VSTFJlcXVlc3QuaD4KI2ltcG9ydCA8Rm91bmRhdGlvbi9O U0Vycm9yLmg+CgojaW1wb3J0IDxXZWJLaXQvRE9NRXh0ZW5zaW9ucy5oPgojaW1wb3J0IDxXZWJL aXQvRE9NUmFuZ2UuaD4KI2ltcG9ydCA8V2ViS2l0L1dlYkRhdGFTb3VyY2UuaD4KI2ltcG9ydCA8 V2ViS2l0L1dlYkZyYW1lLmg+CiNpbXBvcnQgPFdlYktpdC9XZWJGcmFtZUxvYWREZWxlZ2F0ZS5o PgojaW1wb3J0IDxXZWJLaXQvV2ViRnJhbWVWaWV3Lmg+CiNpbXBvcnQgPFdlYktpdC9XZWJQcmVm ZXJlbmNlcy5oPgojaW1wb3J0IDxXZWJLaXQvV2ViVmlldy5oPgoKQGludGVyZmFjZSBXZWJWaWV3 IChXZWJWaWV3UGVuZGluZ1B1YmxpYykKLSAodm9pZClmb3JjZUxheW91dDsKQGVuZAoKCkBpbnRl cmZhY2UgV2FpdFVudGlsRG9uZURlbGVnYXRlIDogTlNPYmplY3QKQGVuZAoKc3RhdGljIHZvbGF0 aWxlIEJPT0wgZG9uZTsKCmludCBtYWluKGludCBhcmdjLCBjb25zdCBjaGFyICphcmd2W10pCnsK ICAgIE5TQXV0b3JlbGVhc2VQb29sICpwb29sID0gW1tOU0F1dG9yZWxlYXNlUG9vbCBhbGxvY10g aW5pdF07CgogICAgaW50IHdpZHRoID0gODAwOwogICAgaW50IGhlaWdodCA9IDYwMDsKCiAgICBX ZWJWaWV3ICp2aWV3ID0gW1tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3Qo MCwgMCwgd2lkdGgsIGhlaWdodCldOwogICAgCiAgICAvLyBGb3IgcmVhc29ucyB0aGF0IGFyZSBu b3QgZW50aXJlbHkgY2xlYXIsIHRoZSBmb2xsb3dpbmcgcGFpciBvZiBjYWxscyBtYWtlcyBXZWJW aWV3IGhhbmRsZSBpdHMKICAgIC8vIGR5bmFtaWMgc2Nyb2xsYmFycyBwcm9wZXJseS4gV2l0aG91 dCBpdCwgZXZlcnkgZnJhbWUgd2lsbCBhbHdheXMgaGF2ZSBzY3JvbGxiYXJzLgogICAgTlNCaXRt YXBJbWFnZVJlcCAqaW1hZ2VSZXAgPSBbdmlldyBiaXRtYXBJbWFnZVJlcEZvckNhY2hpbmdEaXNw bGF5SW5SZWN0Olt2aWV3IGJvdW5kc11dOwogICAgW3ZpZXcgY2FjaGVEaXNwbGF5SW5SZWN0Olt2 aWV3IGJvdW5kc10gdG9CaXRtYXBJbWFnZVJlcDppbWFnZVJlcF07CgogICAgV2FpdFVudGlsRG9u ZURlbGVnYXRlICpkZWxlZ2F0ZSA9IFtbV2FpdFVudGlsRG9uZURlbGVnYXRlIGFsbG9jXSBpbml0 XTsKICAgIFt2aWV3IHNldEZyYW1lTG9hZERlbGVnYXRlOmRlbGVnYXRlXTsKCiAgICB7CiAgICAg ICAgZG9uZSA9IE5POwoKICAgICAgICBOU0F1dG9yZWxlYXNlUG9vbCAqcG9vbCA9IFtbTlNBdXRv cmVsZWFzZVBvb2wgYWxsb2NdIGluaXRdOwogICAgICAgIFtbdmlldyBtYWluRnJhbWVdIGxvYWRI VE1MU3RyaW5nOkAiPGh0bWw+PGJvZHk+PC9ib2R5PjwvaHRtbD4iIGJhc2VVUkw6bmlsXTsKCiAg ICAgICAgW3Bvb2wgcmVsZWFzZV07CiAgICAgICAgd2hpbGUgKCFkb25lKSB7CiAgICAgICAgICAg IHBvb2wgPSBbW05TQXV0b3JlbGVhc2VQb29sIGFsbG9jXSBpbml0XTsKICAgICAgICAgICAgW1tO U1J1bkxvb3AgY3VycmVudFJ1bkxvb3BdIHJ1bk1vZGU6TlNEZWZhdWx0UnVuTG9vcE1vZGUgYmVm b3JlRGF0ZTpbTlNEYXRlIGRpc3RhbnRQYXN0XV07CiAgICAgICAgICAgIFtwb29sIHJlbGVhc2Vd OwogICAgICAgIH0KICAgIH0KICAgIAogICAgW3ZpZXcgc2V0RnJhbWVMb2FkRGVsZWdhdGU6bmls XTsKCiAgICBbdmlldyByZWxlYXNlXTsKICAgIFtkZWxlZ2F0ZSByZWxlYXNlXTsKICAgIFtwb29s IHJlbGVhc2VdOwogICAgcmV0dXJuIDA7Cn0KCkBpbXBsZW1lbnRhdGlvbiBXYWl0VW50aWxEb25l RGVsZWdhdGUKCi0gKHZvaWQpd2ViVmlldzooV2ViVmlldyAqKXZpZXcgZGlkRmluaXNoTG9hZEZv ckZyYW1lOihXZWJGcmFtZSAqKWZyYW1lCnsKICAgIERPTURvY3VtZW50ICpkb2MgPSBbW3ZpZXcg bWFpbkZyYW1lXSBET01Eb2N1bWVudF07CiAgICBET01Ob2RlTGlzdCAqbGlzdCA9IFtkb2MgZ2V0 RWxlbWVudHNCeVRhZ05hbWU6QCJCT0RZIl07CiAgICBET01Ob2RlICpib2R5ID0gW2xpc3QgaXRl bTowXTsKICAgIERPTUVsZW1lbnQgKmVsID0gW2RvYyBjcmVhdGVFbGVtZW50OkAiUCJdOwogICAg W2JvZHkgYXBwZW5kQ2hpbGQ6ZWxdOwogICAgW2VsIGFwcGVuZENoaWxkOltkb2MgY3JlYXRlVGV4 dE5vZGU6QCJ0aGlzIHRleHQgaGFzIGJlZW4gYWRkZWQgdmlhIERPTSBtYW5pcHVsYXRpb24iXV07 CgogICAgTlNCaXRtYXBJbWFnZVJlcCAqaW1hZ2VSZXAgPSBbdmlldyBiaXRtYXBJbWFnZVJlcEZv ckNhY2hpbmdEaXNwbGF5SW5SZWN0Olt2aWV3IGZyYW1lXV07CiAgICBbdmlldyBjYWNoZURpc3Bs YXlJblJlY3Q6W3ZpZXcgZnJhbWVdIHRvQml0bWFwSW1hZ2VSZXA6aW1hZ2VSZXBdOwogCiAgICBO U0RhdGEgKmltYWdlRGF0YSA9IFtpbWFnZVJlcCByZXByZXNlbnRhdGlvblVzaW5nVHlwZTpOU1BO R0ZpbGVUeXBlIHByb3BlcnRpZXM6bmlsXTsKICAgIEZJTEUgKmYgPSBmb3BlbigiYmFkLnBuZyIs ICJ3Iik7CiAgICBmd3JpdGUoW2ltYWdlRGF0YSBieXRlc10sIDEsIFtpbWFnZURhdGEgbGVuZ3Ro XSwgZik7CiAgICBmY2xvc2UoZik7CgogICAgW3ZpZXcgZm9yY2VMYXlvdXRdOyAvLyBmbHVzaCBy ZW5kZXJpbmcgaGVyZQoKICAgIFt2aWV3IGNhY2hlRGlzcGxheUluUmVjdDpbdmlldyBmcmFtZV0g dG9CaXRtYXBJbWFnZVJlcDppbWFnZVJlcF07CiAKICAgIGltYWdlRGF0YSA9IFtpbWFnZVJlcCBy ZXByZXNlbnRhdGlvblVzaW5nVHlwZTpOU1BOR0ZpbGVUeXBlIHByb3BlcnRpZXM6bmlsXTsKICAg IGYgPSBmb3BlbigiZ29vZC5wbmciLCAidyIpOwogICAgZndyaXRlKFtpbWFnZURhdGEgYnl0ZXNd LCAxLCBbaW1hZ2VEYXRhIGxlbmd0aF0sIGYpOwogICAgZmNsb3NlKGYpOwoKICAgIGRvbmUgPSBZ RVM7Cn0KCkBlbmQKCg== 4119 2005-09-30 13:32:02 -0700 2005-10-04 13:26:31 -0700 patch forcelayout.patch text/plain 1793 duncan SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dl YktpdC9DaGFuZ2VMb2csdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMzMzNgpkaWZmIC1wIC11IC1y MS4zMzM2IFdlYktpdC9DaGFuZ2VMb2cKLS0tIFdlYktpdC9DaGFuZ2VMb2cJMjggU2VwIDIwMDUg MjE6MDQ6NDcgLTAwMDAJMS4zMzM2CisrKyBXZWJLaXQvQ2hhbmdlTG9nCTMwIFNlcCAyMDA1IDIw OjMzOjQ0IC0wMDAwCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDUtMDktMzAgIER1bmNhbiBXaWxjb3gg IDxkdW5jYW5AbWNsaW5rLml0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGZpeCBmb3IgaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3df YnVnLmNnaT9pZD01MTk1CisgICAgICAgICJXb3VsZCBsaWtlIEFQSSB0byBmbHVzaCByZW5kZXJp bmcgb2YgcGVuZGluZyBET00gY2hhbmdlcyIKKworICAgICAgICAqIFdlYlZpZXcuc3VicHJvai9X ZWJWaWV3Lm06CisgICAgICAgICgtW1dlYlZpZXcgY2FjaGVEaXNwbGF5SW5SZWN0OnRvQml0bWFw SW1hZ2VSZXA6XSk6CisKKyAgICAgICAgRm9yY2UgYSBsYXlvdXQgaWYgdGhlIGNhbGxlciBpcyB0 cnlpbmcgdG8gZ2V0IHRoZSBiaXRtYXAsIGJ5IGNhbGxpbmcKKyAgICAgICAgZG93biB0byBLV1FL SFRNTFBhcnQ6OmZvcmNlTGF5b3V0IGFuZCB1bHRpbWF0ZWx5IEtIVE1MVmlldzo6bGF5b3V0LAor ICAgICAgICBvdmVycmlkaW5nIEtIVE1MVmlldydzIGludGVybmFsIHJlbGF5b3V0IHNjaGVkdWxp bmcgdGhyZXNob2xkIHRpbWVyLgorCiAyMDA1LTA5LTI4ICBKdXN0aW4gR2FyY2lhICA8anVzdGlu LmdhcmNpYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgZ2VvZmYKSW5kZXg6IFdl YktpdC9XZWJWaWV3LnN1YnByb2ovV2ViVmlldy5tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMv cm9vdC9XZWJLaXQvV2ViVmlldy5zdWJwcm9qL1dlYlZpZXcubSx2CnJldHJpZXZpbmcgcmV2aXNp b24gMS4zMDkKZGlmZiAtcCAtdSAtcjEuMzA5IFdlYktpdC9XZWJWaWV3LnN1YnByb2ovV2ViVmll dy5tCi0tLSBXZWJLaXQvV2ViVmlldy5zdWJwcm9qL1dlYlZpZXcubQkyOCBTZXAgMjAwNSAxODo0 MzoxNCAtMDAwMAkxLjMwOQorKysgV2ViS2l0L1dlYlZpZXcuc3VicHJvai9XZWJWaWV3Lm0JMzAg U2VwIDIwMDUgMjA6MzM6NDkgLTAwMDAKQEAgLTIzMjQsNiArMjMyNCwxMyBAQCBzdGF0aWMgV2Vi RnJhbWUgKmluY3JlbWVudEZyYW1lKFdlYkZyYW1lCiAgICAgX3ByaXZhdGUtPmRyYWdDYXJldEJy aWRnZSA9IG5pbDsKIH0KIAorLSAodm9pZCljYWNoZURpc3BsYXlJblJlY3Q6KE5TUmVjdClyZWN0 IHRvQml0bWFwSW1hZ2VSZXA6KE5TQml0bWFwSW1hZ2VSZXAgKiliaXRtYXBJbWFnZVJlcAorewor ICAgIC8vIGZvcmNlIGEgbGF5b3V0IGlmIHRoZSBjYWxsZXIgaXMgdHJ5aW5nIHRvIGdldCB0aGUg Yml0bWFwCisgICAgW1tbc2VsZiBtYWluRnJhbWVdIF9icmlkZ2VdIGZvcmNlTGF5b3V0QWRqdXN0 aW5nVmlld1NpemU6Tk9dOworICAgIFtzdXBlciBjYWNoZURpc3BsYXlJblJlY3Q6cmVjdCB0b0Jp dG1hcEltYWdlUmVwOmJpdG1hcEltYWdlUmVwXTsKK30KKwogQGVuZAogCiBAaW1wbGVtZW50YXRp b24gV2ViVmlldyAoV2ViSUJBY3Rpb25zKQo= 4199 2005-10-04 13:26:31 -0700 2010-06-10 16:48:34 -0700 patch doing what Duncan and I discussed in email RecursiveDisplayPatch.txt text/plain 2228 darin SW5kZXg6IFdlYlZpZXcuc3VicHJvai9XZWJIVE1MVmlldy5tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6 IC9jdnMvcm9vdC9XZWJLaXQvV2ViVmlldy5zdWJwcm9qL1dlYkhUTUxWaWV3Lm0sdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuNDcxCmRpZmYgLXAgLXUgLXIxLjQ3MSBXZWJWaWV3LnN1YnByb2ovV2Vi SFRNTFZpZXcubQotLS0gV2ViVmlldy5zdWJwcm9qL1dlYkhUTUxWaWV3Lm0JMjQgU2VwIDIwMDUg MTA6NTg6MTkgLTAwMDAJMS40NzEKKysrIFdlYlZpZXcuc3VicHJvai9XZWJIVE1MVmlldy5tCTQg T2N0IDIwMDUgMjA6Mjg6NDAgLTAwMDAKQEAgLTkyLDYgKzkyLDcgQEAgdm9pZCBfTlNSZXNldEtp bGxSaW5nT3BlcmF0aW9uRmxhZyh2b2lkKQogQGludGVyZmFjZSBOU1ZpZXcgKEFwcEtpdFNlY3Jl dHNJS25vd0Fib3V0KQogLSAodm9pZClfcmVjdXJzaXZlRGlzcGxheVJlY3RJZk5lZWRlZElnbm9y aW5nT3BhY2l0eTooTlNSZWN0KXJlY3QgaXNWaXNpYmxlUmVjdDooQk9PTClpc1Zpc2libGVSZWN0 IHJlY3RJc1Zpc2libGVSZWN0Rm9yVmlldzooTlNWaWV3ICopdmlzaWJsZVZpZXcgdG9wVmlldzoo Qk9PTCl0b3BWaWV3OwogLSAodm9pZClfcmVjdXJzaXZlRGlzcGxheUFsbERpcnR5V2l0aExvY2tG b2N1czooQk9PTCluZWVkc0xvY2tGb2N1cyB2aXNSZWN0OihOU1JlY3QpdmlzUmVjdDsKKy0gKHZv aWQpX3JlY3Vyc2l2ZURpc3BsYXlSZWN0SWdub3JpbmdPcGFjaXR5OihOU1JlY3QpcmVjdCBpbkNv bnRleHQ6KE5TR3JhcGhpY3NDb250ZXh0ICopY29udGV4dCB0b3BWaWV3OihCT09MKXRvcFZpZXc7 CiAtIChOU1JlY3QpX2RpcnR5UmVjdDsKIC0gKHZvaWQpX3NldERyYXdzT3duRGVzY2VuZGFudHM6 KEJPT0wpZHJhd3NPd25EZXNjZW5kYW50czsKIC0gKHZvaWQpX3Byb3BhZ2F0ZURpcnR5UmVjdHNU b09wYXF1ZUFuY2VzdG9yczsKQEAgLTgwOSw2ICs4MTAsMzYgQEAgdm9pZCAqX05TU29mdExpbmtp bmdHZXRGcmFtZXdvcmtGdW5jUHRyKAogICAgIH0KIH0KIAorLy8gRG9uJ3QgbGV0IEFwcEtpdCBl dmVuIGRyYXcgc3Vidmlld3MuIFdlIHRha2UgY2FyZSBvZiB0aGF0LgorLSAodm9pZClfcmVjdXJz aXZlRGlzcGxheVJlY3RJZ25vcmluZ09wYWNpdHk6KE5TUmVjdClyZWN0IGluQ29udGV4dDooTlNH cmFwaGljc0NvbnRleHQgKiljb250ZXh0IHRvcFZpZXc6KEJPT0wpdG9wVmlldworeworICAgIC8v IFRoaXMgaGVscHMgd2hlbiB3ZSBwcmludCBhcyBwYXJ0IG9mIGEgbGFyZ2VyIHByaW50IHByb2Nl c3MuCisgICAgLy8gSWYgdGhlIFdlYkhUTUxWaWV3IGl0c2VsZiBpcyB3aGF0IHdlJ3JlIHByaW50 aW5nLCB0aGVuIHdlIHdpbGwgbmV2ZXIgaGF2ZSB0byBkbyB0aGlzLgorICAgIEJPT0wgd2FzSW5Q cmludGluZ01vZGUgPSBfcHJpdmF0ZS0+cHJpbnRpbmc7CisgICAgQk9PTCBpc1ByaW50aW5nID0g IVtjb250ZXh0IGlzRHJhd2luZ1RvU2NyZWVuXTsKKyAgICBpZiAod2FzSW5QcmludGluZ01vZGUg IT0gaXNQcmludGluZykgeworICAgICAgICBpZiAoaXNQcmludGluZykgeworICAgICAgICAgICAg W3NlbGYgX3dlYl9zZXRQcmludGluZ01vZGVSZWN1cnNpdmVdOworICAgICAgICB9IGVsc2Ugewor ICAgICAgICAgICAgW3NlbGYgX3dlYl9jbGVhclByaW50aW5nTW9kZVJlY3Vyc2l2ZV07CisgICAg ICAgIH0KKyAgICB9CisKKyAgICBbc2VsZiBfd2ViX2xheW91dElmTmVlZGVkUmVjdXJzaXZlOnJl Y3QgdGVzdERpcnR5UmVjdDpOT107CisKKyAgICBbc2VsZiBfc2V0QXNpZGVTdWJ2aWV3c107Cisg ICAgW3N1cGVyIF9yZWN1cnNpdmVEaXNwbGF5UmVjdElnbm9yaW5nT3BhY2l0eTpyZWN0IGluQ29u dGV4dDpjb250ZXh0IHRvcFZpZXc6dG9wVmlld107CisgICAgW3NlbGYgX3Jlc3RvcmVTdWJ2aWV3 c107CisKKyAgICBpZiAod2FzSW5QcmludGluZ01vZGUgIT0gaXNQcmludGluZykgeworICAgICAg ICBpZiAod2FzSW5QcmludGluZ01vZGUpIHsKKyAgICAgICAgICAgIFtzZWxmIF93ZWJfc2V0UHJp bnRpbmdNb2RlUmVjdXJzaXZlXTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIFtzZWxm IF93ZWJfY2xlYXJQcmludGluZ01vZGVSZWN1cnNpdmVdOworICAgICAgICB9CisgICAgfQorfQor CiAtIChCT09MKV9pbnNpZGVBbm90aGVySFRNTFZpZXcKIHsKICAgICBOU1ZpZXcgKnZpZXcgPSBz ZWxmOwo= 4210 2005-10-05 03:41:41 -0700 2005-10-05 03:41:41 -0700 Tweaked test case dump.m text/plain 2557 duncan I2ltcG9ydCA8Rm91bmRhdGlvbi9OU1VSTFJlcXVlc3QuaD4KI2ltcG9ydCA8Rm91bmRhdGlvbi9O U0Vycm9yLmg+CgojaW1wb3J0IDxXZWJLaXQvRE9NRXh0ZW5zaW9ucy5oPgojaW1wb3J0IDxXZWJL aXQvRE9NUmFuZ2UuaD4KI2ltcG9ydCA8V2ViS2l0L1dlYkRhdGFTb3VyY2UuaD4KI2ltcG9ydCA8 V2ViS2l0L1dlYkZyYW1lLmg+CiNpbXBvcnQgPFdlYktpdC9XZWJGcmFtZUxvYWREZWxlZ2F0ZS5o PgojaW1wb3J0IDxXZWJLaXQvV2ViRnJhbWVWaWV3Lmg+CiNpbXBvcnQgPFdlYktpdC9XZWJQcmVm ZXJlbmNlcy5oPgojaW1wb3J0IDxXZWJLaXQvV2ViVmlldy5oPgoKQGludGVyZmFjZSBXZWJWaWV3 IChXZWJWaWV3UGVuZGluZ1B1YmxpYykKLSAodm9pZClmb3JjZUxheW91dDsKQGVuZAoKCkBpbnRl cmZhY2UgV2FpdFVudGlsRG9uZURlbGVnYXRlIDogTlNPYmplY3QKQGVuZAoKc3RhdGljIHZvbGF0 aWxlIEJPT0wgZG9uZTsKCmludCBtYWluKGludCBhcmdjLCBjb25zdCBjaGFyICphcmd2W10pCnsK ICAgIE5TQXV0b3JlbGVhc2VQb29sICpwb29sID0gW1tOU0F1dG9yZWxlYXNlUG9vbCBhbGxvY10g aW5pdF07CgogICAgaW50IHdpZHRoID0gODAwOwogICAgaW50IGhlaWdodCA9IDYwMDsKCiAgICBX ZWJWaWV3ICp2aWV3ID0gW1tXZWJWaWV3IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3Qo MCwgMCwgd2lkdGgsIGhlaWdodCldOwogICAgCiAgICAvLyBGb3IgcmVhc29ucyB0aGF0IGFyZSBu b3QgZW50aXJlbHkgY2xlYXIsIHRoZSBmb2xsb3dpbmcgcGFpciBvZiBjYWxscyBtYWtlcyBXZWJW aWV3IGhhbmRsZSBpdHMKICAgIC8vIGR5bmFtaWMgc2Nyb2xsYmFycyBwcm9wZXJseS4gV2l0aG91 dCBpdCwgZXZlcnkgZnJhbWUgd2lsbCBhbHdheXMgaGF2ZSBzY3JvbGxiYXJzLgogICAgTlNCaXRt YXBJbWFnZVJlcCAqaW1hZ2VSZXAgPSBbdmlldyBiaXRtYXBJbWFnZVJlcEZvckNhY2hpbmdEaXNw bGF5SW5SZWN0Olt2aWV3IGJvdW5kc11dOwogICAgW3ZpZXcgY2FjaGVEaXNwbGF5SW5SZWN0Olt2 aWV3IGJvdW5kc10gdG9CaXRtYXBJbWFnZVJlcDppbWFnZVJlcF07CgogICAgV2FpdFVudGlsRG9u ZURlbGVnYXRlICpkZWxlZ2F0ZSA9IFtbV2FpdFVudGlsRG9uZURlbGVnYXRlIGFsbG9jXSBpbml0 XTsKICAgIFt2aWV3IHNldEZyYW1lTG9hZERlbGVnYXRlOmRlbGVnYXRlXTsKCiAgICB7CiAgICAg ICAgZG9uZSA9IE5POwoKICAgICAgICBOU0F1dG9yZWxlYXNlUG9vbCAqcG9vbCA9IFtbTlNBdXRv cmVsZWFzZVBvb2wgYWxsb2NdIGluaXRdOwogICAgICAgIFtbdmlldyBtYWluRnJhbWVdIGxvYWRI VE1MU3RyaW5nOkAiPGh0bWw+PGJvZHk+PC9ib2R5PjwvaHRtbD4iIGJhc2VVUkw6bmlsXTsKCiAg ICAgICAgW3Bvb2wgcmVsZWFzZV07CiAgICAgICAgd2hpbGUgKCFkb25lKSB7CiAgICAgICAgICAg IHBvb2wgPSBbW05TQXV0b3JlbGVhc2VQb29sIGFsbG9jXSBpbml0XTsKICAgICAgICAgICAgW1tO U1J1bkxvb3AgY3VycmVudFJ1bkxvb3BdIHJ1bk1vZGU6TlNEZWZhdWx0UnVuTG9vcE1vZGUgYmVm b3JlRGF0ZTpbTlNEYXRlIGRpc3RhbnRQYXN0XV07CiAgICAgICAgICAgIFtwb29sIHJlbGVhc2Vd OwogICAgICAgIH0KICAgIH0KICAgIAogICAgW3ZpZXcgc2V0RnJhbWVMb2FkRGVsZWdhdGU6bmls XTsKCiAgICBbdmlldyByZWxlYXNlXTsKICAgIFtkZWxlZ2F0ZSByZWxlYXNlXTsKICAgIFtwb29s IHJlbGVhc2VdOwogICAgcmV0dXJuIDA7Cn0KCkBpbXBsZW1lbnRhdGlvbiBXYWl0VW50aWxEb25l RGVsZWdhdGUKCi0gKHZvaWQpd2ViVmlldzooV2ViVmlldyAqKXZpZXcgZGlkRmluaXNoTG9hZEZv ckZyYW1lOihXZWJGcmFtZSAqKWZyYW1lCnsKICAgIERPTURvY3VtZW50ICpkb2MgPSBbW3ZpZXcg bWFpbkZyYW1lXSBET01Eb2N1bWVudF07CiAgICBET01Ob2RlTGlzdCAqbGlzdCA9IFtkb2MgZ2V0 RWxlbWVudHNCeVRhZ05hbWU6QCJCT0RZIl07CiAgICBET01Ob2RlICpib2R5ID0gW2xpc3QgaXRl bTowXTsKICAgIERPTUVsZW1lbnQgKmVsID0gW2RvYyBjcmVhdGVFbGVtZW50OkAiUCJdOwogICAg W2JvZHkgYXBwZW5kQ2hpbGQ6ZWxdOwogICAgW2VsIGFwcGVuZENoaWxkOltkb2MgY3JlYXRlVGV4 dE5vZGU6QCJ0aGlzIHRleHQgaGFzIGJlZW4gYWRkZWQgdmlhIERPTSBtYW5pcHVsYXRpb24iXV07 CgogICAgTlNCaXRtYXBJbWFnZVJlcCAqaW1hZ2VSZXAgPSBbdmlldyBiaXRtYXBJbWFnZVJlcEZv ckNhY2hpbmdEaXNwbGF5SW5SZWN0Olt2aWV3IGZyYW1lXV07CiAgICBbdmlldyBjYWNoZURpc3Bs YXlJblJlY3Q6W3ZpZXcgZnJhbWVdIHRvQml0bWFwSW1hZ2VSZXA6aW1hZ2VSZXBdOwogCiAgICBO U0RhdGEgKmltYWdlRGF0YSA9IFtpbWFnZVJlcCByZXByZXNlbnRhdGlvblVzaW5nVHlwZTpOU1BO R0ZpbGVUeXBlIHByb3BlcnRpZXM6bmlsXTsKICAgIEZJTEUgKmYgPSBmb3BlbigiZHVtcC5wbmci LCAidyIpOwogICAgZndyaXRlKFtpbWFnZURhdGEgYnl0ZXNdLCAxLCBbaW1hZ2VEYXRhIGxlbmd0 aF0sIGYpOwogICAgZmNsb3NlKGYpOwoKICAgIGRvbmUgPSBZRVM7Cn0KCkBlbmQKCg==