51938 2011-01-05 11:19:13 -0800 check-webkit-style should not suggest removing argument names in WebKit2 API files 2011-01-05 18:22:39 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED DUPLICATE 51970 P2 Normal --- 1 ap levin andersca levin sam oldest_to_newest 329680 0 ap 2011-01-05 11:19:13 -0800 E.g. https://bugs.webkit.org/show_bug.cgi?id=51935#c2 These are C headers, so argument names are not optional. 329693 1 ap 2011-01-05 11:44:27 -0800 I was wrong - argument names are not necessary in function declarations even in plain C. So, it's a style choice for WebKit2 API headers - perhaps check-webkit-style should warn if arguments are missing. Sam, Anders, can you confirm? 329702 2 78024 levin 2011-01-05 12:02:25 -0800 Created attachment 78024 Patch 329705 3 levin 2011-01-05 12:04:38 -0800 (In reply to comment #1) > perhaps check-webkit-style should warn if arguments are missing. Feel free to file a bug if you think this is a common issue that is worth adding a check for. Since I'm messing around in this area right now, I will probably tackle it soon-ish. (If this issue is pretty rare, feel free to not add a bug so I don't spend time on it :).) 329959 4 levin 2011-01-05 18:22:39 -0800 Resolved as dup since the other bug with the fix has an r+ now :). *** This bug has been marked as a duplicate of bug 51970 *** 78024 2011-01-05 12:02:25 -0800 2011-01-05 18:21:18 -0800 Patch bug-51938-20110105120224.patch text/plain 1586 levin ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA0Zjk4 YTEwNWNlNGEwYjhhOGM1OWQ0YTVjYzdiNTE2YmM1MzU3YzgyLi5jYWY2ZmZmNGY4YmJlMTgwOTJh Zjk2NTQ4Zjg0NjAxZGQxNDY0MjRiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDEtMDUgIERhdmlkIExldmlu ICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBzaG91bGQgbm90IHN1Z2dlc3QgcmVt b3ZpbmcgYXJndW1lbnQgbmFtZXMgaW4gV2ViS2l0MiBBUEkgZmlsZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxOTM4CisKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHk6IEFkZCBwYXJhbWV0ZXIgbmFtZSBleGNlcHRp b24gZm9yIFdlYktpdDIgQyBhcGkuCisKIDIwMTEtMDEtMDMgIEFkYW0gQmFydGggIDxhYmFydGhA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXIucHkKaW5kZXggMjA3NThiYTRhYmYwNzg5OGFiMmJi MGU5YzRlZDM2ZWRmMTRiYzllZC4uMjA4Zjc5ZGNlZWNmMTFiOTVhZTZlMzE0YjQ3OTk4ZTQ2Yjcx NDMzOSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5 CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQpAQCAtMTY4LDEy ICsxNjgsMTMgQEAgX1BBVEhfUlVMRVNfU1BFQ0lGSUVSID0gWwogICAgICAgIldlYktpdDIvV2Vi UHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlIl0sCiAgICAgIFsiLWJ1aWxkL2luY2x1ZGVfb3JkZXIi LAogICAgICAgIi1yZWFkYWJpbGl0eS9uYW1pbmciXSksCi0gICAgKFsjIFRoZSBXZWJLaXQyIEMg QVBJIGhhcyBuYW1lcyB3aXRoIHVuZGVyc2NvcmVzIGFuZCB3aGl0ZXNwYWNlLWFsaWduZWQKLSAg ICAgICMgc3RydWN0IG1lbWJlcnMuCisgICAgKFsjIFRoZSBXZWJLaXQyIEMgQVBJIGhhcyBuYW1l cyB3aXRoIHVuZGVyc2NvcmVzLCB3aGl0ZXNwYWNlLWFsaWduZWQKKyAgICAgICMgc3RydWN0IG1l bWJlcnMsIGFuZCBhbHdheXMgc2hvdWxkIGhhdmUgcGFyYW1ldGVyIG5hbWVzLgogICAgICAgIldl YktpdDIvVUlQcm9jZXNzL0FQSS9DLyIsCiAgICAgICAiV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVj dGVkQnVuZGxlL0FQSS9jLyJdLAogICAgICBbIi1idWlsZC9pbmNsdWRlX29yZGVyIiwKICAgICAg ICItcmVhZGFiaWxpdHkvbmFtaW5nIiwKKyAgICAgICItcmVhZGFiaWxpdHkvcGFyYW1ldGVyX25h bWUiLAogICAgICAgIi13aGl0ZXNwYWNlL2RlY2xhcmF0aW9uIl0pLAogICAgIChbIyBOb3RoaW5n IGluIFdlYktpdDIgdXNlcyBjb25maWcuaC4KICAgICAgICJXZWJLaXQyLyJdLAo=