51935 2011-01-05 11:04:03 -0800 Add WebKit2 API for largest frame 2011-01-05 11:49:20 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap andersca sam webkit.review.bot oldest_to_newest 329667 0 ap 2011-01-05 11:04:03 -0800 Forgot to publish the new accessor as WK2 API. 329672 1 78018 ap 2011-01-05 11:05:16 -0800 Created attachment 78018 proposed patch 329673 2 webkit.review.bot 2011-01-05 11:06:47 -0800 Attachment 78018 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'WebKit2/ChangeLog', u'WebKit2/UIProcess/API/C/WKPage.cpp', u'WebKit2/UIProcess/API/C/WKPage.h']" exit_code: 1 WebKit2/UIProcess/API/C/WKPage.h:271: The parameter name "page" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 329681 3 ap 2011-01-05 11:19:37 -0800 Filed 51938 against check-webkit-style. 329697 4 ap 2011-01-05 11:49:20 -0800 Committed <http://trac.webkit.org/changeset/75089>. 78018 2011-01-05 11:05:16 -0800 2011-01-05 11:32:22 -0800 proposed patch LargestFrameAPI.txt text/plain 1779 ap SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NTA4MikKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTEtMDEtMDUgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxOTM1CisgICAgICAgIEFk ZCBXZWJLaXQyIEFQSSBmb3IgbGFyZ2VzdCBmcmFtZQorCisgICAgICAgICogVUlQcm9jZXNzL0FQ SS9DL1dLUGFnZS5jcHA6CisgICAgICAgIChXS1BhZ2VHZXRGcmFtZVNldExhcmdlc3RGcmFtZSk6 CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5oOgorCiAyMDExLTAxLTA1ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFuIEJlcm5zdGVpbi4KSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0MvV0tQYWdlLmNwcAkocmV2aXNp b24gNzUwNzYpCisrKyBXZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQy9XS1BhZ2UuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0xNTIsNiArMTUyLDExIEBAIFdLRnJhbWVSZWYgV0tQYWdlR2V0Rm9jdXNlZEZy YW1lKFdLUGFnZVIKICAgICByZXR1cm4gdG9BUEkodG9JbXBsKHBhZ2VSZWYpLT5mb2N1c2VkRnJh bWUoKSk7CiB9CiAKK1dLRnJhbWVSZWYgV0tQYWdlR2V0RnJhbWVTZXRMYXJnZXN0RnJhbWUoV0tQ YWdlUmVmIHBhZ2VSZWYpCit7CisgICAgcmV0dXJuIHRvQVBJKHRvSW1wbChwYWdlUmVmKS0+ZnJh bWVTZXRMYXJnZXN0RnJhbWUoKSk7Cit9CisKICNpZiBkZWZpbmVkKEVOQUJMRV9JTlNQRUNUT1Ip ICYmIEVOQUJMRV9JTlNQRUNUT1IKIFdLSW5zcGVjdG9yUmVmIFdLUGFnZUdldEluc3BlY3RvcihX S1BhZ2VSZWYgcGFnZVJlZikKIHsKSW5kZXg6IFdlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFn ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5oCShyZXZp c2lvbiA3NTA3NikKKysrIFdlYktpdDIvVUlQcm9jZXNzL0FQSS9DL1dLUGFnZS5oCSh3b3JraW5n IGNvcHkpCkBAIC0yNjgsNiArMjY4LDcgQEAgV0tfRVhQT1JUIFdLU3RyaW5nUmVmIFdLUGFnZUNv cHlUaXRsZShXSwogCiBXS19FWFBPUlQgV0tGcmFtZVJlZiBXS1BhZ2VHZXRNYWluRnJhbWUoV0tQ YWdlUmVmIHBhZ2UpOwogV0tfRVhQT1JUIFdLRnJhbWVSZWYgV0tQYWdlR2V0Rm9jdXNlZEZyYW1l KFdLUGFnZVJlZiBwYWdlKTsgLy8gVGhlIGZvY3VzZWQgZnJhbWUgbWF5IGJlIGluYWN0aXZlLgor V0tfRVhQT1JUIFdLRnJhbWVSZWYgV0tQYWdlR2V0RnJhbWVTZXRMYXJnZXN0RnJhbWUoV0tQYWdl UmVmIHBhZ2UpOwogV0tfRVhQT1JUIGRvdWJsZSBXS1BhZ2VHZXRFc3RpbWF0ZWRQcm9ncmVzcyhX S1BhZ2VSZWYgcGFnZSk7CiAKICNpZiBkZWZpbmVkKEVOQUJMRV9JTlNQRUNUT1IpICYmIEVOQUJM RV9JTlNQRUNUT1IK