51911 2011-01-04 18:07:24 -0800 GTK: AX: DRT needs to use correct root object method. 2011-01-05 10:19:34 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach mrobinson xan.lopez oldest_to_newest 329349 0 cfleizach 2011-01-04 18:07:24 -0800 GTK needs to get the correct accessibility root object by using axObjectCache() root object. 329353 1 77958 cfleizach 2011-01-04 18:10:44 -0800 Created attachment 77958 Patch 329354 2 cfleizach 2011-01-04 18:11:31 -0800 we can also use this bug to address the fact that DRT is crashing a lot now. I need some help figuring out what's going on there, since I can't see the crash logs. 329371 3 mrobinson 2011-01-04 18:36:29 -0800 Here are the crash logs for the GTK+ bots: http://webkit-bots.igalia.com/ 329459 4 cfleizach 2011-01-04 23:56:12 -0800 looks like i fixed the layout test crashing. i suspect the API tests may still fail, don't know if I can fix those on my own 329463 5 77958 mrobinson 2011-01-05 00:14:24 -0800 Comment on attachment 77958 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77958&action=review Thanks for the fix! > Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:63 > + AtkObject* accessible = DumpRenderTreeSupportGtk::getRootAccessibleElement(mainFrame); There's an extra space here after =. 329602 6 cfleizach 2011-01-05 09:31:58 -0800 http://trac.webkit.org/changeset/75072 77958 2011-01-04 18:10:44 -0800 2011-01-05 00:14:24 -0800 Patch bug-51911-20110104181040.patch text/plain 4024 cfleizach SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc1MDM1KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTEtMDEtMDQgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHVEs6 IEFYOiBEUlQgbmVlZHMgdG8gdXNlIGNvcnJlY3Qgcm9vdCBvYmplY3QgbWV0aG9kLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE5MTEKKworICAgICAg ICAqIER1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5Q29udHJvbGxlckd0ay5jcHA6Cisg ICAgICAgIChBY2Nlc3NpYmlsaXR5Q29udHJvbGxlcjo6cm9vdEVsZW1lbnQpOgorCiAyMDExLTAx LTA0ICBDaHJpcyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nl c3NpYmlsaXR5Q29udHJvbGxlckd0ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRHVtcFJlbmRl clRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlDb250cm9sbGVyR3RrLmNwcAkocmV2aXNpb24gNzUwMzAp CisrKyBUb29scy9EdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eUNvbnRyb2xsZXJHdGsu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MCwxMyArNjAsMTEgQEAgQWNjZXNzaWJpbGl0eVVJRWxl bWVudCBBY2Nlc3NpYmlsaXR5Q29udAogCiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50IEFjY2Vzc2li aWxpdHlDb250cm9sbGVyOjpyb290RWxlbWVudCgpCiB7Ci0gICAgV2ViS2l0V2ViVmlldyogdmll dyA9IHdlYmtpdF93ZWJfZnJhbWVfZ2V0X3dlYl92aWV3KG1haW5GcmFtZSk7CisgICAgQXRrT2Jq ZWN0KiBhY2Nlc3NpYmxlID0gIER1bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6Z2V0Um9vdEFjY2Vz c2libGVFbGVtZW50KG1haW5GcmFtZSk7CisgICAgaWYgKCFhY2Nlc3NpYmxlKQorICAgICAgICBy ZXR1cm4gMDsKIAotICAgIC8vIFRoZSBwcmVzdW1lZCwgZGVzaXJlZCByb290RWxlbWVudCBpcyB0 aGUgcGFyZW50IG9mIHRoZSB3ZWIgdmlldy4KLSAgICBHdGtXaWRnZXQqIHdlYlZpZXdQYXJlbnQg PSBndGtfd2lkZ2V0X2dldF9wYXJlbnQoR1RLX1dJREdFVCh2aWV3KSk7Ci0gICAgQXRrT2JqZWN0 KiBheE9iamVjdCA9IGd0a193aWRnZXRfZ2V0X2FjY2Vzc2libGUod2ViVmlld1BhcmVudCk7Ci0g Ci0gICAgcmV0dXJuIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQoYXhPYmplY3QpOworICAgIHJldHVy biBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50KGFjY2Vzc2libGUpOwogfQogCiB2b2lkIEFjY2Vzc2li aWxpdHlDb250cm9sbGVyOjpzZXRMb2dGb2N1c0V2ZW50cyhib29sKQpJbmRleDogV2ViS2l0L2d0 ay9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHJldmlzaW9u IDc1MDM1KQorKysgV2ViS2l0L2d0ay9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyAr MSwxNSBAQAorMjAxMS0wMS0wNCAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdUSzog QVg6IERSVCBuZWVkcyB0byB1c2UgY29ycmVjdCByb290IG9iamVjdCBtZXRob2QuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTkxMQorCisgICAgICAg ICogV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0R3RrLmNwcDoKKyAgICAgICAg KER1bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6Z2V0Um9vdEFjY2Vzc2libGVFbGVtZW50KToKKyAg ICAgICAgKER1bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6Z2V0Rm9jdXNlZEFjY2Vzc2libGVFbGVt ZW50KToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsu aDoKKwogMjAxMS0wMS0wNCAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgog CiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCkluZGV4OiBXZWJLaXQvZ3RrL1dlYkNv cmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGsuY3BwCShyZXZp c2lvbiA3NTAzMSkKKysrIFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVT dXBwb3J0R3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDEzLDcgKzQxMyw3IEBAIHZvaWQgRHVt cFJlbmRlclRyZWVTdXBwb3J0R3RrOjpjbGVhck1haW4KICAgICBjb3JlKGZyYW1lKS0+dHJlZSgp LT5jbGVhck5hbWUoKTsKIH0KIAotQXRrT2JqZWN0KiBEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6 OmdldEZvY3VzZWRBY2Nlc3NpYmxlRWxlbWVudChXZWJLaXRXZWJGcmFtZSogZnJhbWUpCitBdGtP YmplY3QqIER1bXBSZW5kZXJUcmVlU3VwcG9ydEd0azo6Z2V0Um9vdEFjY2Vzc2libGVFbGVtZW50 KFdlYktpdFdlYkZyYW1lKiBmcmFtZSkKIHsKICAgICBnX3JldHVybl92YWxfaWZfZmFpbChXRUJL SVRfSVNfV0VCX0ZSQU1FKGZyYW1lKSwgMCk7CiAKQEAgLTQyOSw2ICs0MjksMTkgQEAgQXRrT2Jq ZWN0KiBEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6OmdldAogICAgIGlmICghd3JhcHBlcikKICAg ICAgICAgcmV0dXJuIDA7CiAKKyAgICByZXR1cm4gd3JhcHBlcjsKKyNlbHNlCisgICAgcmV0dXJu IDA7CisjZW5kaWYKK30KKworQXRrT2JqZWN0KiBEdW1wUmVuZGVyVHJlZVN1cHBvcnRHdGs6Omdl dEZvY3VzZWRBY2Nlc3NpYmxlRWxlbWVudChXZWJLaXRXZWJGcmFtZSogZnJhbWUpCit7CisjaWYg SEFWRShBQ0NFU1NJQklMSVRZKQorICAgIEF0a09iamVjdCogd3JhcHBlciA9IGdldFJvb3RBY2Nl c3NpYmxlRWxlbWVudChmcmFtZSk7CisgICAgaWYgKCF3cmFwcGVyKQorICAgICAgICByZXR1cm4g MDsKKwogICAgIHJldHVybiB3ZWJraXRfYWNjZXNzaWJsZV9nZXRfZm9jdXNlZF9lbGVtZW50KFdF QktJVF9BQ0NFU1NJQkxFKHdyYXBwZXIpKTsKICNlbHNlCiAgICAgcmV0dXJuIDA7CkluZGV4OiBX ZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydEd0ay5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0 R3RrLmgJKHJldmlzaW9uIDc1MDMwKQorKysgV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EdW1w UmVuZGVyVHJlZVN1cHBvcnRHdGsuaAkod29ya2luZyBjb3B5KQpAQCAtNjQsNiArNjQsNyBAQCBw dWJsaWM6CiAgICAgc3RhdGljIHZvaWQgcmVzdW1lQW5pbWF0aW9ucyhXZWJLaXRXZWJGcmFtZSop OwogICAgIHN0YXRpYyB2b2lkIGNsZWFyTWFpbkZyYW1lTmFtZShXZWJLaXRXZWJGcmFtZSopOwog ICAgIHN0YXRpYyBBdGtPYmplY3QqIGdldEZvY3VzZWRBY2Nlc3NpYmxlRWxlbWVudChXZWJLaXRX ZWJGcmFtZSopOworICAgIHN0YXRpYyBBdGtPYmplY3QqIGdldFJvb3RBY2Nlc3NpYmxlRWxlbWVu dChXZWJLaXRXZWJGcmFtZSopOwogICAgIHN0YXRpYyB2b2lkIGxheW91dEZyYW1lKFdlYktpdFdl YkZyYW1lKik7CiAKICAgICAvLyBXZWJLaXRXZWJWaWV3Cg==