<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>5189</bug_id>
          
          <creation_ts>2005-09-29 12:41:50 -0700</creation_ts>
          <short_desc>pcre_exec.c fails to compile using MSVC</short_desc>
          <delta_ts>2005-10-08 21:21:48 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>420+</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows XP</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Justin Haygood">jhaygood</reporter>
          <assigned_to name="Maciej Stachowiak">mjs</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>20954</commentid>
    <comment_count>0</comment_count>
    <who name="Justin Haygood">jhaygood</who>
    <bug_when>2005-09-29 12:41:50 -0700</bug_when>
    <thetext>PCRE 6.1&apos;s pcre_exec.c fails to compile using MSVC.

Work Arounds to compile correctly:

Compile using C++ instead of C
Apply following patch (does the exact same thing as original, but seperates
declaration of initial assignment)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>20955</commentid>
    <comment_count>1</comment_count>
      <attachid>4095</attachid>
    <who name="Justin Haygood">jhaygood</who>
    <bug_when>2005-09-29 12:43:31 -0700</bug_when>
    <thetext>Created attachment 4095
Separates int utf16Length declaration and assignment into 2 lines.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>20956</commentid>
    <comment_count>2</comment_count>
      <attachid>4095</attachid>
    <who name="Justin Haygood">jhaygood</who>
    <bug_when>2005-09-29 12:44:22 -0700</bug_when>
    <thetext>Comment on attachment 4095
Separates int utf16Length declaration and assignment into 2 lines.

Very simple fix, without which MSVC will claim not to see the initial
declaration, and die trying.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>20973</commentid>
    <comment_count>3</comment_count>
      <attachid>4095</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2005-09-30 07:37:46 -0700</bug_when>
    <thetext>Comment on attachment 4095
Separates int utf16Length declaration and assignment into 2 lines.

Code change looks OK (but strange, amazing that MSVC has this bug), but patch
has a tab in it. Lets not add a tab to the file.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>4095</attachid>
            <date>2005-09-29 12:43:31 -0700</date>
            <delta_ts>2005-09-30 07:37:46 -0700</delta_ts>
            <desc>Separates int utf16Length declaration and assignment into 2 lines.</desc>
            <filename>pcre_exec_win32_fix.patch</filename>
            <type>text/plain</type>
            <size>625</size>
            <attacher name="Justin Haygood">jhaygood</attacher>
            
              <data encoding="base64">SW5kZXg6IHBjcmUvcGNyZV9leGVjLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBmaWxlOiAvY3ZzL3Jvb3Qv
SmF2YVNjcmlwdENvcmUvcGNyZS9wY3JlX2V4ZWMuYyx2DQpyZXRyaWV2aW5nIHJldmlzaW9uIDEu
Mw0KZGlmZiAtdSAtcjEuMyBwY3JlX2V4ZWMuYw0KLS0tIHBjcmUvcGNyZV9leGVjLmMJOSBTZXAg
MjAwNSAwMDo1MTowNiAtMDAwMAkxLjMNCisrKyBwY3JlL3BjcmVfZXhlYy5jCTI5IFNlcCAyMDA1
IDE4OjQyOjIyIC0wMDAwDQpAQCAtMTkyNyw3ICsxOTI3LDggQEANCiAjaWYgUENSRV9VVEYxNg0K
ICAgICAgIGxlbmd0aCA9IDE7DQogICAgICAgR0VUVVRGOENIQVJMRU4oZmMsIGVjb2RlLCBsZW5n
dGgpOw0KLSAgICAgIGludCB1dGYxNkxlbmd0aCA9IGZjID4gMHhGRkZGID8gMiA6IDE7DQorCSAg
aW50IHV0ZjE2TGVuZ3RoOw0KKyAgICAgIHV0ZjE2TGVuZ3RoID0gZmMgPiAweEZGRkYgPyAyIDog
MTsNCiAgICAgICBpZiAobWluICogdXRmMTZMZW5ndGggPiBtZC0+ZW5kX3N1YmplY3QgLSBlcHRy
KSBSUkVUVVJOKE1BVENIX05PTUFUQ0gpOw0KICAgICAgIGVjb2RlICs9IGxlbmd0aDsNCiANCg==
</data>
<flag name="review"
          id="638"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>