51888 2011-01-04 12:31:01 -0800 [Qt] [Symbian] Make CONFIG-=def_files the default configuration for trunk builds 2011-01-05 09:55:33 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC S60 3rd edition RESOLVED FIXED Qt, QtTriaged P5 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue hausmann koshuin laszlo.gombos oldest_to_newest 329129 0 laszlo.gombos 2011-01-04 12:31:01 -0800 Currently CONFIG(def_files) (almost always) evaluates to true as that is the default in Qt's qconfig.pri. This can be overruled at qmake time by changing the CONFIG variable. This means that (more often than not) the QtWebKit trunk build fails as the def file is not up-to-date. The current practice is to always pass CONFIG-=def_files for QtWebKit trunk builds. CONFIG(production) has been introduced as a single bit to switch between the somewhat unstable trunk environment to a more stable production environment. CONFIG(production) evaluates to true on production branches of QtWebKit and false on the trunk. It seems like a good idea to overrule Qt's default from qconfig.pri for non-production builds so that CONFIG(def_files) evaluates to false and QtWebKit trunk builds succeeds. 329132 1 77916 laszlo.gombos 2011-01-04 12:34:49 -0800 Created attachment 77916 proposed patch 329588 2 77916 ariya.hidayat 2011-01-05 09:07:21 -0800 Comment on attachment 77916 proposed patch LGTM. re=me 329618 3 77916 commit-queue 2011-01-05 09:55:26 -0800 Comment on attachment 77916 proposed patch Clearing flags on attachment: 77916 Committed r75076: <http://trac.webkit.org/changeset/75076> 329619 4 commit-queue 2011-01-05 09:55:33 -0800 All reviewed patches have been landed. Closing bug. 77916 2011-01-04 12:34:49 -0800 2011-01-05 09:55:26 -0800 proposed patch 51888.patch text/plain 1157 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDk5MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMDEtMDQgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gW1N5bWJpYW5dIE1ha2UgQ09ORklHLT1kZWZfZmlsZXMgdGhlIGRlZmF1bHQg Y29uZmlndXJhdGlvbiBmb3IgdHJ1bmsgYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTg4OAorCisgICAgICAgIE92ZXJydWxlIFF0J3MgZGVm YXVsdCBmcm9tIHFjb25maWcucHJpIGZvciBub24tcHJvZHVjdGlvbiBidWlsZHMgc28KKyAgICAg ICAgdGhhdCBDT05GSUcoZGVmX2ZpbGVzKSBldmFsdWF0ZXMgdG8gZmFsc2UgYW5kIFF0V2ViS2l0 IHRydW5rIGJ1aWxkcyBzdWNjZWVkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGVyZSBp cyBubyBuZXcgZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIFdlYkNvcmUucHJvOgorCiAyMDEx LTAxLTA0ICBZb25nIExpICA8eW9saUByaW0uY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFk YW0gQmFydGguCkluZGV4OiBXZWJDb3JlL1dlYkNvcmUucHJvCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvV2ViQ29yZS5wcm8JKHJldmlzaW9uIDc0OTg5KQorKysgV2ViQ29yZS9XZWJDb3JlLnBybwko d29ya2luZyBjb3B5KQpAQCAtNzQsNiArNzQsOCBAQCBzeW1iaWFuOiB7CiAgICAgICAgIFFNQUtF X0NYWEZMQUdTIC09IC0tdGh1bWIKICAgICB9CiAgICAgQ09ORklHKHJlbGVhc2UsIGRlYnVnfHJl bGVhc2UpOiBRTUFLRV9DWFhGTEFHUy5BUk1DQyArPSAtT1RpbWUgLU8zCisKKyAgICAhQ09ORklH KHByb2R1Y3Rpb24pOkNPTkZJRy09ZGVmX2ZpbGVzCiB9CiAKIGlzRW1wdHkoT1VUUFVUX0RJUik6 IE9VVFBVVF9ESVIgPSAuLgo=