51886 2011-01-04 11:15:01 -0800 Add more spelling/grammar related methods 2011-01-04 11:49:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 329094 0 andersca 2011-01-04 11:15:01 -0800 Add more spelling/grammar related methods 329098 1 77910 andersca 2011-01-04 11:18:15 -0800 Created attachment 77910 Patch 329106 2 77910 sullivan 2011-01-04 11:39:39 -0800 Comment on attachment 77910 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77910&action=review > WebKit2/UIProcess/API/mac/WKView.mm:57 > +// FIXME: <rdar://problem/8728860> WebKit2 needs to be localized It would help us track down remaining WebKit2 work if you used the format: // FIXME (WebKit2) <etc> > WebKit2/UIProcess/API/mac/WKView.mm:417 > + // FIXME: <rdar://problem/8245958> Make Spelling/Grammar checking work in WebKit2 Same here. > WebKit2/UIProcess/API/mac/WKView.mm:422 > + // FIXME: <rdar://problem/8245958> Make Spelling/Grammar checking work in WebKit2 Same here. > WebKit2/WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:43 > +// FIXME: <rdar://problem/8728860> WebKit2 needs to be localized Same here. 329111 3 andersca 2011-01-04 11:49:36 -0800 Committed r74989: <http://trac.webkit.org/changeset/74989> 77910 2011-01-04 11:18:15 -0800 2011-01-04 11:39:39 -0800 Patch bug-51886-20110104111814.patch text/plain 7351 andersca SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDk3NykKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzUgQEAKKzIwMTEtMDEtMDQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFw cGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgbW9yZSBzcGVsbGluZy9ncmFtbWFyIHJlbGF0ZWQgbWV0aG9kcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE4ODYKKworICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvbWFjL1dLVmlldy5tbToKKyAgICAgICAgKC1bV0tWaWV3IHZhbGlkYXRlVXNl ckludGVyZmFjZUl0ZW06XSk6CisgICAgICAgIEhhbmRsZSBtb3JlIHNlbGVjdG9ycy4KKworICAg ICAgICAoLVtXS1ZpZXcgc2hvd0d1ZXNzUGFuZWw6XSk6CisgICAgICAgIEFkZCBzdHViLgorCisg ICAgICAgICgtW1dLVmlldyBjaGVja1NwZWxsaW5nOl0pOgorICAgICAgICBEaXR0by4KKworICAg ICAgICAoLVtXS1ZpZXcgdG9nZ2xlQXV0b21hdGljU3BlbGxpbmdDb3JyZWN0aW9uOl0pOgorICAg ICAgICBUb2dnbGUgYXV0b21hdGljIHNwZWxsaW5nIGNvcnJlY3Rpb24uCisKKyAgICAgICAgKiBV SVByb2Nlc3MvVGV4dENoZWNrZXIuaDoKKyAgICAgICAgQWRkIHNldEF1dG9tYXRpY1NwZWxsaW5n Q29ycmVjdGlvbkVuYWJsZWQgYW5kIGlzQXV0b21hdGljU3BlbGxpbmdDb3JyZWN0aW9uRW5hYmxl ZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvVGV4dENoZWNrZXJNYWMubW06CisgICAgICAg IChXZWJLaXQ6OlRleHRDaGVja2VyOjpzZXRBdXRvbWF0aWNTcGVsbGluZ0NvcnJlY3Rpb25FbmFi bGVkKToKKyAgICAgICAgKFdlYktpdDo6VGV4dENoZWNrZXI6OmlzQXV0b21hdGljU3BlbGxpbmdD b3JyZWN0aW9uRW5hYmxlZCk6CisgICAgICAgIFVwZGF0ZSB0aGUgdG9nZ2xlLgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJQbGF0Zm9ybVN0cmF0ZWdpZXMuY3BwOgor ICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvbWFjL1dlYkVycm9yc01hYy5tbToK KyAgICAgICAgQWRkIGEgUmFkYXIgVVJMIGZvciB0aGUgbG9jYWxpemF0aW9uIEZJWE1Fcy4KKwog MjAxMS0wMS0wNCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJLaXQyL1VJUHJvY2Vzcy9UZXh0Q2hl Y2tlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNzL1RleHRDaGVja2VyLmgJKHJl dmlzaW9uIDc0OTczKQorKysgV2ViS2l0Mi9VSVByb2Nlc3MvVGV4dENoZWNrZXIuaAkod29ya2lu ZyBjb3B5KQpAQCAtMzYsNiArMzYsOSBAQCBwdWJsaWM6CiAKICAgICBzdGF0aWMgYm9vbCBpc0dy YW1tYXJDaGVja2luZ0VuYWJsZWQoKTsKICAgICBzdGF0aWMgdm9pZCBzZXRHcmFtbWFyQ2hlY2tp bmdFbmFibGVkKGJvb2wpOworCisgICAgc3RhdGljIHZvaWQgc2V0QXV0b21hdGljU3BlbGxpbmdD b3JyZWN0aW9uRW5hYmxlZChib29sKTsKKyAgICBzdGF0aWMgYm9vbCBpc0F1dG9tYXRpY1NwZWxs aW5nQ29ycmVjdGlvbkVuYWJsZWQoKTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApJbmRl eDogV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHJldmlzaW9uIDc0OTczKQorKysgV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTU0LDYg KzU0LDkgQEAKICNpbXBvcnQgPHd0Zi9SZWZQdHIuaD4KICNpbXBvcnQgPHd0Zi9SZXRhaW5QdHIu aD4KIAorLy8gRklYTUU6IDxyZGFyOi8vcHJvYmxlbS84NzI4ODYwPiBXZWJLaXQyIG5lZWRzIHRv IGJlIGxvY2FsaXplZAorI2RlZmluZSBVSV9TVFJJTkcoX19zdHIsIF9fZGVzYykgW05TU3RyaW5n IHN0cmluZ1dpdGhVVEY4U3RyaW5nOl9fc3RyXQorCiBAaW50ZXJmYWNlIE5TQXBwbGljYXRpb24g KERldGFpbHMpCiAtICh2b2lkKXNwZWFrU3RyaW5nOihOU1N0cmluZyAqKXN0cmluZzsKIEBlbmQK QEAgLTMzMCw4ICszMzMsMTggQEAgLSAoQk9PTCl2YWxpZGF0ZVVzZXJJbnRlcmZhY2VJdGVtOihp ZCA8TgogewogICAgIFNFTCBhY3Rpb24gPSBbaXRlbSBhY3Rpb25dOwogCi0gICAgaWYgKGFjdGlv biA9PSBAc2VsZWN0b3Ioc3RvcFNwZWFraW5nOikpCi0gICAgICAgIHJldHVybiBbTlNBcHAgaXNT cGVha2luZ107CisgICAgaWYgKGFjdGlvbiA9PSBAc2VsZWN0b3Ioc2hvd0d1ZXNzUGFuZWw6KSkg eworICAgICAgICBpZiAoTlNNZW51SXRlbSAqbWVudUl0ZW0gPSA6Om1lbnVJdGVtKGl0ZW0pKSB7 CisgICAgICAgICAgICBCT09MIHBhbmVsU2hvd2luZyA9IFtbW05TU3BlbGxDaGVja2VyIHNoYXJl ZFNwZWxsQ2hlY2tlcl0gc3BlbGxpbmdQYW5lbF0gaXNWaXNpYmxlXTsKKyAgICAgICAgICAgIFtt ZW51SXRlbSBzZXRUaXRsZTpwYW5lbFNob3dpbmcKKyAgICAgICAgICAgICAgICA/IFVJX1NUUklO RygiSGlkZSBTcGVsbGluZyBhbmQgR3JhbW1hciIsICJtZW51IGl0ZW0gdGl0bGUiKQorICAgICAg ICAgICAgICAgIDogVUlfU1RSSU5HKCJTaG93IFNwZWxsaW5nIGFuZCBHcmFtbWFyIiwgIm1lbnUg aXRlbSB0aXRsZSIpXTsKKyAgICAgICAgfQorICAgICAgICByZXR1cm4gX2RhdGEtPl9wYWdlLT5z ZWxlY3Rpb25TdGF0ZSgpLmlzQ29udGVudEVkaXRhYmxlOworICAgIH0KKworICAgIGlmIChhY3Rp b24gPT0gQHNlbGVjdG9yKGNoZWNrU3BlbGxpbmc6KSkKKyAgICAgICAgcmV0dXJuIF9kYXRhLT5f cGFnZS0+c2VsZWN0aW9uU3RhdGUoKS5pc0NvbnRlbnRFZGl0YWJsZTsKIAogICAgIGlmIChhY3Rp b24gPT0gQHNlbGVjdG9yKHRvZ2dsZUNvbnRpbnVvdXNTcGVsbENoZWNraW5nOikpIHsKICAgICAg ICAgYm9vbCBlbmFibGVkID0gVGV4dENoZWNrZXI6OmlzQ29udGludW91c1NwZWxsQ2hlY2tpbmdB bGxvd2VkKCk7CkBAIC0zNDYsNiArMzU5LDE1IEBAIC0gKEJPT0wpdmFsaWRhdGVVc2VySW50ZXJm YWNlSXRlbTooaWQgPE4KICAgICAgICAgcmV0dXJuIFlFUzsKICAgICB9CiAKKyAgICBpZiAoYWN0 aW9uID09IEBzZWxlY3Rvcih0b2dnbGVBdXRvbWF0aWNTcGVsbGluZ0NvcnJlY3Rpb246KSkgewor ICAgICAgICBib29sIGNoZWNrZWQgPSBUZXh0Q2hlY2tlcjo6aXNBdXRvbWF0aWNTcGVsbGluZ0Nv cnJlY3Rpb25FbmFibGVkKCk7CisgICAgICAgIFttZW51SXRlbShpdGVtKSBzZXRTdGF0ZTpjaGVj a2VkID8gTlNPblN0YXRlIDogTlNPZmZTdGF0ZV07CisgICAgICAgIHJldHVybiBfZGF0YS0+X3Bh Z2UtPnNlbGVjdGlvblN0YXRlKCkuaXNDb250ZW50RWRpdGFibGU7CisgICAgfQorCisgICAgaWYg KGFjdGlvbiA9PSBAc2VsZWN0b3Ioc3RvcFNwZWFraW5nOikpCisgICAgICAgIHJldHVybiBbTlNB cHAgaXNTcGVha2luZ107CisKICAgICAvLyBOZXh0LCBoYW5kbGUgZWRpdG9yIGNvbW1hbmRzLiBT dGFydCBieSByZXR1cm5pbmcgWUVTIGZvciBhbnl0aGluZyB0aGF0IGlzIG5vdCBhbiBlZGl0b3Ig Y29tbWFuZC4KICAgICAvLyBSZXR1cm5pbmcgWUVTIGlzIHRoZSBkZWZhdWx0IHRoaW5nIHRvIGRv IGluIGFuIEFwcEtpdCB2YWxpZGF0ZSBtZXRob2QgZm9yIGFueSBzZWxlY3RvciB0aGF0IGlzIG5v dCByZWNvZ25pemVkLgogICAgIFN0cmluZyBjb21tYW5kTmFtZSA9IGNvbW1hbmROYW1lRm9yU2Vs ZWN0b3IoW2l0ZW0gYWN0aW9uXSk7CkBAIC0zOTAsNiArNDEyLDE2IEBAIC0gKElCQWN0aW9uKXN0 b3BTcGVha2luZzooaWQpc2VuZGVyCiAgICAgW05TQXBwIHN0b3BTcGVha2luZzpzZW5kZXJdOwog fQogCistIChJQkFjdGlvbilzaG93R3Vlc3NQYW5lbDooaWQpc2VuZGVyCit7CisgICAgLy8gRklY TUU6IDxyZGFyOi8vcHJvYmxlbS84MjQ1OTU4PiBNYWtlIFNwZWxsaW5nL0dyYW1tYXIgY2hlY2tp bmcgd29yayBpbiBXZWJLaXQyCit9CisKKy0gKElCQWN0aW9uKWNoZWNrU3BlbGxpbmc6KGlkKXNl bmRlcgoreworICAgIC8vIEZJWE1FOiA8cmRhcjovL3Byb2JsZW0vODI0NTk1OD4gTWFrZSBTcGVs bGluZy9HcmFtbWFyIGNoZWNraW5nIHdvcmsgaW4gV2ViS2l0MgorfQorCiAtIChJQkFjdGlvbil0 b2dnbGVDb250aW51b3VzU3BlbGxDaGVja2luZzooaWQpc2VuZGVyCiB7CiAgICAgYm9vbCBzcGVs bENoZWNraW5nRW5hYmxlZCA9ICFUZXh0Q2hlY2tlcjo6aXNDb250aW51b3VzU3BlbGxDaGVja2lu Z0VuYWJsZWQoKTsKQEAgLTQwOCw2ICs0NDAsMTEgQEAgLSAoSUJBY3Rpb24pdG9nZ2xlR3JhbW1h ckNoZWNraW5nOihpZClzZQogICAgICAgICBfZGF0YS0+X3BhZ2UtPnVubWFya0FsbEJhZEdyYW1t YXIoKTsKIH0KIAorLSAoSUJBY3Rpb24pdG9nZ2xlQXV0b21hdGljU3BlbGxpbmdDb3JyZWN0aW9u OihpZClzZW5kZXIKK3sKKyAgICBUZXh0Q2hlY2tlcjo6c2V0QXV0b21hdGljU3BlbGxpbmdDb3Jy ZWN0aW9uRW5hYmxlZCghVGV4dENoZWNrZXI6OmlzQXV0b21hdGljU3BlbGxpbmdDb3JyZWN0aW9u RW5hYmxlZCgpKTsKK30KKwogLy8gRXZlbnRzCiAKIC8vIE92ZXJyaWRlIHRoaXMgc28gdGhhdCBB cHBLaXQgd2lsbCBzZW5kIHVzIGFycm93IGtleXMgYXMga2V5IGRvd24gZXZlbnRzIHNvIHdlIGNh bgpJbmRleDogV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1RleHRDaGVja2VyTWFjLm1tCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdDIvVUlQcm9jZXNzL21hYy9UZXh0Q2hlY2tlck1hYy5tbQkocmV2aXNpb24g NzQ5NzMpCisrKyBXZWJLaXQyL1VJUHJvY2Vzcy9tYWMvVGV4dENoZWNrZXJNYWMubW0JKHdvcmtp bmcgY29weSkKQEAgLTI5LDYgKzI5LDcgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiAKIHN0YXRpYyBi b29sIGNvbnRpbnVvdXNTcGVsbENoZWNraW5nRW5hYmxlZDsKIHN0YXRpYyBib29sIGdyYW1tYXJD aGVja2luZ0VuYWJsZWQ7CitzdGF0aWMgYm9vbCBhdXRvbWF0aWNTcGVsbGluZ0NvcnJlY3Rpb25F bmFibGVkOwogICAgIAogYm9vbCBUZXh0Q2hlY2tlcjo6aXNDb250aW51b3VzU3BlbGxDaGVja2lu Z0FsbG93ZWQoKQogewpAQCAtNzIsNCArNzMsMTggQEAgdm9pZCBUZXh0Q2hlY2tlcjo6c2V0R3Jh bW1hckNoZWNraW5nRW5hYgogICAgIC8vIGJlY2F1c2UgZ3JhbW1hciBjaGVja2luZyBvbmx5IG9j Y3VycyBvbiBjb2RlIHBhdGhzIHRoYXQgYWxyZWFkeSBwcmVmbGlnaHQgc3BlbGwgY2hlY2tpbmcg YXBwcm9wcmlhdGVseS4KIH0KIAordm9pZCBUZXh0Q2hlY2tlcjo6c2V0QXV0b21hdGljU3BlbGxp bmdDb3JyZWN0aW9uRW5hYmxlZChib29sIGlzQXV0b21hdGljU3BlbGxpbmdDb3JyZWN0aW9uRW5h YmxlZCkKK3sKKyAgICBpZiAoYXV0b21hdGljU3BlbGxpbmdDb3JyZWN0aW9uRW5hYmxlZCA9PSBp c0F1dG9tYXRpY1NwZWxsaW5nQ29ycmVjdGlvbkVuYWJsZWQpCisgICAgICAgIHJldHVybjsKKwor ICAgIGF1dG9tYXRpY1NwZWxsaW5nQ29ycmVjdGlvbkVuYWJsZWQgPSBpc0F1dG9tYXRpY1NwZWxs aW5nQ29ycmVjdGlvbkVuYWJsZWQ7CisgICAgW1tOU1NwZWxsQ2hlY2tlciBzaGFyZWRTcGVsbENo ZWNrZXJdIHVwZGF0ZVBhbmVsc107Cit9CisKK2Jvb2wgVGV4dENoZWNrZXI6OmlzQXV0b21hdGlj U3BlbGxpbmdDb3JyZWN0aW9uRW5hYmxlZCgpCit7CisgICAgcmV0dXJuIGF1dG9tYXRpY1NwZWxs aW5nQ29ycmVjdGlvbkVuYWJsZWQ7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApJbmRleDog V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYlBs YXRmb3JtU3RyYXRlZ2llcy5jcHAJKHJldmlzaW9uIDc0OTczKQorKysgV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYkNvcmVTdXBwb3J0L1dlYlBsYXRmb3JtU3RyYXRlZ2llcy5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTQxLDcgKzQxLDcgQEAKICNpbmNsdWRlIDx3dGYvUmV0YWluUHRyLmg+CiAjZW5kaWYK IAotLy8gRklYTUU6IEltcGxlbWVudCBsb2NhbGl6YXRpb24uCisvLyBGSVhNRTogPHJkYXI6Ly9w cm9ibGVtLzg3Mjg4NjA+IFdlYktpdDIgbmVlZHMgdG8gYmUgbG9jYWxpemVkCiAjZGVmaW5lIFVJ X1NUUklORyhzdHJpbmcsIGRlc2NyaXB0aW9uKSBTdHJpbmc6OmZyb21VVEY4KHN0cmluZywgc3Ry bGVuKHN0cmluZykpCiAjZGVmaW5lIFVJX1NUUklOR19LRVkoc3RyaW5nLCBrZXksIGRlc2NyaXB0 aW9uKSBTdHJpbmc6OmZyb21VVEY4KHN0cmluZywgc3RybGVuKHN0cmluZykpCiAKSW5kZXg6IFdl YktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViRXJyb3JzTWFjLm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9tYWMvV2ViRXJyb3Jz TWFjLm1tCShyZXZpc2lvbiA3NDk3MykKKysrIFdlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3Vw cG9ydC9tYWMvV2ViRXJyb3JzTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00MCw2ICs0MCw3IEBA IHN0YXRpYyBOU1N0cmluZyAqIGNvbnN0IFdlYktpdEVycm9yTUlNRVQKIHN0YXRpYyBOU1N0cmlu ZyAqIGNvbnN0IFdlYktpdEVycm9yUGx1Z0luTmFtZUtleSA9ICAgICAgICAgICAgIEAiV2ViS2l0 RXJyb3JQbHVnSW5OYW1lS2V5IjsKIHN0YXRpYyBOU1N0cmluZyAqIGNvbnN0IFdlYktpdEVycm9y UGx1Z0luUGFnZVVSTFN0cmluZ0tleSA9ICAgIEAiV2ViS2l0RXJyb3JQbHVnSW5QYWdlVVJMU3Ry aW5nS2V5IjsKIAorLy8gRklYTUU6IDxyZGFyOi8vcHJvYmxlbS84NzI4ODYwPiBXZWJLaXQyIG5l ZWRzIHRvIGJlIGxvY2FsaXplZAogI2RlZmluZSBVSV9TVFJJTkcoX19zdHIsIF9fZGVzYykgW05T U3RyaW5nIHN0cmluZ1dpdGhVVEY4U3RyaW5nOl9fc3RyXQogCiAvLyBQb2xpY3kgZXJyb3JzCg==