51881 2011-01-04 10:32:43 -0800 StackBounds initialization in WTFThreadData should be guarded by #if USE(JSC) 2011-01-04 22:40:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth barraclough commit-queue eric oliver webkit.review.bot oldest_to_newest 329051 0 jamesr 2011-01-04 10:32:43 -0800 StackBounds initialization in WTFThreadData should be guarded by #if USE(JSC) 329058 1 77901 jamesr 2011-01-04 10:39:30 -0800 Created attachment 77901 Patch 329234 2 77901 commit-queue 2011-01-04 14:47:59 -0800 Comment on attachment 77901 Patch Clearing flags on attachment: 77901 Committed r75011: <http://trac.webkit.org/changeset/75011> 329235 3 commit-queue 2011-01-04 14:48:05 -0800 All reviewed patches have been landed. Closing bug. 329239 4 webkit.review.bot 2011-01-04 14:54:34 -0800 http://trac.webkit.org/changeset/75011 might have broken Qt Linux Release 329409 5 barraclough 2011-01-04 21:26:41 -0800 This seems like a slightly odd change to make. There are a number of features of WTF that are presently only used in JSC, but we don't choose to #ifdef, and there is unsafe recursion in WebCore that could be addressed using this mechanism. Still, this doesn't do any actual harm - we can always just remove the #ifdefs if and when we do start making use of this from WebCore. 329425 6 jamesr 2011-01-04 22:23:17 -0800 This particular bit of code was causing problems with the Chromium linux sandbox, which motivated the change. If we want to use this functionality elsewhere we'll have to figure out how to make those pthread_* calls from within the sandbox (or route the calls some other way for Chromium linux). It seemed easier to just #ifdef the code out for non-JSC builds since it's not currently being used outside of JSC. 329430 7 barraclough 2011-01-04 22:40:54 -0800 (In reply to comment #6) > This particular bit of code was causing problems with the Chromium linux sandbox, which motivated the change. If we want to use this functionality elsewhere we'll have to figure out how to make those pthread_* calls from within the sandbox (or route the calls some other way for Chromium linux). It seemed easier to just #ifdef the code out for non-JSC builds since it's not currently being used outside of JSC. Ah, makes sense now, & good to know. If we plan on making use of this from WebCore then I'll try to make sure we give you some heads up, so you have time to look into the sandboxing issues. 77901 2011-01-04 10:39:30 -0800 2011-01-04 14:47:58 -0800 Patch bug-51881-20110104103929.patch text/plain 2365 jamesr ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGU1ZDhhNTU0Njk2ZTNlYWM0ZTE1MzFkMjVhNzJh OWVmNGJmYTBjNmIuLjc0MzRmMTFlY2M5Y2E4NmYyNWQ0MjgwNTA0ODU0ZDNkYTQ3OTA5ZTYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDExLTAxLTA0ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RhY2tCb3VuZHMgaW5pdGlhbGl6YXRpb24gaW4g V1RGVGhyZWFkRGF0YSBzaG91bGQgYmUgZ3VhcmRlZCBieSAjaWYgVVNFKEpTQykKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxODgxCisKKyAgICAgICAg VGhlIFN0YWNrQm91bmRzIGNsYXNzIGlzIG9ubHkgdXNlZCBieSBKYXZhU2NyaXB0Q29yZS4KKwor ICAgICAgICAqIHd0Zi9XVEZUaHJlYWREYXRhLmNwcDoKKyAgICAgICAgKFdURjo6V1RGVGhyZWFk RGF0YTo6V1RGVGhyZWFkRGF0YSk6CisgICAgICAgICogd3RmL1dURlRocmVhZERhdGEuaDoKKyAg ICAgICAgKFdURjo6V1RGVGhyZWFkRGF0YTo6cmVzZXRDdXJyZW50SWRlbnRpZmllclRhYmxlKToK KwogMjAxMS0wMS0wMyAgRGFuaWVsIEJhdGVzICA8ZGJhdGVzQHJpbS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvd3RmL1dURlRocmVhZERhdGEuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9XVEZU aHJlYWREYXRhLmNwcAppbmRleCAwNWJlOGQxYzc1MTVlNTM1YTkwYzIxYWEzY2E5NTcwYzMxM2E5 Zjc4Li44NGUxODU2OWZmYTQ3NWFiMmZiMDg4NmQ4YTc3ZWI1ODdmNjlmM2E2IDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1dURlRocmVhZERhdGEuY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS93dGYvV1RGVGhyZWFkRGF0YS5jcHAKQEAgLTQxLDggKzQxLDggQEAg V1RGVGhyZWFkRGF0YTo6V1RGVGhyZWFkRGF0YSgpCiAjaWYgVVNFKEpTQykKICAgICAsIG1fZGVm YXVsdElkZW50aWZpZXJUYWJsZShuZXcgSlNDOjpJZGVudGlmaWVyVGFibGUoKSkKICAgICAsIG1f Y3VycmVudElkZW50aWZpZXJUYWJsZShtX2RlZmF1bHRJZGVudGlmaWVyVGFibGUpCi0jZW5kaWYK ICAgICAsIG1fc3RhY2tCb3VuZHMoU3RhY2tCb3VuZHM6OmN1cnJlbnRUaHJlYWRTdGFja0JvdW5k cygpKQorI2VuZGlmCiB7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93 dGYvV1RGVGhyZWFkRGF0YS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9XVEZUaHJlYWRE YXRhLmgKaW5kZXggZGExYjZlYmEyM2M3Y2IyZDk1NmQ3MDJiOWJhYTYxZmRkZGJjZGRmMi4uNTJj MjY3YWMzZDJjMTgzMjIxZGY2N2JiN2UwYjRhZGQ4ODBmZjVmNyAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3d0Zi9XVEZUaHJlYWREYXRhLmgKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL3d0Zi9XVEZUaHJlYWREYXRhLmgKQEAgLTExMiwxMiArMTEyLDEyIEBAIHB1YmxpYzoK ICAgICB7CiAgICAgICAgIG1fY3VycmVudElkZW50aWZpZXJUYWJsZSA9IG1fZGVmYXVsdElkZW50 aWZpZXJUYWJsZTsKICAgICB9Ci0jZW5kaWYKIAogICAgIGNvbnN0IFN0YWNrQm91bmRzJiBzdGFj aygpIGNvbnN0CiAgICAgewogICAgICAgICByZXR1cm4gbV9zdGFja0JvdW5kczsKICAgICB9Cisj ZW5kaWYKIAogcHJpdmF0ZToKICAgICBBdG9taWNTdHJpbmdUYWJsZSogbV9hdG9taWNTdHJpbmdU YWJsZTsKQEAgLTEyNiw2ICsxMjYsNyBAQCBwcml2YXRlOgogI2lmIFVTRShKU0MpCiAgICAgSlND OjpJZGVudGlmaWVyVGFibGUqIG1fZGVmYXVsdElkZW50aWZpZXJUYWJsZTsKICAgICBKU0M6Oklk ZW50aWZpZXJUYWJsZSogbV9jdXJyZW50SWRlbnRpZmllclRhYmxlOworICAgIFN0YWNrQm91bmRz IG1fc3RhY2tCb3VuZHM7CiAjZW5kaWYKIAogI2lmIFdURlRIUkVBRERBVEFfTVVMVElUSFJFQURF RApAQCAtMTM1LDggKzEzNiw2IEBAIHByaXZhdGU6CiAjZW5kaWYKICAgICBmcmllbmQgV1RGVGhy ZWFkRGF0YSYgd3RmVGhyZWFkRGF0YSgpOwogICAgIGZyaWVuZCBjbGFzcyBBdG9taWNTdHJpbmdU YWJsZTsKLQotICAgIFN0YWNrQm91bmRzIG1fc3RhY2tCb3VuZHM7CiB9OwogCiBpbmxpbmUgV1RG VGhyZWFkRGF0YSYgd3RmVGhyZWFkRGF0YSgpCg==