51879 2011-01-04 10:29:55 -0800 [Symbian] Adobe flash Lite plugin on Symbian needs null window quirk 2022-02-28 03:58:31 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED P2 Normal --- 1 leonid.ebril leonid.ebril ademar commit-queue darin kenneth laszlo.gombos nancy.piedra webkit.review.bot oldest_to_newest 329047 0 leonid.ebril 2011-01-04 10:29:55 -0800 WebKit crash on Symbian if Adobe Flash Lite plugin (version 10) unloaded. The PluginQuirkDontSetNullWindowHandleOnDestroy needs to be set for the Adobe Flash Lite plugin on Symbian so the window does not get unset when destroying the plugin. Setting the PluginQuirkDontSetNullWindowHandleOnDestroy flag fixes the crash. 331667 1 78406 leonid.ebril 2011-01-10 09:57:44 -0800 Created attachment 78406 Patch for "Adobe flash Lite plugin on Symbian needs null window quirk" Set the PluginQuirkDontSetNullWindowHandleOnDestroy for Adobe Lite plugin if Flash 10 or newer (for Symbian platform), setting a NULL window handler on destroy crashes WebKit. 331670 2 webkit.review.bot 2011-01-10 10:00:55 -0800 Attachment 78406 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp']" exit_code: 1 Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp:58: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp:58: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp:71: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp:72: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp:72: Use 0 instead of NULL. [readability/null] [4] Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp:73: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Source/WebCore/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 9 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 331754 3 78406 eric 2011-01-10 11:29:28 -0800 Comment on attachment 78406 Patch for "Adobe flash Lite plugin on Symbian needs null window quirk" Please fix the style errors. 331779 4 laszlo.gombos 2011-01-10 11:46:08 -0800 > Source/WebCore/ChangeLog:5 > + https://bugs.webkit.org/show_bug.cgi?id=51879 Title for the bug is missing. Use "[Qt][Symbian]" as a prefix in the title as this issue is specific to the Symbian port of QtWebKit. > Source/WebCore/ChangeLog:7 > + Set the PluginQuirkDontSetNullWindowHandleOnDestroy for Adobe Lite Fix English - Setting a NULL window handler on destroy crashes Symbian port of QtWebKit, use PluginQuirkDontSetNullWindowHandleOnDestroy quirk for Adobe Flash Lite 4 (Flash 10 or newer). > Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp:58 > + determineQuirks (mime[0]); Perhaps make the call before "m_mimeToExtensions.add" line. I do not see a particular reason to call determineQuirks() between the two m_mimeToDescriptions.add.. lines. 331787 5 kenneth 2011-01-10 11:49:20 -0800 > Fix English - Setting a NULL window handler on destroy crashes Symbian port of QtWebKit, use PluginQuirkDontSetNullWindowHandleOnDestroy quirk for Adobe Flash Lite 4 (Flash 10 or newer). We should say null, not NULL. It is null/somethingNull in Qt API's and in C++0x it is called nullptr. 331788 6 78420 leonid.ebril 2011-01-10 11:51:25 -0800 Created attachment 78420 An updated version of the patch file 331790 7 webkit.review.bot 2011-01-10 11:52:50 -0800 Attachment 78420 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp']" exit_code: 1 Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp:58: Extra space before ( in function call [whitespace/parens] [4] Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp:72: Use 0 instead of NULL. [readability/null] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 331823 8 78427 leonid.ebril 2011-01-10 12:13:55 -0800 Created attachment 78427 Fixed check-webkit-style issues 331825 9 webkit.review.bot 2011-01-10 12:15:05 -0800 Attachment 78427 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp']" exit_code: 1 Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp:58: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 331827 10 78427 kenneth 2011-01-10 12:16:36 -0800 Comment on attachment 78427 Fixed check-webkit-style issues View in context: https://bugs.webkit.org/attachment.cgi?id=78427&action=review > Source/WebCore/ChangeLog:8 > + plugin if Flash 10 or newer (for Symbian platform), setting a NULL s/NULL/nulled/ > Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp:58 > + determineQuirks (mime[0]); no space needed before ( > Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp:70 > + static const PlatformModuleVersion flashTenVersion(0x000a0000); flashVersionTen seems more proper. > Source/WebCore/plugins/symbian/PluginPackageSymbian.cpp:72 > + // Flash 10 doesn't like having a 0 window handle comments need a dot at the end. ie. be proper sentences. 331852 11 78432 leonid.ebril 2011-01-10 12:49:25 -0800 Created attachment 78432 Modified files according to Kenneth Rohde Christiansen comments 331962 12 78432 commit-queue 2011-01-10 14:47:36 -0800 Comment on attachment 78432 Modified files according to Kenneth Rohde Christiansen comments Clearing flags on attachment: 78432 Committed r75439: <http://trac.webkit.org/changeset/75439> 332513 13 78420 laszlo.gombos 2011-01-11 11:58:08 -0800 Comment on attachment 78420 An updated version of the patch file Clearing review as a newer version of a patch has been committed. 332514 14 laszlo.gombos 2011-01-11 11:58:26 -0800 Changing the state as fix has been committed. 333043 15 ademar 2011-01-12 05:15:35 -0800 Revision r75439 cherry-picked into qtwebkit-2.2 with commit a32c088 <http://gitorious.org/webkit/qtwebkit/commit/a32c088> 78406 2011-01-10 09:57:44 -0800 2011-01-10 11:29:28 -0800 Patch for "Adobe flash Lite plugin on Symbian needs null window quirk" 51879.patch text/plain 1989 leonid.ebril SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc1MzgwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDEtMTAgIExlb25pZCBF YnJpbCAgPGxlb25pZC5lYnJpbEBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUxODc5CisJCisJU2V0IHRoZSBQbHVnaW5RdWlya0RvbnRTZXROdWxsV2luZG93SGFu ZGxlT25EZXN0cm95IGZvciBBZG9iZSBMaXRlICAKKyAgICAgICAgcGx1Z2luIGlmIEZsYXNoIDEw IG9yIG5ld2VyIChmb3IgU3ltYmlhbiBwbGF0Zm9ybSksIHNldHRpbmcgYSBOVUxMIAorCXdpbmRv dyBoYW5kbGVyIG9uIGRlc3Ryb3kgY3Jhc2hlcyBXZWJLaXQuCisKKyAgICAgICAgKiBwbHVnaW5z L3N5bWJpYW4vUGx1Z2luUGFja2FnZVN5bWJpYW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1 Z2luUGFja2FnZTo6ZmV0Y2hJbmZvKToKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblBhY2thZ2U6 OmRldGVybWluZVF1aXJrcyk6CisKIDIwMTEtMDEtMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8 Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNv bi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvc3ltYmlhbi9QbHVnaW5QYWNrYWdlU3lt Ymlhbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGx1Z2lucy9zeW1iaWFuL1Bs dWdpblBhY2thZ2VTeW1iaWFuLmNwcAkocmV2aXNpb24gNzUzNzgpCisrKyBTb3VyY2UvV2ViQ29y ZS9wbHVnaW5zL3N5bWJpYW4vUGx1Z2luUGFja2FnZVN5bWJpYW4uY3BwCSh3b3JraW5nIGNvcHkp CkBAIC01NSw2ICs1NSw3IEBAIGJvb2wgUGx1Z2luUGFja2FnZTo6ZmV0Y2hJbmZvKCkKICAgICAg ICAgICAgICAgICBtaW1lWzFdLnNwbGl0KFVDaGFyKCcsJyksIGZhbHNlLCBleHRzKTsgLy8gPGV4 dDEsZXh0MixleHQzLC4uLj4KICAgICAgICAgICAgIAogICAgICAgICAgICAgbV9taW1lVG9FeHRl bnNpb25zLmFkZChtaW1lWzBdLCBleHRzKTsgLy8gPE1JTUU+LDxleHQxLGV4dDIsZXh0Mz4KKwkg ICAgZGV0ZXJtaW5lUXVpcmtzIChtaW1lWzBdKTsKICAgICAgICAgICAgIGlmIChtaW1lLnNpemUo KSA+IDIpCiAgICAgICAgICAgICAgICAgbV9taW1lVG9EZXNjcmlwdGlvbnMuYWRkKG1pbWVbMF0s IG1pbWVbMl0pOyAvLyA8TUlNRT4sPERlc2NyaXB0aW9uPgogICAgICAgICB9CkBAIC02Myw2ICs2 NCwxNyBAQCBib29sIFBsdWdpblBhY2thZ2U6OmZldGNoSW5mbygpCiAgICAgcmV0dXJuIHRydWU7 CiB9CiAKK3ZvaWQgUGx1Z2luUGFja2FnZTo6ZGV0ZXJtaW5lUXVpcmtzKGNvbnN0IFN0cmluZyYg bWltZVR5cGUpCit7CisgICAgaWYgKG1pbWVUeXBlID09ICJhcHBsaWNhdGlvbi94LXNob2Nrd2F2 ZS1mbGFzaCIpIHsKKyAgICAgICAgc3RhdGljIGNvbnN0IFBsYXRmb3JtTW9kdWxlVmVyc2lvbiBm bGFzaFRlblZlcnNpb24oMHgwMDBhMDAwMCk7CisJaWYgKGNvbXBhcmVGaWxlVmVyc2lvbihmbGFz aFRlblZlcnNpb24pID49IDApIHsKKwkgICAgLy8gRmxhc2ggMTAgZG9lc24ndCBsaWtlIGhhdmlu ZyBhIE5VTEwgd2luZG93IGhhbmRsZQorCSAgICBtX3F1aXJrcy5hZGQoUGx1Z2luUXVpcmtEb250 U2V0TnVsbFdpbmRvd0hhbmRsZU9uRGVzdHJveSk7CisgICAgICAgIH0KKyAgICB9Cit9CisKIGJv b2wgUGx1Z2luUGFja2FnZTo6bG9hZCgpCiB7CiAgICAgaWYgKG1faXNMb2FkZWQpIHsK 78420 2011-01-10 11:51:25 -0800 2022-02-28 03:58:23 -0800 An updated version of the patch file 51879.patch text/plain 2030 leonid.ebril SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc1MzgwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDEtMTAgIExlb25pZCBF YnJpbCAgPGxlb25pZC5lYnJpbEBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUxODc5CisKKyAgICAgICAgU2V0IHRoZSBQbHVnaW5RdWlya0RvbnRTZXROdWxsV2lu ZG93SGFuZGxlT25EZXN0cm95IGZvciBBZG9iZSBMaXRlICAKKyAgICAgICAgcGx1Z2luIGlmIEZs YXNoIDEwIG9yIG5ld2VyIChmb3IgU3ltYmlhbiBwbGF0Zm9ybSksIHNldHRpbmcgYSBOVUxMIAor ICAgICAgICB3aW5kb3cgaGFuZGxlciBvbiBkZXN0cm95IGNyYXNoZXMgV2ViS2l0LgorCisgICAg ICAgICogcGx1Z2lucy9zeW1iaWFuL1BsdWdpblBhY2thZ2VTeW1iaWFuLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlBsdWdpblBhY2thZ2U6OmZldGNoSW5mbyk6CisgICAgICAgIChXZWJDb3JlOjpQ bHVnaW5QYWNrYWdlOjpkZXRlcm1pbmVRdWlya3MpOgorCiAyMDExLTAxLTEwICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBN YXJ0aW4gUm9iaW5zb24uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3N5bWJpYW4vUGx1 Z2luUGFja2FnZVN5bWJpYW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsdWdp bnMvc3ltYmlhbi9QbHVnaW5QYWNrYWdlU3ltYmlhbi5jcHAJKHJldmlzaW9uIDc1Mzc4KQorKysg U291cmNlL1dlYkNvcmUvcGx1Z2lucy9zeW1iaWFuL1BsdWdpblBhY2thZ2VTeW1iaWFuLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNTUsNiArNTUsNyBAQCBib29sIFBsdWdpblBhY2thZ2U6OmZldGNo SW5mbygpCiAgICAgICAgICAgICAgICAgbWltZVsxXS5zcGxpdChVQ2hhcignLCcpLCBmYWxzZSwg ZXh0cyk7IC8vIDxleHQxLGV4dDIsZXh0MywuLi4+CiAgICAgICAgICAgICAKICAgICAgICAgICAg IG1fbWltZVRvRXh0ZW5zaW9ucy5hZGQobWltZVswXSwgZXh0cyk7IC8vIDxNSU1FPiw8ZXh0MSxl eHQyLGV4dDM+CisgICAgICAgICAgICBkZXRlcm1pbmVRdWlya3MgKG1pbWVbMF0pOwogICAgICAg ICAgICAgaWYgKG1pbWUuc2l6ZSgpID4gMikKICAgICAgICAgICAgICAgICBtX21pbWVUb0Rlc2Ny aXB0aW9ucy5hZGQobWltZVswXSwgbWltZVsyXSk7IC8vIDxNSU1FPiw8RGVzY3JpcHRpb24+CiAg ICAgICAgIH0KQEAgLTYzLDYgKzY0LDE3IEBAIGJvb2wgUGx1Z2luUGFja2FnZTo6ZmV0Y2hJbmZv KCkKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAordm9pZCBQbHVnaW5QYWNrYWdlOjpkZXRlcm1pbmVR dWlya3MoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSkKK3sKKyAgICBpZiAobWltZVR5cGUgPT0gImFw cGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIikgeworICAgICAgICBzdGF0aWMgY29uc3QgUGxh dGZvcm1Nb2R1bGVWZXJzaW9uIGZsYXNoVGVuVmVyc2lvbigweDAwMGEwMDAwKTsKKyAgICAgICAg aWYgKGNvbXBhcmVGaWxlVmVyc2lvbihmbGFzaFRlblZlcnNpb24pID49IDApIHsKKyAgICAgICAg ICAgIC8vIEZsYXNoIDEwIGRvZXNuJ3QgbGlrZSBoYXZpbmcgYSBOVUxMIHdpbmRvdyBoYW5kbGUK KyAgICAgICAgICAgIG1fcXVpcmtzLmFkZChQbHVnaW5RdWlya0RvbnRTZXROdWxsV2luZG93SGFu ZGxlT25EZXN0cm95KTsKKyAgICAgICAgfQorICAgIH0KK30KKwogYm9vbCBQbHVnaW5QYWNrYWdl Ojpsb2FkKCkKIHsKICAgICBpZiAobV9pc0xvYWRlZCkgewo= 78427 2011-01-10 12:13:55 -0800 2022-02-28 03:58:31 -0800 Fixed check-webkit-style issues 51879.patch text/plain 2027 leonid.ebril SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc1MzgwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDEtMTAgIExlb25pZCBF YnJpbCAgPGxlb25pZC5lYnJpbEBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUxODc5CisKKyAgICAgICAgU2V0IHRoZSBQbHVnaW5RdWlya0RvbnRTZXROdWxsV2lu ZG93SGFuZGxlT25EZXN0cm95IGZvciBBZG9iZSBMaXRlICAKKyAgICAgICAgcGx1Z2luIGlmIEZs YXNoIDEwIG9yIG5ld2VyIChmb3IgU3ltYmlhbiBwbGF0Zm9ybSksIHNldHRpbmcgYSBOVUxMIAor ICAgICAgICB3aW5kb3cgaGFuZGxlciBvbiBkZXN0cm95IGNyYXNoZXMgV2ViS2l0LgorCisgICAg ICAgICogcGx1Z2lucy9zeW1iaWFuL1BsdWdpblBhY2thZ2VTeW1iaWFuLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlBsdWdpblBhY2thZ2U6OmZldGNoSW5mbyk6CisgICAgICAgIChXZWJDb3JlOjpQ bHVnaW5QYWNrYWdlOjpkZXRlcm1pbmVRdWlya3MpOgorCiAyMDExLTAxLTEwICBDYXJsb3MgR2Fy Y2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBN YXJ0aW4gUm9iaW5zb24uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3N5bWJpYW4vUGx1 Z2luUGFja2FnZVN5bWJpYW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsdWdp bnMvc3ltYmlhbi9QbHVnaW5QYWNrYWdlU3ltYmlhbi5jcHAJKHJldmlzaW9uIDc1Mzc4KQorKysg U291cmNlL1dlYkNvcmUvcGx1Z2lucy9zeW1iaWFuL1BsdWdpblBhY2thZ2VTeW1iaWFuLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNTUsNiArNTUsNyBAQCBib29sIFBsdWdpblBhY2thZ2U6OmZldGNo SW5mbygpCiAgICAgICAgICAgICAgICAgbWltZVsxXS5zcGxpdChVQ2hhcignLCcpLCBmYWxzZSwg ZXh0cyk7IC8vIDxleHQxLGV4dDIsZXh0MywuLi4+CiAgICAgICAgICAgICAKICAgICAgICAgICAg IG1fbWltZVRvRXh0ZW5zaW9ucy5hZGQobWltZVswXSwgZXh0cyk7IC8vIDxNSU1FPiw8ZXh0MSxl eHQyLGV4dDM+CisgICAgICAgICAgICBkZXRlcm1pbmVRdWlya3MgKG1pbWVbMF0pOwogICAgICAg ICAgICAgaWYgKG1pbWUuc2l6ZSgpID4gMikKICAgICAgICAgICAgICAgICBtX21pbWVUb0Rlc2Ny aXB0aW9ucy5hZGQobWltZVswXSwgbWltZVsyXSk7IC8vIDxNSU1FPiw8RGVzY3JpcHRpb24+CiAg ICAgICAgIH0KQEAgLTYzLDYgKzY0LDE3IEBAIGJvb2wgUGx1Z2luUGFja2FnZTo6ZmV0Y2hJbmZv KCkKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAordm9pZCBQbHVnaW5QYWNrYWdlOjpkZXRlcm1pbmVR dWlya3MoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSkKK3sKKyAgICBpZiAobWltZVR5cGUgPT0gImFw cGxpY2F0aW9uL3gtc2hvY2t3YXZlLWZsYXNoIikgeworICAgICAgICBzdGF0aWMgY29uc3QgUGxh dGZvcm1Nb2R1bGVWZXJzaW9uIGZsYXNoVGVuVmVyc2lvbigweDAwMGEwMDAwKTsKKyAgICAgICAg aWYgKGNvbXBhcmVGaWxlVmVyc2lvbihmbGFzaFRlblZlcnNpb24pID49IDApIHsKKyAgICAgICAg ICAgIC8vIEZsYXNoIDEwIGRvZXNuJ3QgbGlrZSBoYXZpbmcgYSAwIHdpbmRvdyBoYW5kbGUKKyAg ICAgICAgICAgIG1fcXVpcmtzLmFkZChQbHVnaW5RdWlya0RvbnRTZXROdWxsV2luZG93SGFuZGxl T25EZXN0cm95KTsKKyAgICAgICAgfQorICAgIH0KK30KKwogYm9vbCBQbHVnaW5QYWNrYWdlOjps b2FkKCkKIHsKICAgICBpZiAobV9pc0xvYWRlZCkgewo= 78432 2011-01-10 12:49:25 -0800 2011-01-10 14:47:35 -0800 Modified files according to Kenneth Rohde Christiansen comments 51879.patch text/plain 2016 leonid.ebril SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDc1MzgwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDEtMTAgIExlb25pZCBF YnJpbCAgPGxlb25pZC5lYnJpbEBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUxODc5CisKKyAgICAgICAgU2V0IHRoZSBQbHVnaW5RdWlya0RvbnRTZXROdWxsV2lu ZG93SGFuZGxlT25EZXN0cm95IGZvciBBZG9iZSBMaXRlICAKKyAgICAgICAgcGx1Z2luIGlmIEZs YXNoIDEwIG9yIG5ld2VyIChmb3IgU3ltYmlhbiBwbGF0Zm9ybSksIHNldHRpbmcgYSBudWxsZWQg CisgICAgICAgIHdpbmRvdyBoYW5kbGVyIG9uIGRlc3Ryb3kgY3Jhc2hlcyBXZWJLaXQuCisKKyAg ICAgICAgKiBwbHVnaW5zL3N5bWJpYW4vUGx1Z2luUGFja2FnZVN5bWJpYW4uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UGx1Z2luUGFja2FnZTo6ZmV0Y2hJbmZvKToKKyAgICAgICAgKFdlYkNvcmU6 OlBsdWdpblBhY2thZ2U6OmRldGVybWluZVF1aXJrcyk6CisKIDIwMTEtMDEtMTAgIENhcmxvcyBH YXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IE1hcnRpbiBSb2JpbnNvbi4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvc3ltYmlhbi9Q bHVnaW5QYWNrYWdlU3ltYmlhbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGx1 Z2lucy9zeW1iaWFuL1BsdWdpblBhY2thZ2VTeW1iaWFuLmNwcAkocmV2aXNpb24gNzUzNzgpCisr KyBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3N5bWJpYW4vUGx1Z2luUGFja2FnZVN5bWJpYW4uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC01NSw2ICs1NSw3IEBAIGJvb2wgUGx1Z2luUGFja2FnZTo6ZmV0 Y2hJbmZvKCkKICAgICAgICAgICAgICAgICBtaW1lWzFdLnNwbGl0KFVDaGFyKCcsJyksIGZhbHNl LCBleHRzKTsgLy8gPGV4dDEsZXh0MixleHQzLC4uLj4KICAgICAgICAgICAgIAogICAgICAgICAg ICAgbV9taW1lVG9FeHRlbnNpb25zLmFkZChtaW1lWzBdLCBleHRzKTsgLy8gPE1JTUU+LDxleHQx LGV4dDIsZXh0Mz4KKyAgICAgICAgICAgIGRldGVybWluZVF1aXJrcyhtaW1lWzBdKTsKICAgICAg ICAgICAgIGlmIChtaW1lLnNpemUoKSA+IDIpCiAgICAgICAgICAgICAgICAgbV9taW1lVG9EZXNj cmlwdGlvbnMuYWRkKG1pbWVbMF0sIG1pbWVbMl0pOyAvLyA8TUlNRT4sPERlc2NyaXB0aW9uPgog ICAgICAgICB9CkBAIC02Myw2ICs2NCwxNyBAQCBib29sIFBsdWdpblBhY2thZ2U6OmZldGNoSW5m bygpCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKK3ZvaWQgUGx1Z2luUGFja2FnZTo6ZGV0ZXJtaW5l UXVpcmtzKGNvbnN0IFN0cmluZyYgbWltZVR5cGUpCit7CisgICAgaWYgKG1pbWVUeXBlID09ICJh cHBsaWNhdGlvbi94LXNob2Nrd2F2ZS1mbGFzaCIpIHsKKyAgICAgICAgUGxhdGZvcm1Nb2R1bGVW ZXJzaW9uIGZsYXNoVGVuVmVyc2lvbigweDAwMGEwMDAwKTsKKyAgICAgICAgaWYgKGNvbXBhcmVG aWxlVmVyc2lvbihmbGFzaFRlblZlcnNpb24pID49IDApIHsKKyAgICAgICAgICAgIC8vIEZsYXNo IDEwIGRvZXNuJ3QgbGlrZSBoYXZpbmcgYSAwIHdpbmRvdyBoYW5kbGUuCisgICAgICAgICAgICBt X3F1aXJrcy5hZGQoUGx1Z2luUXVpcmtEb250U2V0TnVsbFdpbmRvd0hhbmRsZU9uRGVzdHJveSk7 CisgICAgICAgIH0KKyAgICB9Cit9CisKIGJvb2wgUGx1Z2luUGFja2FnZTo6bG9hZCgpCiB7CiAg ICAgaWYgKG1faXNMb2FkZWQpIHsK