<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>51866</bug_id>
          
          <creation_ts>2011-01-03 21:14:29 -0800</creation_ts>
          <short_desc>Use __builtin_expect when compiling using RVCT in GNU mode</short_desc>
          <delta_ts>2011-01-10 16:52:01 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Template Framework</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Daniel Bates">dbates</reporter>
          <assigned_to name="Siddharth Mathur">s.mathur</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>joybro201</cc>
    
    <cc>koshuin</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>skyul</cc>
    
    <cc>s.mathur</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>328889</commentid>
    <comment_count>0</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-01-03 21:14:29 -0800</bug_when>
    <thetext>When in GNU mode, RVCT supports the GNU language intrinsic __builtin_expect, which is used to provide the compiler with branch prediction information. We should favor using this intrinsic if we are compiling with RVCT in GNU mode (i.e. COMPILER(RVCT) &amp;&amp; defined(__GNUC__)).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>328890</commentid>
    <comment_count>1</comment_count>
      <attachid>77867</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-01-03 21:20:05 -0800</bug_when>
    <thetext>Created attachment 77867
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>328892</commentid>
    <comment_count>2</comment_count>
      <attachid>77867</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2011-01-03 21:29:07 -0800</bug_when>
    <thetext>Comment on attachment 77867
Patch

OK</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>329005</commentid>
    <comment_count>3</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2011-01-04 08:47:33 -0800</bug_when>
    <thetext>Looks good to me too. A simpler way to express this is to test for defined(__GNUC__), instead of &quot;COMPILER(GCC) || (COMPILER(RVCT) &amp;&amp; defined(__GNUC__))&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>329021</commentid>
    <comment_count>4</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-01-04 09:31:00 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; Looks good to me too. A simpler way to express this is to test for defined(__GNUC__), instead of &quot;COMPILER(GCC) || (COMPILER(RVCT) &amp;&amp; defined(__GNUC__))&quot;.

Will change before I land.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>329026</commentid>
    <comment_count>5</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-01-04 09:44:51 -0800</bug_when>
    <thetext>Committed r74973: &lt;http://trac.webkit.org/changeset/74973&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331816</commentid>
    <comment_count>6</comment_count>
      <attachid>78423</attachid>
    <who name="Siddharth Mathur">s.mathur</who>
    <bug_when>2011-01-10 12:08:33 -0800</bug_when>
    <thetext>Created attachment 78423
Exclude RVCT2.2 from using this intrinsic

According to ARM&apos;s documentation (http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0202h/Cjabddedbde.html), this GNU-style intrinsic is only available with RVCT 3 and later , so exclude previous major version from using it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331820</commentid>
    <comment_count>7</comment_count>
      <attachid>78425</attachid>
    <who name="Siddharth Mathur">s.mathur</who>
    <bug_when>2011-01-10 12:11:20 -0800</bug_when>
    <thetext>Created attachment 78425
Same patch as above, but with Changelog format issue corrected.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331916</commentid>
    <comment_count>8</comment_count>
      <attachid>78425</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-01-10 13:50:40 -0800</bug_when>
    <thetext>Comment on attachment 78425
Same patch as above, but with Changelog format issue corrected. 

rs=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331917</commentid>
    <comment_count>9</comment_count>
      <attachid>77867</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2011-01-10 13:51:19 -0800</bug_when>
    <thetext>Comment on attachment 77867
Patch

I&apos;m confused by the status of this bug.  Did this get landed?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331931</commentid>
    <comment_count>10</comment_count>
    <who name="Siddharth Mathur">s.mathur</who>
    <bug_when>2011-01-10 14:03:14 -0800</bug_when>
    <thetext>(In reply to comment #9)
&gt; (From update of attachment 77867 [details])
&gt; I&apos;m confused by the status of this bug.  Did this get landed?

Sorry Eric for the confusion. I reopened a previously closed bug (manually landed by Daniel Bates) to add an amendment, which you just r+ed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331950</commentid>
    <comment_count>11</comment_count>
      <attachid>78425</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-01-10 14:36:20 -0800</bug_when>
    <thetext>Comment on attachment 78425
Same patch as above, but with Changelog format issue corrected. 

Why are we hardcoding __ARMCC_2_2__ instead of checking __ARMCC_VERSION &gt;= 300000?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331953</commentid>
    <comment_count>12</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-01-10 14:37:49 -0800</bug_when>
    <thetext>(In reply to comment #11)
&gt; (From update of attachment 78425 [details])
&gt; Why are we hardcoding __ARMCC_2_2__ instead of checking __ARMCC_VERSION &gt;= 300000?

I mean checking that __ARMCC_VERSION &lt;= 300000</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331976</commentid>
    <comment_count>13</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-01-10 15:05:33 -0800</bug_when>
    <thetext>(In reply to comment #12)
&gt; (In reply to comment #11)
&gt; &gt; (From update of attachment 78425 [details] [details])
&gt; &gt; Why are we hardcoding __ARMCC_2_2__ instead of checking __ARMCC_VERSION &gt;= 300000?
&gt; 
&gt; I mean checking that __ARMCC_VERSION &lt;= 300000

Disregard this comment. The inequality in the previous comment (comment 11) was correct. That is, we should change the check from:

#if defined(__GNUC__)

to

#if COMPILER(GCC) || (COMPILER(RVCT) &amp;&amp; defined(__GNUC__) &amp;&amp; __ARMCC_VERSION &gt;= 300000)

so that we only use __builtin_expect if we are compiling with GCC or compiling with RVCT version 3.0 or higher in GNU mode.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>331999</commentid>
    <comment_count>14</comment_count>
      <attachid>78461</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-01-10 15:37:35 -0800</bug_when>
    <thetext>Created attachment 78461
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>332002</commentid>
    <comment_count>15</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-01-10 15:39:40 -0800</bug_when>
    <thetext>Attachment 78461 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Source/JavaScriptCore/ChangeLog&apos;, u&apos;Source...&quot; exit_code: 1
Source/JavaScriptCore/wtf/Platform.h:1016:  Missing space after ,  [whitespace/comma] [3]
Source/JavaScriptCore/wtf/AlwaysInline.h:44:  Missing space after ,  [whitespace/comma] [3]
Source/JavaScriptCore/wtf/AlwaysInline.h:52:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>332003</commentid>
    <comment_count>16</comment_count>
      <attachid>78461</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2011-01-10 15:40:35 -0800</bug_when>
    <thetext>Comment on attachment 78461
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=78461&amp;action=review

&gt; Source/JavaScriptCore/wtf/Platform.h:79
&gt; +/* Define this for !RVCT compilers, just so we can write things like COMPILER(RVCT) &amp;&amp; RVCT_VERSION_AT_LEAST(3,0,0,0). */

It occurs to me that this means that you could always just use RVCT_VERSION_AT_LEAST(3,0,0,0) without COMPILER(RVCT); maybe we should.

&gt; Source/JavaScriptCore/wtf/Platform.h:91
&gt; -/* define this for !GCC compilers, just so we can write things like COMPILER(GCC) &amp;&amp; GCC_VERSION_AT_LEAST(4,1,0) */
&gt; +/* Define this for !GCC compilers, just so we can write things like COMPILER(GCC) &amp;&amp; GCC_VERSION_AT_LEAST(4,1,0). */
&gt;  #define GCC_VERSION_AT_LEAST(major, minor, patch) 0

It occurs to me that this means that you could always just use GCC_VERSION_AT_LEAST(3,0,0,0) without COMPILER(GCC); maybe we should.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>332021</commentid>
    <comment_count>17</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-01-10 16:03:44 -0800</bug_when>
    <thetext>(In reply to comment #16)
&gt; (From update of attachment 78461 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=78461&amp;action=review
&gt; 
&gt; &gt; Source/JavaScriptCore/wtf/Platform.h:79
&gt; &gt; +/* Define this for !RVCT compilers, just so we can write things like COMPILER(RVCT) &amp;&amp; RVCT_VERSION_AT_LEAST(3,0,0,0). */
&gt; 
&gt; It occurs to me that this means that you could always just use RVCT_VERSION_AT_LEAST(3,0,0,0) without COMPILER(RVCT); maybe we should.

Correct. Will change both comment and callsites before landing.

&gt; 
&gt; &gt; Source/JavaScriptCore/wtf/Platform.h:91
&gt; &gt; -/* define this for !GCC compilers, just so we can write things like COMPILER(GCC) &amp;&amp; GCC_VERSION_AT_LEAST(4,1,0) */
&gt; &gt; +/* Define this for !GCC compilers, just so we can write things like COMPILER(GCC) &amp;&amp; GCC_VERSION_AT_LEAST(4,1,0). */
&gt; &gt;  #define GCC_VERSION_AT_LEAST(major, minor, patch) 0
&gt; 
&gt; It occurs to me that this means that you could always just use GCC_VERSION_AT_LEAST(3,0,0,0) without COMPILER(GCC); maybe we should.

Correct. Will change comment before landing. I suggest that we update the callsites in a separate bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>332030</commentid>
    <comment_count>18</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-01-10 16:18:21 -0800</bug_when>
    <thetext>Committed r75447: &lt;http://trac.webkit.org/changeset/75447&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>332048</commentid>
    <comment_count>19</comment_count>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2011-01-10 16:52:01 -0800</bug_when>
    <thetext>(In reply to comment #17)
&gt; (In reply to comment #16)
&gt; &gt; It occurs to me that this means that you could always just use GCC_VERSION_AT_LEAST(3,0,0,0) without COMPILER(GCC); maybe we should.
&gt; 
&gt; Correct. Will change comment before landing. I suggest that we update the callsites in a separate bug.

Filed bug #52178 for this and decided to make the comment change in the patch for this bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>77867</attachid>
            <date>2011-01-03 21:20:05 -0800</date>
            <delta_ts>2011-01-10 13:51:18 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>Bug51866.patch</filename>
            <type>text/plain</type>
            <size>1239</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzQ5NTQpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAK
KzIwMTEtMDEtMDMgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBfX2J1aWx0aW5fZXhwZWN0
IHdoZW4gY29tcGlsaW5nIHVzaW5nIFJWQ1QgaW4gR05VIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxODY2CisKKyAgICAgICAgRGVyaXZlZCBm
cm9tIGEgcGF0Y2ggYnkgRGF2ZSBUYXB1c2thLgorCisgICAgICAgICogd3RmL0Fsd2F5c0lubGlu
ZS5oOgorCiAyMDExLTAxLTAzICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAg
ICAgICBSZXZpZXdlZCBieSBCcmFkeSBFaWRzb24uCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv
cmUvd3RmL0Fsd2F5c0lubGluZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y
ZS93dGYvQWx3YXlzSW5saW5lLmgJKHJldmlzaW9uIDc0ODk2KQorKysgU291cmNlL0phdmFTY3Jp
cHRDb3JlL3d0Zi9BbHdheXNJbmxpbmUuaAkod29ya2luZyBjb3B5KQpAQCAtNDEsNyArNDEsNyBA
QAogI2VuZGlmCiAKICNpZm5kZWYgVU5MSUtFTFkKLSNpZiBDT01QSUxFUihHQ0MpCisjaWYgQ09N
UElMRVIoR0NDKSB8fCAoQ09NUElMRVIoUlZDVCkgJiYgZGVmaW5lZChfX0dOVUNfXykpCiAjZGVm
aW5lIFVOTElLRUxZKHgpIF9fYnVpbHRpbl9leHBlY3QoKHgpLCAwKQogI2Vsc2UKICNkZWZpbmUg
VU5MSUtFTFkoeCkgKHgpCkBAIC00OSw3ICs0OSw3IEBACiAjZW5kaWYKIAogI2lmbmRlZiBMSUtF
TFkKLSNpZiBDT01QSUxFUihHQ0MpCisjaWYgQ09NUElMRVIoR0NDKSB8fCAoQ09NUElMRVIoUlZD
VCkgJiYgZGVmaW5lZChfX0dOVUNfXykpCiAjZGVmaW5lIExJS0VMWSh4KSBfX2J1aWx0aW5fZXhw
ZWN0KCh4KSwgMSkKICNlbHNlCiAjZGVmaW5lIExJS0VMWSh4KSAoeCkK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>78423</attachid>
            <date>2011-01-10 12:08:33 -0800</date>
            <delta_ts>2011-01-10 12:11:20 -0800</delta_ts>
            <desc>Exclude RVCT2.2 from using this intrinsic</desc>
            <filename>51866_sm.patch</filename>
            <type>text/plain</type>
            <size>1183</size>
            <attacher name="Siddharth Mathur">s.mathur</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQWx3YXlzSW5saW5lLmgKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9BbHdheXNJbmxpbmUuaAkocmV2aXNpb24g
NzUzODEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Fsd2F5c0lubGluZS5oCSh3b3Jr
aW5nIGNvcHkpCkBAIC00MSw3ICs0MSw3IEBACiAjZW5kaWYKIAogI2lmbmRlZiBVTkxJS0VMWQot
I2lmIGRlZmluZWQoX19HTlVDX18pCisjaWYgZGVmaW5lZChfX0dOVUNfXykgJiYgIWRlZmluZWQo
X19BUk1DQ18yXzJfXykKICNkZWZpbmUgVU5MSUtFTFkoeCkgX19idWlsdGluX2V4cGVjdCgoeCks
IDApCiAjZWxzZQogI2RlZmluZSBVTkxJS0VMWSh4KSAoeCkKQEAgLTQ5LDcgKzQ5LDcgQEAKICNl
bmRpZgogCiAjaWZuZGVmIExJS0VMWQotI2lmIGRlZmluZWQoX19HTlVDX18pCisjaWYgZGVmaW5l
ZChfX0dOVUNfXykgJiYgIWRlZmluZWQoX19BUk1DQ18yXzJfXykKICNkZWZpbmUgTElLRUxZKHgp
IF9fYnVpbHRpbl9leHBlY3QoKHgpLCAxKQogI2Vsc2UKICNkZWZpbmUgTElLRUxZKHgpICh4KQpJ
bmRleDogU291cmNlL0phdmFzY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy
Y2UvSmF2YXNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA3NTM4MykKKysrIFNvdXJjZS9K
YXZhc2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAor
MjAxMS0wMS0xMCAgU2lkZGhhcnRoIE1hdGh1ciAgPHNpZGRoYXJ0aC5tYXRodXJAbm9raWEuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBf
X2J1aWx0aW5fZXhwZWN0IGZvciBSVkNUIDMgYW5kIGhpZ2hlciBvbmx5CisJaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxODY2CisKKyAgICAgICAgKiB3dGYvQWx3YXlz
SW5saW5lLmg6CisKIDIwMTEtMDEtMDggIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtp
dC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>78425</attachid>
            <date>2011-01-10 12:11:20 -0800</date>
            <delta_ts>2011-01-10 15:37:35 -0800</delta_ts>
            <desc>Same patch as above, but with Changelog format issue corrected. </desc>
            <filename>51866_sm.patch</filename>
            <type>text/plain</type>
            <size>1190</size>
            <attacher name="Siddharth Mathur">s.mathur</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQWx3YXlzSW5saW5lLmgKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9BbHdheXNJbmxpbmUuaAkocmV2aXNpb24g
NzUzODEpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Fsd2F5c0lubGluZS5oCSh3b3Jr
aW5nIGNvcHkpCkBAIC00MSw3ICs0MSw3IEBACiAjZW5kaWYKIAogI2lmbmRlZiBVTkxJS0VMWQot
I2lmIGRlZmluZWQoX19HTlVDX18pCisjaWYgZGVmaW5lZChfX0dOVUNfXykgJiYgIWRlZmluZWQo
X19BUk1DQ18yXzJfXykKICNkZWZpbmUgVU5MSUtFTFkoeCkgX19idWlsdGluX2V4cGVjdCgoeCks
IDApCiAjZWxzZQogI2RlZmluZSBVTkxJS0VMWSh4KSAoeCkKQEAgLTQ5LDcgKzQ5LDcgQEAKICNl
bmRpZgogCiAjaWZuZGVmIExJS0VMWQotI2lmIGRlZmluZWQoX19HTlVDX18pCisjaWYgZGVmaW5l
ZChfX0dOVUNfXykgJiYgIWRlZmluZWQoX19BUk1DQ18yXzJfXykKICNkZWZpbmUgTElLRUxZKHgp
IF9fYnVpbHRpbl9leHBlY3QoKHgpLCAxKQogI2Vsc2UKICNkZWZpbmUgTElLRUxZKHgpICh4KQpJ
bmRleDogU291cmNlL0phdmFzY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy
Y2UvSmF2YXNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA3NTM4MykKKysrIFNvdXJjZS9K
YXZhc2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAor
MjAxMS0wMS0xMCAgU2lkZGhhcnRoIE1hdGh1ciAgPHNpZGRoYXJ0aC5tYXRodXJAbm9raWEuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBf
X2J1aWx0aW5fZXhwZWN0IGZvciBSVkNUIDMgYW5kIGhpZ2hlciBvbmx5CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTg2NgorCisgICAgICAgICogd3Rm
L0Fsd2F5c0lubGluZS5oOgorCiAyMDExLTAxLTA4ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9n
YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgo=
</data>
<flag name="review"
          id="69737"
          type_id="1"
          status="-"
          setter="dbates"
    />
    <flag name="commit-queue"
          id="69760"
          type_id="3"
          status="-"
          setter="dbates"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>78461</attachid>
            <date>2011-01-10 15:37:35 -0800</date>
            <delta_ts>2011-01-10 15:40:35 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>Bug51866_1.patch</filename>
            <type>text/plain</type>
            <size>3497</size>
            <attacher name="Daniel Bates">dbates</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNzU0NDEpCisrKyBTb3VyY2Uv
SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAK
KzIwMTEtMDEtMTAgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBfX2J1aWx0aW5fZXhwZWN0
IHdoZW4gY29tcGlsaW5nIHVzaW5nIFJWQ1QgaW4gR05VIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxODY2CisKKyAgICAgICAgV2Ugc2hvdWxk
IG9ubHkgdXNlIF9fYnVpbHRpbl9leHBlY3QgaWYgd2UgYXJlIGNvbXBpbGluZyB3aXRoIEdDQyBv
ciBSVkNUIDMgb3IgaGlnaGVyIGluIEdOVSBtb2RlCisgICAgICAgIGFzIHBvaW50ZWQgb3V0IGJ5
IFNpZGRoYXJ0aCBNYXRodXIgcGVyIDxodHRwOi8vaW5mb2NlbnRlci5hcm0uY29tL2hlbHAvaW5k
ZXguanNwP3RvcGljPS9jb20uYXJtLmRvYy5kdWkwMjAyaC9DamFiZGRlZGJkZS5odG1sPi4KKwor
ICAgICAgICAqIHd0Zi9BbHdheXNJbmxpbmUuaDoKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDog
UmVtb3ZlZCBkZWZpbmUgV1RGX0NPTVBJTEVSX1JWQ1Q0X09SX0dSRUFURVIuIEluc3RlYWQgYWRk
ZWQgbWFjcm8KKyAgICAgICAgZnVuY3Rpb24gUlZDVF9WRVJTSU9OX0FUX0xFQVNUIHNvIHRoYXQg
d2UgY2FuIHRlc3QgZm9yIGFuIGFyYml0cmFyeSBtaW5pbXVtIFJWQ1QKKyAgICAgICAgdmVyc2lv
bi4gQWxzbywgbWFkZSB0aGUgY29tbWVudCBhYm92ZSB0aGUgI2RlZmluZSBHQ0NfVkVSU0lPTl9B
VF9MRUFTVCguLi4pIGEgZnVsbCBzZW50ZW5jZS4KKwogMjAxMS0wMS0xMCAgWGFuIExvcGV6ICA8
eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2F2aW4gQmFycmFjbG91
Z2guCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL0Fsd2F5c0lubGluZS5oCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvQWx3YXlzSW5saW5lLmgJKHJldmlz
aW9uIDc1NDI4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9BbHdheXNJbmxpbmUuaAko
d29ya2luZyBjb3B5KQpAQCAtNDEsNyArNDEsNyBAQAogI2VuZGlmCiAKICNpZm5kZWYgVU5MSUtF
TFkKLSNpZiBkZWZpbmVkKF9fR05VQ19fKQorI2lmIENPTVBJTEVSKEdDQykgfHwgKENPTVBJTEVS
KFJWQ1QpICYmIFJWQ1RfVkVSU0lPTl9BVF9MRUFTVCgzLDAsMCwwKSAmJiBkZWZpbmVkKF9fR05V
Q19fKSkKICNkZWZpbmUgVU5MSUtFTFkoeCkgX19idWlsdGluX2V4cGVjdCgoeCksIDApCiAjZWxz
ZQogI2RlZmluZSBVTkxJS0VMWSh4KSAoeCkKQEAgLTQ5LDcgKzQ5LDcgQEAKICNlbmRpZgogCiAj
aWZuZGVmIExJS0VMWQotI2lmIGRlZmluZWQoX19HTlVDX18pCisjaWYgQ09NUElMRVIoR0NDKSB8
fCAoQ09NUElMRVIoUlZDVCkgJiYgUlZDVF9WRVJTSU9OX0FUX0xFQVNUKDMsMCwwLDApICYmIGRl
ZmluZWQoX19HTlVDX18pKQogI2RlZmluZSBMSUtFTFkoeCkgX19idWlsdGluX2V4cGVjdCgoeCks
IDEpCiAjZWxzZQogI2RlZmluZSBMSUtFTFkoeCkgKHgpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw
dENvcmUvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl
L3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiA3NTQyOCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y
ZS93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtNzQsOSArNzQsMTAgQEAKIC8qIENP
TVBJTEVSKFJWQ1Q0X09SX0dSRUFURVIpIC0gQVJNIFJlYWxWaWV3IENvbXBpbGF0aW9uIFRvb2xz
IDQuMCBvciBncmVhdGVyICovCiAjaWYgZGVmaW5lZChfX0NDX0FSTSkgfHwgZGVmaW5lZChfX0FS
TUNDX18pCiAjZGVmaW5lIFdURl9DT01QSUxFUl9SVkNUIDEKLSNpZiBfX0FSTUNDX1ZFUlNJT04g
Pj0gNDAwMDAwCi0jZGVmaW5lIFdURl9DT01QSUxFUl9SVkNUNF9PUl9HUkVBVEVSIDEKLSNlbmRp
ZgorI2RlZmluZSBSVkNUX1ZFUlNJT05fQVRfTEVBU1QobWFqb3IsIG1pbm9yLCBwYXRjaCwgYnVp
bGQpIChfX0FSTUNDX1ZFUlNJT04gPj0gKG1ham9yICogMTAwMDAwICsgbWlub3IgKiAxMDAwMCAr
IHBhdGNoICogMTAwMCArIGJ1aWxkKSkKKyNlbHNlCisvKiBEZWZpbmUgdGhpcyBmb3IgIVJWQ1Qg
Y29tcGlsZXJzLCBqdXN0IHNvIHdlIGNhbiB3cml0ZSB0aGluZ3MgbGlrZSBDT01QSUxFUihSVkNU
KSAmJiBSVkNUX1ZFUlNJT05fQVRfTEVBU1QoMywwLDAsMCkuICovCisjZGVmaW5lIFJWQ1RfVkVS
U0lPTl9BVF9MRUFTVChtYWpvciwgbWlub3IsIHBhdGNoLCBidWlsZCkgMAogI2VuZGlmCiAKIC8q
IENPTVBJTEVSKEdDQykgLSBHTlUgQ29tcGlsZXIgQ29sbGVjdGlvbiAqLwpAQCAtODYsNyArODcs
NyBAQAogI2RlZmluZSBHQ0NfVkVSU0lPTiAoX19HTlVDX18gKiAxMDAwMCArIF9fR05VQ19NSU5P
Ul9fICogMTAwICsgX19HTlVDX1BBVENITEVWRUxfXykKICNkZWZpbmUgR0NDX1ZFUlNJT05fQVRf
TEVBU1QobWFqb3IsIG1pbm9yLCBwYXRjaCkgKEdDQ19WRVJTSU9OID49IChtYWpvciAqIDEwMDAw
ICsgbWlub3IgKiAxMDAgKyBwYXRjaCkpCiAjZWxzZQotLyogZGVmaW5lIHRoaXMgZm9yICFHQ0Mg
Y29tcGlsZXJzLCBqdXN0IHNvIHdlIGNhbiB3cml0ZSB0aGluZ3MgbGlrZSBDT01QSUxFUihHQ0Mp
ICYmIEdDQ19WRVJTSU9OX0FUX0xFQVNUKDQsMSwwKSAqLworLyogRGVmaW5lIHRoaXMgZm9yICFH
Q0MgY29tcGlsZXJzLCBqdXN0IHNvIHdlIGNhbiB3cml0ZSB0aGluZ3MgbGlrZSBDT01QSUxFUihH
Q0MpICYmIEdDQ19WRVJTSU9OX0FUX0xFQVNUKDQsMSwwKS4gKi8KICNkZWZpbmUgR0NDX1ZFUlNJ
T05fQVRfTEVBU1QobWFqb3IsIG1pbm9yLCBwYXRjaCkgMAogI2VuZGlmCiAKQEAgLTEwMTIsNyAr
MTAxMyw3IEBACiAjZW5kaWYKIAogLyogQ29uZmlndXJlIHRoZSBpbnRlcnByZXRlciAqLwotI2lm
IENPTVBJTEVSKEdDQykgfHwgKENPTVBJTEVSKFJWQ1Q0X09SX0dSRUFURVIpICYmIGRlZmluZWQo
X19HTlVDX18pKQorI2lmIENPTVBJTEVSKEdDQykgfHwgKENPTVBJTEVSKFJWQ1QpICYmIFJWQ1Rf
VkVSU0lPTl9BVF9MRUFTVCg0LDAsMCwwKSAmJiBkZWZpbmVkKF9fR05VQ19fKSkKICNkZWZpbmUg
SEFWRV9DT01QVVRFRF9HT1RPIDEKICNlbmRpZgogI2lmIEhBVkUoQ09NUFVURURfR09UTykgJiYg
RU5BQkxFKElOVEVSUFJFVEVSKQo=
</data>
<flag name="review"
          id="69780"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>