51849 2011-01-03 13:35:51 -0800 InsertTextCommand::m_charactersAdded is unused 2011-01-03 16:41:06 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 darin darin abarth commit-queue eric webkit.review.bot oldest_to_newest 328754 0 darin 2011-01-03 13:35:51 -0800 Noticed an unused data member. 328756 1 77841 darin 2011-01-03 13:36:53 -0800 Created attachment 77841 Patch 328820 2 77841 commit-queue 2011-01-03 16:09:28 -0800 Comment on attachment 77841 Patch Clearing flags on attachment: 77841 Committed r74946: <http://trac.webkit.org/changeset/74946> 328821 3 commit-queue 2011-01-03 16:09:33 -0800 All reviewed patches have been landed. Closing bug. 328835 4 webkit.review.bot 2011-01-03 16:41:06 -0800 http://trac.webkit.org/changeset/74946 might have broken GTK Linux 32-bit Release and GTK Linux 64-bit Debug 77841 2011-01-03 13:36:53 -0800 2011-01-03 16:09:28 -0800 Patch EditingPatch.txt text/plain 2636 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDkzNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTEtMDEtMDMgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluc2Vy dFRleHRDb21tYW5kOjptX2NoYXJhY3RlcnNBZGRlZCBpcyB1bnVzZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxODQ5CisKKyAgICAgICAgKiBlZGl0 aW5nL0luc2VydFRleHRDb21tYW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc2VydFRleHRD b21tYW5kOjpJbnNlcnRUZXh0Q29tbWFuZCk6IERvbid0IGluaXRpYWxpemUgbV9jaGFyYWN0ZXJz QWRkZWQuCisgICAgICAgIChXZWJDb3JlOjpJbnNlcnRUZXh0Q29tbWFuZDo6aW5wdXQpOiBEb24n dCB1cGRhdGUgbV9jaGFyYWN0ZXJzQWRkZWQuCisgICAgICAgICogZWRpdGluZy9JbnNlcnRUZXh0 Q29tbWFuZC5oOiBSZW1vdmVkIGNoYXJhY3RlcnNBZGRlZCBmdW5jdGlvbiBhbmQKKyAgICAgICAg bV9jaGFyYWN0ZXJzQWRkZWQgZGF0YSBtZW1iZXIuCisKIDIwMTEtMDEtMDMgIEd1c3Rhdm8gTm9y b25oYSBTaWx2YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgpJbmRleDogV2ViQ29yZS9lZGl0aW5nL0luc2Vy dFRleHRDb21tYW5kLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2VkaXRpbmcvSW5zZXJ0VGV4 dENvbW1hbmQuY3BwCShyZXZpc2lvbiA3NDkzMSkKKysrIFdlYkNvcmUvZWRpdGluZy9JbnNlcnRU ZXh0Q29tbWFuZC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ1LDcgKzQ1LDcgQEAKIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIAogSW5zZXJ0VGV4dENvbW1hbmQ6Okluc2VydFRleHRDb21tYW5kKERvY3Vt ZW50ICpkb2N1bWVudCkgCi0gICAgOiBDb21wb3NpdGVFZGl0Q29tbWFuZChkb2N1bWVudCksIG1f Y2hhcmFjdGVyc0FkZGVkKDApCisgICAgOiBDb21wb3NpdGVFZGl0Q29tbWFuZChkb2N1bWVudCkK IHsKIH0KIApAQCAtMTYxLDcgKzE2MSw2IEBAIHZvaWQgSW5zZXJ0VGV4dENvbW1hbmQ6OmlucHV0 KGNvbnN0IFN0cmkKICAgICAgICAgc3RhcnRQb3NpdGlvbiA9IGVuZFBvc2l0aW9uLnByZXZpb3Vz KCk7CiAgICAgICAgIGlmIChwbGFjZWhvbGRlci5pc05vdE51bGwoKSkKICAgICAgICAgICAgIHJl bW92ZVBsYWNlaG9sZGVyQXQocGxhY2Vob2xkZXIpOwotICAgICAgICBtX2NoYXJhY3RlcnNBZGRl ZCArPSAxOwogICAgIH0gZWxzZSB7CiAgICAgICAgIC8vIE1ha2Ugc3VyZSB0aGUgZG9jdW1lbnQg aXMgc2V0IHVwIHRvIHJlY2VpdmUgdGV4dAogICAgICAgICBzdGFydFBvc2l0aW9uID0gcHJlcGFy ZUZvclRleHRJbnNlcnRpb24oc3RhcnRQb3NpdGlvbik7CkBAIC0xNzgsOCArMTc3LDYgQEAgdm9p ZCBJbnNlcnRUZXh0Q29tbWFuZDo6aW5wdXQoY29uc3QgU3RyaQogICAgICAgICAvLyBSZWJhbGFu Y2luZyBvbiBib3RoIHNpZGVzIGlzbid0IG5lY2Vzc2FyeSBpZiB3ZSd2ZSBpbnNlcnRlZCBhIHNw YWNlLgogICAgICAgICBpZiAodGV4dCAhPSAiICIpIAogICAgICAgICAgICAgcmViYWxhbmNlV2hp dGVzcGFjZUF0KHN0YXJ0UG9zaXRpb24pOwotICAgICAgICAgICAgCi0gICAgICAgIG1fY2hhcmFj dGVyc0FkZGVkICs9IHRleHQubGVuZ3RoKCk7CiAgICAgfQogCiAgICAgLy8gV2UgY291bGQgaGF2 ZSBpbnNlcnRlZCBhIHBhcnQgb2YgY29tcG9zZWQgY2hhcmFjdGVyIHNlcXVlbmNlLApJbmRleDog V2ViQ29yZS9lZGl0aW5nL0luc2VydFRleHRDb21tYW5kLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9lZGl0aW5nL0luc2VydFRleHRDb21tYW5kLmgJKHJldmlzaW9uIDc0OTMxKQorKysgV2ViQ29y ZS9lZGl0aW5nL0luc2VydFRleHRDb21tYW5kLmgJKHdvcmtpbmcgY29weSkKQEAgLTQzLDcgKzQz LDYgQEAgcHJpdmF0ZToKICAgICBJbnNlcnRUZXh0Q29tbWFuZChEb2N1bWVudCopOwogCiAgICAg dm9pZCBkZWxldGVDaGFyYWN0ZXIoKTsKLSAgICB1bnNpZ25lZCBjaGFyYWN0ZXJzQWRkZWQoKSBj b25zdCB7IHJldHVybiBtX2NoYXJhY3RlcnNBZGRlZDsgfQogICAgIAogICAgIHZpcnR1YWwgdm9p ZCBkb0FwcGx5KCk7CiAgICAgdmlydHVhbCBib29sIGlzSW5zZXJ0VGV4dENvbW1hbmQoKSBjb25z dDsKQEAgLTUzLDggKzUyLDYgQEAgcHJpdmF0ZToKICAgICAKICAgICBib29sIHBlcmZvcm1Ucml2 aWFsUmVwbGFjZShjb25zdCBTdHJpbmcmLCBib29sIHNlbGVjdEluc2VydGVkVGV4dCk7CiAKLSAg ICB1bnNpZ25lZCBtX2NoYXJhY3RlcnNBZGRlZDsKLQogICAgIGZyaWVuZCBjbGFzcyBUeXBpbmdD b21tYW5kOwogfTsKIAo=