51847 2011-01-03 13:17:59 -0800 Shrink RootInlineBox 2011-01-03 14:10:37 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mitz mitz abarth eric webkit.review.bot oldest_to_newest 328735 0 mitz 2011-01-03 13:17:59 -0800 Shrink RootInlineBox 328736 1 77839 mitz 2011-01-03 13:20:20 -0800 Created attachment 77839 Roll m_baselineType into a bitfield 328745 2 77839 darin 2011-01-03 13:24:46 -0800 Comment on attachment 77839 Roll m_baselineType into a bitfield Did you test whether this works properly on Windows? I seem to recall that on Windows bitfields are signed so the 1 value ends up being -1. Sometimes we have to use the type unsigned instead of the actual enum type to work around that. r=m if this doesn't break with MSVC. 328761 3 mitz 2011-01-03 13:42:00 -0800 Committed r74937. <http://trac.webkit.org/projects/webkit/changeset/74937> 328783 4 webkit.review.bot 2011-01-03 14:10:37 -0800 http://trac.webkit.org/changeset/74937 might have broken SnowLeopard Intel Release (Build) 77839 2011-01-03 13:20:20 -0800 2011-01-03 13:24:46 -0800 Roll m_baselineType into a bitfield bug-51847-20110103132019.patch text/plain 1070 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDkzMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTEtMDEtMDMgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaHJp bmsgUm9vdElubGluZUJveAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTE4NDcKKworICAgICAgICAqIHJlbmRlcmluZy9Sb290SW5saW5lQm94Lmg6IFJv bGxlZCBtX2Jhc2VsaW5lVHlwZSBpbnRvIGEgYml0ZmllbGQuCisKIDIwMTEtMDEtMDMgIEJyYWR5 IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUm9vdElubGluZUJveC5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1Jvb3RJbmxpbmVCb3guaAkocmV2aXNpb24gNzQ5MTIp CisrKyBXZWJDb3JlL3JlbmRlcmluZy9Sb290SW5saW5lQm94LmgJKHdvcmtpbmcgY29weSkKQEAg LTE1OCw3ICsxNTgsNyBAQCBwcml2YXRlOgogICAgIGludCBtX2Jsb2NrTG9naWNhbEhlaWdodDsK IAogICAgIC8vIFdoZXRoZXIgb3Igbm90IHRoaXMgbGluZSB1c2VzIGFscGhhYmV0aWMgb3IgaWRl b2dyYXBoaWMgYmFzZWxpbmVzIGJ5IGRlZmF1bHQuCi0gICAgRm9udEJhc2VsaW5lIG1fYmFzZWxp bmVUeXBlOworICAgIEZvbnRCYXNlbGluZSBtX2Jhc2VsaW5lVHlwZSA6IDE7CiAgICAgCiAgICAg Ly8gSWYgdGhlIGxpbmUgY29udGFpbnMgYW55IHJ1YnkgcnVucywgdGhlbiB0aGlzIHdpbGwgYmUg dHJ1ZS4KICAgICBib29sIG1faGFzQW5ub3RhdGlvbnNCZWZvcmUgOiAxOwo=