51842 2011-01-03 12:00:17 -0800 check-webkit-style shouldn't consider "value" automatically to be a meaningless name. 2011-01-03 14:07:53 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 levin levin abarth commit-queue eric hamaji webkit.review.bot oldest_to_newest 328697 0 levin 2011-01-03 12:00:17 -0800 For example: add(key, value) or more concretely: https://bugs.webkit.org/attachment.cgi?id=77820&action=prettypatch 328704 1 77833 levin 2011-01-03 12:04:05 -0800 Created attachment 77833 Patch 328709 2 77833 eric 2011-01-03 12:20:57 -0800 Comment on attachment 77833 Patch Why not? :) 328739 3 77833 commit-queue 2011-01-03 13:21:42 -0800 Comment on attachment 77833 Patch Clearing flags on attachment: 77833 Committed r74934: <http://trac.webkit.org/changeset/74934> 328740 4 commit-queue 2011-01-03 13:21:49 -0800 All reviewed patches have been landed. Closing bug. 328781 5 webkit.review.bot 2011-01-03 14:07:53 -0800 http://trac.webkit.org/changeset/74934 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/xmlhttprequest/remember-bad-password.html 77833 2011-01-03 12:04:05 -0800 2011-01-03 13:21:42 -0800 Patch bug-51842-20110103120403.patch text/plain 3355 levin ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2Yjg1 MjNjNDk0MGU0NGJkY2YxYjhhZDNjOTAzYjQwYmJmZTA0OWYyLi41ZDMzYWU4NGY3MzJjMDY4MWU3 ODMzYmE1NTg3MGY2NGFhYWMzYTcxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDEtMDMgIERhdmlkIExldmlu ICA8bGV2aW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBzaG91bGRuJ3QgY29uc2lkZXIgInZh bHVlIiBhdXRvbWF0aWNhbGx5IHRvIGJlIGEgbWVhbmluZ2xlc3MgbmFtZS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxODQyCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weTogUmVtb3ZlIHRoZSBjaGVjayBm b3IgdmFsdWUuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBf dW5pdHRlc3QucHk6IFJlbW92ZSB0aGUgdGVzdCBmb3IgdmFsdWUuCisKIDIwMTEtMDEtMDMgIEFk YW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1v biBGcmFzZXIuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 CmluZGV4IDU4YzEzZGY5MGM3ZTdjOGU3Y2QzM2Y5NGRjMTRmYzc1NWRjMTZmYWEuLmFhMWE4ZjAx NTlkNDVlNzg1MzIzODM5YTU5YmE0NzVmN2I5MzMzYWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0xNTI5LDE4ICsxNTI5LDExIEBAIGRlZiBj aGVja19mdW5jdGlvbl9kZWZpbml0aW9uKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwgZnVuY3Rp b25fc3RhdGUsIGVycm9yKToKICAgICAgICAgaWYgbGVuKHBhcmFtZXRlcl9saXN0KSA9PSAxIGFu ZCBtYXRjaCgnc2V0W0EtWl0nLCBmdW5jdGlvbl9zdGF0ZS5jdXJyZW50X2Z1bmN0aW9uKToKICAg ICAgICAgICAgIHRyaW1tZWRfZnVuY3Rpb25fbmFtZSA9IGZ1bmN0aW9uX3N0YXRlLmN1cnJlbnRf ZnVuY3Rpb25bbGVuKCdzZXQnKTpdCiAgICAgICAgICAgICBpZiBub3QgX2NoZWNrX3BhcmFtZXRl cl9uYW1lX2FnYWluc3RfdGV4dChwYXJhbWV0ZXIsIHRyaW1tZWRfZnVuY3Rpb25fbmFtZSwgZXJy b3IpOgotICAgICAgICAgICAgICAgICMgU2luY2UgYW4gZXJyb3Igd2FzIG5vdGVkIGZvciB0aGlz IG5hbWUsIG1vdmUgdG8gdGhlIG5leHQgcGFyYW1ldGVyLgotICAgICAgICAgICAgICAgIGNvbnRp bnVlCisgICAgICAgICAgICAgICAgY29udGludWUgICMgU2luY2UgYW4gZXJyb3Igd2FzIG5vdGVk IGZvciB0aGlzIG5hbWUsIG1vdmUgdG8gdGhlIG5leHQgcGFyYW1ldGVyLgogCiAgICAgICAgICMg Q2hlY2sgdGhlIHBhcmFtZXRlciBuYW1lIGFnYWluc3QgdGhlIHR5cGUuCiAgICAgICAgIGlmIG5v dCBfY2hlY2tfcGFyYW1ldGVyX25hbWVfYWdhaW5zdF90ZXh0KHBhcmFtZXRlciwgcGFyYW1ldGVy LnR5cGUsIGVycm9yKToKLSAgICAgICAgICAgIGNvbnRpbnVlCi0KLSAgICAgICAgIyBTa2lwIHNp bmdsZSBsZXR0ZXIgcGFyYW1ldGVycyBiZWZvcmUgY29tcGFyaW5nIGFnYWluc3QgdmFsdWUgKGJl Y2F1c2UgJ2EnIHdvdWxkCi0gICAgICAgICMgYmUgZmxhZ2dlZCwgYnV0IGl0IG1heSBiZSBhbiBv ayB2YXJpYWJsZSB3aGVuIHVzZWQgaW4gYW4gcmdiYSBmdW5jdGlvbikuCi0gICAgICAgIGlmIGxl bihwYXJhbWV0ZXIubmFtZSkgPiAxOgotICAgICAgICAgICAgIyAndmFsdWUnIGlzIGEgbWVhbmlu Z2xlc3MgdmFyaWFibGUgbmFtZSB0aGF0IGlzIHVzZWQgaW4gc29tZSBwbGFjZXMsIHNvIGZsYWcg aXQuCi0gICAgICAgICAgICBfY2hlY2tfcGFyYW1ldGVyX25hbWVfYWdhaW5zdF90ZXh0KHBhcmFt ZXRlciwgJ3ZhbHVlJywgZXJyb3IpCisgICAgICAgICAgICBjb250aW51ZSAgIyBTaW5jZSBhbiBl cnJvciB3YXMgbm90ZWQgZm9yIHRoaXMgbmFtZSwgbW92ZSB0byB0aGUgbmV4dCBwYXJhbWV0ZXIu CiAKIAogZGVmIGNoZWNrX3Bhc3NfcHRyX3VzYWdlKGNsZWFuX2xpbmVzLCBsaW5lX251bWJlciwg ZnVuY3Rpb25fc3RhdGUsIGVycm9yKToKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggYmIwNTc5ZWFhMGIxOWJiMDQz NGUyMDhmMTk4ZjhiOWYzZTk0YjgyNy4uMjJkMDdlM2UzNmQ2NDYxYTI0MmM2MzM0OGVkMThmMGVj YTI1NGE2YSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHBfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jcHBfdW5pdHRlc3QucHkKQEAgLTQxNjMsMTAgKzQxNjMsNiBAQCBjbGFzcyBXZWJLaXRT dHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWxzKG1l YW5pbmdsZXNzX3ZhcmlhYmxlX25hbWVfZXJyb3JfbWVzc2FnZSAlICdydm8nLAogICAgICAgICAg ICAgICAgICAgICAgICAgICBzZWxmLnBlcmZvcm1fbGludCgndm9pZCBmdW5jdChSZW5kZXJWaWV3 IHJ2byk7JywgJ3Rlc3QuY3BwJywgcGFyYW1ldGVyX2Vycm9yX3J1bGVzKSkKIAotICAgICAgICAj ICd2YWx1ZScgaXMgYSBtZWFuaW5nbGVzcyB2YXJpYWJsZSBuYW1lLgotICAgICAgICBzZWxmLmFz c2VydEVxdWFscyhtZWFuaW5nbGVzc192YXJpYWJsZV9uYW1lX2Vycm9yX21lc3NhZ2UgJSAndmFs dWUnLAotICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxmLnBlcmZvcm1fbGludCgndm9pZCBm dW5jdChSZW5kZXJWaWV3IHZhbHVlKTsnLCAndGVzdC5jcHAnLCBwYXJhbWV0ZXJfZXJyb3JfcnVs ZXMpKQotCiAgICAgICAgICMgQ2hlY2sgdGhhdCByLCBnLCBiLCBhbmQgYSBhcmUgYWxsb3dlZC4K ICAgICAgICAgc2VsZi5hc3NlcnRFcXVhbHMoJycsCiAgICAgICAgICAgICAgICAgICAgICAgICAg IHNlbGYucGVyZm9ybV9saW50KCd2b2lkIHNldFJHQkFWYWx1ZXMoaW50IHIsIGludCBnLCBpbnQg YiwgaW50IGEpOycsICd0ZXN0LmNwcCcsIHBhcmFtZXRlcl9lcnJvcl9ydWxlcykpCg==