51841 2011-01-03 11:59:48 -0800 [Chromium] Add CSS3 elliptical gradient support to GradientSkia 2011-12-21 23:22:17 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 55742 56736 1 mihaip noel.gordon andreip bsalomon commit-queue jamesr peter reed senorblanco oldest_to_newest 328696 0 mihaip 2011-01-03 11:59:48 -0800 The patches in bug 28152 added support for the current CSS3 gradient spec, including elliptical graidents. We'll probably need to do a similar change to: http://trac.webkit.org/changeset/74915/trunk/WebCore/platform/graphics/cg/GradientCG.cpp 328701 1 mihaip 2011-01-03 12:03:19 -0800 For now I've added failing expectations for affected tests: http://trac.webkit.org/changeset/74921 330200 2 andreip 2011-01-06 10:13:32 -0800 *** Bug 51988 has been marked as a duplicate of this bug. *** 349552 3 82084 noel.gordon 2011-02-10 18:13:08 -0800 Created attachment 82084 Patch 352656 4 82764 noel.gordon 2011-02-17 00:55:56 -0800 Created attachment 82764 Patch fix spelling Stephen, could you review this please? 352819 5 reed 2011-02-17 06:47:42 -0800 LGTM 352883 6 senorblanco 2011-02-17 07:44:45 -0800 (In reply to comment #4) > Created an attachment (id=82764) [details] > Patch fix spelling > > Stephen, could you review this please? This looks fine to me. However, I'm not a WK reviewer. James, care to give this an r+? 353960 7 commit-queue 2011-02-18 18:16:53 -0800 The commit-queue encountered the following flaky tests while processing attachment 82764: http/tests/websocket/tests/handshake-fail-by-cross-origin.html bug 54147 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 353962 8 82764 commit-queue 2011-02-18 18:19:01 -0800 Comment on attachment 82764 Patch fix spelling Clearing flags on attachment: 82764 Committed r79063: <http://trac.webkit.org/changeset/79063> 353963 9 commit-queue 2011-02-18 18:19:05 -0800 All reviewed patches have been landed. Closing bug. 82084 2011-02-10 18:13:08 -0800 2011-02-17 00:55:56 -0800 Patch patch-git.diff text/plain 2783 noel.gordon ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwMjAzOTIxLi44NzBkZGFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTEtMDItMTAgIE5vbGUgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0g QWRkIGVsbGlwdGljYWwgZ3JhZGllbnQgc3VwcG9ydCB0byBHcmFkaWVudFNraWEKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxODQxCisKKyAgICAgICAg VGVzdHMgd2lsbCBuZWVkIG5ldyByZWJhc2VsaW5lcyBmb3IgY2hyb21lIGxpbnV4LCB3aW4zMgor ICAgICAgICBmYXN0L2dyYWRpZW50cy9jc3MzLWNvbG9yLXN0b3AtdW5pdHMuaHRtbAorICAgICAg ICBmYXN0L2dyYWRpZW50cy9jc3MzLWNvbG9yLXN0b3BzLmh0bWwKKyAgICAgICAgZmFzdC9ncmFk aWVudHMvY3NzMy1saW5lYXItYW5nbGUtZ3JhZGllbnRzLmh0bWwKKyAgICAgICAgZmFzdC9ncmFk aWVudHMvY3NzMy1yYWRpYWwtZ3JhZGllbnRzLmh0bWwKKyAgICAgICAgZmFzdC9ncmFkaWVudHMv Y3NzMy1yYWRpYWwtZ3JhZGllbnRzMi5odG1sCisgICAgICAgIGZhc3QvZ3JhZGllbnRzL2NzczMt cmFkaWFsLWdyYWRpZW50czMuaHRtbAorICAgICAgICBmYXN0L2dyYWRpZW50cy9jc3MzLXJlcGVh dGluZy1yYWRpYWwtZ3JhZGllbnRzLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L3NraWEvR3JhZGllbnRTa2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYWRpZW50OjpwbGF0 Zm9ybUdyYWRpZW50KToKKwogMjAxMS0wMi0wMyAgRG9taW5pYyBDb29uZXkgIDxkb21pbmljY0Bn b29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhZGllbnRTa2lh LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhZGllbnRTa2lh LmNwcAppbmRleCBhNjM2ZDEwLi4xYmI4ZDIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYWRpZW50U2tpYS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFkaWVudFNraWEuY3BwCkBAIC0xMjcsNiArMTI3 LDcgQEAgU2tTaGFkZXIqIEdyYWRpZW50OjpwbGF0Zm9ybUdyYWRpZW50KCkKICAgICAgICAgICAg IHN0ZDo6c3RhYmxlX3NvcnQobV9zdG9wcy5iZWdpbigpLCBtX3N0b3BzLmVuZCgpLCBjb21wYXJl U3RvcHMpOwogICAgICAgICBtX3N0b3BzU29ydGVkID0gdHJ1ZTsKICAgICB9CisKICAgICBzaXpl X3QgY291bnRVc2VkID0gdG90YWxTdG9wc05lZWRlZChtX3N0b3BzLmRhdGEoKSwgbV9zdG9wcy5z aXplKCkpOwogICAgIEFTU0VSVChjb3VudFVzZWQgPj0gMik7CiAgICAgQVNTRVJUKGNvdW50VXNl ZCA+PSBtX3N0b3BzLnNpemUoKSk7CkBAIC0xNjcsMTcgKzE2OCwyMyBAQCBTa1NoYWRlciogR3Jh ZGllbnQ6OnBsYXRmb3JtR3JhZGllbnQoKQogICAgICAgICAgICAgU2tTY2FsYXIgcmFkaXVzMSA9 IG1fcjEgPj0gMC4wZiA/IFdlYkNvcmVGbG9hdFRvU2tTY2FsYXIobV9yMSkgOiAwOwogICAgICAg ICAgICAgbV9ncmFkaWVudCA9IFNrR3JhZGllbnRTaGFkZXI6OkNyZWF0ZVR3b1BvaW50UmFkaWFs KG1fcDAsIHJhZGl1czAsIG1fcDEsIHJhZGl1czEsIGNvbG9ycywgcG9zLCBzdGF0aWNfY2FzdDxp bnQ+KGNvdW50VXNlZCksIHRpbGUpOwogICAgICAgICB9CisKKyAgICAgICAgaWYgKGFzcGVjdFJh dGlvKCkgIT0gMSkgeworICAgICAgICAgICAgLy8gQ1NTMyBlbGxpcHRpY2FsIGdyYWRpZW50czog YXBwbHkgdGhlIGVsbGlwdGljYWwgc2NhbGluZyBhdCB0aGUKKyAgICAgICAgICAgIC8vIGdyYWRp ZW50IGNlbnRlciBwb2ludC4KKyAgICAgICAgICAgIG1fZ3JhZGllbnRTcGFjZVRyYW5zZm9ybWF0 aW9uLnRyYW5zbGF0ZShtX3AwLngoKSwgbV9wMC55KCkpOworICAgICAgICAgICAgbV9ncmFkaWVu dFNwYWNlVHJhbnNmb3JtYXRpb24uc2NhbGUoMSwgMSAvIGFzcGVjdFJhdGlvKCkpOworICAgICAg ICAgICAgbV9ncmFkaWVudFNwYWNlVHJhbnNmb3JtYXRpb24udHJhbnNsYXRlKC1tX3AwLngoKSwg LW1fcDAueSgpKTsKKyAgICAgICAgICAgIEFTU0VSVChtX3AwID09IG1fcDEpOworICAgICAgICB9 CiAgICAgfSBlbHNlIHsKICAgICAgICAgU2tQb2ludCBwdHNbMl0gPSB7IG1fcDAsIG1fcDEgfTsK LSAgICAgICAgbV9ncmFkaWVudCA9IFNrR3JhZGllbnRTaGFkZXI6OkNyZWF0ZUxpbmVhcihwdHMs IGNvbG9ycywgcG9zLAotICAgICAgICAgICAgc3RhdGljX2Nhc3Q8aW50Pihjb3VudFVzZWQpLCB0 aWxlKTsKKyAgICAgICAgbV9ncmFkaWVudCA9IFNrR3JhZGllbnRTaGFkZXI6OkNyZWF0ZUxpbmVh cihwdHMsIGNvbG9ycywgcG9zLCBzdGF0aWNfY2FzdDxpbnQ+KGNvdW50VXNlZCksIHRpbGUpOwog ICAgIH0KIAogICAgIEFTU0VSVChtX2dyYWRpZW50KTsKLQogICAgIFNrTWF0cml4IG1hdHJpeCA9 IG1fZ3JhZGllbnRTcGFjZVRyYW5zZm9ybWF0aW9uOwogICAgIG1fZ3JhZGllbnQtPnNldExvY2Fs TWF0cml4KG1hdHJpeCk7Ci0KICAgICByZXR1cm4gbV9ncmFkaWVudDsKIH0KIAo= 82764 2011-02-17 00:55:56 -0800 2011-02-18 18:19:01 -0800 Patch fix spelling patch-git.diff text/plain 2832 noel.gordon ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYzg5MzE2Li45YTdmMmY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTEtMDItMTcgIE5vZWwgR29yZG9uICA8bm9lbC5nb3Jkb25AZ21haWwuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0g QWRkIGVsbGlwdGljYWwgZ3JhZGllbnQgc3VwcG9ydCB0byBHcmFkaWVudFNraWEKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxODQxCisKKyAgICAgICAg Q292ZXJlZCBieSBleGlzdGluZyB0ZXN0cywgdGhlc2UgbmVlZCBuZXcgcmViYXNlbGluZXMgb25j ZSB0aGlzIHBhdGNoCisgICAgICAgIGxhbmRzIGZvciBjaHJvbWUgbGludXgsIHdpbjMyCisKKyAg ICAgICAgZmFzdC9ncmFkaWVudHMvY3NzMy1jb2xvci1zdG9wLXVuaXRzLmh0bWwKKyAgICAgICAg ZmFzdC9ncmFkaWVudHMvY3NzMy1jb2xvci1zdG9wcy5odG1sCisgICAgICAgIGZhc3QvZ3JhZGll bnRzL2NzczMtbGluZWFyLWFuZ2xlLWdyYWRpZW50cy5odG1sCisgICAgICAgIGZhc3QvZ3JhZGll bnRzL2NzczMtcmFkaWFsLWdyYWRpZW50cy5odG1sCisgICAgICAgIGZhc3QvZ3JhZGllbnRzL2Nz czMtcmFkaWFsLWdyYWRpZW50czIuaHRtbAorICAgICAgICBmYXN0L2dyYWRpZW50cy9jc3MzLXJh ZGlhbC1ncmFkaWVudHMzLmh0bWwKKyAgICAgICAgZmFzdC9ncmFkaWVudHMvY3NzMy1yZXBlYXRp bmctcmFkaWFsLWdyYWRpZW50cy5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9z a2lhL0dyYWRpZW50U2tpYS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFkaWVudDo6cGxhdGZv cm1HcmFkaWVudCk6CisKIDIwMTEtMDItMTYgIEJyaWFuIFJ5bmVyICA8YnJ5bmVyQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBGaXNoZXIuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYWRpZW50U2tpYS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYWRpZW50U2tpYS5jcHAKaW5k ZXggYTYzNmQxMC4uMWJiOGQyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvc2tpYS9HcmFkaWVudFNraWEuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3NraWEvR3JhZGllbnRTa2lhLmNwcApAQCAtMTI3LDYgKzEyNyw3IEBAIFNr U2hhZGVyKiBHcmFkaWVudDo6cGxhdGZvcm1HcmFkaWVudCgpCiAgICAgICAgICAgICBzdGQ6OnN0 YWJsZV9zb3J0KG1fc3RvcHMuYmVnaW4oKSwgbV9zdG9wcy5lbmQoKSwgY29tcGFyZVN0b3BzKTsK ICAgICAgICAgbV9zdG9wc1NvcnRlZCA9IHRydWU7CiAgICAgfQorCiAgICAgc2l6ZV90IGNvdW50 VXNlZCA9IHRvdGFsU3RvcHNOZWVkZWQobV9zdG9wcy5kYXRhKCksIG1fc3RvcHMuc2l6ZSgpKTsK ICAgICBBU1NFUlQoY291bnRVc2VkID49IDIpOwogICAgIEFTU0VSVChjb3VudFVzZWQgPj0gbV9z dG9wcy5zaXplKCkpOwpAQCAtMTY3LDE3ICsxNjgsMjMgQEAgU2tTaGFkZXIqIEdyYWRpZW50Ojpw bGF0Zm9ybUdyYWRpZW50KCkKICAgICAgICAgICAgIFNrU2NhbGFyIHJhZGl1czEgPSBtX3IxID49 IDAuMGYgPyBXZWJDb3JlRmxvYXRUb1NrU2NhbGFyKG1fcjEpIDogMDsKICAgICAgICAgICAgIG1f Z3JhZGllbnQgPSBTa0dyYWRpZW50U2hhZGVyOjpDcmVhdGVUd29Qb2ludFJhZGlhbChtX3AwLCBy YWRpdXMwLCBtX3AxLCByYWRpdXMxLCBjb2xvcnMsIHBvcywgc3RhdGljX2Nhc3Q8aW50Pihjb3Vu dFVzZWQpLCB0aWxlKTsKICAgICAgICAgfQorCisgICAgICAgIGlmIChhc3BlY3RSYXRpbygpICE9 IDEpIHsKKyAgICAgICAgICAgIC8vIENTUzMgZWxsaXB0aWNhbCBncmFkaWVudHM6IGFwcGx5IHRo ZSBlbGxpcHRpY2FsIHNjYWxpbmcgYXQgdGhlCisgICAgICAgICAgICAvLyBncmFkaWVudCBjZW50 ZXIgcG9pbnQuCisgICAgICAgICAgICBtX2dyYWRpZW50U3BhY2VUcmFuc2Zvcm1hdGlvbi50cmFu c2xhdGUobV9wMC54KCksIG1fcDAueSgpKTsKKyAgICAgICAgICAgIG1fZ3JhZGllbnRTcGFjZVRy YW5zZm9ybWF0aW9uLnNjYWxlKDEsIDEgLyBhc3BlY3RSYXRpbygpKTsKKyAgICAgICAgICAgIG1f Z3JhZGllbnRTcGFjZVRyYW5zZm9ybWF0aW9uLnRyYW5zbGF0ZSgtbV9wMC54KCksIC1tX3AwLnko KSk7CisgICAgICAgICAgICBBU1NFUlQobV9wMCA9PSBtX3AxKTsKKyAgICAgICAgfQogICAgIH0g ZWxzZSB7CiAgICAgICAgIFNrUG9pbnQgcHRzWzJdID0geyBtX3AwLCBtX3AxIH07Ci0gICAgICAg IG1fZ3JhZGllbnQgPSBTa0dyYWRpZW50U2hhZGVyOjpDcmVhdGVMaW5lYXIocHRzLCBjb2xvcnMs IHBvcywKLSAgICAgICAgICAgIHN0YXRpY19jYXN0PGludD4oY291bnRVc2VkKSwgdGlsZSk7Cisg ICAgICAgIG1fZ3JhZGllbnQgPSBTa0dyYWRpZW50U2hhZGVyOjpDcmVhdGVMaW5lYXIocHRzLCBj b2xvcnMsIHBvcywgc3RhdGljX2Nhc3Q8aW50Pihjb3VudFVzZWQpLCB0aWxlKTsKICAgICB9CiAK ICAgICBBU1NFUlQobV9ncmFkaWVudCk7Ci0KICAgICBTa01hdHJpeCBtYXRyaXggPSBtX2dyYWRp ZW50U3BhY2VUcmFuc2Zvcm1hdGlvbjsKICAgICBtX2dyYWRpZW50LT5zZXRMb2NhbE1hdHJpeCht YXRyaXgpOwotCiAgICAgcmV0dXJuIG1fZ3JhZGllbnQ7CiB9CiAK