51840 2011-01-03 11:43:24 -0800 webkit-patch shouldn't waste time cleaning a working directory that's already clean 2011-01-03 14:22:38 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth abarth abarth commit-queue eric webkit.review.bot oldest_to_newest 328687 0 abarth 2011-01-03 11:43:24 -0800 webkit-patch shouldn't waste time cleaning a working directory that's already clean 328688 1 77832 abarth 2011-01-03 11:44:51 -0800 Created attachment 77832 Patch 328690 2 77832 eric 2011-01-03 11:47:21 -0800 Comment on attachment 77832 Patch I believe this was done this way to avoid doing the "is clean" check at all if --force-clean was passed. 328691 3 abarth 2011-01-03 11:50:48 -0800 According to perf measurements, that seems to be a backwards optimization. :) Cleaning working directory webkitpy.common.system: [DEBUG] "svn cleanup" took 14.47s webkitpy.common.system: [DEBUG] "svn --version --quiet" took 0.02s webkitpy.common.system: [DEBUG] "svn status" took 4.55s webkitpy.common.system: [DEBUG] "svn revert -R ." took 45.45s 328693 4 eric 2011-01-03 11:55:27 -0800 I wonder how it compares for git, since I'm sure that code was written for git. :) But I'm willing to believe it reamains backwards for git. 328714 5 77832 commit-queue 2011-01-03 12:40:35 -0800 Comment on attachment 77832 Patch Clearing flags on attachment: 77832 Committed r74925: <http://trac.webkit.org/changeset/74925> 328715 6 commit-queue 2011-01-03 12:40:41 -0800 All reviewed patches have been landed. Closing bug. 328787 7 webkit.review.bot 2011-01-03 14:22:38 -0800 http://trac.webkit.org/changeset/74925 might have broken Leopard Intel Debug (Tests) 77832 2011-01-03 11:44:51 -0800 2011-01-03 12:40:34 -0800 Patch bug-51840-20110103114450.patch text/plain 1629 abarth SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc0OTE3KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTEtMDEtMDMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB3ZWJraXQtcGF0 Y2ggc2hvdWxkbid0IHdhc3RlIHRpbWUgY2xlYW5pbmcgYSB3b3JraW5nIGRpcmVjdG9yeSB0aGF0 J3MgYWxyZWFkeSBjbGVhbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTE4NDAKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNr b3V0L3NjbS5weToKKwogMjAxMS0wMS0wMyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KSW5kZXg6IFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20ucHkJKHJldmlzaW9uIDc0OTE2KQor KysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtLnB5CSh3b3JraW5n IGNvcHkpCkBAIC0xNzIsMTQgKzE3MiwxNSBAQCBjbGFzcyBTQ006CiAgICAgICAgIHJldHVybiBv cy5wYXRoLmpvaW4oc2VsZi5zY3JpcHRzX2RpcmVjdG9yeSgpLCBzY3JpcHRfbmFtZSkKIAogICAg IGRlZiBlbnN1cmVfY2xlYW5fd29ya2luZ19kaXJlY3Rvcnkoc2VsZiwgZm9yY2VfY2xlYW4pOgot ICAgICAgICBpZiBub3QgZm9yY2VfY2xlYW4gYW5kIG5vdCBzZWxmLndvcmtpbmdfZGlyZWN0b3J5 X2lzX2NsZWFuKCk6CisgICAgICAgIGlmIHNlbGYud29ya2luZ19kaXJlY3RvcnlfaXNfY2xlYW4o KToKKyAgICAgICAgICAgIHJldHVybgorICAgICAgICBpZiBub3QgZm9yY2VfY2xlYW46CiAgICAg ICAgICAgICAjIEZJWE1FOiBTaG91bGRuJ3QgdGhpcyB1c2UgY3dkPXNlbGYuY2hlY2tvdXRfcm9v dD8KICAgICAgICAgICAgIHByaW50IHNlbGYucnVuKHNlbGYuc3RhdHVzX2NvbW1hbmQoKSwgZXJy b3JfaGFuZGxlcj1FeGVjdXRpdmUuaWdub3JlX2Vycm9yKQogICAgICAgICAgICAgcmFpc2UgU2Ny aXB0RXJyb3IobWVzc2FnZT0iV29ya2luZyBkaXJlY3RvcnkgaGFzIG1vZGlmaWNhdGlvbnMsIHBh c3MgLS1mb3JjZS1jbGVhbiBvciAtLW5vLWNsZWFuIHRvIGNvbnRpbnVlLiIpCi0gICAgICAgIAog ICAgICAgICBsb2coIkNsZWFuaW5nIHdvcmtpbmcgZGlyZWN0b3J5IikKICAgICAgICAgc2VsZi5j bGVhbl93b3JraW5nX2RpcmVjdG9yeSgpCi0gICAgCisKICAgICBkZWYgZW5zdXJlX25vX2xvY2Fs X2NvbW1pdHMoc2VsZiwgZm9yY2UpOgogICAgICAgICBpZiBub3Qgc2VsZi5zdXBwb3J0c19sb2Nh bF9jb21taXRzKCk6CiAgICAgICAgICAgICByZXR1cm4K