51832 2011-01-03 10:38:48 -0800 [GTK] Move paintMenuListButton() to RenderThemeGtk.cpp 2011-01-03 15:56:36 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 cgarcia webkit-unassigned commit-queue oldest_to_newest 328631 0 cgarcia 2011-01-03 10:38:48 -0800 It's common code duplicated in both RenderThemeGtk2.cpp and RenderThemeGtk3.cpp 328639 1 77824 cgarcia 2011-01-03 10:43:31 -0800 Created attachment 77824 Move paintMenuListButton() to RenderThemeGtk.cpp 328817 2 77824 commit-queue 2011-01-03 15:56:31 -0800 Comment on attachment 77824 Move paintMenuListButton() to RenderThemeGtk.cpp Clearing flags on attachment: 77824 Committed r74945: <http://trac.webkit.org/changeset/74945> 328818 3 commit-queue 2011-01-03 15:56:36 -0800 All reviewed patches have been landed. Closing bug. 77824 2011-01-03 10:43:31 -0800 2011-01-03 15:56:31 -0800 Move paintMenuListButton() to RenderThemeGtk.cpp move-paint-menu-list-button.diff text/plain 2889 cgarcia ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWUxZWQ1OC4uYzFkMmI3OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMS0wMS0wMyAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gTW92ZSBwYWludE1lbnVMaXN0QnV0dG9uKCkg dG8gUmVuZGVyVGhlbWVHdGsuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD01MTgzMgorCisgICAgICAgIE1ldGhvZCBwYWludE1lbnVMaXN0QnV0dG9u KCkgY29udGFpbnMgY29kZSBjb21tb24gdG8gYm90aCBndGsgMgorICAgICAgICBhbmQgMywgc28g aXQgY2FuIGJlIG1vdmVkIHRvIFJlbmRlclRoZW1lR3RrLmNwcCBpbnN0ZWFkIG9mCisgICAgICAg IGR1cGxpY2F0aW5nIGl0LgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3Rr LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lR3RrOjpwYWludE1lbnVMaXN0QnV0 dG9uKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsyLmNwcDoKKyAgICAg ICAgKiBwbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcDoKKwogMjAxMS0wMS0wMiAgRGFu IEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5 IFNpbW9uIEZyYXNlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRo ZW1lR3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcAppbmRl eCA4ZWNkMjVhLi44ZmNhNzExIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5k ZXJUaGVtZUd0ay5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsu Y3BwCkBAIC0yNjAsNiArMjYwLDExIEBAIHZvaWQgUmVuZGVyVGhlbWVHdGs6OmFkanVzdE1lbnVM aXN0QnV0dG9uU3R5bGUoQ1NTU3R5bGVTZWxlY3Rvciogc2VsZWN0b3IsIFJlbmRlCiAgICAgYWRq dXN0TWVudUxpc3RTdHlsZShzZWxlY3Rvciwgc3R5bGUsIGUpOwogfQogCitib29sIFJlbmRlclRo ZW1lR3RrOjpwYWludE1lbnVMaXN0QnV0dG9uKFJlbmRlck9iamVjdCogb2JqZWN0LCBjb25zdCBQ YWludEluZm8mIGluZm8sIGNvbnN0IEludFJlY3QmIHJlY3QpCit7CisgICAgcmV0dXJuIHBhaW50 TWVudUxpc3Qob2JqZWN0LCBpbmZvLCByZWN0KTsKK30KKwogdm9pZCBSZW5kZXJUaGVtZUd0azo6 YWRqdXN0VGV4dEZpZWxkU3R5bGUoQ1NTU3R5bGVTZWxlY3Rvciogc2VsZWN0b3IsIFJlbmRlclN0 eWxlKiBzdHlsZSwgRWxlbWVudCogZSkgY29uc3QKIHsKICAgICBSZW5kZXJUaGVtZUd0azo6c2V0 VGV4dElucHV0Qm9yZGVycyhzdHlsZSk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2d0 ay9SZW5kZXJUaGVtZUd0azIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVH dGsyLmNwcAppbmRleCAzMDg5MWMxLi4xNzY3NzBiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRm b3JtL2d0ay9SZW5kZXJUaGVtZUd0azIuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Jl bmRlclRoZW1lR3RrMi5jcHAKQEAgLTIzMSwxMSArMjMxLDYgQEAgYm9vbCBSZW5kZXJUaGVtZUd0 azo6cGFpbnRNZW51TGlzdChSZW5kZXJPYmplY3QqIG9iamVjdCwgY29uc3QgUGFpbnRJbmZvJiBp bmZvLAogICAgIHJldHVybiBwYWludFJlbmRlck9iamVjdChNT1pfR1RLX0RST1BET1dOLCBvYmpl Y3QsIGluZm8uY29udGV4dCwgcmVjdCk7CiB9CiAKLWJvb2wgUmVuZGVyVGhlbWVHdGs6OnBhaW50 TWVudUxpc3RCdXR0b24oUmVuZGVyT2JqZWN0KiBvYmplY3QsIGNvbnN0IFBhaW50SW5mbyYgaW5m bywgY29uc3QgSW50UmVjdCYgcmVjdCkKLXsKLSAgICByZXR1cm4gcGFpbnRNZW51TGlzdChvYmpl Y3QsIGluZm8sIHJlY3QpOwotfQotCiB2b2lkIFJlbmRlclRoZW1lR3RrOjpzZXRUZXh0SW5wdXRC b3JkZXJzKFJlbmRlclN0eWxlKiBzdHlsZSkKIHsKICAgICAvLyBJZiB0aGlzIGNvbnRyb2wgaXNu J3QgZHJhd24gdXNpbmcgdGhlIG5hdGl2ZSB0aGVtZSwgd2UgZG9uJ3QgdG91Y2ggdGhlIGJvcmRl cnMuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0azMuY3Bw IGIvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGszLmNwcAppbmRleCAxOWRhMzVj Li40MjdmYzJiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0 azMuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrMy5jcHAKQEAg LTU0NCwxMSArNTQ0LDYgQEAgYm9vbCBSZW5kZXJUaGVtZUd0azo6cGFpbnRNZW51TGlzdChSZW5k ZXJPYmplY3QqIHJlbmRlck9iamVjdCwgY29uc3QgUGFpbnRJbmZvJgogICAgIHJldHVybiBmYWxz ZTsKIH0KIAotYm9vbCBSZW5kZXJUaGVtZUd0azo6cGFpbnRNZW51TGlzdEJ1dHRvbihSZW5kZXJP YmplY3QqIG9iamVjdCwgY29uc3QgUGFpbnRJbmZvJiBpbmZvLCBjb25zdCBJbnRSZWN0JiByZWN0 KQotewotICAgIHJldHVybiBwYWludE1lbnVMaXN0KG9iamVjdCwgaW5mbywgcmVjdCk7Ci19Ci0K IHZvaWQgUmVuZGVyVGhlbWVHdGs6OnNldFRleHRJbnB1dEJvcmRlcnMoUmVuZGVyU3R5bGUqIHN0 eWxlKQogewogICAgIC8vIElmIHRoaXMgY29udHJvbCBpc24ndCBkcmF3biB1c2luZyB0aGUgbmF0 aXZlIHRoZW1lLCB3ZSBkb24ndCB0b3VjaCB0aGUgYm9yZGVycy4K