51827 2011-01-03 10:16:09 -0800 In the cmake build system move logic related to ENABLE_NOTIFICATIONS into its own block. 2011-01-03 11:37:56 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 ben webkit-unassigned commit-queue dbates paroga oldest_to_newest 328609 0 ben 2011-01-03 10:16:09 -0800 Just like with ENABLE_FILE_SYSTEM in the cmake file, unless there is a build issue it is worth putting the ENABLE_NOTIFICATIONS files in a block. 328612 1 77817 ben 2011-01-03 10:18:02 -0800 Created attachment 77817 proposed solution 328614 2 paroga 2011-01-03 10:20:54 -0800 LGTM 328632 3 77817 dbates 2011-01-03 10:38:58 -0800 Comment on attachment 77817 proposed solution This change looks good to both Patrick Gansterer and I. r=me. 328682 4 77817 commit-queue 2011-01-03 11:37:51 -0800 Comment on attachment 77817 proposed solution Clearing flags on attachment: 77817 Committed r74916: <http://trac.webkit.org/changeset/74916> 328683 5 commit-queue 2011-01-03 11:37:56 -0800 All reviewed patches have been landed. Closing bug. 77817 2011-01-03 10:18:02 -0800 2011-01-03 11:37:51 -0800 proposed solution 0001-2011-01-03-Benjamin-C-Meyer-bmeyer-rim.com.patch text/plain 2241 ben RnJvbSAyYzRmMWQyMmIzMTE4MDMzMGU4YjFmNTZhZTc4ZWNhNGRmYmM1MzkzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5qYW1pbiBDIE1leWVyIDxibWV5ZXJAcmltLmNvbT4KRGF0 ZTogVGh1LCAzMCBEZWMgMjAxMCAxODo1Mzo0MiAtMDUwMApTdWJqZWN0OiAyMDExLTAxLTAzICBC ZW5qYW1pbiBDIE1leWVyICA8Ym1leWVyQHJpbS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBJbiB0aGUgY21ha2UgYnVpbGQgc3lzdGVtIG1vdmUgbG9n aWMgcmVsYXRlZCB0byBFTkFCTEVfTk9USUZJQ0FUSU9OUyBpbnRvIGl0cyBvd24gYmxvY2suCiAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxODI3CgogICAg ICAgICogQ01ha2VMaXN0cy50eHQ6Ci0tLQogV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCB8ICAgMTQg KysrKysrKysrKy0tLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgfCAgICA5ICsrKysrKysrKwog MiBmaWxlcyBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9XZWJDb3JlL0NNYWtlTGlzdHMudHh0Cmlu ZGV4IDkxOWE2YTQuLjVmNzEwZGIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQK KysrIGIvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMzEyLDkgKzMxMiw2IEBAIFNFVChXZWJD b3JlX0lETF9GSUxFUwogCiAgICAgbG9hZGVyL2FwcGNhY2hlL0RPTUFwcGxpY2F0aW9uQ2FjaGUu aWRsCiAKLSAgICBub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbi5pZGwKLSAgICBub3RpZmljYXRp b25zL05vdGlmaWNhdGlvbkNlbnRlci5pZGwKLQogICAgIHBhZ2UvQmFySW5mby5pZGwKICAgICBw YWdlL0NvbnNvbGUuaWRsCiAgICAgcGFnZS9Db29yZGluYXRlcy5pZGwKQEAgLTYzMiw3ICs2Mjks NiBAQCBTRVQoV2ViQ29yZV9TT1VSQ0VTCiAgICAgYmluZGluZ3MvanMvSlNEYXRhR3JpZERhdGFT b3VyY2UuY3BwCiAgICAgYmluZGluZ3MvanMvSlNEZWJ1Z1dyYXBwZXJTZXQuY3BwCiAgICAgYmlu ZGluZ3MvanMvSlNEZWRpY2F0ZWRXb3JrZXJDb250ZXh0Q3VzdG9tLmNwcAotICAgIGJpbmRpbmdz L2pzL0pTRGVza3RvcE5vdGlmaWNhdGlvbnNDdXN0b20uY3BwCiAgICAgYmluZGluZ3MvanMvSlNE ZXZpY2VNb3Rpb25FdmVudEN1c3RvbS5jcHAKICAgICBiaW5kaW5ncy9qcy9KU0RldmljZU9yaWVu dGF0aW9uRXZlbnRDdXN0b20uY3BwCiAgICAgYmluZGluZ3MvanMvSlNEb2N1bWVudEN1c3RvbS5j cHAKQEAgLTE3MTgsNiArMTcxNCwxNiBAQCBFTFNFICgpCiAgICAgKQogRU5ESUYgKCkKIAorSUYg KEVOQUJMRV9OT1RJRklDQVRJT05TKQorICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwor ICAgICAgICBiaW5kaW5ncy9qcy9KU0Rlc2t0b3BOb3RpZmljYXRpb25zQ3VzdG9tLmNwcAorICAg ICkKKyAgICBMSVNUKEFQUEVORCBXZWJDb3JlX0lETF9GSUxFUworICAgICAgICBub3RpZmljYXRp b25zL05vdGlmaWNhdGlvbi5pZGwKKyAgICAgICAgbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25D ZW50ZXIuaWRsCisgICAgKQorRU5ESUYgKCkKKwogaWYgKEVOQUJMRV9GSUxFX1NZU1RFTSkKICAg ICBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKICAgICAgICAgYmluZGluZ3MvanMvSlNEaXJl Y3RvcnlFbnRyeUN1c3RvbS5jcHAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggM2ZlNzc4Ni4uNjI1NGQ2ZCAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAx MS0wMS0wMyAgQmVuamFtaW4gQyBNZXllciAgPGJtZXllckByaW0uY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHRoZSBjbWFrZSBidWlsZCBz eXN0ZW0gbW92ZSBsb2dpYyByZWxhdGVkIHRvIEVOQUJMRV9OT1RJRklDQVRJT05TIGludG8gaXRz IG93biBibG9jay4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTUxODI3CisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxMS0wMS0wMiAgRGFy aW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBU YW11cmEuCi0tIAoxLjcuMQoK