<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>51822</bug_id>
          
          <creation_ts>2011-01-03 08:30:49 -0800</creation_ts>
          <short_desc>ContextShadow::blurLayerImage() not endian-safe</short_desc>
          <delta_ts>2011-01-05 12:37:18 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter>fabien.coeurjoly</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ariya.hidayat</cc>
    
    <cc>krit</cc>
    
    <cc>mrobinson</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>328580</commentid>
    <comment_count>0</comment_count>
    <who name="">fabien.coeurjoly</who>
    <bug_when>2011-01-03 08:30:49 -0800</bug_when>
    <thetext>On my PowerPC machine, CSS text/box blurred shadows have disappeared since a couple weeks. 
I investigated a bit and tracked it down to ContextShadow::blurLayerImage() being the culprit, using hardcoded positions for channels:

int channels[4] = { 3, 0, 1, 3 };

where it should be int channels[4] = { 0, 3, 2, 0 }; on a big endian machine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>329640</commentid>
    <comment_count>1</comment_count>
      <attachid>78015</attachid>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-01-05 10:24:53 -0800</bug_when>
    <thetext>Created attachment 78015
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>329662</commentid>
    <comment_count>2</comment_count>
      <attachid>78015</attachid>
    <who name="Ariya Hidayat">ariya.hidayat</who>
    <bug_when>2011-01-05 10:58:22 -0800</bug_when>
    <thetext>Comment on attachment 78015
Patch

LGTM. re=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>329731</commentid>
    <comment_count>3</comment_count>
    <who name="Martin Robinson">mrobinson</who>
    <bug_when>2011-01-05 12:37:06 -0800</bug_when>
    <thetext>Committed r75095: &lt;http://trac.webkit.org/changeset/75095&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>78015</attachid>
            <date>2011-01-05 10:24:53 -0800</date>
            <delta_ts>2011-01-05 12:37:18 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-51822-20110105102452.patch</filename>
            <type>text/plain</type>
            <size>1768</size>
            <attacher name="Martin Robinson">mrobinson</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
NzEzMTdjNzM1YTNlMjU0NWFhNmE0ZTIwMGNjMTU4MDliZDRiMmU1MC4uZWExYWIzZDljMmE3YTEx
MTQ2YjdhYjdjZWVlOWY5Mzg3ZTM1YzllOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK
KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMS0wMS0wNSAgTWFy
dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg
YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29udGV4dFNoYWRvdzo6Ymx1ckxheWVySW1h
Z2UoKSBub3QgZW5kaWFuLXNhZmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTUxODIyCisKKyAgICAgICAgQ29ycmVjdCB0aGUgY2hhbm5lbCBtYXAgaW4g
Q29udGV4dFNoYWRvdyB0byByZWZsZWN0IHRoZSBkaWZmZXJlbnQKKyAgICAgICAgb3JkZXJpbmcg
b2YgcGl4ZWxzIG9uIHByb2Nlc3NvcnMgd2l0aCBkaWZmZXJlbnQgZW5kaWFubmVzcy4KKworICAg
ICAgICBObyBuZXcgdGVzdHMuIFRoaXMgaXMgY292ZXJlZCBieSB0aGUgZXhpc3Rpbmcgc2hhZG93
IHRlc3RzLiBJdCB3YXMKKyAgICAgICAgbm90IGRpc2NvdmVyZWQsIGJlY2F1c2UgYWxsIG9mIHRo
ZSBib3RzIHVzaW5nIENvbnRleHRTaGFkb3cgYXJlCisgICAgICAgIGxpdHRsZS1lbmRpYW4uCisK
KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9Db250ZXh0U2hhZG93LmNwcDoKKyAgICAgICAg
KFdlYkNvcmU6OkNvbnRleHRTaGFkb3c6OmJsdXJMYXllckltYWdlKTogSW5pdGlhbGl6ZSB0aGUg
Y2hhbm5lbCBtYXBwaW5nCisgICAgICAgIGJhc2VkIG9uIG1hY2hpbmUgZW5kaWFubmVzcy4KKwog
MjAxMS0wMS0wNSAgWWkgU2hlbiAgPHlpLjQuc2hlbkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2
aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh
cGhpY3MvQ29udGV4dFNoYWRvdy5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0NvbnRl
eHRTaGFkb3cuY3BwCmluZGV4IDc2M2U1OTU0N2ExOWU4M2RiZWRiNjgxZmE3NWFkODRjYmNmODg4
OWEuLjdiZWNkYTczZjI1ZTA3NmExOTA0ZTQ3Y2Y4ZTlmMDA5M2YyN2ViODQgMTAwNjQ0Ci0tLSBh
L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQ29udGV4dFNoYWRvdy5jcHAKKysrIGIvV2ViQ29y
ZS9wbGF0Zm9ybS9ncmFwaGljcy9Db250ZXh0U2hhZG93LmNwcApAQCAtMTA4LDcgKzEwOCwxNCBA
QCBzdGF0aWMgY29uc3QgaW50IEJsdXJTdW1TaGlmdCA9IDE1OwogCiB2b2lkIENvbnRleHRTaGFk
b3c6OmJsdXJMYXllckltYWdlKHVuc2lnbmVkIGNoYXIqIGltYWdlRGF0YSwgY29uc3QgSW50U2l6
ZSYgc2l6ZSwgaW50IHJvd1N0cmlkZSkKIHsKKyNpZiBDUFUoQklHX0VORElBTikKKyAgICBpbnQg
Y2hhbm5lbHNbNF0gPSB7IDAsIDMsIDIsIDAgfTsKKyNlbGlmIENQVShNSURETEVfRU5ESUFOKQor
ICAgIGludCBjaGFubmVsc1s0XSA9IHsgMSwgMiwgMywgMSB9OworI2Vsc2UKICAgICBpbnQgY2hh
bm5lbHNbNF0gPSB7IDMsIDAsIDEsIDMgfTsKKyNlbmRpZgorCiAgICAgaW50IGQgPSBtYXgoMiwg
c3RhdGljX2Nhc3Q8aW50PihmbG9vcmYoKDIgLyAzLmYpICogbV9ibHVyRGlzdGFuY2UpKSk7CiAg
ICAgaW50IGRtYXggPSBkID4+IDE7CiAgICAgaW50IGRtaW4gPSBkbWF4IC0gMSArIChkICYgMSk7
Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>