51806 2011-01-02 19:40:18 -0800 "Tool/Scripts/run-launcher --gtk" stopped working after 74855 2011-01-03 06:00:41 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Trivial --- 0 koansin.tan webkit-unassigned commit-queue joone pnormand xan.lopez oldest_to_newest 328470 0 koansin.tan 2011-01-02 19:40:18 -0800 "Tool/Scripts/run-launcher --gtk" stopped working after 74855 (JavaScriptCore/ moved to Source/JavaScriptCore) should fix Tools/Scripts/webkitdirs.pm 328476 1 77790 koansin.tan 2011-01-02 20:51:03 -0800 Created attachment 77790 proposed patch this is kinda trivial 328513 2 xan.lopez 2011-01-03 04:23:05 -0800 (In reply to comment #1) > Created an attachment (id=77790) [details] > proposed patch > > this is kinda trivial I must admit I don't get what the patch is supposed to achieve or how it's related to moving JSC to Source/. Can you explain? 328517 3 xan.lopez 2011-01-03 04:32:45 -0800 (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=77790) [details] [details] > > proposed patch > > > > this is kinda trivial > > I must admit I don't get what the patch is supposed to achieve or how it's related to moving JSC to Source/. Can you explain? From talking to Philippe (who also sees the brokeness), it seems that the problem is that this is called with JavaScriptCore as $libraryName, which does not exist now as a directory, so the whole thing will fail. I'm not sure what was the point of doing $dir/$foo/../.libs, but I think just $dir/.libs is OK as you suggest. I wonder if this has changed recently, our solution (and Qt, Elf,...) does not seem so robust anymore. 328518 4 77790 xan.lopez 2011-01-03 04:33:21 -0800 Comment on attachment 77790 proposed patch The patch is good, but you need to explain a bit more what's going on in the ChangeLog. Thanks! 328524 5 pnormand 2011-01-03 04:51:01 -0800 it used to work before JavascriptCore moved to Source/: /path/to/WebKitBuild/JavascriptCore/../.libs existed but now indeed: /path/to/WebkitBuild/Source/JavascriptCore/../.libs doesn't exist. Using ../../.libs would work but I agree with Xan that the proposed patch is better 328527 6 koansin.tan 2011-01-03 04:56:14 -0800 (In reply to comment #5) > it used to work before JavascriptCore moved to Source/: > > /path/to/WebKitBuild/JavascriptCore/../.libs existed > > but now indeed: > > /path/to/WebkitBuild/Source/JavascriptCore/../.libs doesn't exist. > > Using ../../.libs would work but I agree with Xan that the proposed patch is better yeah, I don't know why that was "JavascriptCore/../" which doesn't really make sense to me, so i removed it 328531 7 xan.lopez 2011-01-03 05:19:11 -0800 *** Bug 51816 has been marked as a duplicate of this bug. *** 328533 8 77804 koansin.tan 2011-01-03 05:25:25 -0800 Created attachment 77804 proposed patch add some explanation as Xan suggested 328535 9 77804 xan.lopez 2011-01-03 05:27:12 -0800 Comment on attachment 77804 proposed patch Thank you! 328541 10 commit-queue 2011-01-03 05:59:33 -0800 The commit-queue encountered the following flaky tests while processing attachment 77804: http/tests/xmlhttprequest/access-control-preflight-credential-async.html bug 51817 (author: jchaffraix@webkit.org) The commit-queue is continuing to process your patch. 328542 11 77804 commit-queue 2011-01-03 06:00:34 -0800 Comment on attachment 77804 proposed patch Clearing flags on attachment: 77804 Committed r74889: <http://trac.webkit.org/changeset/74889> 328543 12 commit-queue 2011-01-03 06:00:41 -0800 All reviewed patches have been landed. Closing bug. 77790 2011-01-02 20:51:03 -0800 2011-01-03 05:25:25 -0800 proposed patch after-source.diff text/plain 1156 koansin.tan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc0ODg1KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTEtMDEtMDIgIEtvYW4tU2luIFRhbiAgPGtvYW5zaW4udGFuQGdtYWlsLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAiVG9v bC9TY3JpcHRzL3J1bi1sYXVuY2hlciAtLWd0ayIgc3RvcHBlZCB3b3JraW5nIGFmdGVyIDc0ODU1 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTgwNgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOiBmaXhlZCB0aGUgcGF0aCB0byB0aGUg bGlid2Via2l0Z3RrLnNvCisKIDIwMTEtMDEtMDIgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dh QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFRv b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dl YmtpdGRpcnMucG0JKHJldmlzaW9uIDc0ODg1KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtCSh3b3JraW5nIGNvcHkpCkBAIC02MDAsNyArNjAwLDcgQEAgc3ViIGJ1aWx0RHlsaWJQYXRo Rm9yTmFtZQogICAgICAgICByZXR1cm4gIiRjb25maWd1cmF0aW9uUHJvZHVjdERpci9saWJ3eHdl YmtpdC5keWxpYiI7CiAgICAgfQogICAgIGlmIChpc0d0aygpKSB7Ci0gICAgICAgIG15ICRsaWJy YXJ5RGlyID0gIiRjb25maWd1cmF0aW9uUHJvZHVjdERpci8kbGlicmFyeU5hbWUvLi4vLmxpYnMv IjsKKyAgICAgICAgbXkgJGxpYnJhcnlEaXIgPSAiJGNvbmZpZ3VyYXRpb25Qcm9kdWN0RGlyLy5s aWJzLyI7CiAgICAgICAgIGlmICgtZSAkbGlicmFyeURpciAuICJsaWJ3ZWJraXRndGstMy4wLnNv IikgewogICAgICAgICAgICAgcmV0dXJuICRsaWJyYXJ5RGlyIC4gImxpYndlYmtpdGd0ay0zLjAu c28iOwogICAgICAgICB9Cg== 77804 2011-01-03 05:25:25 -0800 2011-01-03 06:00:34 -0800 proposed patch weird.diff text/plain 1552 koansin.tan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDc0ODg4KQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTkgQEAKKzIwMTEtMDEtMDMgIEtvYW4tU2luIFRhbiAgPGtvYW5zaW4udGFuQGdtYWlsLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAiVG9v bC9TY3JpcHRzL3J1bi1sYXVuY2hlciAtLWd0ayIgc3RvcHBlZCB3b3JraW5nIGFmdGVyIDc0ODU1 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTgwNgor CisgICAgICAgIE9yaWdpbmFsbHksIHRoZSAkbGlicmFyeU5hbWUgaXMgJ0phdmFTY3JpcHRDb3Jl Jy4gV2hlbiBidWlsZGluZyByZWxlYXNlIAorICAgICAgICBvbmUsIHRoZSAkbGlicmFyeURpciB3 YXMgJ1dlYktpdEJ1aWxkL1JlbGVhc2UvSmF2YVNjcmlwdENvcmUvLi4vLmxpYnMvJworICAgICAg ICB3aGljaCBkb2Vzbid0IGV4aXN0IGFueW1vcmUgKCdXZWJLaXRCdWlsZC9SZWxlYXNlL0phdmFT Y3JpcHRDb3JlJworICAgICAgICBpcyAnV2ViS2l0QnVpbGQvUmVsZWFzZS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUnIG5vdyksIGFuZCAKKyAgICAgICAgJ1dlYktpdEJ1aWxkL1JlbGVhc2UvU291cmNl L0phdmFTY3JpcHRDb3JlLy4uLy4uLy5saWJzJyBsb29rcyB3ZWlyZCwKKyAgICAgICAgc28gbWFr ZSBpdCAnV2ViS2l0QnVpbGQvUmVsZWFzZS8ubGlicycKKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0ZGlycy5wbTogCisKIDIwMTEtMDEtMDIgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFRvb2xz L1NjcmlwdHMvd2Via2l0ZGlycy5wbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtp dGRpcnMucG0JKHJldmlzaW9uIDc0ODg4KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt CSh3b3JraW5nIGNvcHkpCkBAIC02MDAsNyArNjAwLDcgQEAgc3ViIGJ1aWx0RHlsaWJQYXRoRm9y TmFtZQogICAgICAgICByZXR1cm4gIiRjb25maWd1cmF0aW9uUHJvZHVjdERpci9saWJ3eHdlYmtp dC5keWxpYiI7CiAgICAgfQogICAgIGlmIChpc0d0aygpKSB7Ci0gICAgICAgIG15ICRsaWJyYXJ5 RGlyID0gIiRjb25maWd1cmF0aW9uUHJvZHVjdERpci8kbGlicmFyeU5hbWUvLi4vLmxpYnMvIjsK KyAgICAgICAgbXkgJGxpYnJhcnlEaXIgPSAiJGNvbmZpZ3VyYXRpb25Qcm9kdWN0RGlyLy5saWJz LyI7CiAgICAgICAgIGlmICgtZSAkbGlicmFyeURpciAuICJsaWJ3ZWJraXRndGstMy4wLnNvIikg ewogICAgICAgICAgICAgcmV0dXJuICRsaWJyYXJ5RGlyIC4gImxpYndlYmtpdGd0ay0zLjAuc28i OwogICAgICAgICB9Cg==