51804 2011-01-02 13:23:49 -0800 Make EFL a core builder 2011-01-12 23:27:47 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED LATER P2 Normal --- 52357 1 paroga paroga abarth ap commit-queue eric wsiegrist oldest_to_newest 328423 0 paroga 2011-01-02 13:23:49 -0800 see patch 328424 1 77780 paroga 2011-01-02 13:26:18 -0800 Created attachment 77780 Patch 328426 2 77780 abarth 2011-01-02 13:45:45 -0800 Comment on attachment 77780 Patch Thanks. I'm surprised you don't need to update the webkitpy unit tests. Did you try running ./Tools/Scripts/test-webkitpy ? 328427 3 paroga 2011-01-02 13:51:27 -0800 (In reply to comment #2) > (From update of attachment 77780 [details]) > Thanks. I'm surprised you don't need to update the webkitpy unit tests. Did you try running ./Tools/Scripts/test-webkitpy ? Not all build slaves are in the unit tests (e.g. WinCairo too). So i don't find sth to change. 328428 4 abarth 2011-01-02 14:10:55 -0800 Ok. We might need to update the test to cover all the builders we have now. 328433 5 77780 commit-queue 2011-01-02 15:09:13 -0800 Comment on attachment 77780 Patch Rejecting attachment 77780 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'build-and-test', '--no-clean', '--no-update', '--test', '--non-interactive']" exit_code: 2 Last 500 characters of output: self.assertEquals(buildbot.core_builder_names_regexps, name_regexps) AssertionError: ['SnowLeopard.*Build', 'SnowLeopard.*\\(Test', 'Leopard', 'Tiger', 'Windows.*Build', 'EFL', 'GTK.*32', 'GTK.*64.*Debug', 'Qt', 'Chromium.*Release$'] != ['SnowLeopard.*Build', 'SnowLeopard.*\\(Test', 'Leopard', 'Tiger', 'Windows.*Build', 'GTK.*32', 'GTK.*64.*Debug', 'Qt', 'Chromium.*Release$'] ---------------------------------------------------------------------- Ran 766 tests in 19.645s FAILED (failures=1) Full output: http://queues.webkit.org/results/7251392 328435 6 77781 paroga 2011-01-02 15:18:34 -0800 Created attachment 77781 Patch (In reply to comment #2) > (From update of attachment 77780 [details]) > Did you try running ./Tools/Scripts/test-webkitpy ? Now it works on my machine. 328449 7 77781 commit-queue 2011-01-02 17:07:13 -0800 Comment on attachment 77781 Patch Clearing flags on attachment: 77781 Committed r74881: <http://trac.webkit.org/changeset/74881> 328450 8 commit-queue 2011-01-02 17:07:19 -0800 All reviewed patches have been landed. Closing bug. 328457 9 commit-queue 2011-01-02 17:27:03 -0800 The commit-queue encountered the following flaky tests while processing attachment 77781: fast/images/load-img-with-empty-src.html bug 50855 (author: mitz@webkit.org) The commit-queue is continuing to process your patch. 328467 10 ap 2011-01-02 19:21:42 -0800 Shouldn't making a builder "core" require webkit-dev discussion? This is a burden on all WebKit developers. 328473 11 abarth 2011-01-02 20:33:02 -0800 (In reply to comment #10) > Shouldn't making a builder "core" require webkit-dev discussion? This is a burden on all WebKit developers. Historically we haven't. Being a core builder is just an empirical property. If the builder is consistently green, it's a core builder. According to the buildbot logs, the EFL builder has been pretty consistently green. If it stops being green consistently, we can remove it from the list of core builders. 331295 12 eric 2011-01-08 15:02:57 -0800 The EFL builder is now core, but has been read for at least the last day due to some sort of compile failure. 331297 13 paroga 2011-01-08 15:11:19 -0800 (In reply to comment #12) > The EFL builder is now core, but has been read for at least the last day due to some sort of compile failure. There's some problem with the machine. The port is ok at the moment and compiles on my machine. I didn't see one of the slave admin in IRC since it's down. :-( 331298 14 eric 2011-01-08 15:14:29 -0800 Thanks. 332006 15 abarth 2011-01-10 15:46:51 -0800 This bot has been red for a while. Looks like we might have acted too soon. I didn't realize that paroga owns the WinCE bots and not the EFL bot. 333566 16 abarth 2011-01-12 23:27:47 -0800 Revert the change in https://bugs.webkit.org/show_bug.cgi?id=52357 77780 2011-01-02 13:26:18 -0800 2011-01-02 15:18:34 -0800 Patch bug-51804.patch text/plain 1009 paroga ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhM2Jh ZTEzLi43NTM3MDY0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDEtMDIgIFBhdHJpY2sgR2Fuc3RlcmVyICA8 cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTWFrZSBFRkwgYSBjb3JlIGJ1aWxkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxODA0CisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QvYnVpbGRib3QucHk6CisKIDIwMTEtMDEtMDIgIFJv YmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGJ1 aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9i dWlsZGJvdC9idWlsZGJvdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9i dWlsZGJvdC9idWlsZGJvdC5weQppbmRleCAzY2I2ZGE1Li45OGUyZmFlIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QvYnVpbGRib3QucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1aWxkYm90L2J1aWxkYm90LnB5 CkBAIC0yNzAsNiArMjcwLDcgQEAgY2xhc3MgQnVpbGRCb3Qob2JqZWN0KToKICAgICAgICAgICAg ICJMZW9wYXJkIiwKICAgICAgICAgICAgICJUaWdlciIsCiAgICAgICAgICAgICAiV2luZG93cy4q QnVpbGQiLAorICAgICAgICAgICAgIkVGTCIsCiAgICAgICAgICAgICAiR1RLLiozMiIsCiAgICAg ICAgICAgICAiR1RLLio2NC4qRGVidWciLCAgIyBEaXNhbGxvdyB0aGUgNjQtYml0IFJlbGVhc2Ug Ym90IHdoaWNoIGlzIGJyb2tlbi4KICAgICAgICAgICAgICJRdCIsCg== 77781 2011-01-02 15:18:34 -0800 2011-01-02 17:07:13 -0800 Patch bug-51804b.patch text/plain 1670 paroga ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhM2Jh ZTEzLi43NDExYzIxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDEtMDIgIFBhdHJpY2sgR2Fuc3RlcmVyICA8 cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KKwor ICAgICAgICBNYWtlIEVGTCBhIGNvcmUgYnVpbGRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE4MDQKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvY29tbW9uL25ldC9idWlsZGJvdC9idWlsZGJvdC5weToKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QvYnVpbGRib3RfdW5pdHRlc3QucHk6CisKIDIwMTEt MDEtMDIgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL25ldC9idWlsZGJvdC9idWlsZGJvdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29t bW9uL25ldC9idWlsZGJvdC9idWlsZGJvdC5weQppbmRleCAzY2I2ZGE1Li45OGUyZmFlIDEwMDY0 NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QvYnVpbGRi b3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1aWxkYm90L2J1 aWxkYm90LnB5CkBAIC0yNzAsNiArMjcwLDcgQEAgY2xhc3MgQnVpbGRCb3Qob2JqZWN0KToKICAg ICAgICAgICAgICJMZW9wYXJkIiwKICAgICAgICAgICAgICJUaWdlciIsCiAgICAgICAgICAgICAi V2luZG93cy4qQnVpbGQiLAorICAgICAgICAgICAgIkVGTCIsCiAgICAgICAgICAgICAiR1RLLioz MiIsCiAgICAgICAgICAgICAiR1RLLio2NC4qRGVidWciLCAgIyBEaXNhbGxvdyB0aGUgNjQtYml0 IFJlbGVhc2UgYm90IHdoaWNoIGlzIGJyb2tlbi4KICAgICAgICAgICAgICJRdCIsCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3QvYnVpbGRib3Rf dW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVpbGRib3Qv YnVpbGRib3RfdW5pdHRlc3QucHkKaW5kZXggYTEwZTQzMi4uODQ5OWM5ZCAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1aWxkYm90L2J1aWxkYm90X3VuaXR0 ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWlsZGJvdC9i dWlsZGJvdF91bml0dGVzdC5weQpAQCAtMjU0LDYgKzI1NCw3IEBAIGNsYXNzIEJ1aWxkQm90VGVz dCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgICAgICAgICAiTGVvcGFyZCIsCiAgICAgICAgICAg ICAiVGlnZXIiLAogICAgICAgICAgICAgIldpbmRvd3MuKkJ1aWxkIiwKKyAgICAgICAgICAgICJF RkwiLAogICAgICAgICAgICAgIkdUSy4qMzIiLAogICAgICAgICAgICAgIkdUSy4qNjQuKkRlYnVn IiwgICMgRGlzYWxsb3cgdGhlIDY0LWJpdCBSZWxlYXNlIGJvdCB3aGljaCBpcyBicm9rZW4uCiAg ICAgICAgICAgICAiUXQiLAo=