51778 2010-12-31 07:40:49 -0800 Detect direction of stack growth at runtime 2011-01-06 13:14:22 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 paroga paroga barraclough webkit-ews webkit.review.bot oldest_to_newest 328165 0 paroga 2010-12-31 07:40:49 -0800 see patch 328166 1 77719 paroga 2010-12-31 07:45:35 -0800 Created attachment 77719 Patch 328167 2 webkit.review.bot 2010-12-31 07:46:53 -0800 Attachment 77719 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'JavaScriptCore/ChangeLog', u'JavaScriptCore/wtf/StackBounds.cpp', u'JavaScriptCore/wtf/StackBounds.h']" exit_code: 1 JavaScriptCore/wtf/StackBounds.cpp:78: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] Suppressing further [whitespace/carriage_return] reports for this file. Total errors found: 7 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 328189 3 77719 eric 2010-12-31 09:32:29 -0800 Comment on attachment 77719 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77719&action=review > JavaScriptCore/wtf/StackBounds.h:89 > + static bool result = detectGrowingDownward(&dummy); result could have had a better name. Like growsDownward, etc. 328198 4 77727 paroga 2010-12-31 10:09:44 -0800 Created attachment 77727 Patch 328438 5 paroga 2011-01-02 15:58:13 -0800 Can review this one too? It's required by bug 26276. 328439 6 77783 paroga 2011-01-02 16:08:33 -0800 Created attachment 77783 Alternative Patch If the change in isGrowingDownward isn't cool we can omit it. This is an alternative patch without this change. 328441 7 77784 paroga 2011-01-02 16:19:57 -0800 Created attachment 77784 Alternative Patch (Minimal Version) That's the minimal version required for WinCE 328442 8 webkit.review.bot 2011-01-02 16:21:41 -0800 Attachment 77784 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/wtf/StackBounds.cpp']" exit_code: 1 Source/JavaScriptCore/wtf/StackBounds.cpp:78: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] Suppressing further [whitespace/carriage_return] reports for this file. Total errors found: 7 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 328444 9 webkit-ews 2011-01-02 16:42:32 -0800 Attachment 77784 did not build on qt: Build output: http://queues.webkit.org/results/7241334 328464 10 webkit.review.bot 2011-01-02 18:17:38 -0800 Attachment 77784 did not build on mac: Build output: http://queues.webkit.org/results/7273334 330362 11 paroga 2011-01-06 13:13:11 -0800 See r75180: <http://trac.webkit.org/changeset/75180> 77719 2010-12-31 07:45:35 -0800 2010-12-31 10:09:44 -0800 Patch bug-51778.patch text/plain 1861 paroga ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBiOGE2YTkyLi45OGY4MWUxIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTAtMTItMzEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGV0ZWN0IGRp cmVjdGlvbiBvZiBzdGFjayBncm93dGggYXQgcnVudGltZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE3NzgKKworICAgICAgICAqIHd0Zi9TdGFja0Jv dW5kcy5jcHA6CisgICAgICAgIChXVEY6OlN0YWNrQm91bmRzOjpkZXRlY3RHcm93aW5nRG93bndh cmQpOgorICAgICAgICAqIHd0Zi9TdGFja0JvdW5kcy5oOgorICAgICAgICAoV1RGOjpTdGFja0Jv dW5kczo6aXNHcm93aW5nRG93bndhcmQpOgorCiAyMDEwLTEyLTMwICBQYXRyaWNrIEdhbnN0ZXJl ciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFyaXlhIEhpZGF5 YXQuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvU3RhY2tCb3VuZHMuY3BwIGIvSmF2 YVNjcmlwdENvcmUvd3RmL1N0YWNrQm91bmRzLmNwcAppbmRleCBmMjYwMDA3Li40OTA1ZTU1IDEw MDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvU3RhY2tCb3VuZHMuY3BwCisrKyBiL0phdmFT Y3JpcHRDb3JlL3d0Zi9TdGFja0JvdW5kcy5jcHAKQEAgLTc1LDYgKzc1LDEzIEBAIHN0YXRpYyB2 b2lkKiBlc3RpbWF0ZVN0YWNrQm91bmQodm9pZCogb3JpZ2luKQogfQ0KICNlbmRpZg0KIA0KK2Jv b2wgU3RhY2tCb3VuZHM6OmRldGVjdEdyb3dpbmdEb3dud2FyZCh2b2lkKiBwcmV2aW91c0ZyYW1l KQ0KK3sNCisgICAgLy8gZmluZCB0aGUgYWRkcmVzcyBvZiB0aGlzIHN0YWNrIGZyYW1lIGJ5IHRh a2luZyB0aGUgYWRkcmVzcyBvZiBhIGxvY2FsIHZhcmlhYmxlDQorICAgIGludCB0aGlzRnJhbWU7 DQorICAgIHJldHVybiBwcmV2aW91c0ZyYW1lID4gJnRoaXNGcmFtZTsNCit9DQorDQogI2lmIE9T KERBUldJTikNCiANCiB2b2lkIFN0YWNrQm91bmRzOjppbml0aWFsaXplKCkNCmRpZmYgLS1naXQg YS9KYXZhU2NyaXB0Q29yZS93dGYvU3RhY2tCb3VuZHMuaCBiL0phdmFTY3JpcHRDb3JlL3d0Zi9T dGFja0JvdW5kcy5oCmluZGV4IGFmY2U4NjAuLjcyNTVmYmYgMTAwNjQ0Ci0tLSBhL0phdmFTY3Jp cHRDb3JlL3d0Zi9TdGFja0JvdW5kcy5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi9TdGFja0Jv dW5kcy5oCkBAIC04NSwxMSArODUsOSBAQCBwcml2YXRlOgogICAgIGJvb2wgaXNHcm93aW5nRG93 bndhcmQoKSBjb25zdAogICAgIHsKICAgICAgICAgQVNTRVJUKG1fb3JpZ2luICYmIG1fYm91bmQp OwotI2lmIE9TKFdJTkNFKQotICAgICAgICByZXR1cm4gbV9vcmlnaW4gPiBtX2JvdW5kOwotI2Vs c2UKLSAgICAgICAgcmV0dXJuIHRydWU7Ci0jZW5kaWYKKyAgICAgICAgaW50IGR1bW15OworICAg ICAgICBzdGF0aWMgYm9vbCByZXN1bHQgPSBkZXRlY3RHcm93aW5nRG93bndhcmQoJmR1bW15KTsK KyAgICAgICAgcmV0dXJuIHJlc3VsdDsKICAgICB9CiAKICAgICB2b2lkIGNoZWNrQ29uc2lzdGVu Y3koKSBjb25zdApAQCAtMTAzLDYgKzEwMSw4IEBAIHByaXZhdGU6CiAjZW5kaWYKICAgICB9CiAK KyAgICBzdGF0aWMgYm9vbCBkZXRlY3RHcm93aW5nRG93bndhcmQodm9pZCopOworCiAgICAgdm9p ZCogbV9vcmlnaW47CiAgICAgdm9pZCogbV9ib3VuZDsKIH07Cg== 77727 2010-12-31 10:09:44 -0800 2011-01-06 13:13:43 -0800 Patch bug-51778.patch text/plain 1862 paroga ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBiOGE2YTkyLi45OGY4MWUxIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTAtMTItMzEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRGV0ZWN0IGRp cmVjdGlvbiBvZiBzdGFjayBncm93dGggYXQgcnVudGltZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE3NzgKKworICAgICAgICAqIHd0Zi9TdGFja0Jv dW5kcy5jcHA6CisgICAgICAgIChXVEY6OlN0YWNrQm91bmRzOjpkZXRlY3RHcm93aW5nRG93bndh cmQpOgorICAgICAgICAqIHd0Zi9TdGFja0JvdW5kcy5oOgorICAgICAgICAoV1RGOjpTdGFja0Jv dW5kczo6aXNHcm93aW5nRG93bndhcmQpOgorCiAyMDEwLTEyLTMwICBQYXRyaWNrIEdhbnN0ZXJl ciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFyaXlhIEhpZGF5 YXQuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvU3RhY2tCb3VuZHMuY3BwIGIvSmF2 YVNjcmlwdENvcmUvd3RmL1N0YWNrQm91bmRzLmNwcAppbmRleCBmMjYwMDA3Li40OTA1ZTU1IDEw MDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvU3RhY2tCb3VuZHMuY3BwCisrKyBiL0phdmFT Y3JpcHRDb3JlL3d0Zi9TdGFja0JvdW5kcy5jcHAKQEAgLTc1LDYgKzc1LDEzIEBAIHN0YXRpYyB2 b2lkKiBlc3RpbWF0ZVN0YWNrQm91bmQodm9pZCogb3JpZ2luKQogfQogI2VuZGlmCiAKK2Jvb2wg U3RhY2tCb3VuZHM6OmRldGVjdEdyb3dpbmdEb3dud2FyZCh2b2lkKiBwcmV2aW91c0ZyYW1lKQor eworICAgIC8vIGZpbmQgdGhlIGFkZHJlc3Mgb2YgdGhpcyBzdGFjayBmcmFtZSBieSB0YWtpbmcg dGhlIGFkZHJlc3Mgb2YgYSBsb2NhbCB2YXJpYWJsZQorICAgIGludCB0aGlzRnJhbWU7CisgICAg cmV0dXJuIHByZXZpb3VzRnJhbWUgPiAmdGhpc0ZyYW1lOworfQorCiAjaWYgT1MoREFSV0lOKQog CiB2b2lkIFN0YWNrQm91bmRzOjppbml0aWFsaXplKCkKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRD b3JlL3d0Zi9TdGFja0JvdW5kcy5oIGIvSmF2YVNjcmlwdENvcmUvd3RmL1N0YWNrQm91bmRzLmgK aW5kZXggYWZjZTg2MC4uNzI1NWZiZiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL1N0 YWNrQm91bmRzLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL1N0YWNrQm91bmRzLmgKQEAgLTg1 LDExICs4NSw5IEBAIHByaXZhdGU6CiAgICAgYm9vbCBpc0dyb3dpbmdEb3dud2FyZCgpIGNvbnN0 CiAgICAgewogICAgICAgICBBU1NFUlQobV9vcmlnaW4gJiYgbV9ib3VuZCk7Ci0jaWYgT1MoV0lO Q0UpCi0gICAgICAgIHJldHVybiBtX29yaWdpbiA+IG1fYm91bmQ7Ci0jZWxzZQotICAgICAgICBy ZXR1cm4gdHJ1ZTsKLSNlbmRpZgorICAgICAgICBpbnQgZHVtbXk7CisgICAgICAgIHN0YXRpYyBi b29sIGdyb3dzRG93bndhcmQgPSBkZXRlY3RHcm93aW5nRG93bndhcmQoJmR1bW15KTsKKyAgICAg ICAgcmV0dXJuIGdyb3dzRG93bndhcmQ7CiAgICAgfQogCiAgICAgdm9pZCBjaGVja0NvbnNpc3Rl bmN5KCkgY29uc3QKQEAgLTEwMyw2ICsxMDEsOCBAQCBwcml2YXRlOgogI2VuZGlmCiAgICAgfQog CisgICAgc3RhdGljIGJvb2wgZGV0ZWN0R3Jvd2luZ0Rvd253YXJkKHZvaWQqKTsKKwogICAgIHZv aWQqIG1fb3JpZ2luOwogICAgIHZvaWQqIG1fYm91bmQ7CiB9Owo= 77783 2011-01-02 16:08:33 -0800 2011-01-06 13:14:11 -0800 Alternative Patch bug-51778.patch text/plain 1445 paroga ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBiOGE2YTkyLi45OGY4MWUxIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTAtMTItMzEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHJ1bnRp bWUgZGV0ZWN0IG9mIHN0YWNrIGdyb3d0aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NTE3NzgKKworICAgICAgICAqIHd0Zi9TdGFja0JvdW5kcy5jcHA6 CisgICAgICAgIChXVEY6OlN0YWNrQm91bmRzOjpkZXRlY3RHcm93aW5nRG93bndhcmQpOgorICAg ICAgICAqIHd0Zi9TdGFja0JvdW5kcy5oOgorCiAyMDEwLTEyLTMwICBQYXRyaWNrIEdhbnN0ZXJl ciAgPHBhcm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFyaXlhIEhpZGF5 YXQuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93dGYvU3RhY2tCb3VuZHMuY3BwIGIvSmF2 YVNjcmlwdENvcmUvd3RmL1N0YWNrQm91bmRzLmNwcAppbmRleCBmMjYwMDA3Li40OTA1ZTU1IDEw MDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvU3RhY2tCb3VuZHMuY3BwCisrKyBiL0phdmFT Y3JpcHRDb3JlL3d0Zi9TdGFja0JvdW5kcy5jcHAKQEAgLTc1LDYgKzc1LDEzIEBAIHN0YXRpYyB2 b2lkKiBlc3RpbWF0ZVN0YWNrQm91bmQodm9pZCogb3JpZ2luKQogfQogI2VuZGlmCiAKK2Jvb2wg U3RhY2tCb3VuZHM6OmRldGVjdEdyb3dpbmdEb3dud2FyZCh2b2lkKiBwcmV2aW91c0ZyYW1lKQor eworICAgIC8vIGZpbmQgdGhlIGFkZHJlc3Mgb2YgdGhpcyBzdGFjayBmcmFtZSBieSB0YWtpbmcg dGhlIGFkZHJlc3Mgb2YgYSBsb2NhbCB2YXJpYWJsZQorICAgIGludCB0aGlzRnJhbWU7CisgICAg cmV0dXJuIHByZXZpb3VzRnJhbWUgPiAmdGhpc0ZyYW1lOworfQorCiAjaWYgT1MoREFSV0lOKQog CiB2b2lkIFN0YWNrQm91bmRzOjppbml0aWFsaXplKCkKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRD b3JlL3d0Zi9TdGFja0JvdW5kcy5oIGIvSmF2YVNjcmlwdENvcmUvd3RmL1N0YWNrQm91bmRzLmgK aW5kZXggYWZjZTg2MC4uNzI1NWZiZiAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvd3RmL1N0 YWNrQm91bmRzLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL1N0YWNrQm91bmRzLmgKQEAgLTEw Myw2ICsxMDEsOCBAQCBwcml2YXRlOgogI2VuZGlmCiAgICAgfQogCisgICAgc3RhdGljIGJvb2wg ZGV0ZWN0R3Jvd2luZ0Rvd253YXJkKHZvaWQqKTsKKwogICAgIHZvaWQqIG1fb3JpZ2luOwogICAg IHZvaWQqIG1fYm91bmQ7CiB9Owo= 77784 2011-01-02 16:19:57 -0800 2011-01-06 13:14:22 -0800 Alternative Patch (Minimal Version) bug-51778-minimal.patch text/plain 1150 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGFkNjUzODIuLjAyYzMxYTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDExLTAxLTAyICBQYXRyaWNrIEdhbnN0 ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCBydW50aW1lIGRldGVjdGlvbiBvZiBzdGFjayBncm93dGgg ZGlyZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD01MTc3OAorCisgICAgICAgICogd3RmL1N0YWNrQm91bmRzLmNwcDoKKyAgICAgICAgKFdURjo6 ZGV0ZWN0R3Jvd2luZ0Rvd253YXJkKToKKwogMjAxMS0wMS0wMiAgQ3NhYmEgT3N6dHJvZ29uw6Fj ICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBHVEsrIGJ1aWxkIGFmdGVyIHI3NDg1 NS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvU3RhY2tCb3VuZHMuY3Bw IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9TdGFja0JvdW5kcy5jcHAKaW5kZXggZjI2MDAw Ny4uZTI0MmVlMiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9TdGFja0Jv dW5kcy5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9TdGFja0JvdW5kcy5jcHAK QEAgLTc1LDYgKzc1LDEzIEBAIHN0YXRpYyB2b2lkKiBlc3RpbWF0ZVN0YWNrQm91bmQodm9pZCog b3JpZ2luKQogfQ0KICNlbmRpZg0KIA0KK3N0YXRpYyBib29sIGRldGVjdEdyb3dpbmdEb3dud2Fy ZCh2b2lkKiBwcmV2aW91c0ZyYW1lKQ0KK3sNCisgICAgLy8gZmluZCB0aGUgYWRkcmVzcyBvZiB0 aGlzIHN0YWNrIGZyYW1lIGJ5IHRha2luZyB0aGUgYWRkcmVzcyBvZiBhIGxvY2FsIHZhcmlhYmxl DQorICAgIGludCB0aGlzRnJhbWU7DQorICAgIHJldHVybiBwcmV2aW91c0ZyYW1lID4gJnRoaXNG cmFtZTsNCit9DQorDQogI2lmIE9TKERBUldJTikNCiANCiB2b2lkIFN0YWNrQm91bmRzOjppbml0 aWFsaXplKCkNCg==