51776 2010-12-31 05:26:19 -0800 Web Inspector: make properties on Array's prototype non-enumerable 2011-01-10 06:40:07 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov podivilov apavlov bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 328161 0 podivilov 2010-12-31 05:26:19 -0800 Web Inspector: make properties on Array's prototype non-enumerable 328162 1 77717 podivilov 2010-12-31 05:27:23 -0800 Created attachment 77717 Patch. 328188 2 77717 eric 2010-12-31 09:31:05 -0800 Comment on attachment 77717 Patch. How do we test this? What's the purpose of this change? 331589 3 pfeldman 2011-01-10 04:46:45 -0800 (In reply to comment #2) > (From update of attachment 77717 [details]) > How do we test this? What's the purpose of this change? Hey. This is a trivial change to the inspector's utility Array extension. It just makes functions on array prototype non-enumerable. It does not affect web-facing functionality. I would test it using jsunit or similar in inspector context, but we don't have such harness yet. 331604 4 commit-queue 2011-01-10 06:38:30 -0800 The commit-queue encountered the following flaky tests while processing attachment 77717: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch. 331605 5 77717 commit-queue 2011-01-10 06:39:59 -0800 Comment on attachment 77717 Patch. Clearing flags on attachment: 77717 Committed r75370: <http://trac.webkit.org/changeset/75370> 331606 6 commit-queue 2011-01-10 06:40:07 -0800 All reviewed patches have been landed. Closing bug. 77717 2010-12-31 05:27:23 -0800 2011-01-10 06:39:59 -0800 Patch. patch text/plain 1502 podivilov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWQwNTFjZC4uYzFhZmRiZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMi0zMSAgUGF2ZWwgUG9kaXZp bG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBtYWtlIHByb3BlcnRpZXMgb24g QXJyYXkncyBwcm90b3R5cGUgbm9uLWVudW1lcmFibGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTc3NgorCisgICAgICAgICogaW5zcGVjdG9yL2Zy b250LWVuZC91dGlsaXRpZXMuanM6CisgICAgICAgICgpOgorCiAyMDEwLTEyLTI5ICBaaGVueWFv IE1vICA8em1vQGdvb2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSdXNz ZWxsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5q cyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMuanMKaW5kZXggNjg4ZTA4 MC4uMTFmNjM4NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxp dGllcy5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdXRpbGl0aWVzLmpzCkBA IC03MTUsNyArNzE1LDcgQEAgSFRNTFRleHRBcmVhRWxlbWVudC5wcm90b3R5cGUubW92ZUN1cnNv clRvRW5kID0gZnVuY3Rpb24oKQogICAgIHRoaXMuc2V0U2VsZWN0aW9uUmFuZ2UobGVuZ3RoLCBs ZW5ndGgpOwogfQogCi1BcnJheS5wcm90b3R5cGUucmVtb3ZlID0gZnVuY3Rpb24odmFsdWUsIG9u bHlGaXJzdCkKK09iamVjdC5kZWZpbmVQcm9wZXJ0eShBcnJheS5wcm90b3R5cGUsICJyZW1vdmUi LCB7IHZhbHVlOiBmdW5jdGlvbih2YWx1ZSwgb25seUZpcnN0KQogewogICAgIGlmIChvbmx5Rmly c3QpIHsKICAgICAgICAgdmFyIGluZGV4ID0gdGhpcy5pbmRleE9mKHZhbHVlKTsKQEAgLTcyOSwx NSArNzI5LDE1IEBAIEFycmF5LnByb3RvdHlwZS5yZW1vdmUgPSBmdW5jdGlvbih2YWx1ZSwgb25s eUZpcnN0KQogICAgICAgICBpZiAodGhpc1tpXSA9PT0gdmFsdWUpCiAgICAgICAgICAgICB0aGlz LnNwbGljZShpLCAxKTsKICAgICB9Ci19Cit9fSk7CiAKLUFycmF5LnByb3RvdHlwZS5rZXlTZXQg PSBmdW5jdGlvbigpCitPYmplY3QuZGVmaW5lUHJvcGVydHkoQXJyYXkucHJvdG90eXBlLCAia2V5 U2V0IiwgeyB2YWx1ZTogZnVuY3Rpb24oKQogewogICAgIHZhciBrZXlzID0ge307CiAgICAgZm9y ICh2YXIgaSA9IDA7IGkgPCB0aGlzLmxlbmd0aDsgKytpKQogICAgICAgICBrZXlzW3RoaXNbaV1d ID0gdHJ1ZTsKICAgICByZXR1cm4ga2V5czsKLX0KK319KTsKIAogQXJyYXkuZGlmZiA9IGZ1bmN0 aW9uKGxlZnQsIHJpZ2h0KQogewo=