51762 2010-12-30 12:48:46 -0800 Remove unused JSBinding source files 2010-12-30 16:24:48 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 51714 1 darin darin commit-queue oldest_to_newest 328007 0 darin 2010-12-30 12:48:46 -0800 Remove unused JSBinding source files 328008 1 77696 darin 2010-12-30 12:50:22 -0800 Created attachment 77696 Patch 328018 2 77696 ddkilzer 2010-12-30 13:12:56 -0800 Comment on attachment 77696 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=77696&action=review > WebCore/ChangeLog:9 > + * bindings/js/specialization: Removed. It's too bad JSBindingState.h and JSBindindState.cpp aren't listed here in the ChangeLog. It's useful to know when the files were removed by searching for them by name. 328019 3 77696 commit-queue 2010-12-30 13:14:49 -0800 Comment on attachment 77696 Patch Rejecting attachment 77696 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-attachment', '--no-update', '--non-interactive', 77696]" exit_code: 2 Last 500 characters of output: bindings/js/JSBinding.h rm 'WebCore/bindings/js/JSBinding.h' patching file WebCore/bindings/js/JSBindingsAllInOne.cpp patching file WebCore/bindings/js/specialization/JSBindingState.cpp rm 'WebCore/bindings/js/specialization/JSBindingState.cpp' patching file WebCore/bindings/js/specialization/JSBindingState.h rm 'WebCore/bindings/js/specialization/JSBindingState.h' Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'David Kilzer', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7281311 328064 4 darin 2010-12-30 16:24:48 -0800 Committed r74814: <http://trac.webkit.org/changeset/74814> 77696 2010-12-30 12:50:22 -0800 2010-12-30 13:14:49 -0800 Patch bug-51762-20101230125021.patch text/plain 7163 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDgwNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMTItMzAgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92 ZSB1bnVzZWQgSlNCaW5kaW5nIHNvdXJjZSBmaWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE3NjIKKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pT QmluZGluZy5oOiBSZW1vdmVkLgorICAgICAgICAqIGJpbmRpbmdzL2pzL3NwZWNpYWxpemF0aW9u OiBSZW1vdmVkLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6IFJlbW92ZWQgcmVmZXJlbmNl cyB0byBmaWxlcy4KKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbTogRGl0dG8uCisgICAgICAgICog V2ViQ29yZS5neXBpOiBEaXR0by4KKyAgICAgICAgKiBXZWJDb3JlLnBybzogRGl0dG8uCisgICAg ICAgICogV2ViQ29yZS52Y3Byb2ovV2ViQ29yZS52Y3Byb2o6IERpdHRvLgorICAgICAgICAqIGJp bmRpbmdzL2pzL0pTQmluZGluZ3NBbGxJbk9uZS5jcHA6IERpdHRvLgorCiAyMDEwLTEyLTMwICBZ YWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBZGFtIEJhcnRoLgpJbmRleDogV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL0NNYWtlTGlzdHMudHh0CShyZXZpc2lvbiA3NDgwNSkKKysrIFdlYkNvcmUvQ01h a2VMaXN0cy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTcyNiw4ICs3MjYsNiBAQCBTRVQoV2ViQ29y ZV9TT1VSQ0VTCiAgICAgYmluZGluZ3MvanMvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcAogICAg IGJpbmRpbmdzL2pzL1dvcmtlclNjcmlwdENvbnRyb2xsZXIuY3BwCiAKLSAgICBiaW5kaW5ncy9q cy9zcGVjaWFsaXphdGlvbi9KU0JpbmRpbmdTdGF0ZS5jcHAKLQogICAgIGJyaWRnZS9JZGVudGlm aWVyUmVwLmNwcAogICAgIGJyaWRnZS9OUF9qc29iamVjdC5jcHAKICAgICBicmlkZ2UvbnBydW50 aW1lLmNwcApJbmRleDogV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL0dOVW1ha2VmaWxlLmFtCShyZXZpc2lvbiA3NDgwNSkKKysrIFdlYkNvcmUvR05VbWFrZWZp bGUuYW0JKHdvcmtpbmcgY29weSkKQEAgLTY5OCw3ICs2OTgsNiBAQCB3ZWJjb3JlX3NvdXJjZXMg Kz0gXAogCVdlYkNvcmUvYmluZGluZ3MvanMvSlNBdHRyQ3VzdG9tLmNwcCBcCiAJV2ViQ29yZS9i aW5kaW5ncy9qcy9KU0F1ZGlvQ29uc3RydWN0b3IuY3BwIFwKIAlXZWJDb3JlL2JpbmRpbmdzL2pz L0pTQXVkaW9Db25zdHJ1Y3Rvci5oIFwKLQlXZWJDb3JlL2JpbmRpbmdzL2pzL0pTQmluZGluZy5o IFwKIAlXZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ0RBVEFTZWN0aW9uQ3VzdG9tLmNwcCBcCiAJV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU0NTU0ZvbnRGYWNlUnVsZUN1c3RvbS5jcHAgXAogCVdlYkNvcmUv YmluZGluZ3MvanMvSlNDU1NJbXBvcnRSdWxlQ3VzdG9tLmNwcCBcCkBAIC05MDQsOCArOTAzLDYg QEAgd2ViY29yZV9zb3VyY2VzICs9IFwKIAlXZWJDb3JlL2JpbmRpbmdzL2pzL1dlYkNvcmVKU0Ns aWVudERhdGEuaCBcCiAJV2ViQ29yZS9iaW5kaW5ncy9qcy9Xb3JrZXJTY3JpcHRDb250cm9sbGVy LmNwcCBcCiAJV2ViQ29yZS9iaW5kaW5ncy9qcy9Xb3JrZXJTY3JpcHRDb250cm9sbGVyLmggXAot CVdlYkNvcmUvYmluZGluZ3MvanMvc3BlY2lhbGl6YXRpb24vSlNCaW5kaW5nU3RhdGUuY3BwIFwK LQlXZWJDb3JlL2JpbmRpbmdzL2pzL3NwZWNpYWxpemF0aW9uL0pTQmluZGluZ1N0YXRlLmggXAog CVdlYkNvcmUvYmluZGluZ3MvU2NyaXB0Q29udHJvbGxlckJhc2UuY3BwIFwKIAlXZWJDb3JlL2Jp bmRpbmdzL1NjcmlwdENvbnRyb2xsZXJCYXNlLmggXAogCVdlYkNvcmUvYnJpZGdlL0JyaWRnZS5o IFwKSW5kZXg6IFdlYkNvcmUvV2ViQ29yZS5neXBpCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvV2Vi Q29yZS5neXBpCShyZXZpc2lvbiA3NDgwNSkKKysrIFdlYkNvcmUvV2ViQ29yZS5neXBpCSh3b3Jr aW5nIGNvcHkpCkBAIC01NjksNyArNTY5LDYgQEAKICAgICAgICAgICAgICdiaW5kaW5ncy9qcy9K U0F0dHJDdXN0b20uY3BwJywKICAgICAgICAgICAgICdiaW5kaW5ncy9qcy9KU0F1ZGlvQ29uc3Ry dWN0b3IuY3BwJywKICAgICAgICAgICAgICdiaW5kaW5ncy9qcy9KU0F1ZGlvQ29uc3RydWN0b3Iu aCcsCi0gICAgICAgICAgICAnYmluZGluZ3MvanMvSlNCaW5kaW5nLmgnLAogICAgICAgICAgICAg J2JpbmRpbmdzL2pzL0pTQ2FudmFzUmVuZGVyaW5nQ29udGV4dEN1c3RvbS5jcHAnLAogICAgICAg ICAgICAgJ2JpbmRpbmdzL2pzL0pTQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQ3VzdG9tLmNwcCcs CiAgICAgICAgICAgICAnYmluZGluZ3MvanMvSlNDREFUQVNlY3Rpb25DdXN0b20uY3BwJywKQEAg LTc1OCw4ICs3NTcsNiBAQAogICAgICAgICAgICAgJ2JpbmRpbmdzL2pzL1dlYkNvcmVKU0NsaWVu dERhdGEuaCcsCiAgICAgICAgICAgICAnYmluZGluZ3MvanMvV29ya2VyU2NyaXB0Q29udHJvbGxl ci5jcHAnLAogICAgICAgICAgICAgJ2JpbmRpbmdzL2pzL1dvcmtlclNjcmlwdENvbnRyb2xsZXIu aCcsCi0gICAgICAgICAgICAnYmluZGluZ3MvanMvc3BlY2lhbGl6YXRpb24vSlNCaW5kaW5nU3Rh dGUuY3BwJywKLSAgICAgICAgICAgICdiaW5kaW5ncy9qcy9zcGVjaWFsaXphdGlvbi9KU0JpbmRp bmdTdGF0ZS5oJywKICAgICAgICAgICAgICdiaW5kaW5ncy9TY3JpcHRDb250cm9sbGVyQmFzZS5j cHAnLAogICAgICAgICAgICAgJ2JpbmRpbmdzL1NjcmlwdENvbnRyb2xsZXJCYXNlLmgnLAogICAg ICAgICAgICAgJ2JpbmRpbmdzL3Y4L0NoaWxkVGhyZWFkRE9NRGF0YS5jcHAnLApJbmRleDogV2Vi Q29yZS9XZWJDb3JlLnBybwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL1dlYkNvcmUucHJvCShyZXZp c2lvbiA3NDgwNSkKKysrIFdlYkNvcmUvV2ViQ29yZS5wcm8JKHdvcmtpbmcgY29weSkKQEAgLTYx OCw3ICs2MTgsNiBAQCB2OCB7CiAgICAgICAgIGJpbmRpbmdzL2pzL1NjcmlwdFN0YXRlLmNwcCBc CiAgICAgICAgIGJpbmRpbmdzL2pzL1NjcmlwdFZhbHVlLmNwcCBcCiAgICAgICAgIGJpbmRpbmdz L2pzL1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAgXAotICAgICAgICBiaW5kaW5ncy9qcy9zcGVj aWFsaXphdGlvbi9KU0JpbmRpbmdTdGF0ZS5jcHAgXAogICAgICAgICBicmlkZ2UvSWRlbnRpZmll clJlcC5jcHAgXAogICAgICAgICBicmlkZ2UvTlBfanNvYmplY3QuY3BwIFwKICAgICAgICAgYnJp ZGdlL2MvQ1J1bnRpbWVPYmplY3QuY3BwIFwKSW5kZXg6IFdlYkNvcmUvV2ViQ29yZS52Y3Byb2ov V2ViQ29yZS52Y3Byb2oKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9XZWJDb3JlLnZjcHJvai9XZWJD b3JlLnZjcHJvagkocmV2aXNpb24gNzQ4MDUpCisrKyBXZWJDb3JlL1dlYkNvcmUudmNwcm9qL1dl YkNvcmUudmNwcm9qCSh3b3JraW5nIGNvcHkpCkBAIC01NTg0NSw3MCArNTU4NDUsMTAgQEAKIAkJ CQkJPgogCQkJCTwvRmlsZT4KIAkJCQk8RmlsZQotCQkJCQlSZWxhdGl2ZVBhdGg9Ii4uXGJpbmRp bmdzXGpzXEpTQmluZGluZy5oIgotCQkJCQk+Ci0JCQkJPC9GaWxlPgotCQkJCTxGaWxlCiAJCQkJ CVJlbGF0aXZlUGF0aD0iLi5cYmluZGluZ3NcanNcSlNCaW5kaW5nc0FsbEluT25lLmNwcCIKIAkJ CQkJPgogCQkJCTwvRmlsZT4KIAkJCQk8RmlsZQotCQkJCQlSZWxhdGl2ZVBhdGg9Ii4uXGJpbmRp bmdzXGpzXHNwZWNpYWxpemF0aW9uXEpTQmluZGluZ1N0YXRlLmNwcCIKLQkJCQkJPgotCQkJCQk8 RmlsZUNvbmZpZ3VyYXRpb24KLQkJCQkJCU5hbWU9IkRlYnVnfFdpbjMyIgotCQkJCQkJRXhjbHVk ZWRGcm9tQnVpbGQ9InRydWUiCi0JCQkJCQk+Ci0JCQkJCQk8VG9vbAotCQkJCQkJCU5hbWU9IlZD Q0xDb21waWxlclRvb2wiCi0JCQkJCQkvPgotCQkJCQk8L0ZpbGVDb25maWd1cmF0aW9uPgotCQkJ CQk8RmlsZUNvbmZpZ3VyYXRpb24KLQkJCQkJCU5hbWU9IlJlbGVhc2V8V2luMzIiCi0JCQkJCQlF eGNsdWRlZEZyb21CdWlsZD0idHJ1ZSIKLQkJCQkJCT4KLQkJCQkJCTxUb29sCi0JCQkJCQkJTmFt ZT0iVkNDTENvbXBpbGVyVG9vbCIKLQkJCQkJCS8+Ci0JCQkJCTwvRmlsZUNvbmZpZ3VyYXRpb24+ Ci0JCQkJCTxGaWxlQ29uZmlndXJhdGlvbgotCQkJCQkJTmFtZT0iRGVidWdfQ2Fpcm9fQ0ZMaXRl fFdpbjMyIgotCQkJCQkJRXhjbHVkZWRGcm9tQnVpbGQ9InRydWUiCi0JCQkJCQk+Ci0JCQkJCQk8 VG9vbAotCQkJCQkJCU5hbWU9IlZDQ0xDb21waWxlclRvb2wiCi0JCQkJCQkvPgotCQkJCQk8L0Zp bGVDb25maWd1cmF0aW9uPgotCQkJCQk8RmlsZUNvbmZpZ3VyYXRpb24KLQkJCQkJCU5hbWU9IlJl bGVhc2VfQ2Fpcm9fQ0ZMaXRlfFdpbjMyIgotCQkJCQkJRXhjbHVkZWRGcm9tQnVpbGQ9InRydWUi Ci0JCQkJCQk+Ci0JCQkJCQk8VG9vbAotCQkJCQkJCU5hbWU9IlZDQ0xDb21waWxlclRvb2wiCi0J CQkJCQkvPgotCQkJCQk8L0ZpbGVDb25maWd1cmF0aW9uPgotCQkJCQk8RmlsZUNvbmZpZ3VyYXRp b24KLQkJCQkJCU5hbWU9IkRlYnVnX0FsbHxXaW4zMiIKLQkJCQkJCUV4Y2x1ZGVkRnJvbUJ1aWxk PSJ0cnVlIgotCQkJCQkJPgotCQkJCQkJPFRvb2wKLQkJCQkJCQlOYW1lPSJWQ0NMQ29tcGlsZXJU b29sIgotCQkJCQkJLz4KLQkJCQkJPC9GaWxlQ29uZmlndXJhdGlvbj4KLQkJCQkJPEZpbGVDb25m aWd1cmF0aW9uCi0JCQkJCQlOYW1lPSJSZWxlYXNlX0xUQ0d8V2luMzIiCi0JCQkJCQlFeGNsdWRl ZEZyb21CdWlsZD0idHJ1ZSIKLQkJCQkJCT4KLQkJCQkJCTxUb29sCi0JCQkJCQkJTmFtZT0iVkND TENvbXBpbGVyVG9vbCIKLQkJCQkJCS8+Ci0JCQkJCTwvRmlsZUNvbmZpZ3VyYXRpb24+Ci0JCQkJ PC9GaWxlPgotCQkJCTxGaWxlCi0JCQkJCVJlbGF0aXZlUGF0aD0iLi5cYmluZGluZ3NcanNcc3Bl Y2lhbGl6YXRpb25cSlNCaW5kaW5nU3RhdGUuaCIKLQkJCQkJPgotCQkJCTwvRmlsZT4KLQkJCQk8 RmlsZQogCQkJCQlSZWxhdGl2ZVBhdGg9Ii4uXGJpbmRpbmdzXGpzXEpTQ2FsbGJhY2tEYXRhLmNw cCIKIAkJCQkJPgogCQkJCQk8RmlsZUNvbmZpZ3VyYXRpb24KSW5kZXg6IFdlYkNvcmUvYmluZGlu Z3MvanMvSlNCaW5kaW5nLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0Jp bmRpbmcuaAkocmV2aXNpb24gNzQ4MDUpCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTQmluZGlu Zy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xLDIgKzAsMCBAQAotLy8gT25jZSByZWZlcmVuY2VzIHRv IHRoaXMgZmlsZSBhcmUgcmVtb3ZlZCBmcm9tIGJ1aWxkIGZpbGVzLCB0aGlzIGZpbGUgc2hvdWxk IGJlIGRlbGV0ZWQuCi0jZXJyb3IKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvanMvSlNCaW5kaW5n c0FsbEluT25lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTQmluZGlu Z3NBbGxJbk9uZS5jcHAJKHJldmlzaW9uIDc0ODA1KQorKysgV2ViQ29yZS9iaW5kaW5ncy9qcy9K U0JpbmRpbmdzQWxsSW5PbmUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMCw3ICszMCw2IEBACiAj aW5jbHVkZSAiR0NDb250cm9sbGVyLmNwcCIKICNpbmNsdWRlICJKU0F0dHJDdXN0b20uY3BwIgog I2luY2x1ZGUgIkpTQXVkaW9Db25zdHJ1Y3Rvci5jcHAiCi0jaW5jbHVkZSAiSlNCaW5kaW5nU3Rh dGUuY3BwIgogI2luY2x1ZGUgIkpTQ0RBVEFTZWN0aW9uQ3VzdG9tLmNwcCIKICNpbmNsdWRlICJK U0NTU0ZvbnRGYWNlUnVsZUN1c3RvbS5jcHAiCiAjaW5jbHVkZSAiSlNDU1NJbXBvcnRSdWxlQ3Vz dG9tLmNwcCIKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvanMvc3BlY2lhbGl6YXRpb24vSlNCaW5k aW5nU3RhdGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvanMvc3BlY2lhbGl6 YXRpb24vSlNCaW5kaW5nU3RhdGUuY3BwCShyZXZpc2lvbiA3NDgwNSkKKysrIFdlYkNvcmUvYmlu ZGluZ3MvanMvc3BlY2lhbGl6YXRpb24vSlNCaW5kaW5nU3RhdGUuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xICswLDAgQEAKLS8vIE9uY2UgcmVmZXJlbmNlcyB0byB0aGlzIGZpbGUgYXJlIHJlbW92 ZWQgZnJvbSBidWlsZCBmaWxlcywgdGhpcyBmaWxlIHNob3VsZCBiZSBkZWxldGVkLgpJbmRleDog V2ViQ29yZS9iaW5kaW5ncy9qcy9zcGVjaWFsaXphdGlvbi9KU0JpbmRpbmdTdGF0ZS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvanMvc3BlY2lhbGl6YXRpb24vSlNCaW5kaW5nU3Rh dGUuaAkocmV2aXNpb24gNzQ4MDUpCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL3NwZWNpYWxpemF0 aW9uL0pTQmluZGluZ1N0YXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTEsMiArMCwwIEBACi0vLyBP bmNlIHJlZmVyZW5jZXMgdG8gdGhpcyBmaWxlIGFyZSByZW1vdmVkIGZyb20gYnVpbGQgZmlsZXMs IHRoaXMgZmlsZSBzaG91bGQgYmUgZGVsZXRlZC4KLSNlcnJvcgo=