51758 2010-12-30 11:41:50 -0800 check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get 2010-12-30 13:46:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned oldest_to_newest 327981 0 mrobinson 2010-12-30 11:41:50 -0800 gtk_widget_style_get requies the use of NULL as a call sentinel much like in g_object_get and g_object_set. 327996 1 77695 mrobinson 2010-12-30 12:20:06 -0800 Created attachment 77695 Patch 327997 2 mrobinson 2010-12-30 12:21:21 -0800 Unfortunately this patch does not remove all of the false positives from RenderThemeGtk. It seems that check-webkit-style does not always handle multi-line function calls properly. 328031 3 mrobinson 2010-12-30 13:46:32 -0800 Committed r74809: <http://trac.webkit.org/changeset/74809> 77695 2010-12-30 12:20:06 -0800 2010-12-30 12:38:08 -0800 Patch bug-51758-20101230122005.patch text/plain 2711 mrobinson ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1NGU3 ZmRjYmY3ZWE5NDMzNDU0MGM2ZWEzM2VjYTRhZGFhMTFlZjVhLi4wN2E4MDc2ZjRlMTNjYmYxZjc1 N2E4ZDIzODViNDAwZjBiM2ZmYjM0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTItMzAgIE1hcnRpbiBSb2Jp bnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBzaG91bGQgaWdub3JlIE5V TEwgdXNhZ2UgaW4gY2FsbHMgdG8gZ3RrX3dpZGdldF9zdHlsZV9nZXQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNzU4CisKKyAgICAgICAgQWRkIGEg Y2hlY2std2Via2l0LXN0eWxlIGV4Y2VwdGlvbiBmb3IgZ3RrX3dpZGdldF9zdHlsZV9nZXQgYW5k IE5VTEwgdXNhZ2UuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJz L2NwcC5weTogQWRkIHRoZSBleGNlcHRpb24uCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9z dHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHk6IEFkZCBzb21lIHRlc3RzIGZvciB0aGlzLgor CiAyMDEwLTEyLTI5ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBPamFuIFZhZmFpLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NwcC5weQppbmRleCA5MDJhMGExYmE3YmIwNjc2OTE0MTVlYjIyZDk2 M2RjODM2N2YyYmVkLi41OGMxM2RmOTBjN2U3YzhlN2NkMzNmOTRkYzE0ZmM3NTVkYzE2ZmFhIDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMjI4 Myw2ICsyMjgzLDEwIEBAIGRlZiBjaGVja19mb3JfbnVsbChjbGVhbl9saW5lcywgbGluZV9udW1i ZXIsIGZpbGVfc3RhdGUsIGVycm9yKToKICAgICBpZiBzZWFyY2gocidcYmdka19waXhidWZfc2F2 ZV90b1x3K1xiJywgbGluZSk6CiAgICAgICAgIHJldHVybgogCisgICAgIyBEb24ndCB3YXJuIGFi b3V0IE5VTEwgdXNhZ2UgaW4gZ3RrX3dpZGdldF9zdHlsZV9nZXQoKS4gU2VlIEJ1ZyA1MTc1OC4K KyAgICBpZiBzZWFyY2gocidcYmd0a193aWRnZXRfc3R5bGVfZ2V0XChcdytcYicsIGxpbmUpOgor ICAgICAgICByZXR1cm4KKwogICAgIGlmIHNlYXJjaChyJ1xiTlVMTFxiJywgbGluZSk6CiAgICAg ICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncmVhZGFiaWxpdHkvbnVsbCcsIDUsICdVc2UgMCBpbnN0 ZWFkIG9mIE5VTEwuJykKICAgICAgICAgcmV0dXJuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IDhlZTczZmVlNTg1 NWZkODU0ZjUxODQxODJiZDgyM2JiZWUyNzlmZGYuLjU3NDZlZjNlNTg3ZTQ1MDE5ZjcxZjlkNjUx M2VmMzYzMWM3MjkxYzIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC0zODU4LDYgKzM4NTgsMTcgQEAgY2xhc3Mg V2ViS2l0U3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICBzZWxmLmFzc2VydF9s aW50KAogICAgICAgICAgICAgJ2djaGFyKiByZXN1bHQgPSBnZGtfcGl4YnVmX3NhdmVfdG9fc3Ry ZWFtKHBpeGJ1ZiwgZnVuY3Rpb24sIGRhdGEsIHR5cGUsIGVycm9yLCBOVUxMKTsnLAogICAgICAg ICAgICAgJycpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoCisgICAgICAgICAgICAnZ3RrX3dp ZGdldF9zdHlsZV9nZXQoc3R5bGUsICJwcm9wZXJ0eU5hbWUiLCAmdmFsdWUsICJvdGhlck5hbWUi LCAmb3RoZXJWYWx1ZSwgTlVMTCk7JywKKyAgICAgICAgICAgICcnKQorICAgICAgICBzZWxmLmFz c2VydF9saW50KAorICAgICAgICAgICAgJ2d0a193aWRnZXRfc3R5bGVfZ2V0X3Byb3BlcnR5KHN0 eWxlLCBOVUxMLCBOVUxMKTsnLAorICAgICAgICAgICAgJ1VzZSAwIGluc3RlYWQgb2YgTlVMTC4g IFtyZWFkYWJpbGl0eS9udWxsXSBbNV0nLAorICAgICAgICAgICAgJ2Zvby5jcHAnKQorICAgICAg ICBzZWxmLmFzc2VydF9saW50KAorICAgICAgICAgICAgJ2d0a193aWRnZXRfc3R5bGVfZ2V0X3Zh bGlzdChzdHlsZSwgTlVMTCwgTlVMTCk7JywKKyAgICAgICAgICAgICdVc2UgMCBpbnN0ZWFkIG9m IE5VTEwuICBbcmVhZGFiaWxpdHkvbnVsbF0gWzVdJywKKyAgICAgICAgICAgICdmb28uY3BwJykK IAogICAgICAgICAjIDIuIEMrKyBhbmQgQyBib29sIHZhbHVlcyBzaG91bGQgYmUgd3JpdHRlbiBh cyB0cnVlIGFuZAogICAgICAgICAjICAgIGZhbHNlLiBPYmplY3RpdmUtQyBCT09MIHZhbHVlcyBz aG91bGQgYmUgd3JpdHRlbiBhcyBZRVMgYW5kIE5PLgo=