5175 2005-09-28 17:41:17 -0700 Missing image for SVG embedded in <object> tag in HTML document 2005-10-06 04:40:59 -0700 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED http://www.sensoryoutput.com/freshview/index_svg.php P2 Normal --- 1 krove eric oldest_to_newest 20879 0 krove 2005-09-28 17:41:17 -0700 Overview Description: HTML document with <object> tags referencing SVG do not show the SVG content, instead displaying the missing image icon. HTML pages with the <embed> tag, do properly show the SVG content, as in http://www.sensoryoutput.com/freshview/index_svg2.php Steps to Reproduce: 1) Create an HTML page with <object> tag referencing an SVG document. 2) View that HTML page. Actual Results: A missing image icon shows up in place of the expected SVG document. Expected Results: Should see SVG document. Build Date & Platform: WebKit+SVG nightly build 2005-09-28 21257 1 eric 2005-10-03 01:28:00 -0700 Can you point me to an example? Or a reduced test case? Thanks. 21299 2 eric 2005-10-03 14:51:20 -0700 Ok, now I notice the URL given is actually an example: http://www.sensoryoutput.com/freshview/index_svg.php but directly accessing the svg: http://www.sensoryoutput.com/mint/pepper/kylerove/freshview/caches/pastweek_graph.svg works. Definitely a bug, and different from http://bugzilla.opendarwin.org/show_bug.cgi?id=5246 21374 3 4202 julien.palmas 2005-10-04 19:54:39 -0700 Created attachment 4202 patch that makes Webkit+svg render <object> tags with image/svg+xml type Hack to render html pages with svg in <object> tags. The problem comes from KWQPixmap.mm, canRenderImageType methods that returns yes for the serviceType "image/svg+xml". Is this a desired behaviour that WebCoreImageRendererFactory supports the svg MIME type ? If yes, the hack should not take place in canRenderImageType but rather in html_objectimpl.cpp, HTMLObjectElementImpl::attach() 21379 4 4202 eric 2005-10-04 22:13:45 -0700 Comment on attachment 4202 patch that makes Webkit+svg render <object> tags with image/svg+xml type So a couple things. 1. We use spaces and not tabs, per: http://webkit.opendarwin.org/blog/?page_id=25 2. We would need any SVG specific changes to KWQ to be inside SVG_SUPPORT change blocks. Otherwise this looks OK. We don't need any comments on this type of change. It would be better to investigate why WebCoreImageRendererFactory allows this as a MIME type though. 21386 5 4206 eric 2005-10-05 00:30:45 -0700 Created attachment 4206 An alternative patch, which fixes HTMLObjectElementImpl to not use image mode for SVGs 21387 6 eric 2005-10-05 00:33:26 -0700 Thank you Julien for all your hard work on this bug! I've gone ahead and adapted your patch and moved the code into HTMLObjectElementImpl. What was causing this was the fact that I created an NSSVGImageRep which registers with the NSImage system as able to support SVG images. Then, due to: http://bugzilla.opendarwin.org/show_bug.cgi?id=5270 WebKit thought it could support SVGs when it really couldn't. This patch makes it so that WebCore will always default to it's own SVG rendering for <object> tags (and only for object tags), even if the image system says it supports them. 21390 7 4206 mjs 2005-10-05 01:11:50 -0700 Comment on attachment 4206 An alternative patch, which fixes HTMLObjectElementImpl to not use image mode for SVGs r=me 4202 2005-10-04 19:54:39 -0700 2005-10-05 00:30:45 -0700 patch that makes Webkit+svg render <object> tags with image/svg+xml type patch_for_object_tag text/plain 924 julien.palmas SW5kZXg6IGt3cS9LV1FQaXhtYXAubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dl YkNvcmUva3dxL0tXUVBpeG1hcC5tbSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS41MApkaWZmIC1w IC11IC1yMS41MCBLV1FQaXhtYXAubW0KLS0tIGt3cS9LV1FQaXhtYXAubW0JMjcgQXVnIDIwMDUg MDA6MTQ6MjIgLTAwMDAJMS41MAorKysga3dxL0tXUVBpeG1hcC5tbQk1IE9jdCAyMDA1IDAyOjQ5 OjUyIC0wMDAwCkBAIC0zOCw3ICszOCwxNSBAQCBRUGl4bWFwICpLV1FMb2FkUGl4bWFwKGNvbnN0 IGNoYXIgKm5hbWUpCiAKIGJvb2wgY2FuUmVuZGVySW1hZ2VUeXBlKGNvbnN0IFFTdHJpbmcgJnR5 cGUpCiB7Ci0gICAgcmV0dXJuIFtbW1dlYkNvcmVJbWFnZVJlbmRlcmVyRmFjdG9yeSBzaGFyZWRG YWN0b3J5XSBzdXBwb3J0ZWRNSU1FVHlwZXNdIGNvbnRhaW5zT2JqZWN0OnR5cGUuZ2V0TlNTdHJp bmcoKV07CisJLy8gYSBoYWNrIHRoYXQgcmV0dXJucyBOTyBpZiB0eXBlID09IEAiaW1hZ2Uvc3Zn K3htbCIKKwkvLyB0aGFua3MgdG8gdGhpcywgaHRtbCBwYWdlcyB3aXRoIDxvYmplY3Q+IHRhZ3Mg Y29udGFpbmluZworCS8vIHN2ZyBhcmUgcmVuZGVyZWQgY29ycmVjdGx5CisJTlNTdHJpbmcgKnNl cnZpY2VUeXBlID0gdHlwZS5nZXROU1N0cmluZygpOworCWlmIChbc2VydmljZVR5cGUgaXNFcXVh bFRvU3RyaW5nOkAiaW1hZ2Uvc3ZnK3htbCJdKQorCQlyZXR1cm4gTk87CisJZWxzZQorCQorCQly ZXR1cm4gW1tbV2ViQ29yZUltYWdlUmVuZGVyZXJGYWN0b3J5IHNoYXJlZEZhY3RvcnldIHN1cHBv cnRlZE1JTUVUeXBlc10gY29udGFpbnNPYmplY3Q6c2VydmljZVR5cGVdOwogfQogCiBRUGl4bWFw OjpRUGl4bWFwKCkK 4206 2005-10-05 00:30:45 -0700 2005-10-05 01:11:50 -0700 An alternative patch, which fixes HTMLObjectElementImpl to not use image mode for SVGs object-fix.patch text/plain 758 eric SW5kZXg6IGh0bWwvaHRtbF9vYmplY3RpbXBsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3Zz L3Jvb3QvV2ViQ29yZS9raHRtbC9odG1sL2h0bWxfb2JqZWN0aW1wbC5jcHAsdgpyZXRyaWV2aW5n IHJldmlzaW9uIDEuODAKZGlmZiAtcCAtdSAtcjEuODAgaHRtbC9odG1sX29iamVjdGltcGwuY3Bw Ci0tLSBodG1sL2h0bWxfb2JqZWN0aW1wbC5jcHAJMyBPY3QgMjAwNSAyMToxMjoyOSAtMDAwMAkx LjgwCisrKyBodG1sL2h0bWxfb2JqZWN0aW1wbC5jcHAJNSBPY3QgMjAwNSAwNzozMjowMiAtMDAw MApAQCAtODM5LDYgKzgzOSwxMiBAQCBib29sIEhUTUxPYmplY3RFbGVtZW50SW1wbDo6aXNJbWFn ZVR5cGUoCiAgICAgICAgICAgICAgICAgc2VydmljZVR5cGUgPSAidGV4dC9wbGFpbiI7IC8vIERh dGEgVVJMcyB3aXRoIG5vIE1JTUUgdHlwZSBhcmUgY29uc2lkZXJlZCB0ZXh0L3BsYWluLgogICAg ICAgICB9CiAgICAgfQorICAgIAorI2lmIFNWR19TVVBQT1JUCisgICAgLy8gRXZlbiBpZiB0aGUg aW1hZ2Ugc3lzdGVtIHN1cHBvcnRzIGl0LCB3ZSBkb24ndCB3YW50IHRvIHJlbmRlciBTVkdzIGFz IGltYWdlcy4KKyAgICBpZiAoc2VydmljZVR5cGUgPT0gImltYWdlL3N2Zyt4bWwiKQorICAgICAg ICByZXR1cm4gZmFsc2U7CisjZW5kaWYKIAogICAgIHJldHVybiBjYW5SZW5kZXJJbWFnZVR5cGUo c2VydmljZVR5cGUpOwogfQo=