51749 2010-12-30 06:34:54 -0800 Web Inspector: [REGRESSION] Load timing is requested for all resources (not only for the main one). 2011-01-11 03:44:36 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman abarth apavlov bweinstein eric japhet joepeck keishi loislo pfeldman pmuellr rik simonjam timothy tonyg yurys oldest_to_newest 327916 0 pfeldman 2010-12-30 06:34:54 -0800 This regressed when I was extracting ResourceManager (r70853). 327917 1 77679 pfeldman 2010-12-30 06:41:56 -0800 Created attachment 77679 [PATCH] Proposed change. 329634 2 tonyg 2011-01-05 10:19:40 -0800 For web timing to work properly, we should set this for all frames (including sub frames, not just main frames). It would be nice to add a regression test, but I'm guessing there's no good way to do that because test shell doesn't populate resource timing. Everything else looks good to me. 330099 3 78109 pfeldman 2011-01-06 04:12:48 -0800 Created attachment 78109 [PATCH] Proposed change. 330100 4 pfeldman 2011-01-06 04:15:37 -0800 (In reply to comment #2) > For web timing to work properly, we should set this for all frames (including sub frames, not just main frames). It would be nice to add a regression test, but I'm guessing there's no good way to do that because test shell doesn't populate resource timing. > > Everything else looks good to me. Modified to report timing for subframes. Did not put the call into Timing for now, but moved it out from inspector. 330116 5 78109 loislo 2011-01-06 06:28:32 -0800 Comment on attachment 78109 [PATCH] Proposed change. looks good to me 330228 6 tonyg 2011-01-06 10:57:44 -0800 You might mention something in the ChangeLog about the motivation for moving to ResourceLoadNotifier. Although I'm still sad about the inability to test, this LGTM. 332244 7 78109 yurys 2011-01-11 03:37:19 -0800 Comment on attachment 78109 [PATCH] Proposed change. Inspector change looks good to me, I lean on Tony's comment about reporting the timing for the subframes. 332249 8 78109 pfeldman 2011-01-11 03:44:25 -0800 Comment on attachment 78109 [PATCH] Proposed change. Clearing flags on attachment: 78109 Committed r75485: <http://trac.webkit.org/changeset/75485> 332250 9 pfeldman 2011-01-11 03:44:36 -0800 All reviewed patches have been landed. Closing bug. 77679 2010-12-30 06:41:56 -0800 2011-01-06 04:12:48 -0800 [PATCH] Proposed change. web_timing text/plain 1838 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGIxMDc5Ni4uZjdiNDkwNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMi0zMCAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbUkVHUkVTU0lPTl0gTG9hZCB0aW1p bmcgaXMgcmVxdWVzdGVkCisgICAgICAgIGZvciBhbGwgcmVzb3VyY2VzIChub3Qgb25seSBmb3Ig dGhlIG1haW4gb25lKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUxNzQ5CisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjp3aWxsU2VuZFJlcXVl c3QpOgorCiAyMDEwLTEyLTMwICBNaWtoYWlsIE5hZ2Fub3YgIDxtbmFnYW5vdkBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwIGIvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKaW5kZXggNzI0OGRjOS4uYWZiNTE0ZiAxMDA2NDQK LS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKKysrIGIvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKQEAgLTgzMCwxMSArODMwLDkg QEAgdm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjp3aWxsU2VuZFJlcXVlc3QodW5zaWduZWQgbG9u ZyBpZGVudGlmaWVyLCBSZXNvdXJjZVJlcXUKICAgICBpZiAoIWVuYWJsZWQoKSkKICAgICAgICAg cmV0dXJuOwogCi0gICAgcmVxdWVzdC5zZXRSZXBvcnRMb2FkVGltaW5nKHRydWUpOwotCiAgICAg aWYgKG1fZnJvbnRlbmQpIHsKLSAgICAgICAgLy8gT25seSBlbmFibGUgcmF3IGhlYWRlcnMgaWYg ZnJvbnQtZW5kIGlzIGF0dGFjaGVkLCBhcyBvdGhlcndpc2Ugd2UgbWF5IGxhY2sKLSAgICAgICAg Ly8gcGVybWlzc2lvbnMgdG8gZmV0Y2ggdGhlIGhlYWRlcnMuCisgICAgICAgIC8vIE9ubHkgZW5h YmxlIGxvYWQgdGltaW5nIGFuZCByYXcgaGVhZGVycyBpZiBmcm9udC1lbmQgaXMgYXR0YWNoZWQs IGFzIG90aGVyd2lzZSB3ZSBtYXkgcHJvZHVjZSBvdmVyaGVhZC4KKyAgICAgICAgcmVxdWVzdC5z ZXRSZXBvcnRMb2FkVGltaW5nKHRydWUpOwogICAgICAgICByZXF1ZXN0LnNldFJlcG9ydFJhd0hl YWRlcnModHJ1ZSk7CiAKICAgICAgICAgaWYgKG1fZXh0cmFIZWFkZXJzKSB7CkBAIC04NDUsNiAr ODQzLDEwIEBAIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6d2lsbFNlbmRSZXF1ZXN0KHVuc2ln bmVkIGxvbmcgaWRlbnRpZmllciwgUmVzb3VyY2VSZXF1CiAgICAgfQogCiAgICAgYm9vbCBpc01h aW5SZXNvdXJjZSA9IG1fbWFpblJlc291cmNlSWRlbnRpZmllciA9PSBpZGVudGlmaWVyOworICAg IC8vIE1haW4gcmVzb3VyY2UgYWx3YXlzIHJlcG9ydHMgdGltaW5nIGZvciBXZWJUaW1pbmcuCisg ICAgaWYgKGlzTWFpblJlc291cmNlKQorICAgICAgICByZXF1ZXN0LnNldFJlcG9ydExvYWRUaW1p bmcodHJ1ZSk7CisKICAgICBpZiAobV90aW1lbGluZUFnZW50KQogICAgICAgICBtX3RpbWVsaW5l QWdlbnQtPndpbGxTZW5kUmVzb3VyY2VSZXF1ZXN0KGlkZW50aWZpZXIsIGlzTWFpblJlc291cmNl LCByZXF1ZXN0KTsKIAo= 78109 2011-01-06 04:12:48 -0800 2011-01-11 03:44:25 -0800 [PATCH] Proposed change. web_timing text/plain 2288 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MGIxMDc5Ni4uZjFmYzViNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wMS0wNiAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbUkVHUkVTU0lPTl0gTG9hZCB0aW1p bmcgaXMgcmVxdWVzdGVkCisgICAgICAgIGZvciBhbGwgcmVzb3VyY2VzIChub3Qgb25seSBmb3Ig dGhlIG1haW4gb25lKS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTUxNzQ5CisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JDb250cm9sbGVyOjp3aWxsU2VuZFJlcXVl c3QpOgorICAgICAgICAqIGxvYWRlci9SZXNvdXJjZUxvYWROb3RpZmllci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZXNvdXJjZUxvYWROb3RpZmllcjo6ZGlzcGF0Y2hXaWxsU2VuZFJlcXVlc3Qp OgorCiAyMDEwLTEyLTMwICBNaWtoYWlsIE5hZ2Fub3YgIDxtbmFnYW5vdkBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KZGlmZiAtLWdpdCBhL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwIGIvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yQ29udHJvbGxlci5jcHAKaW5kZXggNzI0OGRjOS4uMzFiNmI5YyAxMDA2NDQKLS0t IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKKysrIGIvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKQEAgLTgzMCwxMSArODMwLDkgQEAg dm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjp3aWxsU2VuZFJlcXVlc3QodW5zaWduZWQgbG9uZyBp ZGVudGlmaWVyLCBSZXNvdXJjZVJlcXUKICAgICBpZiAoIWVuYWJsZWQoKSkKICAgICAgICAgcmV0 dXJuOwogCi0gICAgcmVxdWVzdC5zZXRSZXBvcnRMb2FkVGltaW5nKHRydWUpOwotCiAgICAgaWYg KG1fZnJvbnRlbmQpIHsKLSAgICAgICAgLy8gT25seSBlbmFibGUgcmF3IGhlYWRlcnMgaWYgZnJv bnQtZW5kIGlzIGF0dGFjaGVkLCBhcyBvdGhlcndpc2Ugd2UgbWF5IGxhY2sKLSAgICAgICAgLy8g cGVybWlzc2lvbnMgdG8gZmV0Y2ggdGhlIGhlYWRlcnMuCisgICAgICAgIC8vIE9ubHkgZW5hYmxl IGxvYWQgdGltaW5nIGFuZCByYXcgaGVhZGVycyBpZiBmcm9udC1lbmQgaXMgYXR0YWNoZWQsIGFz IG90aGVyd2lzZSB3ZSBtYXkgcHJvZHVjZSBvdmVyaGVhZC4KKyAgICAgICAgcmVxdWVzdC5zZXRS ZXBvcnRMb2FkVGltaW5nKHRydWUpOwogICAgICAgICByZXF1ZXN0LnNldFJlcG9ydFJhd0hlYWRl cnModHJ1ZSk7CiAKICAgICAgICAgaWYgKG1fZXh0cmFIZWFkZXJzKSB7CmRpZmYgLS1naXQgYS9X ZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWROb3RpZmllci5jcHAgYi9XZWJDb3JlL2xvYWRlci9S ZXNvdXJjZUxvYWROb3RpZmllci5jcHAKaW5kZXggZDAwMmVmMy4uYTM2ZWQ5NCAxMDA2NDQKLS0t IGEvV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkTm90aWZpZXIuY3BwCisrKyBiL1dlYkNvcmUv bG9hZGVyL1Jlc291cmNlTG9hZE5vdGlmaWVyLmNwcApAQCAtMTI4LDYgKzEyOCwxMCBAQCB2b2lk IFJlc291cmNlTG9hZE5vdGlmaWVyOjpkaXNwYXRjaFdpbGxTZW5kUmVxdWVzdChEb2N1bWVudExv YWRlciogbG9hZGVyLCB1bnNpZwogICAgIGlmIChQYWdlKiBwYWdlID0gbV9mcmFtZS0+cGFnZSgp KQogICAgICAgICBwYWdlLT5pbnNwZWN0b3JDb250cm9sbGVyKCktPndpbGxTZW5kUmVxdWVzdChp ZGVudGlmaWVyLCByZXF1ZXN0LCByZWRpcmVjdFJlc3BvbnNlKTsKICNlbmRpZgorCisgICAgLy8g UmVwb3J0IFdlYlRpbWluZyBmb3IgYWxsIGZyYW1lcy4KKyAgICBpZiAobG9hZGVyICYmICFyZXF1 ZXN0LmlzTnVsbCgpICYmIHJlcXVlc3QudXJsKCkgPT0gbG9hZGVyLT5yZXF1ZXN0VVJMKCkpCisg ICAgICAgIHJlcXVlc3Quc2V0UmVwb3J0TG9hZFRpbWluZyh0cnVlKTsKIH0KIAogdm9pZCBSZXNv dXJjZUxvYWROb3RpZmllcjo6ZGlzcGF0Y2hEaWRSZWNlaXZlUmVzcG9uc2UoRG9jdW1lbnRMb2Fk ZXIqIGxvYWRlciwgdW5zaWduZWQgbG9uZyBpZGVudGlmaWVyLCBjb25zdCBSZXNvdXJjZVJlc3Bv bnNlJiByKQo=