51745 2010-12-30 05:36:20 -0800 Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox. 2010-12-30 07:33:32 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov podivilov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 327897 0 podivilov 2010-12-30 05:36:20 -0800 Web Inspector: breakpoint is not disabled when clicking on breakpoints sidebar pane checkbox. 327899 1 77675 podivilov 2010-12-30 05:37:11 -0800 Created attachment 77675 Patch. 327904 2 77675 pfeldman 2010-12-30 05:59:07 -0800 Comment on attachment 77675 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=77675&action=review > WebCore/inspector/front-end/Breakpoint.js:55 > + this.remove(); It would be great if breakpoint had two states: "resolved" and "unresolved". In that case, setting enabled to false would simply make it unresolved unless backend confirms disabling. 327923 3 podivilov 2010-12-30 07:33:32 -0800 Committed r74798: <http://trac.webkit.org/changeset/74798> 77675 2010-12-30 05:37:11 -0800 2010-12-30 05:59:07 -0800 Patch. patch text/plain 1208 podivilov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWU2Zjc1My4uNzFlYWEzYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMi0zMCAgUGF2ZWwgUG9kaXZp bG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBicmVha3BvaW50IGlzIG5vdCBk aXNhYmxlZCB3aGVuIGNsaWNraW5nIG9uIGJyZWFrcG9pbnRzIHNpZGViYXIgcGFuZSBjaGVja2Jv eC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNzQ1 CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0JyZWFrcG9pbnQuanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuQnJlYWtwb2ludC5wcm90b3R5cGUuc2V0IGVuYWJsZWQpOgorCiAyMDEw LTEyLTI5ICBBbnRvbiBNdWhpbiAgPGFudG9ubUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvQnJlYWtwb2ludC5qcyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9CcmVha3Bv aW50LmpzCmluZGV4IGRkMGNlMTIuLjBhODg4ZDIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9CcmVha3BvaW50LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9CcmVha3BvaW50LmpzCkBAIC00OCw2ICs0OCwxNCBAQCBXZWJJbnNwZWN0b3IuQnJlYWtw b2ludC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHJldHVybiB0aGlzLl9lbmFibGVkOwogICAgIH0s CiAKKyAgICBzZXQgZW5hYmxlZChlbmFibGVkKQorICAgIHsKKyAgICAgICAgaWYgKHRoaXMuX2Vu YWJsZWQgPT09IGVuYWJsZWQpCisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIHRoaXMucmVt b3ZlKCk7CisgICAgICAgIFdlYkluc3BlY3Rvci5kZWJ1Z2dlck1vZGVsLnNldEJyZWFrcG9pbnQo dGhpcy5zb3VyY2VJRCwgdGhpcy5saW5lLCBlbmFibGVkLCB0aGlzLmNvbmRpdGlvbik7CisgICAg fSwKKwogICAgIGdldCBzb3VyY2VUZXh0KCkKICAgICB7CiAgICAgICAgIHJldHVybiB0aGlzLl9z b3VyY2VUZXh0Owo=