51740 2010-12-30 03:08:57 -0800 Enable JSC Rich Source Info for Android even when Inspector and Debugger are disabled 2010-12-30 12:53:53 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 steveblock steveblock barraclough benm commit-queue steveblock swang oldest_to_newest 327872 0 steveblock 2010-12-30 03:08:57 -0800 Android does not enable either the Inspector or Debugger. It does however use rich source info (eg line numbers for exceptions) http://trac.webkit.org/changeset/72360 changed JSC to guard the exception-generation code behind enable flags. As a result, rich source info was disabled for Android. We should re-enable rich source info for Android. This can be done in JSDOMWindowBase::supportsRichSourceInfo(), which encapsulates such policy decisions. 327875 1 77670 steveblock 2010-12-30 03:18:36 -0800 Created attachment 77670 Patch 328010 2 77670 commit-queue 2010-12-30 12:53:46 -0800 Comment on attachment 77670 Patch Clearing flags on attachment: 77670 Committed r74806: <http://trac.webkit.org/changeset/74806> 328011 3 commit-queue 2010-12-30 12:53:53 -0800 All reviewed patches have been landed. Closing bug. 77670 2010-12-30 03:18:36 -0800 2010-12-30 12:53:46 -0800 Patch bug-51740-20101230111834.patch text/plain 1327 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA3NDc5MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMTItMzAgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEVuYWJsZSBKU0MgUmljaCBTb3VyY2UgSW5mbyBmb3IgQW5kcm9pZCBldmVuIHdoZW4gSW5zcGVj dG9yIGFuZCBEZWJ1Z2dlciBhcmUgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTUxNzQwCisKKyAgICAgICAgVGhpcyBpcyBhIHBvbGljeSBk ZWNpc2lvbiBmb3IgQW5kcm9pZC4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHNpbXBseSBlbmFi bGluZyBleGlzdGluZywgdGVzdGVkIGNvZGUgb24gQW5kcm9pZC4KKworICAgICAgICAqIGJpbmRp bmdzL2pzL0pTRE9NV2luZG93QmFzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0RPTVdpbmRv d0Jhc2U6OnN1cHBvcnRzUmljaFNvdXJjZUluZm8pOgorCiAyMDEwLTEyLTI5ICBQaGlsaXBwZSBO b3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0 aW4gUm9iaW5zb24uCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NV2luZG93QmFzZS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0Jhc2UuY3Bw CShyZXZpc2lvbiA3NDc0NCkKKysrIFdlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dCYXNl LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEzLDcgKzExMyw5IEBAIGJvb2wgSlNET01XaW5kb3dC YXNlOjpzdXBwb3J0c1Byb2ZpbGluZygKIAogYm9vbCBKU0RPTVdpbmRvd0Jhc2U6OnN1cHBvcnRz UmljaFNvdXJjZUluZm8oKSBjb25zdAogewotI2lmICFFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dF UikgfHwgIUVOQUJMRShJTlNQRUNUT1IpCisjaWYgUExBVEZPUk0oQU5EUk9JRCkKKyAgICByZXR1 cm4gdHJ1ZTsKKyNlbGlmICFFTkFCTEUoSkFWQVNDUklQVF9ERUJVR0dFUikgfHwgIUVOQUJMRShJ TlNQRUNUT1IpCiAgICAgcmV0dXJuIGZhbHNlOwogI2Vsc2UKICAgICBGcmFtZSogZnJhbWUgPSBp bXBsKCktPmZyYW1lKCk7Cg==