51735 2010-12-30 01:18:41 -0800 Web Inspector: another problem with slowness of Inspector's tests at Chromium 2010-12-31 03:42:17 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 loislo loislo apavlov bweinstein commit-queue eric joepeck keishi loislo pfeldman pmuellr rik timothy tkent webkit.review.bot yurys oldest_to_newest 327858 0 loislo 2010-12-30 01:18:41 -0800 Inspector's tests very slow at Chromium Win Dbg. Patch to follow. 327859 1 77664 loislo 2010-12-30 01:22:45 -0800 Created attachment 77664 [patch] initial version It was a problem with Chromium DRT. DevToolsAgent object instance was attached not only to the inspected page but to the DevTools window too. As result all the inspector files were interpreted as a content of inspected page and were transfered to the DevTools scripts panel for debugging etc. 327884 2 77664 pfeldman 2010-12-30 04:54:03 -0800 Comment on attachment 77664 [patch] initial version Please put a comment explaining that inspected web view is not changed throughout the drt lifetime. 327927 3 77680 loislo 2010-12-30 08:04:34 -0800 Created attachment 77680 [patch] second version 327928 4 webkit.review.bot 2010-12-30 08:06:45 -0800 Attachment 77680 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/DumpRenderTree/chromium/TestShell.cpp', u'Tools/DumpRenderTree/chromium/TestShell.h', u'Tools/DumpRenderTree/chromium/WebViewHost.cpp']" exit_code: 1 Tools/DumpRenderTree/chromium/TestShell.h:170: The parameter name "devToolsAgent" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 328144 5 77680 pfeldman 2010-12-31 03:37:02 -0800 Comment on attachment 77680 [patch] second version View in context: https://bugs.webkit.org/attachment.cgi?id=77680&action=review > Tools/DumpRenderTree/chromium/TestShell.cpp:570 > +WebViewHost* TestShell::createNewWindow(const WebKit::WebURL& url, DRTDevToolsAgent* devToolsAgent) Nit: It would be great if there was no way to create non-main web views with existing devtools agent. 328145 6 77680 loislo 2010-12-31 03:42:05 -0800 Comment on attachment 77680 [patch] second version Clearing flags on attachment: 77680 Committed r74826: <http://trac.webkit.org/changeset/74826> 328146 7 loislo 2010-12-31 03:42:17 -0800 All reviewed patches have been landed. Closing bug. 77664 2010-12-30 01:22:45 -0800 2010-12-30 08:04:34 -0800 [patch] initial version patch text/plain 2684 loislo ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4NmEz NTU5Li43NTRjM2I3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMTItMjkgIElseWEgVGlraG9ub3Zza3kgIDxs b2lzbG9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtDaHJvbWl1bV0gSW5zcGVjdG9yJ3MgdGVzdHMg YXJlIHZlcnkgc2xvdyBvbiBXaW4oRGJnKS4KKworICAgICAgICBJdCB3YXMgYSBwcm9ibGVtIHdp dGggQ2hyb21pdW0gRFJULiBEZXZUb29sc0FnZW50IG9iamVjdCBpbnN0YW5jZSB3YXMKKyAgICAg ICAgYXR0YWNoZWQgbm90IG9ubHkgdG8gdGhlIGluc3BlY3RlZCBwYWdlIGJ1dCB0byB0aGUgRGV2 VG9vbHMgd2luZG93IHRvby4KKyAgICAgICAgQXMgcmVzdWx0IGFsbCB0aGUgaW5zcGVjdG9yIGZp bGVzIHdlcmUgaW50ZXJwcmV0ZWQgYXMgYSBjb250ZW50IG9mIGluc3BlY3RlZCBwYWdlCisgICAg ICAgIGFuZCB3ZXJlIHRyYW5zZmVyZWQgdG8gdGhlIERldlRvb2xzIHNjcmlwdHMgcGFuZWwgZm9y IGRlYnVnZ2luZyBldGMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTUxNzM1CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0 U2hlbGwuY3BwOgorICAgICAgICAoVGVzdFNoZWxsOjpzaG93RGV2VG9vbHMpOgorICAgICAgICAo VGVzdFNoZWxsOjpjcmVhdGVOZXdXaW5kb3cpOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2No cm9taXVtL1Rlc3RTaGVsbC5oOgorCiAyMDEwLTEyLTI5ICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBh cm9nYUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgV2luQ0UgYnVpbGRmaXguCmRp ZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3BwIGIv VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNwcAppbmRleCAyMWY0MjA4 Li4xNTM4ZTA5IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0 U2hlbGwuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5j cHAKQEAgLTEzNCw3ICsxMzQsNyBAQCB2b2lkIFRlc3RTaGVsbDo6c2hvd0RldlRvb2xzKCkKICAg ICAgICAgICAgIEFTU0VSVChmYWxzZSk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0K LSAgICAgICAgbV9kZXZUb29scyA9IGNyZWF0ZU5ld1dpbmRvdyh1cmwpOworICAgICAgICBtX2Rl dlRvb2xzID0gY3JlYXRlTmV3V2luZG93KHVybCwgZmFsc2UpOwogICAgICAgICBBU1NFUlQobV9k ZXZUb29scyk7CiAgICAgICAgIGNyZWF0ZURSVERldlRvb2xzQ2xpZW50KG1fZHJ0RGV2VG9vbHNB Z2VudC5nZXQoKSk7CiAgICAgfQpAQCAtNTYyLDEwICs1NjIsMTAgQEAgV2ViVmlld0hvc3QqIFRl c3RTaGVsbDo6Y3JlYXRlV2ViVmlldygpCiAgICAgcmV0dXJuIGNyZWF0ZU5ld1dpbmRvdyhXZWJV UkwoKSk7CiB9CiAKLVdlYlZpZXdIb3N0KiBUZXN0U2hlbGw6OmNyZWF0ZU5ld1dpbmRvdyhjb25z dCBXZWJVUkwmIHVybCkKK1dlYlZpZXdIb3N0KiBUZXN0U2hlbGw6OmNyZWF0ZU5ld1dpbmRvdyhj b25zdCBXZWJVUkwmIHVybCwgYm9vbCBhdHRhY2hEZXZUb29scykKIHsKICAgICBXZWJWaWV3SG9z dCogaG9zdCA9IG5ldyBXZWJWaWV3SG9zdCh0aGlzKTsKLSAgICBXZWJWaWV3KiB2aWV3ID0gV2Vi Vmlldzo6Y3JlYXRlKGhvc3QsIG1fZHJ0RGV2VG9vbHNBZ2VudC5nZXQoKSk7CisgICAgV2ViVmll dyogdmlldyA9IFdlYlZpZXc6OmNyZWF0ZShob3N0LCBhdHRhY2hEZXZUb29scyA/IG1fZHJ0RGV2 VG9vbHNBZ2VudC5nZXQoKSA6IDApOwogICAgIGhvc3QtPnNldFdlYldpZGdldCh2aWV3KTsKICAg ICBtX3ByZWZzLmFwcGx5VG8odmlldyk7CiAgICAgdmlldy0+aW5pdGlhbGl6ZU1haW5GcmFtZSho b3N0KTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVs bC5oIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmgKaW5kZXggMWRh NGUxNy4uNjdiMGI5NCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0v VGVzdFNoZWxsLmgKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxs LmgKQEAgLTE1Miw3ICsxNTIsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXREdW1wV2hlbkZpbmlz aGVkKGJvb2wgZHVtcFdoZW5GaW5pc2hlZCkgeyBtX2R1bXBXaGVuRmluaXNoZWQgPSBkdW1wV2hl bkZpbmlzaGVkOyB9CiAKICAgICBXZWJWaWV3SG9zdCogY3JlYXRlV2ViVmlldygpOwotICAgIFdl YlZpZXdIb3N0KiBjcmVhdGVOZXdXaW5kb3coY29uc3QgV2ViS2l0OjpXZWJVUkwmKTsKKyAgICBX ZWJWaWV3SG9zdCogY3JlYXRlTmV3V2luZG93KGNvbnN0IFdlYktpdDo6V2ViVVJMJiwgYm9vbCBh dHRhY2hEZXZUb29scyA9IHRydWUpOwogICAgIHZvaWQgY2xvc2VXaW5kb3coV2ViVmlld0hvc3Qq KTsKICAgICB2b2lkIGNsb3NlUmVtYWluaW5nV2luZG93cygpOwogICAgIGludCB3aW5kb3dDb3Vu dCgpOwo= 77680 2010-12-30 08:04:34 -0800 2010-12-31 03:42:05 -0800 [patch] second version patch text/plain 3996 loislo ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4NmEz NTU5Li40ZTY1OTE3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTAtMTItMjkgIElseWEgVGlraG9ub3Zza3kgIDxs b2lzbG9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4u CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogW0Nocm9taXVtXSBJbnNwZWN0b3IncyB0ZXN0cyBh cmUgdmVyeSBzbG93IG9uIFdpbihEYmcpLgorCisgICAgICAgIEl0IHdhcyBhIHByb2JsZW0gd2l0 aCBDaHJvbWl1bSBEUlQuIERldlRvb2xzQWdlbnQgb2JqZWN0IGluc3RhbmNlIHdhcworICAgICAg ICBhdHRhY2hlZCBub3Qgb25seSB0byB0aGUgaW5zcGVjdGVkIHBhZ2UgYnV0IHRvIHRoZSBEZXZU b29scyB3aW5kb3cgdG9vLgorICAgICAgICBBcyByZXN1bHQgYWxsIHRoZSBpbnNwZWN0b3IgZmls ZXMgd2VyZSBpbnRlcnByZXRlZCBhcyBhIGNvbnRlbnQgb2YgaW5zcGVjdGVkIHBhZ2UKKyAgICAg ICAgYW5kIHdlcmUgdHJhbnNmZXJlZCB0byB0aGUgRGV2VG9vbHMgc2NyaXB0cyBwYW5lbCBmb3Ig ZGVidWdnaW5nIGV0Yy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NTE3MzUKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RT aGVsbC5jcHA6CisgICAgICAgIChUZXN0U2hlbGw6OlRlc3RTaGVsbCk6CisgICAgICAgIChUZXN0 U2hlbGw6OmJpbmRKU09iamVjdHNUb1dpbmRvdyk6CisgICAgICAgIChUZXN0U2hlbGw6OmNyZWF0 ZU5ld1dpbmRvdyk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxs Lmg6CisKIDIwMTAtMTItMjkgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+ CiAKICAgICAgICAgVW5yZXZpZXdlZCBXaW5DRSBidWlsZGZpeC4KZGlmZiAtLWdpdCBhL1Rvb2xz L0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwuY3BwCmluZGV4IDIxZjQyMDguLmQ1ZjJiNWMgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5jcHAKKysrIGIv VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFNoZWxsLmNwcApAQCAtMTA2LDggKzEw NiwxMyBAQCBUZXN0U2hlbGw6OlRlc3RTaGVsbChib29sIHRlc3RTaGVsbE1vZGUpCiAgICAgLy8g dGltZWQtb3V0IERSVCBwcm9jZXNzIHdhcyBjcmFzaGVkLgogICAgIG1fdGltZW91dCA9IDMwICog MTAwMDsKIAorICAgIGNyZWF0ZU1haW5XaW5kb3coKTsKK30KKwordm9pZCBUZXN0U2hlbGw6OmNy ZWF0ZU1haW5XaW5kb3coKQorewogICAgIG1fZHJ0RGV2VG9vbHNBZ2VudC5zZXQobmV3IERSVERl dlRvb2xzQWdlbnQpOwotICAgIG1fd2ViVmlld0hvc3QgPSBjcmVhdGVXZWJWaWV3KCk7CisgICAg bV93ZWJWaWV3SG9zdCA9IGNyZWF0ZU5ld1dpbmRvdyhXZWJVUkwoKSwgbV9kcnREZXZUb29sc0Fn ZW50LmdldCgpKTsKICAgICBtX3dlYlZpZXcgPSBtX3dlYlZpZXdIb3N0LT53ZWJWaWV3KCk7CiAg ICAgbV9kcnREZXZUb29sc0FnZW50LT5zZXRXZWJWaWV3KG1fd2ViVmlldyk7CiB9CkBAIC01NTcs MTUgKzU2MiwxNSBAQCB2b2lkIFRlc3RTaGVsbDo6YmluZEpTT2JqZWN0c1RvV2luZG93KFdlYkZy YW1lKiBmcmFtZSkKICAgICBtX3RleHRJbnB1dENvbnRyb2xsZXItPmJpbmRUb0phdmFzY3JpcHQo ZnJhbWUsIFdlYlN0cmluZzo6ZnJvbVVURjgoInRleHRJbnB1dENvbnRyb2xsZXIiKSk7CiB9CiAK LVdlYlZpZXdIb3N0KiBUZXN0U2hlbGw6OmNyZWF0ZVdlYlZpZXcoKQorV2ViVmlld0hvc3QqIFRl c3RTaGVsbDo6Y3JlYXRlTmV3V2luZG93KGNvbnN0IFdlYktpdDo6V2ViVVJMJiB1cmwpCiB7Ci0g ICAgcmV0dXJuIGNyZWF0ZU5ld1dpbmRvdyhXZWJVUkwoKSk7CisgICAgcmV0dXJuIGNyZWF0ZU5l d1dpbmRvdyh1cmwsIDApOwogfQogCi1XZWJWaWV3SG9zdCogVGVzdFNoZWxsOjpjcmVhdGVOZXdX aW5kb3coY29uc3QgV2ViVVJMJiB1cmwpCitXZWJWaWV3SG9zdCogVGVzdFNoZWxsOjpjcmVhdGVO ZXdXaW5kb3coY29uc3QgV2ViS2l0OjpXZWJVUkwmIHVybCwgRFJURGV2VG9vbHNBZ2VudCogZGV2 VG9vbHNBZ2VudCkKIHsKICAgICBXZWJWaWV3SG9zdCogaG9zdCA9IG5ldyBXZWJWaWV3SG9zdCh0 aGlzKTsKLSAgICBXZWJWaWV3KiB2aWV3ID0gV2ViVmlldzo6Y3JlYXRlKGhvc3QsIG1fZHJ0RGV2 VG9vbHNBZ2VudC5nZXQoKSk7CisgICAgV2ViVmlldyogdmlldyA9IFdlYlZpZXc6OmNyZWF0ZSho b3N0LCBkZXZUb29sc0FnZW50KTsKICAgICBob3N0LT5zZXRXZWJXaWRnZXQodmlldyk7CiAgICAg bV9wcmVmcy5hcHBseVRvKHZpZXcpOwogICAgIHZpZXctPmluaXRpYWxpemVNYWluRnJhbWUoaG9z dCk7CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0U2hlbGwu aCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5oCmluZGV4IDFkYTRl MTcuLjhhMWNiYWMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rl c3RTaGVsbC5oCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RTaGVsbC5o CkBAIC0xNTEsNyArMTUxLDYgQEAgcHVibGljOgogICAgIC8vIHRlc3Rpbmcgd2hlcmUgd2Ugb25s eSB3YW50IHRvIGhhdmUgdGhlIG91dHB1dCBmcm9tIHRoZSBsYXN0IGxvYWQuCiAgICAgdm9pZCBz ZXREdW1wV2hlbkZpbmlzaGVkKGJvb2wgZHVtcFdoZW5GaW5pc2hlZCkgeyBtX2R1bXBXaGVuRmlu aXNoZWQgPSBkdW1wV2hlbkZpbmlzaGVkOyB9CiAKLSAgICBXZWJWaWV3SG9zdCogY3JlYXRlV2Vi VmlldygpOwogICAgIFdlYlZpZXdIb3N0KiBjcmVhdGVOZXdXaW5kb3coY29uc3QgV2ViS2l0OjpX ZWJVUkwmKTsKICAgICB2b2lkIGNsb3NlV2luZG93KFdlYlZpZXdIb3N0Kik7CiAgICAgdm9pZCBj bG9zZVJlbWFpbmluZ1dpbmRvd3MoKTsKQEAgLTE2OCw2ICsxNjcsOCBAQCBwdWJsaWM6CiAgICAg c3RhdGljIGNvbnN0IGludCB2aXJ0dWFsV2luZG93Qm9yZGVyID0gMzsKIAogcHJpdmF0ZToKKyAg ICBXZWJWaWV3SG9zdCogY3JlYXRlTmV3V2luZG93KGNvbnN0IFdlYktpdDo6V2ViVVJMJiwgRFJU RGV2VG9vbHNBZ2VudCogZGV2VG9vbHNBZ2VudCk7CisgICAgdm9pZCBjcmVhdGVNYWluV2luZG93 KCk7CiAgICAgdm9pZCBjcmVhdGVEUlREZXZUb29sc0NsaWVudChEUlREZXZUb29sc0FnZW50Kik7 CiAKICAgICB2b2lkIHJlc2V0V2ViU2V0dGluZ3MoV2ViS2l0OjpXZWJWaWV3Jik7CmRpZmYgLS1n aXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAgYi9Ub29s cy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAKaW5kZXggZDg4MDg3OS4u ZjI3MmI1OCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmll d0hvc3QuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0 LmNwcApAQCAtMjM1LDcgKzIzNSw3IEBAIFdlYlZpZXcqIFdlYlZpZXdIb3N0OjpjcmVhdGVWaWV3 KFdlYkZyYW1lKiwgY29uc3QgV2ViV2luZG93RmVhdHVyZXMmLCBjb25zdCBXZWJTCiB7CiAgICAg aWYgKCFsYXlvdXRUZXN0Q29udHJvbGxlcigpLT5jYW5PcGVuV2luZG93cygpKQogICAgICAgICBy ZXR1cm4gMDsKLSAgICByZXR1cm4gbV9zaGVsbC0+Y3JlYXRlV2ViVmlldygpLT53ZWJWaWV3KCk7 CisgICAgcmV0dXJuIG1fc2hlbGwtPmNyZWF0ZU5ld1dpbmRvdyhXZWJVUkwoKSktPndlYlZpZXco KTsKIH0KIAogV2ViV2lkZ2V0KiBXZWJWaWV3SG9zdDo6Y3JlYXRlUG9wdXBNZW51KFdlYlBvcHVw VHlwZSkK