51731 2010-12-29 16:28:02 -0800 [Chromium] storage/indexeddb/objectstore-basics.html is flaky after r74266 2011-01-05 15:18:51 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 mihaip hans andreip commit-queue jorlow oldest_to_newest 327738 0 mihaip 2010-12-29 16:28:02 -0800 storage/indexeddb/objectstore-basics.html became flaky on 12/17, with the first failure being at r74269. Timing-wise this coincides well with the changes made by r74266, so I'm suspecting that as the culprit. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&master=ChromiumWebkit&tests=storage%2Findexeddb%2Fobjectstore-basics.html 329558 1 hans 2011-01-05 07:25:16 -0800 Looking. This reproduces locally on my machine. Running 20 or so times, I sometimes get this text diff: --- /work/chrome/src/webkit/Debug/layout-test-results/storage/indexeddb/objectstore-basics-expected.txt +++ /work/chrome/src/webkit/Debug/layout-test-results/storage/indexeddb/objectstore-basics-actual.txt @@ -199,7 +199,7 @@ PASS 'readyState' in event.target is true PASS event.target.readyState is event.target.DONE -PASS event.result.y is "value" +FAIL event.result.y should be value. Threw exception TypeError: Cannot read property 'y' of null store = event.source store.get(testDate) getSuccessDateKey(): 329570 2 hans 2011-01-05 08:14:03 -0800 This is caused by Chromium bug http://crbug.com/67918, where we fail to store some values in the database. Since the test stores an object containing "new Date()", that object is sometimes not stored successfully, and the test breaks. While we fix the underlying problem, we can re-enable the test by using a known-good Date. 329572 3 78007 hans 2011-01-05 08:15:39 -0800 Created attachment 78007 Patch 329611 4 mihaip 2011-01-05 09:40:24 -0800 (In reply to comment #3) > Created an attachment (id=78007) [details] > Patch That seems fine to me, but unfortunately I'm not a reviewer yet. 329759 5 78007 jorlow 2011-01-05 13:38:45 -0800 Comment on attachment 78007 Patch r=me 329821 6 78007 commit-queue 2011-01-05 15:18:47 -0800 Comment on attachment 78007 Patch Clearing flags on attachment: 78007 Committed r75109: <http://trac.webkit.org/changeset/75109> 329822 7 commit-queue 2011-01-05 15:18:51 -0800 All reviewed patches have been landed. Closing bug. 78007 2011-01-05 08:15:39 -0800 2011-01-05 15:18:47 -0800 Patch bug-51731-20110105161537.patch text/plain 3580 hans ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxMDE3N2RjYzYyYThhYWYzOWY5YmU2MGIzZDdmMmQwZDM0MjJiMGE4Li5jZWZhNDM4 NTg1YmJhM2ZlOWFmZGExN2I2MDAwOWExNTc4NWEzMjhhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAK KzIwMTEtMDEtMDUgIEhhbnMgV2VubmJvcmcgIDxoYW5zQGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1dIHN0b3Jh Z2UvaW5kZXhlZGRiL29iamVjdHN0b3JlLWJhc2ljcy5odG1sIGlzIGZsYWt5IGFmdGVyIHI3NDI2 NgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTE3MzEK KworICAgICAgICBGaXggdGhlIGxheW91dCB0ZXN0IGJ5IHVzaW5nIGEga25vd24tZ29vZCBkYXRl IHZhbHVlIHJhdGhlciB0aGFuCisgICAgICAgIG5ldyBEYXRlKCksIHdoaWNoIHNvbWV0aW1lcyBj YXVzZXMgdGhlIHRlc3QgdG8gZmFpbC4KKworICAgICAgICAoVGhlIHVuZGVybHlpbmcgcmVhc29u IGZvciBmYWlsaW5nIHRvIHN0b3JlIGNlcnRhaW4gRGF0ZSB2YWx1ZXMKKyAgICAgICAgc2hvdWxk IG9mIGNvdXJzZSBiZSBmaXhlZCB0b28sIGJ1dCB0aGF0IHdpbGwgY29tZSBpbiBhIGxhdGVyIHBh dGNoLikKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4 dDoKKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9vYmplY3RzdG9yZS1iYXNpY3MtZXhwZWN0 ZWQudHh0OgorICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL29iamVjdHN0b3JlLWJhc2ljcy5o dG1sOgorCiAyMDExLTAxLTA0ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkLCB0ZXN0IGV4cGVjdGF0aW9uIHVwZGF0ZS4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xh eW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAppbmRleCA0 Y2YyZWI0OWMxZDlmM2U0YWQ1NDIyZWEzNDUyZWJjYTQ1YTNmMmJlLi4xZjA4M2YzYjY2NWNmNGZm MTRkOGU0ZmRjYjZjNTViZTkxZDBlZThiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC0zMDQ4LDcgKzMwNDgsNiBAQCBC VUdXSzUxNzIwIERFQlVHIDogaHR0cC90ZXN0cy9pbmNyZW1lbnRhbC9zcGxpdC1oZXgtZW50aXRp ZXMucGwgPSBDUkFTSCBQQVNTCiBCVUdDUjY0MzcxIFdJTiBSRUxFQVNFIDogaHR0cC90ZXN0cy9h cHBjYWNoZS9vbmxpbmUtd2hpdGVsaXN0Lmh0bWwgPSBURVhUCiBCVUdXSzUxNzIxIERFQlVHIFNM T1c6IGZhc3QvZW5jb2RpbmcvcGFyc2VyLXRlc3RzLmh0bWwgPSBQQVNTCiBCVUdDUjY3NDYzIE1B QyA6IGVkaXRpbmcvc2VsZWN0aW9uL2NhcmV0LW1vZGUtcGFyYWdyYXBoLWtleXMtbmF2aWdhdGlv bi5odG1sID0gVEVYVAotQlVHV0s1MTczMSA6IHN0b3JhZ2UvaW5kZXhlZGRiL29iamVjdHN0b3Jl LWJhc2ljcy5odG1sID0gUEFTUyBURVhUCiAKIEJVR0NSNjg0MzYgTElOVVggTUFDIERFQlVHIDog ZmFzdC9kb20vRE9NSW1wbGVtZW50YXRpb24vY3JlYXRlRG9jdW1lbnQtd2l0aC11c2VkLWRvY3R5 cGUuaHRtbCA9IFBBU1MgVElNRU9VVAogQlVHQ1I2ODQzNiBXSU4gREVCVUcgOiBmYXN0L2RvbS9E T01JbXBsZW1lbnRhdGlvbi9jcmVhdGVEb2N1bWVudC13aXRoLXVzZWQtZG9jdHlwZS5odG1sID0g UEFTUyBURVhUIFRJTUVPVVQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhl ZGRiL29iamVjdHN0b3JlLWJhc2ljcy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9zdG9yYWdl L2luZGV4ZWRkYi9vYmplY3RzdG9yZS1iYXNpY3MtZXhwZWN0ZWQudHh0CmluZGV4IDE3NzQ2ZDNj MzJhZTg1NGVhNTRkMTIxOTQ0MmZkY2JlNjNjZjA2ZjAuLjZlNzQxNjVkMDJkNmRhMWU1MTI5ZDUy Yjc3NDlmN2NlNGY4ZWVlNDMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhl ZGRiL29iamVjdHN0b3JlLWJhc2ljcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvc3Rv cmFnZS9pbmRleGVkZGIvb2JqZWN0c3RvcmUtYmFzaWNzLWV4cGVjdGVkLnR4dApAQCAtMTA0LDcg KzEwNCw3IEBAIHN0b3JlLmFkZCh7eDogJ2JhcicsIHk6IGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCdjb25zb2xlJyl9LCAnYmFyJykKIFBBU1MgRXhjZXB0aW9uIHRocm93bgogUEFTUyBjb2RlIGlz IERPTUV4Y2VwdGlvbi5OT1RfU1VQUE9SVEVEX0VSUgogVHJ5IHRvIGluc2VydCBkYXRhIHdoZXJl IGtleSBwYXRoIHlpZWxkcyBhIERhdGUga2V5Ogotc3RvcmUuYWRkKHt4OiBuZXcgRGF0ZSgpLCB5 OiAndmFsdWUnfSwgJ2tleScpCitzdG9yZS5hZGQoe3g6IHRlc3REYXRlQiwgeTogJ3ZhbHVlJ30s ICdrZXknKQogYWRkU3VjY2VzcygpOgogU3VjY2VzcyBldmVudCBmaXJlZDoKIFBBU1MgJ3Jlc3Vs dCcgaW4gZXZlbnQgaXMgdHJ1ZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRl eGVkZGIvb2JqZWN0c3RvcmUtYmFzaWNzLmh0bWwgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4 ZWRkYi9vYmplY3RzdG9yZS1iYXNpY3MuaHRtbAppbmRleCBhMzY4YzAxNDVkNjgwYjVkMzk1NWQ4 ODVjNWZlMTE0ZTIxOWU0YTliLi4xNDRlMjk2YjAyYTk0OTA0ZTk4OGRjNDc3NDU4MGUxNDc3MTFk MmQ1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9vYmplY3RzdG9y ZS1iYXNpY3MuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9vYmplY3Rz dG9yZS1iYXNpY3MuaHRtbApAQCAtMTM3LDYgKzEzNyw3IEBAIGZ1bmN0aW9uIGNoZWNrTWV0YWRh dGEoKQogfQogCiB2YXIgdGVzdERhdGUgPSBuZXcgRGF0ZSgiQXVndXN0IDI1LCAxOTkxIDIwOjU3 OjA4Iik7Cit2YXIgdGVzdERhdGVCID0gbmV3IERhdGUoIldlZCBKYW4gMDUgMjAxMSAxNTo1NDo0 OSIpOwogCiBmdW5jdGlvbiBhZGREYXRhKCkKIHsKQEAgLTE2NCw3ICsxNjUsNyBAQCBmdW5jdGlv biBhZGREYXRlU3VjY2VzcygpCiAgICAgfQogCiAgICAgZGVidWcoIlRyeSB0byBpbnNlcnQgZGF0 YSB3aGVyZSBrZXkgcGF0aCB5aWVsZHMgYSBEYXRlIGtleToiKTsKLSAgICByZXN1bHQgPSBldmFs QW5kTG9nKCJzdG9yZS5hZGQoe3g6IG5ldyBEYXRlKCksIHk6ICd2YWx1ZSd9LCAna2V5JykiKTsK KyAgICByZXN1bHQgPSBldmFsQW5kTG9nKCJzdG9yZS5hZGQoe3g6IHRlc3REYXRlQiwgeTogJ3Zh bHVlJ30sICdrZXknKSIpOwogICAgIHJlc3VsdC5vbnN1Y2Nlc3MgPSBhZGRTdWNjZXNzOwogICAg IHJlc3VsdC5vbmVycm9yID0gdW5leHBlY3RlZEVycm9yQ2FsbGJhY2s7CiB9Cg==