51726 2010-12-29 14:59:30 -0800 drawElements should raise INVALID_OPERATION if offset is not a multiple of the type size 2010-12-29 20:54:06 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zmo zmo abarth cmarrin commit-queue enne eric kbr webkit.review.bot oldest_to_newest 327710 0 zmo 2010-12-29 14:59:30 -0800 See WebGL spec section 6.3 327713 1 zmo 2010-12-29 15:23:28 -0800 After re-examine the code, it seems that this is already taken care of in WebGLRenderingContext::validateElementArraySize. However, we don't have tests covering this behavior. I'll add test cases. 327716 2 77648 zmo 2010-12-29 15:31:20 -0800 Created attachment 77648 Patch 327792 3 77648 eric 2010-12-29 18:38:03 -0800 Comment on attachment 77648 Patch I like test cases. :) 327808 4 77648 commit-queue 2010-12-29 19:55:04 -0800 Comment on attachment 77648 Patch Clearing flags on attachment: 77648 Committed r74777: <http://trac.webkit.org/changeset/74777> 327809 5 commit-queue 2010-12-29 19:55:10 -0800 All reviewed patches have been landed. Closing bug. 327820 6 webkit.review.bot 2010-12-29 20:54:06 -0800 http://trac.webkit.org/changeset/74777 might have broken GTK Linux 64-bit Debug The following tests are not passing: editing/selection/extend-by-character-005.html 77648 2010-12-29 15:31:20 -0800 2010-12-29 19:55:04 -0800 Patch bug-51726-20101229153118.patch text/plain 2898 zmo SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDc0NzY1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTItMjkgIFpoZW55YW8gTW8gIDx6bW9A Z29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBkcmF3RWxlbWVudHMgc2hvdWxkIHJhaXNlIElOVkFMSURfT1BFUkFUSU9OIGlmIG9mZnNl dCBpcyBub3QgYSBtdWx0aXBsZSBvZiB0aGUgdHlwZSBzaXplCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01MTcyNgorCisgICAgICAgICogZmFzdC9jYW52 YXMvd2ViZ2wvZHJhdy1lbGVtZW50cy1vdXQtb2YtYm91bmRzLWV4cGVjdGVkLnR4dDoKKyAgICAg ICAgKiBmYXN0L2NhbnZhcy93ZWJnbC9kcmF3LWVsZW1lbnRzLW91dC1vZi1ib3VuZHMuaHRtbDog QWRkIHRlc3QgY2FzZXMgdG8gdmVyaWZ5IHRoZSBiZWhhdmlvci4KKwogMjAxMC0xMi0yOSAgTWlo YWkgUGFycGFyaXRhICA8bWloYWlwQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk IENocm9taXVtIGV4cGVjdGF0aW9ucyB1cGRhdGUuIE1hcmsgYW5vdGhlciB0ZXN0IGFzIGZsYWt5 LgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvZHJhdy1lbGVtZW50cy1vdXQt b2YtYm91bmRzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Nh bnZhcy93ZWJnbC9kcmF3LWVsZW1lbnRzLW91dC1vZi1ib3VuZHMtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiA3NDc2NSkKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2RyYXctZWxlbWVu dHMtb3V0LW9mLWJvdW5kcy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTQ5LDYgKzQ5 LDkgQEAgUEFTUyBjb250ZXh0LmRyYXdFbGVtZW50cyhjb250ZXh0LlRSSUFORwogUEFTUyBjb250 ZXh0LmRyYXdFbGVtZW50cyhjb250ZXh0LlRSSUFOR0xFUywgMHhmZmZmZmZmZiwgY29udGV4dC5V TlNJR05FRF9TSE9SVCwgMCkgZ2VuZXJhdGVkIGV4cGVjdGVkIEdMIGVycm9yOiBJTlZBTElEX1ZB TFVFLgogUEFTUyBjb250ZXh0LmRyYXdFbGVtZW50cyhjb250ZXh0LlRSSUFOR0xFUywgMHg3ZmZm ZmZmZiwgY29udGV4dC5VTlNJR05FRF9TSE9SVCwgMCkgZ2VuZXJhdGVkIGV4cGVjdGVkIEdMIGVy cm9yOiBJTlZBTElEX09QRVJBVElPTi4KIFBBU1MgY29udGV4dC5kcmF3RWxlbWVudHMoY29udGV4 dC5UUklBTkdMRVMsIDAsIGNvbnRleHQuVU5TSUdORURfU0hPUlQsIDApIGdlbmVyYXRlZCBleHBl Y3RlZCBHTCBlcnJvcjogTk9fRVJST1IuCitQQVNTIGNvbnRleHQuZHJhd0VsZW1lbnRzKGNvbnRl eHQuVFJJQU5HTEVTLCA2LCBjb250ZXh0LlVOU0lHTkVEX1NIT1JULCAwKSBnZW5lcmF0ZWQgZXhw ZWN0ZWQgR0wgZXJyb3I6IE5PX0VSUk9SLgorUEFTUyBjb250ZXh0LmRyYXdFbGVtZW50cyhjb250 ZXh0LlRSSUFOR0xFUywgNiwgY29udGV4dC5VTlNJR05FRF9TSE9SVCwgMSkgZ2VuZXJhdGVkIGV4 cGVjdGVkIEdMIGVycm9yOiBJTlZBTElEX09QRVJBVElPTi4KK1BBU1MgY29udGV4dC5kcmF3RWxl bWVudHMoY29udGV4dC5UUklBTkdMRVMsIDYsIGNvbnRleHQuVU5TSUdORURfU0hPUlQsIDIpIGdl bmVyYXRlZCBleHBlY3RlZCBHTCBlcnJvcjogTk9fRVJST1IuCiAKIFBBU1Mgc3VjY2Vzc2Z1bGx5 UGFyc2VkIGlzIHRydWUKIApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvZHJh dy1lbGVtZW50cy1vdXQtb2YtYm91bmRzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv ZmFzdC9jYW52YXMvd2ViZ2wvZHJhdy1lbGVtZW50cy1vdXQtb2YtYm91bmRzLmh0bWwJKHJldmlz aW9uIDc0NzY1KQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvZHJhdy1lbGVtZW50 cy1vdXQtb2YtYm91bmRzLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTEyMCw2ICsxMjAsMTEgQEAg c2hvdWxkR2VuZXJhdGVHTEVycm9yKGNvbnRleHQsIGNvbnRleHQuSQogCiBzaG91bGRHZW5lcmF0 ZUdMRXJyb3IoY29udGV4dCwgY29udGV4dC5OT19FUlJPUiwgImNvbnRleHQuZHJhd0VsZW1lbnRz KGNvbnRleHQuVFJJQU5HTEVTLCAwLCBjb250ZXh0LlVOU0lHTkVEX1NIT1JULCAwKSIpOwogCisv LyBpbnZhbGlkIG9wZXJhdGlvbiB3aXRoIG9mZnNldCB0aGF0J3Mgbm90IGEgbXVsdGlwbGUgb2Yg dGhlIHR5cGUgc2l6ZQorc2hvdWxkR2VuZXJhdGVHTEVycm9yKGNvbnRleHQsIGNvbnRleHQuTk9f RVJST1IsICJjb250ZXh0LmRyYXdFbGVtZW50cyhjb250ZXh0LlRSSUFOR0xFUywgNiwgY29udGV4 dC5VTlNJR05FRF9TSE9SVCwgMCkiKTsKK3Nob3VsZEdlbmVyYXRlR0xFcnJvcihjb250ZXh0LCBj b250ZXh0LklOVkFMSURfT1BFUkFUSU9OLCAiY29udGV4dC5kcmF3RWxlbWVudHMoY29udGV4dC5U UklBTkdMRVMsIDYsIGNvbnRleHQuVU5TSUdORURfU0hPUlQsIDEpIik7CitzaG91bGRHZW5lcmF0 ZUdMRXJyb3IoY29udGV4dCwgY29udGV4dC5OT19FUlJPUiwgImNvbnRleHQuZHJhd0VsZW1lbnRz KGNvbnRleHQuVFJJQU5HTEVTLCA2LCBjb250ZXh0LlVOU0lHTkVEX1NIT1JULCAyKSIpOworCiBk ZWJ1ZygiIikKIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7CiA8L3NjcmlwdD4K