51722 2010-12-29 13:53:45 -0800 JSDataViewCustom.cpp gives the fastcall calling convention to functions called via C++ 2010-12-29 14:21:32 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC Linux RESOLVED FIXED P3 Normal --- 31517 1 mrobinson webkit-unassigned alex jianli kbr oldest_to_newest 327687 0 mrobinson 2010-12-29 13:53:45 -0800 JSDataView methods like JSDataView::getInt8 are labeled with JSC_HOST_CALL, which gives them the fastcall calling convention. This leads to runtime errors, because these methods are called from C++ code in the auto-generated JSDataView.cpp. This was observed when running fast/canvas/webgl/data-view-test.html on the upcoming GTK+ WebGL implementation. 327693 1 77643 mrobinson 2010-12-29 14:11:33 -0800 Created attachment 77643 Patch 327700 2 mrobinson 2010-12-29 14:21:12 -0800 Committed r74760: <http://trac.webkit.org/changeset/74760> 77643 2010-12-29 14:11:33 -0800 2010-12-29 14:21:32 -0800 Patch bug-51722-20101229141132.patch text/plain 5091 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODhmYWY0OGY0M2JmMDdiMWNmMjM2ZTNlZmY5YTc1YzYwMTIwMWI1OS4uOWM0OGE3ZTJlZDU2ODNl NzExZjgxYjYxMjA5OWJiODgyMzg2Y2I5YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyOSBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIEpTRGF0YVZpZXdDdXN0b20uY3BwIGdp dmVzIHRoZSBmYXN0Y2FsbCBjYWxsaW5nIGNvbnZlbnRpb24gdG8gZnVuY3Rpb25zIGNhbGxlZCB2 aWEgQysrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD01 MTcyMgorCisgICAgICAgIFJlbW92ZSB0aGUgSlNDX0hPU1RfQ0FMTCBmcm9tIG1ldGhvZHMgdGhh dCBhcmUgY2FsbGVkIGZyb20gQysrLiBKU0NfSE9TVF9DQUxMIGdpdmVzCisgICAgICAgIG1ldGhv ZHMgdGhlIGZhc3RjYWxsIGNhbGxpbmcgY29udmVudGlvbiwgd2hpY2ggbGVhZHMgdG8gcnVudGlt ZSBlcnJvcnMgd2hlbiB0aGV5IGFyZQorICAgICAgICBjYWxsZWQgZnJvbSBDKysuIEFsc28gcmVt b3ZlIGEgYml0IG9mIHVubmVjZXNzYXJ5IGNvZGUgZHVwbGljYXRpb24uCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLiBUaGlzIGlzIGNvdmVyZWQgYnkgZmFzdC9jYW52YXMvd2ViZ2wvZGF0YS12aWV3 LXRlc3QuaHRtbC4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRGF0YVZpZXdDdXN0b20uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Z2V0RGF0YVZpZXdNZW1iZXIpOiBSZW1vdmUgZHVwbGljYXRl ZCBjb2RlLgorICAgICAgICAoV2ViQ29yZTo6SlNEYXRhVmlldzo6Z2V0SW50OCk6IFJlbW92ZSBK U0NfSE9TVF9DQUxMLgorICAgICAgICAoV2ViQ29yZTo6SlNEYXRhVmlldzo6Z2V0VWludDgpOiBE aXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkpTRGF0YVZpZXc6OmdldEZsb2F0MzIpOiBEaXR0by4K KyAgICAgICAgKFdlYkNvcmU6OkpTRGF0YVZpZXc6OmdldEZsb2F0NjQpOiBEaXR0by4KKyAgICAg ICAgKFdlYkNvcmU6OnNldERhdGFWaWV3TWVtYmVyKTogUmVtb3ZlIGR1cGxpY2F0ZWQgY29kZS4K KyAgICAgICAgKFdlYkNvcmU6OkpTRGF0YVZpZXc6OnNldEludDgpOiBSZW1vdmUgSlNDX0hPU1Rf Q0FMTC4KKyAgICAgICAgKFdlYkNvcmU6OkpTRGF0YVZpZXc6OnNldFVpbnQ4KTogRGl0dG8uCisK KzIwMTAtMTItMjkgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIFtHVEtdIEluaXRp YWwgYnVpbGQgc3VwcG9ydCBmb3IgV2ViR0wKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTUxNzE2CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNEYXRhVmlld0N1c3RvbS5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRGF0YVZpZXdD dXN0b20uY3BwCmluZGV4IGYxN2UwZTFkZmFjZjc2ZmE4MjVjMjM1N2QxOTZjNTdkNDY3NGMzYzku LmI3ZDRiOGY5MGNkNzhmMGMwZDE4NDZhZmE5ZjU5YWNkNmYwMmVhMjMgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvYmluZGluZ3MvanMvSlNEYXRhVmlld0N1c3RvbS5jcHAKKysrIGIvV2ViQ29yZS9iaW5k aW5ncy9qcy9KU0RhdGFWaWV3Q3VzdG9tLmNwcApAQCAtNjUsMTMgKzY1LDggQEAgRW5jb2RlZEpT VmFsdWUgSlNDX0hPU1RfQ0FMTCBKU0RhdGFWaWV3Q29uc3RydWN0b3I6OmNvbnN0cnVjdEpTRGF0 YVZpZXcoRXhlY1N0YXQKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGFzT2JqZWN0KHRvSlMo ZXhlYywganNDb25zdHJ1Y3Rvci0+Z2xvYmFsT2JqZWN0KCksIHZpZXcuZ2V0KCkpKSk7CiB9CiAK LXN0YXRpYyBKU1ZhbHVlIGdldERhdGFWaWV3TWVtYmVyKEV4ZWNTdGF0ZSogZXhlYywgRGF0YVZp ZXdBY2Nlc3NUeXBlIHR5cGUpCitzdGF0aWMgSlNWYWx1ZSBnZXREYXRhVmlld01lbWJlcihFeGVj U3RhdGUqIGV4ZWMsIERhdGFWaWV3KiBpbXAsIERhdGFWaWV3QWNjZXNzVHlwZSB0eXBlKQogewot ICAgIEpTVmFsdWUgdGhpc1ZhbHVlID0gZXhlYy0+aG9zdFRoaXNWYWx1ZSgpOwotICAgIGlmICgh dGhpc1ZhbHVlLmluaGVyaXRzKCZKU0RhdGFWaWV3OjpzX2luZm8pKQotICAgICAgICByZXR1cm4g dGhyb3dUeXBlRXJyb3IoZXhlYyk7Ci0gICAgSlNEYXRhVmlldyogY2FzdGVkVGhpcyA9IHN0YXRp Y19jYXN0PEpTRGF0YVZpZXcqPihhc09iamVjdCh0aGlzVmFsdWUpKTsKLSAgICBEYXRhVmlldyog aW1wID0gc3RhdGljX2Nhc3Q8RGF0YVZpZXcqPihjYXN0ZWRUaGlzLT5pbXBsKCkpOwogICAgIGlm IChleGVjLT5hcmd1bWVudENvdW50KCkgPCAxKQogICAgICAgICByZXR1cm4gdGhyb3dFcnJvcihl eGVjLCBjcmVhdGVTeW50YXhFcnJvcihleGVjLCAiTm90IGVub3VnaCBhcmd1bWVudHMiKSk7CiAg ICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7CkBAIC0xMDcsMzMgKzEwMiwyOCBAQCBzdGF0aWMgSlNW YWx1ZSBnZXREYXRhVmlld01lbWJlcihFeGVjU3RhdGUqIGV4ZWMsIERhdGFWaWV3QWNjZXNzVHlw ZSB0eXBlKQogICAgIHJldHVybiByZXN1bHQ7CiB9CiAKLUpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBK U0RhdGFWaWV3OjpnZXRJbnQ4KEV4ZWNTdGF0ZSogZXhlYykKK0pTVmFsdWUgSlNEYXRhVmlldzo6 Z2V0SW50OChFeGVjU3RhdGUqIGV4ZWMpCiB7Ci0gICAgcmV0dXJuIGdldERhdGFWaWV3TWVtYmVy KGV4ZWMsIEFjY2Vzc0RhdGFWaWV3TWVtYmVyQXNJbnQ4KTsKKyAgICByZXR1cm4gZ2V0RGF0YVZp ZXdNZW1iZXIoZXhlYywgc3RhdGljX2Nhc3Q8RGF0YVZpZXcqPihpbXBsKCkpLCBBY2Nlc3NEYXRh Vmlld01lbWJlckFzSW50OCk7CiB9CiAKLUpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBKU0RhdGFWaWV3 OjpnZXRVaW50OChFeGVjU3RhdGUqIGV4ZWMpCitKU1ZhbHVlIEpTRGF0YVZpZXc6OmdldFVpbnQ4 KEV4ZWNTdGF0ZSogZXhlYykKIHsKLSAgICByZXR1cm4gZ2V0RGF0YVZpZXdNZW1iZXIoZXhlYywg QWNjZXNzRGF0YVZpZXdNZW1iZXJBc1VpbnQ4KTsKKyAgICByZXR1cm4gZ2V0RGF0YVZpZXdNZW1i ZXIoZXhlYywgc3RhdGljX2Nhc3Q8RGF0YVZpZXcqPihpbXBsKCkpLCBBY2Nlc3NEYXRhVmlld01l bWJlckFzVWludDgpOwogfQogCi1KU1ZhbHVlIEpTQ19IT1NUX0NBTEwgSlNEYXRhVmlldzo6Z2V0 RmxvYXQzMihFeGVjU3RhdGUqIGV4ZWMpCitKU1ZhbHVlIEpTRGF0YVZpZXc6OmdldEZsb2F0MzIo RXhlY1N0YXRlKiBleGVjKQogewotICAgIHJldHVybiBnZXREYXRhVmlld01lbWJlcihleGVjLCBB Y2Nlc3NEYXRhVmlld01lbWJlckFzRmxvYXQzMik7CisgICAgcmV0dXJuIGdldERhdGFWaWV3TWVt YmVyKGV4ZWMsIHN0YXRpY19jYXN0PERhdGFWaWV3Kj4oaW1wbCgpKSwgQWNjZXNzRGF0YVZpZXdN ZW1iZXJBc0Zsb2F0MzIpOwogfQogCi1KU1ZhbHVlIEpTQ19IT1NUX0NBTEwgSlNEYXRhVmlldzo6 Z2V0RmxvYXQ2NChFeGVjU3RhdGUqIGV4ZWMpCitKU1ZhbHVlIEpTRGF0YVZpZXc6OmdldEZsb2F0 NjQoRXhlY1N0YXRlKiBleGVjKQogewotICAgIHJldHVybiBnZXREYXRhVmlld01lbWJlcihleGVj LCBBY2Nlc3NEYXRhVmlld01lbWJlckFzRmxvYXQ2NCk7CisgICAgcmV0dXJuIGdldERhdGFWaWV3 TWVtYmVyKGV4ZWMsIHN0YXRpY19jYXN0PERhdGFWaWV3Kj4oaW1wbCgpKSwgQWNjZXNzRGF0YVZp ZXdNZW1iZXJBc0Zsb2F0NjQpOwogfQogCi1zdGF0aWMgSlNWYWx1ZSBzZXREYXRhVmlld01lbWJl cihFeGVjU3RhdGUqIGV4ZWMsIERhdGFWaWV3QWNjZXNzVHlwZSB0eXBlKQorc3RhdGljIEpTVmFs dWUgc2V0RGF0YVZpZXdNZW1iZXIoRXhlY1N0YXRlKiBleGVjLCBEYXRhVmlldyogaW1wLCBEYXRh Vmlld0FjY2Vzc1R5cGUgdHlwZSkKIHsKLSAgICBKU1ZhbHVlIHRoaXNWYWx1ZSA9IGV4ZWMtPmhv c3RUaGlzVmFsdWUoKTsKLSAgICBpZiAoIXRoaXNWYWx1ZS5pbmhlcml0cygmSlNEYXRhVmlldzo6 c19pbmZvKSkKLSAgICAgICAgcmV0dXJuIHRocm93VHlwZUVycm9yKGV4ZWMpOwotICAgIEpTRGF0 YVZpZXcqIGNhc3RlZFRoaXMgPSBzdGF0aWNfY2FzdDxKU0RhdGFWaWV3Kj4oYXNPYmplY3QodGhp c1ZhbHVlKSk7Ci0gICAgRGF0YVZpZXcqIGltcCA9IHN0YXRpY19jYXN0PERhdGFWaWV3Kj4oY2Fz dGVkVGhpcy0+aW1wbCgpKTsKICAgICBpZiAoZXhlYy0+YXJndW1lbnRDb3VudCgpIDwgMikKICAg ICAgICAgcmV0dXJuIHRocm93RXJyb3IoZXhlYywgY3JlYXRlU3ludGF4RXJyb3IoZXhlYywgIk5v dCBlbm91Z2ggYXJndW1lbnRzIikpOwogICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwpAQCAtMTU5 LDE0ICsxNDksMTQgQEAgc3RhdGljIEpTVmFsdWUgc2V0RGF0YVZpZXdNZW1iZXIoRXhlY1N0YXRl KiBleGVjLCBEYXRhVmlld0FjY2Vzc1R5cGUgdHlwZSkKICAgICByZXR1cm4ganNVbmRlZmluZWQo KTsKIH0KIAotSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIEpTRGF0YVZpZXc6OnNldEludDgoRXhlY1N0 YXRlKiBleGVjKQorSlNWYWx1ZSBKU0RhdGFWaWV3OjpzZXRJbnQ4KEV4ZWNTdGF0ZSogZXhlYykK IHsKLSAgICByZXR1cm4gc2V0RGF0YVZpZXdNZW1iZXIoZXhlYywgQWNjZXNzRGF0YVZpZXdNZW1i ZXJBc0ludDgpOworICAgIHJldHVybiBzZXREYXRhVmlld01lbWJlcihleGVjLCBzdGF0aWNfY2Fz dDxEYXRhVmlldyo+KGltcGwoKSksIEFjY2Vzc0RhdGFWaWV3TWVtYmVyQXNJbnQ4KTsKIH0KIAot SlNWYWx1ZSBKU0NfSE9TVF9DQUxMIEpTRGF0YVZpZXc6OnNldFVpbnQ4KEV4ZWNTdGF0ZSogZXhl YykKK0pTVmFsdWUgSlNEYXRhVmlldzo6c2V0VWludDgoRXhlY1N0YXRlKiBleGVjKQogewotICAg IHJldHVybiBzZXREYXRhVmlld01lbWJlcihleGVjLCBBY2Nlc3NEYXRhVmlld01lbWJlckFzVWlu dDgpOworICAgIHJldHVybiBzZXREYXRhVmlld01lbWJlcihleGVjLCBzdGF0aWNfY2FzdDxEYXRh Vmlldyo+KGltcGwoKSksIEFjY2Vzc0RhdGFWaWV3TWVtYmVyQXNVaW50OCk7CiB9CiAKIH0gLy8g bmFtZXNwYWNlIFdlYkNvcmUK